Skip to contentSkip to conversation

f2fs: freeze filesystem when fail to update meta page due to IO error

PATCH New Chao Yu 1 participant 1 message Jul 29, 2015 F2FS file system

lore
Share & tools
lore

Chao Yu

author
#0 lore raw

PATCH 1/1 f2fs: freeze filesystem when fail to update meta page due to IO error

In get_meta_page, we guarantee no failure for the returned page, but sometimes, IO error from device will incur returning an non-updated page.

Then, we still use this page as updated one, exception could happen when using this kind of page.

So in this condition, we'd better freeze fs by making fs readonly and and stop doing checkpoint.

---
 fs/f2fs/checkpoint.c | 8 ++++++++
 1 file changed, 8 insertions(+)
fs/f2fs/checkpoint.c +8 -0
index 84e0dfe..c311176 100644
@@ -79,6 +79,14 @@ repeat:
 		f2fs_put_page(page, 1);
 		goto repeat;
 	}
+
+	/*
+	 * if there is any IO error when accessing device, make our filesystem
+	 * readonly and make sure do not write checkpoint with non-uptodate
+	 * meta page.
+	 */
+	if (unlikely(!PageUptodate(page)))
+		f2fs_stop_checkpoint(sbi);
 out:
 	return page;
 }
Signature · 1 line
2.4.2