Skip to contentSkip to conversation

f2fs: remove obsolete code

PATCH In review Jaegeuk Kim 2 participants 3 messages Feb 25, 2015 – Feb 26, 2015

Subsystems (2)
lore
Share & tools
lore

Jaegeuk Kim

author maintainer
#0 lore raw

PATCH 1/2 f2fs: remove obsolete code

This patch removes obsolete code in which summary variable is not needed.

---
 fs/f2fs/recovery.c | 2 --
 1 file changed, 2 deletions(-)
fs/f2fs/recovery.c +0 -2
index 188a034..b2a92d4 100644
@@ -407,8 +407,6 @@ static int do_recover_data(struct f2fs_sb_info *sbi, struct inode *inode,
 		dn.ofs_in_node++;
 	}
 
-	/* write node page in place */
-	set_summary(&sum, dn.nid, 0, 0);
 	if (IS_INODE(dn.node_page))
 		sync_inode_page(&dn);
 
Signature · 9 lines
2.1.1


------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/
author maintainer
#1 lore raw

PATCH 2/2 f2fs: avoid wrong error during recovery

From: Jaegeuk Kim <[email protected]>

During the roll-forward recovery, -ENOENT for f2fs_iget can be skipped. So, this error value should not be propagated.

Change-Id I230ad2371e3fb4b9df42059c4a61f92c1f9838de
---
 fs/f2fs/recovery.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
fs/f2fs/recovery.c +3 -1
index b2a92d4..6e40874 100644
@@ -212,8 +212,10 @@ static int find_fsync_dnodes(struct f2fs_sb_info *sbi, struct list_head *head)
 			if (IS_ERR(entry->inode)) {
 				err = PTR_ERR(entry->inode);
 				kmem_cache_free(fsync_entry_slab, entry);
-				if (err == -ENOENT)
+				if (err == -ENOENT) {
+					err = 0;
 					goto next;
+				}
 				break;
 			}
 			list_add_tail(&entry->list, head);
Signature · 9 lines
2.1.1


------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/
Reviewed-by on v1 2/2
#2 lore raw

RE: [f2fs-dev] [PATCH 2/2] f2fs: avoid wrong error during recovery

Quoted 8 lines

-----Original Message-----
From: Jaegeuk Kim [mailto:[email protected]]
Sent: Thursday, February 26, 2015 5:47 AM
To: [email protected]; [email protected]; [email protected]
Cc: Jaegeuk Kim
Subject: [f2fs-dev] [PATCH 2/2] f2fs: avoid wrong error during recovery

Quoted 7 lines

From: Jaegeuk Kim <[email protected]>

During the roll-forward recovery, -ENOENT for f2fs_iget can be skipped. So, this error value should not be propagated.

Change-Id I230ad2371e3fb4b9df42059c4a61f92c1f9838de