Skip to contentSkip to conversation

km: modify Kconfig file organization for KM boards

PATCH New Pascal Linder 2 participants 4 messages Jun 18, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/6 km: modify Kconfig file organization for KM boards

As preparation for the upcoming transferring of configurations from header files to Kconfig, a common Kconfig file for all KM boards was created. For the moment, it only sources the other three, more specific, Kconfig files. Therefore, the architecture Kconfig files now include the common Kconfig file. Also, the configuration selection for KM boards was moved from the architecture Kconfig files to the board specific Kconfig files.

---
 arch/arm/mach-kirkwood/Kconfig   |  9 ++---
 arch/powerpc/cpu/mpc83xx/Kconfig | 44 ++++++-----------------
 arch/powerpc/cpu/mpc85xx/Kconfig |  8 ++---
 board/keymile/Kconfig            | 16 +++++++++
 board/keymile/km83xx/Kconfig     | 62 ++++++++++++++++++++++++++++++++
 board/keymile/km_arm/Kconfig     |  7 ++++
 board/keymile/kmp204x/Kconfig    |  8 +++++
 7 files changed, 109 insertions(+), 45 deletions(-)
 create mode 100644 board/keymile/Kconfig
arch/arm/mach-kirkwood/Kconfig +3 -6
index 7c4170399a..2f68092f82 100644
@@ -32,11 +32,8 @@ config TARGET_ICONNECT
 	bool "iconnect Board"
 
 config TARGET_KM_KIRKWOOD
-	bool "KM_KIRKWOOD Board"
-	select BOARD_LATE_INIT
-	imply CMD_CRAMFS
-	imply CMD_DIAG
-	imply FS_CRAMFS
+	bool "KM Kirkwood Board"
+	select VENDOR_KM
 
 config TARGET_NET2BIG_V2
 	bool "LaCie 2Big Network v2 NAS Board"
@@ -82,7 +79,7 @@ source "board/buffalo/lsxl/Kconfig"
 source "board/cloudengines/pogo_e02/Kconfig"
 source "board/d-link/dns325/Kconfig"
 source "board/iomega/iconnect/Kconfig"
-source "board/keymile/km_arm/Kconfig"
+source "board/keymile/Kconfig"
 source "board/LaCie/net2big_v2/Kconfig"
 source "board/LaCie/netspace_v2/Kconfig"
 source "board/raidsonic/ib62x0/Kconfig"
arch/powerpc/cpu/mpc83xx/Kconfig +11 -33

83 lines not on this page · raw message

arch/powerpc/cpu/mpc85xx/Kconfig +2 -6
index aebf168a89..f3d2d85ed1 100644
@@ -412,11 +412,7 @@ config TARGET_CONTROLCENTERD
 
 config TARGET_KMP204X
 	bool "Support kmp204x"
-	select ARCH_P2041
-	select PHYS_64BIT
-	select FSL_DDR_INTERACTIVE
-	imply CMD_CRAMFS
-	imply FS_CRAMFS
+	select VENDOR_KM
 
 config TARGET_XPEDITE520X
 	bool "Support xpedite520x"
@@ -1591,7 +1587,7 @@ source "board/freescale/t208xrdb/Kconfig"
 source "board/freescale/t4qds/Kconfig"
 source "board/freescale/t4rdb/Kconfig"
 source "board/gdsys/p1022/Kconfig"
-source "board/keymile/kmp204x/Kconfig"
+source "board/keymile/Kconfig"
 source "board/sbc8548/Kconfig"
 source "board/socrates/Kconfig"
 source "board/varisys/cyrus/Kconfig"
board/keymile/Kconfig new file +16 -0
new file mode 100644
index 0000000000..e30d64818c
@@ -0,0 +1,16 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# Copyright (C) 2019, Pascal Linder <[email protected]>
+
+config VENDOR_KM
+	bool
+	help
+	  Selected by any KM board to have additional configurations.
+
+if VENDOR_KM
+
+source "board/keymile/km83xx/Kconfig"
+source "board/keymile/kmp204x/Kconfig"
+source "board/keymile/km_arm/Kconfig"
+
+endif
board/keymile/km83xx/Kconfig +62 -0

120 lines not on this page · raw message

board/keymile/km_arm/Kconfig +7 -0
index 3476780847..2542f1ea8f 100644
@@ -9,4 +9,11 @@ config SYS_VENDOR
 config SYS_CONFIG_NAME
 	default "km_kirkwood"
 
+config BOARD_SPECIFIC_OPTIONS # dummy
+	def_bool y
+	select BOARD_LATE_INIT
+	imply CMD_CRAMFS
+	imply CMD_DIAG
+	imply FS_CRAMFS
+
 endif
board/keymile/kmp204x/Kconfig +8 -0
index 7b45a13cfb..f74d4295c7 100644
@@ -9,4 +9,12 @@ config SYS_VENDOR
 config SYS_CONFIG_NAME
 	default "kmp204x"
 
+config BOARD_SPECIFIC_OPTIONS # dummy
+	def_bool y
+	select ARCH_P2041
+	select FSL_DDR_INTERACTIVE
+	select PHYS_64BIT
+	imply CMD_CRAMFS
+	imply FS_CRAMFS
+
 endif
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/6 km: modify Kconfig file organization for KM boards

Hi Pascal,

Quoted 20 lines · Pascal Linder

As preparation for the upcoming transferring of configurations from header files to Kconfig, a common Kconfig file for all KM boards was created. For the moment, it only sources the other three, more specific, Kconfig files. Therefore, the architecture Kconfig files now include the common Kconfig file. Also, the configuration selection for KM boards was moved from the architecture Kconfig files to the board specific Kconfig files.

---
  arch/arm/mach-kirkwood/Kconfig   |  9 ++---
  arch/powerpc/cpu/mpc83xx/Kconfig | 44 ++++++-----------------
  arch/powerpc/cpu/mpc85xx/Kconfig |  8 ++---
  board/keymile/Kconfig            | 16 +++++++++
  board/keymile/km83xx/Kconfig     | 62 ++++++++++++++++++++++++++++++++
  board/keymile/km_arm/Kconfig     |  7 ++++
  board/keymile/kmp204x/Kconfig    |  8 +++++
  7 files changed, 109 insertions(+), 45 deletions(-)
Quoted 1 line

create mode 100644 board/keymile/Kconfig

Are you only posting this patch in an updated version? That's fine, I just wanted to know.

But: You need to provide a patch history. Please see here for more details:

http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions

No need to re-do this for this patch. But please next time. ;)

Thanks,
Stefan

#2 lore raw

PATCH 1/6 km: modify Kconfig file organization for KM boards

Hi Stefan,

Yes, it is just an updated version that matches the current mainline. Sorry, I am new to open source contribution, and will take more care next time.

Cheers,

Pascal Linder

________________________________
Von: Stefan Roese <[email protected]>
Gesendet: Dienstag, 18. Juni 2019 13:36
An: Linder Pascal; u-boot at lists.denx.de
Cc: Holger Brunck
Betreff: Re: [U-Boot] [PATCH 1/6] km: modify Kconfig file organization for KM boards

Hi Pascal,

Quoted 20 lines · Pascal Linder

As preparation for the upcoming transferring of configurations from header files to Kconfig, a common Kconfig file for all KM boards was created. For the moment, it only sources the other three, more specific, Kconfig files. Therefore, the architecture Kconfig files now include the common Kconfig file. Also, the configuration selection for KM boards was moved from the architecture Kconfig files to the board specific Kconfig files.

---
  arch/arm/mach-kirkwood/Kconfig   |  9 ++---
  arch/powerpc/cpu/mpc83xx/Kconfig | 44 ++++++-----------------
  arch/powerpc/cpu/mpc85xx/Kconfig |  8 ++---
  board/keymile/Kconfig            | 16 +++++++++
  board/keymile/km83xx/Kconfig     | 62 ++++++++++++++++++++++++++++++++
  board/keymile/km_arm/Kconfig     |  7 ++++
  board/keymile/kmp204x/Kconfig    |  8 +++++
  7 files changed, 109 insertions(+), 45 deletions(-)
Quoted 1 line

create mode 100644 board/keymile/Kconfig

Are you only posting this patch in an updated version? That's fine, I just wanted to know.

But: You need to provide a patch history. Please see here for more details:

http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions

No need to re-do this for this patch. But please next time. ;)

Thanks,
Stefan

#3 lore raw

PATCH 1/6 km: modify Kconfig file organization for KM boards

Hi Pascal,

Quoted 2 lines · Linder Pascal

Yes, it is just an updated version that matches the current mainline. Sorry, I am new to open source contribution,

No problem. Your patches are in very good shape for a "firsttimer" btw. ;)

Quoted 2 lines

and
will take more care next time.

Good, thanks.

Thanks,
Stefan