qemu-iotests: restrict 264 to qcow2 only
PATCH 1/1 qemu-iotests: restrict 264 to qcow2 only
264 is unprepared to run with different formats, for example luks needs handling keys, cloop doesn't support image creation, vpc creates image larger than requested (which breaks "Backup completed: 5242880" in test output).
The test is here to check nbd-reconnect feature and we actually don't need it for all formats. Let's restrict it to qcow2 only.
--- tests/qemu-iotests/264 | 2 ++ 1 file changed, 2 insertions(+)
tests/qemu-iotests/264 +2 -0
@@ -24,6 +24,8 @@ import iotests from iotests import qemu_img_create, qemu_io_silent_check, file_path, \ qemu_nbd_popen, log +iotests.verify_image_format(supported_fmts=['qcow2']) + disk_a, disk_b, nbd_sock = file_path('disk_a', 'disk_b', 'nbd-sock') nbd_uri = 'nbd+unix:///?socket=' + nbd_sock size = 5 * 1024 * 1024
Signature · 1 line
2.21.0
Quoted 5 lines · Vladimir Sementsov-Ogievskiy
264 is unprepared to run with different formats, for example luks needs handling keys, cloop doesn't support image creation, vpc creates image larger than requested (which breaks "Backup completed: 5242880" in test output).
Quoted 8 lines
The test is here to check nbd-reconnect feature and we actually don't need it for all formats. Let's restrict it to qcow2 only.
Reported-by Max Reitz <[email protected]>Signed-off-by Vladimir Sementsov-Ogievskiy <[email protected]>--- tests/qemu-iotests/264 | 2 ++ 1 file changed, 2 insertions(+)
I will queue through my NBD tree; it may miss soft freeze (due to my travel schedule for KVM Forum), but is definite 4.2 material, so it will be in by rc1.
Quoted 15 lines
tests/qemu-iotests/264 +2
-0@@ -24,6 +24,8 @@ import iotests from iotests import qemu_img_create, qemu_io_silent_check, file_path, \ qemu_nbd_popen, log +iotests.verify_image_format(supported_fmts=['qcow2']) + disk_a, disk_b, nbd_sock = file_path('disk_a', 'disk_b', 'nbd-sock') nbd_uri = 'nbd+unix:///?socket=' + nbd_sock size = 5 * 1024 * 1024
Signature · 3 lines
Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
Quoted 15 lines · Eric Blake
Quoted 5 lines · Vladimir Sementsov-Ogievskiy
264 is unprepared to run with different formats, for example luks needs handling keys, cloop doesn't support image creation, vpc creates image larger than requested (which breaks "Backup completed: 5242880" in test output).
Quoted 8 lines
The test is here to check nbd-reconnect feature and we actually don't need it for all formats. Let's restrict it to qcow2 only.
Reported-by Max Reitz <[email protected]>Signed-off-by Vladimir Sementsov-Ogievskiy <[email protected]>---
tests/qemu-iotests/264 | 2 ++1 file changed, 2 insertions(+)
Quoted 5 lines
Reviewed-by Eric Blake <[email protected]>I will queue through my NBD tree; it may miss soft freeze (due to my travel schedule for KVM Forum), but is definite 4.2 material, so it will be in by rc1.
Hm, well. I need this patch anyway or my pre-pull-request tests won’t pass. So I suppose there is no reason for me not to take it. O:-)
Max