eeprom: ee1004: Fix build error
PATCH 1/1 eeprom: ee1004: Fix build error
Currently driver compilation fails because of the undeclared 'ee1004_groups' variable.
This variable was deleted in the commit79d0df36b541 ("eeprom: ee1004: Add nvmem support")
but by mistake was used in the commit1b9ab93850ac ("eeprom: ee1004: Add OF matching support"). Remove 'ee1004_groups' usage from the driver to fix the compilation.
--- drivers/misc/eeprom/ee1004.c | 1 - 1 file changed, 1 deletion(-)
drivers/misc/eeprom/ee1004.c +0 -1
@@ -347,7 +347,6 @@ static int ee1004_probe(struct i2c_client *client)static struct i2c_driver ee1004_driver = { .driver = { .name ="ee1004" , - .dev_groups = ee1004_groups, .of_match_table = ee1004_of_match, }, .probe = ee1004_probe,
Signature · 1 line
2.43.0
PATCH v2 1/1 eeprom: ee1004: Fix build error
Currently driver compilation fails because of the undeclared 'ee1004_groups' variable.
This variable was deleted in the commit79d0df36b541 ("eeprom: ee1004: Add nvmem support")
but by mistake was used in the commit1b9ab93850ac ("eeprom: ee1004: Add OF matching support"). Remove 'ee1004_groups' usage from the driver to fix the compilation.
--- drivers/misc/eeprom/ee1004.c | 1 - 1 file changed, 1 deletion(-)
drivers/misc/eeprom/ee1004.c +0 -1
@@ -347,7 +347,6 @@ static int ee1004_probe(struct i2c_client *client)static struct i2c_driver ee1004_driver = { .driver = { .name ="ee1004" , - .dev_groups = ee1004_groups, .of_match_table = ee1004_of_match, }, .probe = ee1004_probe,
Signature · 1 line
2.43.0
Quoted 4 lines · Konstantin Aladyshev
Currently driver compilation fails because of the undeclared '
ee1004_groups' variable.[...]Fixes 79d0df36b541 ("eeprom: ee1004: Add nvmem support")
Ftr, this patch on (top of 80ec78d (6.18.26)) fixes building linux-aspeed with CONFIG_EEPROM_EE1004=y configured for me, which has otherwise been broken since around October 2025.
I recommend merging it :)
Signature · 4 lines
with best regards: - Johannes Truschnigg ( [email protected] ) www: https://johannes.truschnigg.info/
Quoted 6 lines · Johannes Truschnigg
Quoted 4 lines · Konstantin Aladyshev
Currently driver compilation fails because of the undeclared '
ee1004_groups' variable.[...]Fixes 79d0df36b541 ("eeprom: ee1004: Add nvmem support")
Quoted 6 lines
Ftr, this patch on (top of 80ec78d (6.18.26)) fixes building linux-aspeed with
CONFIG_EEPROM_EE1004=yconfigured for me, which has otherwise been broken since around October 2025.I recommend merging it :)
It'd be great if the patch could be sent to LKML and let it be backported to the upstream 6.18 LTS tree instead of having it only in the OpenBMC tree.
To cite the kernel development doc [0]:
"Submit your patch upstream. It doesn't need to be upstream, but it should be on it's way, and not have any unresolved design concerns."
Tan
I think this is specifically an OpenBMC kernel problem. I don't see this error neither in upstream Linux master
https://github.com/torvalds/linux/blob/master/drivers/misc/eeprom/ee1004.c#L341
nor in Linux 6.18
https://github.com/torvalds/linux/blob/v6.18/drivers/misc/eeprom/ee1004.c#L341
Quoted 27 lines · Tan Siewert
Quoted 6 lines · Johannes Truschnigg
Quoted 4 lines · Konstantin Aladyshev
Currently driver compilation fails because of the undeclared '
ee1004_groups' variable.[...]Fixes 79d0df36b541 ("eeprom: ee1004: Add nvmem support")Quoted 6 lines
Ftr, this patch on (top of 80ec78d (6.18.26)) fixes building linux-aspeed with
CONFIG_EEPROM_EE1004=yconfigured for me, which has otherwise been broken since around October 2025.I recommend merging it :)
It'd be great if the patch could be sent to LKML and let it be backported to the upstream 6.18 LTS tree instead of having it only in the OpenBMC tree.
To cite the kernel development doc [0]:
"Submit your patch upstream. It doesn't need to be upstream, but it should be on it's way, and not have any unresolved design concerns."Tan
Andrew Jeffery
AppliedQuoted 11 lines · Konstantin Aladyshev
Currently driver compilation fails because of the undeclared '
ee1004_groups' variable.
This variable was deleted in the commit79d0df36b541("eeprom: ee1004: Add nvmem support")
but by mistake was used in the commit1b9ab93850ac("eeprom: ee1004: Add OF matching support"). Remove 'ee1004_groups' usage from the driver to fix the compilation.Fixes 79d0df36b541 ("eeprom: ee1004: Add nvmem support")Signed-off-by Konstantin Aladyshev <[email protected]>
Applied, thanks.
Sorry for the delay.
Andrew