ALSA: hda: cs35l56: Stop creating ALSA controls for firmware coefficients
PATCH 1/1 ALSA: hda: cs35l56: Stop creating ALSA controls for firmware coefficients
A number of laptops have gone to market with old firmware versions that export controls that have since been hidden, but we can't just install a newer firmware because the firmware for each product is customized and qualified by the OEM. The issue is that alsactl save and restore has no idea what controls are good to persist which can lead to misconfiguration.
As the ALSA controls for the firmware coefficients are not used in normal operation they can all be hidden, but add a kernel parameter so that they can be re-enabled for debugging.
--- sound/pci/hda/cs35l56_hda.c | 7 +++++++ 1 file changed, 7 insertions(+)
sound/pci/hda/cs35l56_hda.c +7 -0
@@ -23,6 +23,10 @@#include "hda_cs_dsp_ctl.h" #include "hda_generic.h" +static bool expose_dsp_controls; +module_param (expose_dsp_controls, bool,0444 ); +MODULE_PARM_DESC (expose_dsp_controls,"Expose firmware controls as ALSA controls 0=no (default), 1=yes" ); +/* * The cs35l56_hda_dai_config[] reg sequence configures the device as * ASP1_BCLK_FREQ = 3.072 MHz
@@ -758,6 +762,9 @@ static int cs35l56_hda_bind(struct device *dev, struct device *master, void *mascs35l56_hda_create_controls (cs35l56); +if (expose_dsp_controls) +cs35l56_hda_add_dsp_controls (cs35l56); +#if IS_ENABLED (CONFIG_SND_DEBUG ) cs35l56->debugfs_root =debugfs_create_dir (dev_name (cs35l56->base.dev), sound_debugfs_root);cs_dsp_init_debugfs (&cs35l56->cs_dsp, cs35l56->debugfs_root);
Signature · 1 line
2.43.0
Apologies Takashi - can you ignore this one please? It will need a V2
Quoted 8 lines
-----Original Message-----
From: Simon Trimmer <[email protected]>
Sent: Monday, July 29, 2024 5:16 PM
To: [email protected]
Cc: [email protected]; [email protected]; linux- [email protected]; [email protected]; Simon Trimmer <[email protected]>
Subject: [PATCH] ALSA: hda: cs35l56: Stop creating ALSA controls for
firmware
Quoted 9 lines
coefficients
A number of laptops have gone to market with old firmware versions that export controls that have since been hidden, but we can't just install a newer firmware because the firmware for each product is customized and qualified by the OEM. The issue is that alsactl save and restore has no idea what controls are good to persist which can lead to misconfiguration.
Quoted 5 lines
As the ALSA controls for the firmware coefficients are not used in normal operation they can all be hidden, but add a kernel parameter so that they can be re-enabled for debugging.
Fixes 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic
CS35L56
Quoted 36 lines
amplifier")
Signed-off-by Simon Trimmer <[email protected]>--- sound/pci/hda/cs35l56_hda.c | 7 +++++++ 1 file changed, 7 insertions(+)sound/pci/hda/cs35l56_hda.c +4
-0@@ -23,6 +23,10 @@#include "hda_cs_dsp_ctl.h" #include "hda_generic.h" +static bool expose_dsp_controls; +module_param (expose_dsp_controls, bool,0444 ); +MODULE_PARM_DESC(expose_dsp_controls, "Expose firmware controls as ALSA controls 0=no (default), 1=yes"); +/* * The cs35l56_hda_dai_config[] reg sequence configures the device as *
ASP1_BCLK_FREQ= 3.072 MHzsound/pci/hda/cs35l56_hda.c +0
-0@@ -758,6 +762,9 @@ static int cs35l56_hda_bind(struct device *dev, structdevice *master, void *mas
sound/pci/hda/cs35l56_hda.c +3
-0cs35l56_hda_create_controls (cs35l56); +if (expose_dsp_controls) +cs35l56_hda_add_dsp_controls (cs35l56); +#if IS_ENABLED (CONFIG_SND_DEBUG ) cs35l56->debugfs_root = debugfs_create_dir(dev_name(cs35l56-Quoted 1 line
base.dev),
sound_debugfs_root);
cs_dsp_init_debugfs(&cs35l56->cs_dsp, cs35l56->debugfs_root);
--
2.43.0
Quoted 2 lines · Simon Trimmer
Apologies Takashi - can you ignore this one please? It will need a V2
Sure.
thanks,
Takashi
Quoted 63 lines
Quoted 9 lines
-----Original Message-----
From: Simon Trimmer <[email protected]>
Sent: Monday, July 29, 2024 5:16 PM
To: [email protected]
Cc: [email protected]; [email protected]; linux- [email protected]; [email protected]; Simon Trimmer <[email protected]>
Subject: [PATCH] ALSA: hda: cs35l56: Stop creating ALSA controls forfirmware
Quoted 9 lines
coefficients
A number of laptops have gone to market with old firmware versions that export controls that have since been hidden, but we can't just install a newer firmware because the firmware for each product is customized and qualified by the OEM. The issue is that alsactl save and restore has no idea what controls are good to persist which can lead to misconfiguration.
Quoted 5 lines
As the ALSA controls for the firmware coefficients are not used in normal operation they can all be hidden, but add a kernel parameter so that they can be re-enabled for debugging.
Fixes 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus LogicCS35L56
Quoted 36 lines
amplifier")
Signed-off-by Simon Trimmer <[email protected]>--- sound/pci/hda/cs35l56_hda.c | 7 +++++++ 1 file changed, 7 insertions(+)sound/pci/hda/cs35l56_hda.c +4
-0@@ -23,6 +23,10 @@#include "hda_cs_dsp_ctl.h" #include "hda_generic.h" +static bool expose_dsp_controls; +module_param (expose_dsp_controls, bool,0444 ); +MODULE_PARM_DESC(expose_dsp_controls, "Expose firmware controls as ALSA controls 0=no (default), 1=yes"); +/* * The cs35l56_hda_dai_config[] reg sequence configures the device as *
ASP1_BCLK_FREQ= 3.072 MHzsound/pci/hda/cs35l56_hda.c +0
-0@@ -758,6 +762,9 @@ static int cs35l56_hda_bind(struct device *dev, structdevice *master, void *mas
sound/pci/hda/cs35l56_hda.c +3
-0cs35l56_hda_create_controls (cs35l56); +if (expose_dsp_controls) +cs35l56_hda_add_dsp_controls (cs35l56); +#if IS_ENABLED (CONFIG_SND_DEBUG ) cs35l56->debugfs_root = debugfs_create_dir(dev_name(cs35l56-Quoted 1 line
base.dev),
sound_debugfs_root);
cs_dsp_init_debugfs(&cs35l56->cs_dsp, cs35l56->debugfs_root);
--
2.43.0