Skip to contentSkip to conversation

ASoC: Fix idma build after update for channel count check

PATCH In review Mark Brown 3 participants 3 messages Jan 9, 2012

Subsystems (3)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ASoC: Fix idma build after update for channel count check

---
 sound/soc/samsung/idma.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/soc/samsung/idma.c +1 -0
index 3ba6aba..c227c31 100644
@@ -398,6 +398,7 @@ static int idma_new(struct snd_soc_pcm_runtime *rtd)
 	if (pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream) {
 		ret = preallocate_idma_buffer(pcm,
 				SNDRV_PCM_STREAM_PLAYBACK);
+	}
 
 	return ret;
 }
Signature · 1 line
1.7.7.3
Acked-by on v1 1/1
#1 lore raw

Hi Mark,

Quoted 10 lines · Mark Brown

---
 sound/soc/samsung/idma.c |    1 +

 1 files changed, 1 insertions(+), 0 deletions(-)
sound/soc/samsung/idma.c +0 -0
index 3ba6aba..c227c31 100644

sound/soc/samsung/idma.c static int idma_new(struct snd_soc_pcm_runtime *rtd)

Quoted 8 lines
sound/soc/samsung/idma.c +1 -1
@@ -398,6 +398,7 @@ static int idma_new(struct snd_soc_pcm_runtime *rtd)
        if (pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream) {
                ret = preallocate_idma_buffer(pcm,
                                SNDRV_PCM_STREAM_PLAYBACK);
+       }
 
        return ret;
  }
--

I accidentally added the brace to the if test in "ASoC: check for substream not channels_min in pcm engines".
So you either remove the brace from the if test or add another one as you did.

regards
Joachim Eastwood

Quoted 4 lines

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Acked-by
#2 lore raw

Hi Joachim,

Quoted 7 lines · Joachim Eastwood

I accidentally added the brace to the if test in "ASoC: check for substream not channels_min in pcm engines".
So you either remove the brace from the if test or add another one as you did.

Thanks for your care to ASoC Samsung code.
If you change ASoC Samsung code, Could you please include me in the CC list?

Thanks,
Sangbeom.