Skip to contentSkip to conversation

dt-bindings: net: fsl,qoriq-mc-dpmac: add missed property phys

PATCH Applied Frank Li 3 participants 5 messages Aug 9, 2024 – Aug 12, 2024

Subsystems (4)
lore
Share & tools
lore

Frank Li

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: net: fsl,qoriq-mc-dpmac: add missed property phys

Add missed property phys, which indicate how connect to serdes phy.
Fix below warning:
arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: fsl-mc@80c000000: dpmacs:ethernet@7: Unevaluated properties are not allowed ('phys' was unexpected)

---
 Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml +4 -0
index 6538e0ce90b28..25d657be6956f 100644
@@ -38,6 +38,10 @@ properties:
 
   managed: true
 
+  phys:
+    description: A reference to the SerDes lane(s)
+    maxItems: 1
+
 required:
   - reg
 
Signature · 1 line
2.34.1
#1 lore raw
Quoted 14 lines · Frank Li

Add missed property phys, which indicate how connect to serdes phy.
Fix below warning:
arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: fsl-mc@80c000000: dpmacs:ethernet@7: Unevaluated properties are not allowed ('phys' was unexpected)

---
 Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml +0 -0
index 6538e0ce90b28..25d657be6956f 100644

Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml properties: · line 42

Quoted 5 lines
Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml +2 -0
@@ -38,6 +38,10 @@ properties:
 
   managed: true
 
+  phys:
+    description: A reference to the SerDes lane(s)

This is not the same phy as phy-handle points to?

Best regards,
Krzysztof

author maintainer
#2 lore raw
Quoted 16 lines · Krzysztof Kozlowski
Quoted 15 lines · Frank Li

Add missed property phys, which indicate how connect to serdes phy.
Fix below warning:
arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: fsl-mc@80c000000: dpmacs:ethernet@7: Unevaluated properties are not allowed ('phys' was unexpected)

---
 Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml +0 -0
index 6538e0ce90b28..25d657be6956f 100644
@@ -38,6 +38,10 @@ properties:
 
Quoted 6 lines

Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml properties: · line 42

Quoted 4 lines
Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml +2 -0
   managed: true
 
+  phys:
+    description: A reference to the SerDes lane(s)

This is not the same phy as phy-handle points to?

I go through source code and dts, it is not the same. phys connect to chip internal serdas phys. phy-handle points to external ethernet phy, which is connected by mdio bus generally.

Frank

Quoted 4 lines

Best regards,
Krzysztof

#4 lore raw
In reply to Frank Li
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:

Quoted 8 lines · On Fri, 9 Aug 2024 16:06:53 -0400 you wrote:

Add missed property phys, which indicate how connect to serdes phy.
Fix below warning:
arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: fsl-mc@80c000000: dpmacs:ethernet@7: Unevaluated properties are not allowed ('phys' was unexpected)

---
 Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Here is the summary with links:
- [1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: add missed property phys

    https://git.kernel.org/netdev/net/c/c25504a0ba36

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html