exynos: pmu: use PS_HOLD based poweroff for all supported SoCs

PATCH New Marek Szyprowski 4 participants 8 messages Feb 9, 2015 – May 20, 2015

Subsystems (3)

Arm (32-bit) Arm sub-architectures Arm Samsung Exynos

lore

Share & tools

lore

Marek Szyprowski

author

2015-02-09 07:25 UTC #0 lore raw

PATCH 1/1 exynos: pmu: use PS_HOLD based poweroff for all supported SoCs

PS_HOLD based power off procedure is common for all Exynos SoCs, so use it for every Exynos SoC.

Signed-off-by Marek Szyprowski <[email protected]>

---
 arch/arm/mach-exynos/pmu.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

arch/arm/mach-exynos/pmu.c +3 -3

index c15761ca2f18..e812c1c85624 100644
@@ -681,7 +681,7 @@ static unsigned int const exynos5420_list_disable_pmu_reg[] = {
 	EXYNOS5420_CMU_RESET_FSYS_SYS_PWR_REG,
 };
 
-static void exynos5_power_off(void)
+static void exynos_power_off(void)
 {
 	unsigned int tmp;

@@ -872,8 +872,6 @@ static void exynos5420_pmu_init(void)
 			EXYNOS5420_ARM_INTR_SPREAD_USE_STANDBYWFI);
 
 	pmu_raw_writel(0x1, EXYNOS5420_UP_SCHEDULER);
-
-	pm_power_off = exynos5_power_off;
 	pr_info("EXYNOS5420 PMU initialized\n");
 }

@@ -984,6 +982,8 @@ static int exynos_pmu_probe(struct platform_device *pdev)
 	if (ret)
 		dev_warn(dev, "can't register restart handler err=%d\n", ret);
 
+	pm_power_off = exynos_power_off;
+
 	dev_dbg(dev, "Exynos PMU Driver probe done\n");
 	return 0;
 }

Signature · 1 line

1.9.2

Krzysztof Kozlowski

2015-02-09 09:06 UTC #1 lore raw

PATCH 1/1 exynos: pmu: use PS_HOLD based poweroff for all supported SoCs

2015-02-09 8:25 GMT+01:00 Marek Szyprowski <[email protected]>:

Quoted 7 lines

PS_HOLD based power off procedure is common for all Exynos SoCs, so use it for every Exynos SoC.
Signed-off-by Marek Szyprowski <[email protected]>
---
 arch/arm/mach-exynos/pmu.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

I tried this on Trats2 board (Exynos 4412) and message "Power down failed, please power off system manually." appears. Is it expected? Or am I missing some patches (I applied this on top of next-20150129)?

Best regards,
Krzysztof

Quoted 39 lines

arch/arm/mach-exynos/pmu.c +3 -4

index c15761ca2f18..e812c1c85624 100644
@@ -681,7 +681,7 @@ static unsigned int const exynos5420_list_disable_pmu_reg[] = {
        EXYNOS5420_CMU_RESET_FSYS_SYS_PWR_REG,
 };
 
-static void exynos5_power_off(void)
+static void exynos_power_off(void)
 {
        unsigned int tmp;

@@ -872,8 +872,6 @@ static void exynos5420_pmu_init(void)
                        EXYNOS5420_ARM_INTR_SPREAD_USE_STANDBYWFI);
 
        pmu_raw_writel(0x1, EXYNOS5420_UP_SCHEDULER);
-
-       pm_power_off = exynos5_power_off;
        pr_info("EXYNOS5420 PMU initialized\n");
 }

@@ -984,6 +982,8 @@ static int exynos_pmu_probe(struct platform_device *pdev)
        if (ret)
                dev_warn(dev, "can't register restart handler err=%d\n", ret);
 
+       pm_power_off = exynos_power_off;
+
        dev_dbg(dev, "Exynos PMU Driver probe done\n");
        return 0;
 }
--

1.9.2

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Krzysztof Kozlowski

2015-02-09 10:58 UTC #2 lore raw

PATCH 1/1 exynos: pmu: use PS_HOLD based poweroff for all supported SoCs

2015-02-09 10:06 GMT+01:00 Krzysztof Kozlowski <[email protected]>:

Quoted 4 lines

2015-02-09 8:25 GMT+01:00 Marek Szyprowski <[email protected]>:
Quoted 3 lines
PS_HOLD based power off procedure is common for all Exynos SoCs, so use it for every Exynos SoC.

Quoted 8 lines

Quoted 4 lines
Signed-off-by Marek Szyprowski <[email protected]>
---
 arch/arm/mach-exynos/pmu.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
I tried this on Trats2 board (Exynos 4412) and message "Power down failed, please power off system manually." appears. Is it expected? Or am I missing some patches (I applied this on top of next-20150129)?

It was my fault (I left attached JIG cable which prevents power off). Now it works fine.

Tested on Trats2 (Exynos4412):

Tested-by Krzysztof Kozlowski <[email protected]>

Patch also looks good, so:

Reviewed-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

Marek Szyprowski

author

2015-03-20 15:11 UTC #3 lore raw

PATCH 1/1 exynos: pmu: use PS_HOLD based poweroff for all supported SoCs

Hello,

Quoted 12 lines · Krzysztof Kozlowski

2015-02-09 10:06 GMT+01:00 Krzysztof Kozlowski <[email protected]>:
Quoted 11 lines
2015-02-09 8:25 GMT+01:00 Marek Szyprowski <[email protected]>:
Quoted 7 lines
PS_HOLD based power off procedure is common for all Exynos SoCs, so use it for every Exynos SoC.
Signed-off-by Marek Szyprowski <[email protected]>
---
  arch/arm/mach-exynos/pmu.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
I tried this on Trats2 board (Exynos 4412) and message "Power down failed, please power off system manually." appears. Is it expected? Or am I missing some patches (I applied this on top of next-20150129)?

Quoted 8 lines

It was my fault (I left attached JIG cable which prevents power off). Now it works fine.
Tested on Trats2 (Exynos4412):
Tested-by Krzysztof Kozlowski <[email protected]>
Patch also looks good, so:
Reviewed-by Krzysztof Kozlowski <[email protected]>

Gentle ping for merging this in v4.1-next...

Best regards

Signature · 2 lines

Marek Szyprowski, PhD
Samsung R&D Institute Poland

Tobias Jakobi

2015-03-20 16:03 UTC #4 lore raw

PATCH 1/1 exynos: pmu: use PS_HOLD based poweroff for all supported SoCs

Hello Marek,

Quoted 6 lines · Marek Szyprowski

Quoted 6 lines
It was my fault (I left attached JIG cable which prevents power off). Now it works fine.
Tested on Trats2 (Exynos4412):
Tested-by Krzysztof Kozlowski <[email protected]>

Quoted 6 lines

Quoted 2 lines
Patch also looks good, so:
Reviewed-by Krzysztof Kozlowski <[email protected]>
Gentle ping for merging this in v4.1-next...
Best regards

I'd say that this is even a candidate for 4.0.0. Like I reported earlier, the SoC gets really hot without proper shutdown, so definitely something you don't want for a not properly cooled system (U3 without the fan running e.g.).

With best wishes,
Tobias

Kukjin Kim

2015-03-24 08:06 UTC #5 lore raw

PATCH 1/1 exynos: pmu: use PS_HOLD based poweroff for all supported SoCs

In reply to Marek Szyprowski

Quoted 3 lines · Marek Szyprowski

Hello,

Hi,

Quoted 16 lines · Krzysztof Kozlowski

Quoted 15 lines
2015-02-09 10:06 GMT+01:00 Krzysztof Kozlowski <[email protected]>:
Quoted 11 lines
2015-02-09 8:25 GMT+01:00 Marek Szyprowski <[email protected]>:
Quoted 7 lines
PS_HOLD based power off procedure is common for all Exynos SoCs, so use it for every Exynos SoC.
Signed-off-by Marek Szyprowski <[email protected]>
---
  arch/arm/mach-exynos/pmu.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
I tried this on Trats2 board (Exynos 4412) and message "Power down failed, please power off system manually." appears. Is it expected? Or am I missing some patches (I applied this on top of next-20150129)?
It was my fault (I left attached JIG cable which prevents power off). Now it works fine.

Quoted 8 lines

Quoted 5 lines
Tested on Trats2 (Exynos4412):
Tested-by Krzysztof Kozlowski <[email protected]>
Patch also looks good, so:
Reviewed-by Krzysztof Kozlowski <[email protected]>
Gentle ping for merging this in v4.1-next...

OK, I'll queue this into v4.1-next/mach-samsung.

Just note, some newer SoC has different poweroff scheme not just using PS_HOLD based so maybe we need to revisit the poweroff later ;-)

Thanks,
Kukjin

Krzysztof Kozlowski

2015-05-20 06:31 UTC #6 lore raw

PATCH 1/1 exynos: pmu: use PS_HOLD based poweroff for all supported SoCs

2015-03-24 17:06 GMT+09:00 Kukjin Kim <[email protected]>:

Quoted 25 lines

Quoted 3 lines · Marek Szyprowski
Hello,
Hi,
Quoted 19 lines · Krzysztof Kozlowski
Quoted 18 lines
2015-02-09 10:06 GMT+01:00 Krzysztof Kozlowski <[email protected]>:
Quoted 11 lines
2015-02-09 8:25 GMT+01:00 Marek Szyprowski <[email protected]>:
Quoted 7 lines
PS_HOLD based power off procedure is common for all Exynos SoCs, so use it for every Exynos SoC.
Signed-off-by Marek Szyprowski <[email protected]>
---
  arch/arm/mach-exynos/pmu.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
I tried this on Trats2 board (Exynos 4412) and message "Power down failed, please power off system manually." appears. Is it expected? Or am I missing some patches (I applied this on top of next-20150129)?
It was my fault (I left attached JIG cable which prevents power off). Now it works fine.
Tested on Trats2 (Exynos4412):
Tested-by Krzysztof Kozlowski <[email protected]>

Quoted 6 lines

Quoted 5 lines
Quoted 2 lines
Patch also looks good, so:
Reviewed-by Krzysztof Kozlowski <[email protected]>
Gentle ping for merging this in v4.1-next...
OK, I'll queue this into v4.1-next/mach-samsung.

This patch is waiting enough time and it missed the 4.1. Kukjin, could you apply it for 4.2? I'll apply it anyway to my tree.

Best regards,
Krzysztof

Tobias Jakobi

2015-02-09 20:24 UTC #7 lore raw

PATCH 1/1 exynos: pmu: use PS_HOLD based poweroff for all supported SoCs

In reply to Marek Szyprowski

Quoted 2 lines · Marek Szyprowski

PS_HOLD based power off procedure is common for all Exynos SoCs, so use it for every Exynos SoC.

Tested on my Odroid-X2 and it seems to solve the 'heating issue' when the system is shut down but left on the AC adapter.

With best wishes,
Tobias