Skip to contentSkip to conversation

CONFIG_GENERIC_PPC32

DISCUSSION Michael Sokolov 4 participants 5 messages Apr 6, 2002 – Apr 9, 2002

lore
Share & tools
lore
#0 lore raw
Quoted 3 lines · Benjamin Herrenschmidt

I haven't look at the patch yet, but is my understanding correct that you have individual config options enabling the various board support and that you allow more than one to be selected at one time ?

Yes.

Quoted 2 lines

If that is the case, then that's great. It's also what the arm ach does and I like it.

Good.

Quoted 1 line

Great ! Looks like you have more time than I do to spend on this.

It's just that I have a much greater need for it than you do. You guys using PMacs can live with what you've got now, but I'm trying to make my own PPC boards and I have to make mainline Linux support them in order to sell them, so...

Quoted 2 lines

I'll
look at your patch and eventually get it merged asap.

Thanks!

MS

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

#1 lore raw
Quoted 9 lines
Quoted 4 lines

I haven't look at the patch yet, but is my understanding correct that you have individual config options enabling the various board support and that you allow more than one to be selected at one time ?

Yes.

Quoted 2 lines

If that is the case, then that's great. It's also what the arm ach does and I like it.

Hi Paul !

I've looked at the patch in the meantime and it makes much sense. I want to do something around those lines:

- Completely rip off CONFIG_ALL_PPC in favor of CONFIG_GENERIC_PPC32
- Each board model has it's own CONFIG_xxx entry (like Michael patch), which means adding "back" CONFIG_PMAC, CONFIG_CHRP, CONFIG_PREP, but those will only control which set of .c file will get in the makefile and the toplevel switch/case on platform_init. That is you will be able to select an arbitrary set of boards.
- bi_recs are found in r4 when r3 contains "birc" (please, Michael, adapt to this so we stay consistent which what BootX does). Older way of finding them & cmdline & initrd still used when r3 doesn't contain that magic value. r5 still contains the OF PROM pointer, at least until we have the OF interface in a wrapper.

I think this patch will not be that invasive, and it will be fully backward compatible, so I do intend to push it to _2_4_devel though I want your ack first. I don't plan to include Michael boards in it, I want to rework our ground to match what Michael does and then let him drop in his new boards.

Ben.

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

#2 lore raw
Quoted 9 lines · Benjamin Herrenschmidt

I've looked at the patch in the meantime and it makes much sense. I want to do something around those lines:

- Completely rip off CONFIG_ALL_PPC in favor of CONFIG_GENERIC_PPC32
- Each board model has it's own CONFIG_xxx entry (like Michael patch), which means adding "back" CONFIG_PMAC, CONFIG_CHRP, CONFIG_PREP, but those will only control which set of .c file will get in the makefile and the toplevel switch/case on platform_init. That is you will be able to select an arbitrary set of boards.

Good, starts to look like m68k again, where you always were able to compile a generic kernel (except for Sun-3 (not 3x) due to the different MMU)! Now start moving platform specific files to arch/ppc/$platform/ again. Dan is right, we're running in circles :-)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

#3 lore raw
Quoted 12 lines · Benjamin Herrenschmidt
Quoted 9 lines

I've looked at the patch in the meantime and it makes much sense. I want to do something around those lines:

- Completely rip off CONFIG_ALL_PPC in favor of CONFIG_GENERIC_PPC32
- Each board model has it's own CONFIG_xxx entry (like Michael patch), which means adding "back" CONFIG_PMAC, CONFIG_CHRP, CONFIG_PREP, but those will only control which set of .c file will get in the makefile and the toplevel switch/case on platform_init. That is you will be able to select an arbitrary set of boards.

Quoted 4 lines

Good, starts to look like m68k again, where you always were able to compile a generic kernel (except for Sun-3 (not 3x) due to the different MMU)! Now start moving platform specific files to arch/ppc/$platform/ again. Dan is right, we're running in circles :-)

No, we aren't ;)

In some way, all those new board brought us back to the pre-CONFIG_ALL_PPC days since they all have their own config option and can't live in a generic kernel. Mostly for no reason except maybe detecting the board at boot time (which can be done in the wrapper now if there is no other way).

The other way, iirc, making the generic (CONFIG_ALL_PPC) kernel from split pmac/chrp/prep was necessary to get the non-platform specific code really non-platform specific (at that time, we had the "common" irq, pci etc... code diff'ing between platforms or #ifdef'ed in places).

So we aren't circling here. We are slowly moving toward an arch where the common code is really common and no crippled with platform ifdefs, and a platform is just a set of functions behind ppc_md along with appropriate drivers beeing in the Makefile. It's a logical step to do the (few) Makefile and Config.in work to make those individual platforms be selectable in arbitrary sets.

Ben.

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

#4 lore raw
In reply to Geert Uytterhoeven
Quoted 11 lines · Geert Uytterhoeven
Quoted 6 lines

- Completely rip off CONFIG_ALL_PPC in favor of CONFIG_GENERIC_PPC32
- Each board model has it's own CONFIG_xxx entry (like Michael patch), which means adding "back" CONFIG_PMAC, CONFIG_CHRP, CONFIG_PREP, but those will only control which set of .c file will get in the makefile and the toplevel switch/case on platform_init. That is you will be able to select an arbitrary set of boards.

Good, starts to look like m68k again, where you always were able to compile a generic kernel (except for Sun-3 (not 3x) due to the different MMU)! Now start moving platform specific files to arch/ppc/$platform/ again. Dan is right, we're running in circles :-)

Good spotting, Waldorf! :-)

ROTFL,

Michael

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/