Skip to contentSkip to conversation

Miscellaneous updates

PATCH In review Akira Yokosawa 2 participants 7 messages Oct 26, 2017 – Oct 27, 2017

lore
Share & tools
lore
#0 lore raw

cover Miscellaneous updates

From 263fa8f220207903d6c41bddb773b113b65dd98f Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <[email protected]>
Date: Fri, 27 Oct 2017 07:23:35 +0900
Subject: [PATCH 0/5] Miscellaneous updates

Hi Paul,

This patch set is a collection of small fixes and tweaks.

Patchs #1 -- #4 are trivial fixes
Patch #5 shrinks/enlarges figures which were too large/small. (I like those penguin cartoons, but ...) ;-)

Thanks, Akira
--
Akira Yokosawa (5):
memorder: Fix excessive uses of skips in midrule
memorder: Parenthesize properly defer/rcufundamental: Adjust hspace for 1c layout together/applyrcu: Use upright gryph for descriptive suffix Tweak figure size

 SMPdesign/SMPdesign.tex     | 14 +++++++-------
 advsync/rt.tex              | 12 ++++++------
 appendix/questions/time.tex |  2 +-
 count/count.tex             |  4 ++--
 defer/rcufundamental.tex    |  4 ++--
 future/QC.tex               |  2 +-
 future/cpu.tex              |  4 ++--
 future/tm.tex               |  4 ++--
 intro/intro.tex             |  2 +-
 memorder/memorder.tex       | 10 +++++-----
 together/applyrcu.tex       |  8 ++++----
 11 files changed, 33 insertions(+), 33 deletions(-)
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/5 memorder: Fix excessive uses of midrule skip

From 02bb04ebd5d1cce822aebb1e01fb0331e8b56aad Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <[email protected]>
Date: Wed, 25 Oct 2017 20:22:24 +0900
Subject: [PATCH 1/5] memorder: Fix excessive uses of midrule skip

---
 memorder/memorder.tex | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
memorder/memorder.tex +3 -3
index 238783e..0ee4cad 100644
@@ -1973,15 +1973,15 @@ line to carry this new value to them.
 \small
 \centering\OneColumnHSpace{-0.8in}
 \renewcommand*{\arraystretch}{1.1}
-\rowcolors{13}{lightgray}{}
+\rowcolors{10}{}{lightgray}
 \begin{tabular}{rlllllll}\toprule
 	& \multicolumn{1}{c}{\tco{P0()}} & \multicolumn{2}{c}{\tco{P0()} \& \tco{P1()}} &
 		\multicolumn{1}{c}{\tco{P1()}} & \multicolumn{3}{c}{\tco{P2()}} \\
 	\cmidrule(l){2-2} \cmidrule(l){3-4} \cmidrule(lr){5-5} \cmidrule(l){6-8}
 	& Instruction & Store Buffer & Cache & Instruction &
 			Instruction & Store Buffer & Cache \\
-	\cmidrule{1-1} \cmidrule(l){2-2} \cmidrule(l){3-3} \cmidrule(l){4-4}
-		\cmidrule(lr){5-5} \cmidrule(l){6-6} \cmidrule(l){7-7} \cmidrule(l){8-8}
+	\cmidrule{1-1} \cmidrule(l){2-2} \cmidrule(l){3-4}
+		\cmidrule(lr){5-5} \cmidrule(l){6-8}
 	1 & (Initial state) & & \tco{y==0} &
 		(Initial state) &
 			(Initial state) & & \tco{x==0} \\
Signature · 1 line
2.7.4
#2 lore raw

PATCH 2/5 memorder: Parenthesize properly

In reply to Akira Yokosawa

From e1debe2d8a47bae3f81721c576ec978abcee0bab Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <[email protected]>
Date: Thu, 26 Oct 2017 22:34:44 +0900
Subject: [PATCH 2/5] memorder: Parenthesize properly

---
 memorder/memorder.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
memorder/memorder.tex +1 -1
index 0ee4cad..7fa190a 100644
@@ -18,7 +18,7 @@ code that fails to use standard mechanisms, one important example
 of course being the code that implements these standard mechanisms,
 and another being performance-critical code that uses weaker
 synchronization (in fact, some have argued that weakness is a
-virtue~\cite{JadeAlglave2013-WeaknessIsVirtue}..
+virtue~\cite{JadeAlglave2013-WeaknessIsVirtue}).
 This chapter will help you gain an understanding of memory ordering
 sufficient to implement synchronization primitives and other
 performance-critical code.
Signature · 1 line
2.7.4
#3 lore raw

PATCH 3/5 defer/rcufundamental: Adjust hspace for 1c layout

In reply to Akira Yokosawa

From bc8c675a5cb92407aacb90c55473080f40b80236 Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <[email protected]>
Date: Thu, 26 Oct 2017 23:48:30 +0900
Subject: [PATCH 3/5] defer/rcufundamental: Adjust hspace for 1c layout

---
 defer/rcufundamental.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
defer/rcufundamental.tex +1 -1
index 27c6421..9b0ffa7 100644
@@ -382,7 +382,7 @@ circular list:
 \begin{table*}[tb]
 \renewcommand*{\arraystretch}{1.2}
 \centering
-\footnotesize
+\footnotesize\OneColumnHSpace{-0.4in}
 \begin{tabular}{llll}
 \toprule
 Category  & Publish	& Retract	& Subscribe \\
Signature · 1 line
2.7.4
#4 lore raw

PATCH 4/5 together/applyrcu: Use upright glyph for descriptive suffix

In reply to Akira Yokosawa

From 6ed5c9accaad77683040a1c936a27fab3ce5f975 Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <[email protected]>
Date: Fri, 27 Oct 2017 00:14:07 +0900
Subject: [PATCH 4/5] together/applyrcu: Use upright glyph for descriptive suffix

---
 together/applyrcu.tex | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
together/applyrcu.tex +4 -4
index 1169603..11aaa73 100644
@@ -87,13 +87,13 @@ execution.
 
 	Or, for those who prefer equations:
 	\begin{equation}
-	\epsilon = \frac{T_r R_i}{2}
+	\epsilon = \frac{T_\mathrm{r} R_\mathrm{i}}{2}
 	\end{equation}
 	where $\epsilon$ is the expected error in \co{read_count()}'s
 	return value,
-	$T_r$ is the time that \co{read_count()} takes to execute,
-	and $R_i$ is the rate of \co{inc_count()} calls per unit time.
-	(And of course, $T_r$ and $R_i$ should use the same units of
+	$T_\mathrm{r}$ is the time that \co{read_count()} takes to execute,
+	and $R_\mathrm{i}$ is the rate of \co{inc_count()} calls per unit time.
+	(And of course, $T_\mathrm{r}$ and $R_\mathrm{i}$ should use the same units of
 	time: microseconds and calls per microsecond, seconds and calls
 	per second, or whatever, as long as they are the same units.)
 } \QuickQuizEnd
Signature · 1 line
2.7.4
#5 lore raw

PATCH 5/5 Tweak figure size

In reply to Akira Yokosawa

From 263fa8f220207903d6c41bddb773b113b65dd98f Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <[email protected]>
Date: Fri, 27 Oct 2017 00:18:32 +0900
Subject: [PATCH 5/5] Tweak figure size

Some of the figures are rendered too large or too small. This commit tweaks argmuents of \resizebox{} macros to make those figures look consistent in their sizes.

Two figures in advsync/rt.tex was too small with the column width of 2c layout. They are converted to "figure*" environments with larger widths.

---
 SMPdesign/SMPdesign.tex     | 14 +++++++-------
 advsync/rt.tex              | 12 ++++++------
 appendix/questions/time.tex |  2 +-
 count/count.tex             |  4 ++--
 defer/rcufundamental.tex    |  2 +-
 future/QC.tex               |  2 +-
 future/cpu.tex              |  4 ++--
 future/tm.tex               |  4 ++--
 intro/intro.tex             |  2 +-
 memorder/memorder.tex       |  2 +-
 10 files changed, 24 insertions(+), 24 deletions(-)
SMPdesign/SMPdesign.tex +7 -7
index 56eac22..656adda 100644
@@ -45,7 +45,7 @@ takes a brief look beyond partitioning.
 
 \begin{figure}[tb]
 \centering
-\includegraphics{SMPdesign/LockGranularity}
+\resizebox{1.2in}{!}{\includegraphics{SMPdesign/LockGranularity}}
 \caption{Design Patterns and Lock Granularity}
 \label{fig:SMPdesign:Design Patterns and Lock Granularity}
 \end{figure}
@@ -268,7 +268,7 @@ in the next section.
 
 \begin{figure}[tbh]
 \centering
-\resizebox{3in}{!}{\includegraphics{cartoons/r-2014-Data-one-fighting}}
+\resizebox{2.5in}{!}{\includegraphics{cartoons/r-2014-Data-one-fighting}}
 \caption{Lock Contention}
 \ContributedBy{Figure}{fig:SMPdesign:Lock Contention}{Melissa Broussard}
 \end{figure}
@@ -352,7 +352,7 @@ systems~\cite{Beck85,Inman85,Garg90,Dove90,McKenney92b,McKenney92a,McKenney93}.
 
 \begin{figure}[tbh]
 \centering
-\resizebox{3in}{!}{\includegraphics{cartoons/r-2014-Data-many-happy}}
+\resizebox{2.4in}{!}{\includegraphics{cartoons/r-2014-Data-many-happy}}
 \caption{Data Locking}
 \ContributedBy{Figure}{fig:SMPdesign:Data Locking}{Melissa Broussard}
 \end{figure}
@@ -387,7 +387,7 @@ shown in Figure~\ref{fig:SMPdesign:Data and Skew}.
 
 \begin{figure}[tbh]
 \centering
-\resizebox{3in}{!}{\includegraphics{cartoons/r-2014-Data-many-fighting}}
+\resizebox{\twocolumnwidth}{!}{\includegraphics{cartoons/r-2014-Data-many-fighting}}
 \caption{Data Locking and Skew}
 \ContributedBy{Figure}{fig:SMPdesign:Data and Skew}{Melissa Broussard}
 \end{figure}
@@ -772,8 +772,8 @@ as depicted in Figure~\ref{fig:SMPdesign:Parallel-Fastpath Design Patterns}:
 
 \begin{figure}[tbp]
 \centering
-% \resizebox{3in}{!}{\includegraphics{SMPdesign/ParallelFastpath}}
-\includegraphics{SMPdesign/ParallelFastpath}
+\resizebox{2.3in}{!}{\includegraphics{SMPdesign/ParallelFastpath}}
+% \includegraphics{SMPdesign/ParallelFastpath}
 \caption{Parallel-Fastpath Design Patterns}
 \label{fig:SMPdesign:Parallel-Fastpath Design Patterns}
 \end{figure}
@@ -1045,7 +1045,7 @@ smaller than the number of non-\co{NULL} pointers.
 
 \begin{figure}[tbp]
 \centering
-\resizebox{3in}{!}{\includegraphics{SMPdesign/AllocatorPool}}
+\resizebox{2.6in}{!}{\includegraphics{SMPdesign/AllocatorPool}}
 \caption{Allocator Pool Schematic}
 \label{fig:SMPdesign:Allocator Pool Schematic}
 \end{figure}
advsync/rt.tex +6 -6
index 8740e93..ac8cf1a 100644
@@ -971,12 +971,12 @@ In short, the Linux kernel's -rt patchset uses timer wheels for
 error-handling timeouts and a tree for timer events, providing each
 category the required quality of service.
 
-\begin{figure}[tb]
+\begin{figure*}[tb]
 \centering
-\resizebox{3.0in}{!}{\includegraphics{advsync/irq}}
+\resizebox{1.4\twocolumnwidth}{!}{\includegraphics{advsync/irq}}
 \caption{Non-Threaded Interrupt Handler}
 \label{fig:advsync:Non-Threaded Interrupt Handler}
-\end{figure}
+\end{figure*}
 
 \paragraph{Threaded interrupts}
 are used to address a significant source of degraded real-time latencies,
@@ -991,12 +991,12 @@ Worse yet are devices that can deliver new events to a still-running
 interrupt handler, as such an interrupt handler might well run
 indefinitely, thus indefinitely degrading real-time latencies.
 
-\begin{figure}[tb]
+\begin{figure*}[tb]
 \centering
-\resizebox{3.0in}{!}{\includegraphics{advsync/threaded-irq}}
+\resizebox{1.4\twocolumnwidth}{!}{\includegraphics{advsync/threaded-irq}}
 \caption{Threaded Interrupt Handler}
 \label{fig:advsync:Threaded Interrupt Handler}
-\end{figure}
+\end{figure*}
 
 One way of addressing this problem is the use of threaded interrupts shown in
 Figure~\ref{fig:advsync:Threaded Interrupt Handler}.
appendix/questions/time.tex +1 -1
index 137375e..1bbb052 100644
@@ -6,7 +6,7 @@
 
 \begin{figure}[htb]
 \centering
-\resizebox{3in}{!}{\includegraphics{cartoons/r-2014-What-time-is-it}}
+\resizebox{2.6in}{!}{\includegraphics{cartoons/r-2014-What-time-is-it}}
 \caption{What Time Is It?}
 \ContributedBy{Figure}{fig:app:questions:What Time Is It?}{Melissa Broussard}
 \end{figure}
count/count.tex +2 -2
index 9a4835d..900c384 100644
@@ -353,7 +353,7 @@ decidedly non-ideal, and gets worse as you add CPUs.
 
 \begin{figure}[tb]
 \centering
-\resizebox{3in}{!}{\includegraphics{cartoons/r-2014-One-one-thousand}}
+\resizebox{3.2in}{!}{\includegraphics{cartoons/r-2014-One-one-thousand}}
 \caption{Waiting to Count}
 \ContributedBy{Figure}{fig:count:Waiting to Count}{Melissa Broussard}
 \end{figure}
@@ -1408,7 +1408,7 @@ Section~\ref{sec:SMPdesign:Parallel Fastpath}.
 
 \begin{figure}[tb]
 \centering
-\resizebox{3in}{!}{\includegraphics{count/count_lim}}
+\resizebox{2.5in}{!}{\includegraphics{count/count_lim}}
 \caption{Simple Limit Counter Variable Relationships}
 \label{fig:count:Simple Limit Counter Variable Relationships}
 \end{figure}
defer/rcufundamental.tex +1 -1
index 9b0ffa7..ef3e4d4 100644
@@ -215,7 +215,7 @@ absolutely no code.
 
 \begin{figure}[tb]
 \centering
-\resizebox{3in}{!}{\includegraphics{defer/Linux_list_abbr}}
+\resizebox{1.8in}{!}{\includegraphics{defer/Linux_list_abbr}}
 \caption{Linux Linked List Abbreviated}
 \label{fig:defer:Linux Linked List Abbreviated}
 \end{figure}
future/QC.tex +1 -1
index f470de5..70245f9 100644
@@ -286,7 +286,7 @@ challenges from mathematicians.
 
 \begin{figure}[tb]
 \centering
-\resizebox{2.5in}{!}{\includegraphics{future/Bloch_Sphere}}
+\resizebox{2.2in}{!}{\includegraphics{future/Bloch_Sphere}}
 \caption{Qubit as Bloch Sphere}
 \label{fig:future:Qubit as Bloch Sphere}
 \end{figure}
future/cpu.tex +2 -2
index 31cbc18..977140f 100644
@@ -22,14 +22,14 @@ With that in mind, consider the following scenarios:
 
 \begin{figure}[tb]
 \centering
-\resizebox{3in}{!}{\includegraphics{cartoons/r-2014-CPU-Future-Multithreaded-Mania}}
+\resizebox{2.6in}{!}{\includegraphics{cartoons/r-2014-CPU-Future-Multithreaded-Mania}}
 \caption{Multithreaded Mania}
 \ContributedBy{Figure}{fig:future:Multithreaded Mania}{Melissa Broussard}
 \end{figure}
 
 \begin{figure}[tb]
 \centering
-\resizebox{3in}{!}{\includegraphics{cartoons/r-2014-CPU-Future-More-of-the-Same}}
+\resizebox{2.5in}{!}{\includegraphics{cartoons/r-2014-CPU-Future-More-of-the-Same}}
 \caption{More of the Same}
 \ContributedBy{Figure}{fig:future:More of the Same}{Melissa Broussard}
 \end{figure}
future/tm.tex +2 -2
index 8420331..c6c1291 100644
@@ -1027,7 +1027,7 @@ And vice versa.
 
 \begin{figure}[tb]
 \centering
-\resizebox{3in}{!}{\includegraphics{cartoons/TM-the-reality-conflict}}
+\resizebox{2.7in}{!}{\includegraphics{cartoons/TM-the-reality-conflict}}
 \caption{The STM Reality: Conflicts}
 \ContributedBy{Figure}{fig:future:The STM Reality: Conflicts}{Melissa Broussard}
 \end{figure}
@@ -1041,7 +1041,7 @@ And vice versa.
 
 \begin{figure}[tb]
 \centering
-\resizebox{3in}{!}{\includegraphics{cartoons/TM-the-reality-realtime}}
+\resizebox{2.7in}{!}{\includegraphics{cartoons/TM-the-reality-realtime}}
 \caption{The STM Reality: Realtime Response}
 \ContributedBy{Figure}{fig:future:The STM Reality: Realtime Response}{Melissa Broussard}
 \end{figure}
intro/intro.tex +1 -1
index 293a02f..12a2b20 100644
@@ -562,7 +562,7 @@ programming environments:
 
 \begin{figure}[tb]
 \centering
-\resizebox{3in}{!}{\includegraphics{intro/PPGrelation}}
+\resizebox{2in}{!}{\includegraphics{intro/PPGrelation}}
 \caption{Software Layers and Performance, Productivity, and Generality}
 \label{fig:intro:Software Layers and Performance, Productivity, and Generality}
 \end{figure}
memorder/memorder.tex +1 -1
index 7fa190a..f0e65ee 100644
@@ -205,7 +205,7 @@ residing in other CPUs' caches.
 
 \begin{figure}[htb]
 \centering
-\resizebox{3in}{!}{\includegraphics{cartoons/r-2014-Out-of-order}}
+\resizebox{2.4in}{!}{\includegraphics{cartoons/r-2014-Out-of-order}}
 \caption{CPUs Can Do Things Out of Order}
 \ContributedBy{Figure}{fig:memorder:CPUs Can Do Things Out of Order}{Melissa Broussard}
 \end{figure}
Signature · 1 line
2.7.4
#6 lore raw
In reply to Akira Yokosawa
Quoted 7 lines · Akira Yokosawa
Quoted 1 line

From 263fa8f220207903d6c41bddb773b113b65dd98f Mon Sep 17 00:00:00 2001

From: Akira Yokosawa <[email protected]>
Date: Fri, 27 Oct 2017 07:23:35 +0900
Subject: [PATCH 0/5] Miscellaneous updates

Hi Paul,

Quoted 7 lines

This patch set is a collection of small fixes and tweaks.

Patchs #1 -- #4 are trivial fixes
Patch #5 shrinks/enlarges figures which were too large/small. (I like those penguin cartoons, but ...) ;-)

Thanks, Akira

;-)

Applied and pushed, thank you!

Thanx, Paul

Quoted 24 lines

--
Akira Yokosawa (5):
memorder: Fix excessive uses of skips in midrule
memorder: Parenthesize properly defer/rcufundamental: Adjust hspace for 1c layout together/applyrcu: Use upright gryph for descriptive suffix Tweak figure size

 SMPdesign/SMPdesign.tex     | 14 +++++++-------
 advsync/rt.tex              | 12 ++++++------
 appendix/questions/time.tex |  2 +-
 count/count.tex             |  4 ++--
 defer/rcufundamental.tex    |  4 ++--
 future/QC.tex               |  2 +-
 future/cpu.tex              |  4 ++--
 future/tm.tex               |  4 ++--
 intro/intro.tex             |  2 +-
 memorder/memorder.tex       | 10 +++++-----
 together/applyrcu.tex       |  8 ++++----
 11 files changed, 33 insertions(+), 33 deletions(-)
Signature · 1 line
2.7.4