Skip to contentSkip to conversation

Connection issue since 81b3e33bb054 ("Bluetooth: btusb: Don't fail external suspend requests")

DISCUSSION Heiner Kallweit 2 participants 11 messages Oct 11, 2024 – Oct 12, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Since linux-next from Oct 4th my bt speaker fails to connect if I switch it on. It just hangs trying. Manually connecting it via bluetoothctl works though. With this patch reverted it auto-connects again.
If you need additional details, please let me know.

#1 lore raw

Hi Heiner,

Quoted 5 lines · Heiner Kallweit

Since linux-next from Oct 4th my bt speaker fails to connect if I switch it on. It just hangs trying. Manually connecting it via bluetoothctl works though. With this patch reverted it auto-connects again.
If you need additional details, please let me know.

I suspect something is trying to suspend the controller then, it shouldn't be USB auto-suspend since that should behave as it previously but if there is something externally (aka. userspace) trying to suspend then it will force it to suspend.

Signature · 1 line
Luiz Augusto von Dentz
#2 lore raw
Quoted 9 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 5 lines · Heiner Kallweit

Since linux-next from Oct 4th my bt speaker fails to connect if I switch it on. It just hangs trying. Manually connecting it via bluetoothctl works though. With this patch reverted it auto-connects again.
If you need additional details, please let me know.

Quoted 5 lines

I suspect something is trying to suspend the controller then, it shouldn't be USB auto-suspend since that should behave as it previously but if there is something externally (aka. userspace) trying to suspend then it will force it to suspend.

On the host side it's a combined WiFi/BT PCIe adapter (RTL8822CE). Runtime PM is enabled, so this may kick in. I'm not aware of any userspace tool which may try to suspend the WiFi/BT adapter. Disabling Runtime PM may be a workaround, but I don't think that's the actual solution.

#3 lore raw

Hi Heiner,

Quoted 16 lines · Heiner Kallweit
Quoted 9 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 5 lines · Heiner Kallweit

Since linux-next from Oct 4th my bt speaker fails to connect if I switch it on. It just hangs trying. Manually connecting it via bluetoothctl works though. With this patch reverted it auto-connects again.
If you need additional details, please let me know.

Quoted 5 lines

I suspect something is trying to suspend the controller then, it shouldn't be USB auto-suspend since that should behave as it previously but if there is something externally (aka. userspace) trying to suspend then it will force it to suspend.

Quoted 6 lines

On the host side it's a combined WiFi/BT PCIe adapter (RTL8822CE). Runtime PM is enabled, so this may kick in. I'm not aware of any userspace tool which may try to suspend the WiFi/BT adapter. Disabling Runtime PM may be a workaround, but I don't think that's the actual solution.

Well I assume it still using USB as transport, not PCIe, otherwise it wouldn't be using btusb. Regarding runtime PM, I assume it still means PMSG_IS_AUTO Documentation/driver-api/usb/power-management.rst:

'External suspend calls should never be allowed to fail in this way, only autosuspend calls. The driver can tell them apart by applying the :c:func:PMSG_IS_AUTO macro to the message argument to the ``suspend`` method; it will return True for internal PM events'

Signature · 1 line
Luiz Augusto von Dentz
#4 lore raw

Hi Heiner,

Quoted 31 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 16 lines · Heiner Kallweit
Quoted 9 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 5 lines · Heiner Kallweit

Since linux-next from Oct 4th my bt speaker fails to connect if I switch it on. It just hangs trying. Manually connecting it via bluetoothctl works though. With this patch reverted it auto-connects again.
If you need additional details, please let me know.

Quoted 5 lines

I suspect something is trying to suspend the controller then, it shouldn't be USB auto-suspend since that should behave as it previously but if there is something externally (aka. userspace) trying to suspend then it will force it to suspend.

Quoted 6 lines

On the host side it's a combined WiFi/BT PCIe adapter (RTL8822CE). Runtime PM is enabled, so this may kick in. I'm not aware of any userspace tool which may try to suspend the WiFi/BT adapter. Disabling Runtime PM may be a workaround, but I don't think that's the actual solution.

Well I assume it still using USB as transport, not PCIe, otherwise it wouldn't be using btusb. Regarding runtime PM, I assume it still means PMSG_IS_AUTO Documentation/driver-api/usb/power-management.rst:

Quoted 7 lines

'External suspend calls should never be allowed to fail in this way, only autosuspend calls. The driver can tell them apart by applying the :c:func:PMSG_IS_AUTO macro to the message argument to the ``suspend`` method; it will return True for internal PM events'

--
Luiz Augusto von Dentz

Perhaps there is a double call to the likes of hci_suspend_dev due to system suspend and device suspend acting together, so maybe we need something like the following:

net/bluetooth/hci_core.c +2 -2
index 779c4aeaef22..c257759ae2f4 100644
@@ -2812,7 +2812,7 @@ int hci_suspend_dev(struct hci_dev *hdev)
 
        /* Suspend should only act on when powered. */
        if (!hdev_is_powered(hdev) ||
-           hci_dev_test_flag(hdev, HCI_UNREGISTER))
+           hci_dev_test_flag(hdev, HCI_UNREGISTER) || hdev->suspended)
                return 0;
 
        /* If powering down don't attempt to suspend */
@@ -2843,7 +2843,7 @@ int hci_resume_dev(struct hci_dev *hdev)
 
        /* Resume should only act on when powered. */
        if (!hdev_is_powered(hdev) ||
-           hci_dev_test_flag(hdev, HCI_UNREGISTER))
+           hci_dev_test_flag(hdev, HCI_UNREGISTER) || !hdev->suspended)
                return 0;
 
        /* If powering down don't attempt to resume */
Signature · 1 line
Luiz Augusto von Dentz
#5 lore raw
Quoted 63 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 31 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 16 lines · Heiner Kallweit
Quoted 9 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 5 lines · Heiner Kallweit

Since linux-next from Oct 4th my bt speaker fails to connect if I switch it on. It just hangs trying. Manually connecting it via bluetoothctl works though. With this patch reverted it auto-connects again.
If you need additional details, please let me know.

Quoted 5 lines

I suspect something is trying to suspend the controller then, it shouldn't be USB auto-suspend since that should behave as it previously but if there is something externally (aka. userspace) trying to suspend then it will force it to suspend.

Quoted 6 lines

On the host side it's a combined WiFi/BT PCIe adapter (RTL8822CE). Runtime PM is enabled, so this may kick in. I'm not aware of any userspace tool which may try to suspend the WiFi/BT adapter. Disabling Runtime PM may be a workaround, but I don't think that's the actual solution.

Well I assume it still using USB as transport, not PCIe, otherwise it wouldn't be using btusb. Regarding runtime PM, I assume it still means PMSG_IS_AUTO Documentation/driver-api/usb/power-management.rst:

Quoted 7 lines

'External suspend calls should never be allowed to fail in this way, only autosuspend calls. The driver can tell them apart by applying the :c:func:PMSG_IS_AUTO macro to the message argument to the ``suspend`` method; it will return True for internal PM events'

--
Luiz Augusto von Dentz

Perhaps there is a double call to the likes of hci_suspend_dev due to system suspend and device suspend acting together, so maybe we need something like the following:

net/bluetooth/hci_core.c +1 -1
index 779c4aeaef22..c257759ae2f4 100644
@@ -2812,7 +2812,7 @@ int hci_suspend_dev(struct hci_dev *hdev)
 
        /* Suspend should only act on when powered. */
        if (!hdev_is_powered(hdev) ||
-           hci_dev_test_flag(hdev, HCI_UNREGISTER))
+           hci_dev_test_flag(hdev, HCI_UNREGISTER) || hdev->suspended)
                return 0;
 
        /* If powering down don't attempt to suspend */

net/bluetooth/hci_core.c int hci_resume_dev(struct hci_dev *hdev) · line 2849

Quoted 8 lines
net/bluetooth/hci_core.c +1 -1
@@ -2843,7 +2843,7 @@ int hci_resume_dev(struct hci_dev *hdev)
 
        /* Resume should only act on when powered. */
        if (!hdev_is_powered(hdev) ||
-           hci_dev_test_flag(hdev, HCI_UNREGISTER))
+           hci_dev_test_flag(hdev, HCI_UNREGISTER) || !hdev->suspended)
                return 0;
 
        /* If powering down don't attempt to resume */

No change in behavior with this change.

#6 lore raw

Hi Heiner,

Quoted 70 lines · Heiner Kallweit
Quoted 68 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 31 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 16 lines · Heiner Kallweit
Quoted 9 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 5 lines · Heiner Kallweit

Since linux-next from Oct 4th my bt speaker fails to connect if I switch it on. It just hangs trying. Manually connecting it via bluetoothctl works though. With this patch reverted it auto-connects again.
If you need additional details, please let me know.

Quoted 5 lines

I suspect something is trying to suspend the controller then, it shouldn't be USB auto-suspend since that should behave as it previously but if there is something externally (aka. userspace) trying to suspend then it will force it to suspend.

Quoted 6 lines

On the host side it's a combined WiFi/BT PCIe adapter (RTL8822CE). Runtime PM is enabled, so this may kick in. I'm not aware of any userspace tool which may try to suspend the WiFi/BT adapter. Disabling Runtime PM may be a workaround, but I don't think that's the actual solution.

Well I assume it still using USB as transport, not PCIe, otherwise it wouldn't be using btusb. Regarding runtime PM, I assume it still means PMSG_IS_AUTO Documentation/driver-api/usb/power-management.rst:

Quoted 7 lines

'External suspend calls should never be allowed to fail in this way, only autosuspend calls. The driver can tell them apart by applying the :c:func:PMSG_IS_AUTO macro to the message argument to the ``suspend`` method; it will return True for internal PM events'

--
Luiz Augusto von Dentz

Perhaps there is a double call to the likes of hci_suspend_dev due to system suspend and device suspend acting together, so maybe we need something like the following:

net/bluetooth/hci_core.c +2 -2
index 779c4aeaef22..c257759ae2f4 100644
@@ -2812,7 +2812,7 @@ int hci_suspend_dev(struct hci_dev *hdev)
 
        /* Suspend should only act on when powered. */
        if (!hdev_is_powered(hdev) ||
-           hci_dev_test_flag(hdev, HCI_UNREGISTER))
+           hci_dev_test_flag(hdev, HCI_UNREGISTER) || hdev->suspended)
                return 0;
 
        /* If powering down don't attempt to suspend */
@@ -2843,7 +2843,7 @@ int hci_resume_dev(struct hci_dev *hdev)
 
        /* Resume should only act on when powered. */
        if (!hdev_is_powered(hdev) ||
-           hci_dev_test_flag(hdev, HCI_UNREGISTER))
+           hci_dev_test_flag(hdev, HCI_UNREGISTER) || !hdev->suspended)
                return 0;
 
Quoted 4 lines

net/bluetooth/hci_core.c int hci_resume_dev(struct hci_dev *hdev) · line 2849

Quoted 3 lines
net/bluetooth/hci_core.c +0 -0
        /* If powering down don't attempt to resume */

No change in behavior with this change.

Ok, I guess we can rule out system suspend then, does commenting out the call to hci_suspend_dev makes it works again? If it does it means the device is suspending and it appears the likes of HCI_FLT_CONN_SETUP either doesn't work or is not being set to the controller to allow incoming connections, since it is an Audio device I think the problem is that we don't set HCI_CONN_FLAG_REMOTE_WAKEUP, only input device do set it, so we may need to treat device suspend and system suspend differently.

Signature · 1 line
Luiz Augusto von Dentz
#7 lore raw
Quoted 78 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 70 lines · Heiner Kallweit
Quoted 68 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 31 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 16 lines · Heiner Kallweit
Quoted 9 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 5 lines · Heiner Kallweit

Since linux-next from Oct 4th my bt speaker fails to connect if I switch it on. It just hangs trying. Manually connecting it via bluetoothctl works though. With this patch reverted it auto-connects again.
If you need additional details, please let me know.

Quoted 5 lines

I suspect something is trying to suspend the controller then, it shouldn't be USB auto-suspend since that should behave as it previously but if there is something externally (aka. userspace) trying to suspend then it will force it to suspend.

Quoted 6 lines

On the host side it's a combined WiFi/BT PCIe adapter (RTL8822CE). Runtime PM is enabled, so this may kick in. I'm not aware of any userspace tool which may try to suspend the WiFi/BT adapter. Disabling Runtime PM may be a workaround, but I don't think that's the actual solution.

Well I assume it still using USB as transport, not PCIe, otherwise it wouldn't be using btusb. Regarding runtime PM, I assume it still means PMSG_IS_AUTO Documentation/driver-api/usb/power-management.rst:

Quoted 7 lines

'External suspend calls should never be allowed to fail in this way, only autosuspend calls. The driver can tell them apart by applying the :c:func:PMSG_IS_AUTO macro to the message argument to the ``suspend`` method; it will return True for internal PM events'

--
Luiz Augusto von Dentz

Perhaps there is a double call to the likes of hci_suspend_dev due to system suspend and device suspend acting together, so maybe we need something like the following:

net/bluetooth/hci_core.c +2 -2
index 779c4aeaef22..c257759ae2f4 100644
@@ -2812,7 +2812,7 @@ int hci_suspend_dev(struct hci_dev *hdev)
 
        /* Suspend should only act on when powered. */
        if (!hdev_is_powered(hdev) ||
-           hci_dev_test_flag(hdev, HCI_UNREGISTER))
+           hci_dev_test_flag(hdev, HCI_UNREGISTER) || hdev->suspended)
                return 0;
 
        /* If powering down don't attempt to suspend */
@@ -2843,7 +2843,7 @@ int hci_resume_dev(struct hci_dev *hdev)
 
        /* Resume should only act on when powered. */
        if (!hdev_is_powered(hdev) ||
-           hci_dev_test_flag(hdev, HCI_UNREGISTER))
+           hci_dev_test_flag(hdev, HCI_UNREGISTER) || !hdev->suspended)
                return 0;
 
Quoted 4 lines

net/bluetooth/hci_core.c int hci_resume_dev(struct hci_dev *hdev) · line 2849

Quoted 3 lines
net/bluetooth/hci_core.c +0 -0
        /* If powering down don't attempt to resume */

No change in behavior with this change.

Quoted 9 lines

Ok, I guess we can rule out system suspend then, does commenting out the call to hci_suspend_dev makes it works again? If it does it means the device is suspending and it appears the likes of HCI_FLT_CONN_SETUP either doesn't work or is not being set to the controller to allow incoming connections, since it is an Audio device I think the problem is that we don't set HCI_CONN_FLAG_REMOTE_WAKEUP, only input device do set it, so we may need to treat device suspend and system suspend differently.

The following makes it work again.

net/bluetooth/hci_core.c +2 -0
index 7860750ec..33fd65d49 100644
@@ -2808,6 +2808,8 @@ int hci_suspend_dev(struct hci_dev *hdev)
 {
 	int ret;
 
+	return 0;
+
 	bt_dev_dbg(hdev, "");
 
 	/* Suspend should only act on when powered. */
#8 lore raw

Hi Heiner,

Quoted 98 lines · Heiner Kallweit
Quoted 78 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 70 lines · Heiner Kallweit
Quoted 68 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 31 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 16 lines · Heiner Kallweit
Quoted 9 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 5 lines · Heiner Kallweit

Since linux-next from Oct 4th my bt speaker fails to connect if I switch it on. It just hangs trying. Manually connecting it via bluetoothctl works though. With this patch reverted it auto-connects again.
If you need additional details, please let me know.

Quoted 5 lines

I suspect something is trying to suspend the controller then, it shouldn't be USB auto-suspend since that should behave as it previously but if there is something externally (aka. userspace) trying to suspend then it will force it to suspend.

Quoted 6 lines

On the host side it's a combined WiFi/BT PCIe adapter (RTL8822CE). Runtime PM is enabled, so this may kick in. I'm not aware of any userspace tool which may try to suspend the WiFi/BT adapter. Disabling Runtime PM may be a workaround, but I don't think that's the actual solution.

Well I assume it still using USB as transport, not PCIe, otherwise it wouldn't be using btusb. Regarding runtime PM, I assume it still means PMSG_IS_AUTO Documentation/driver-api/usb/power-management.rst:

Quoted 7 lines

'External suspend calls should never be allowed to fail in this way, only autosuspend calls. The driver can tell them apart by applying the :c:func:PMSG_IS_AUTO macro to the message argument to the ``suspend`` method; it will return True for internal PM events'

--
Luiz Augusto von Dentz

Perhaps there is a double call to the likes of hci_suspend_dev due to system suspend and device suspend acting together, so maybe we need something like the following:

net/bluetooth/hci_core.c +2 -2
index 779c4aeaef22..c257759ae2f4 100644
@@ -2812,7 +2812,7 @@ int hci_suspend_dev(struct hci_dev *hdev)
 
        /* Suspend should only act on when powered. */
        if (!hdev_is_powered(hdev) ||
-           hci_dev_test_flag(hdev, HCI_UNREGISTER))
+           hci_dev_test_flag(hdev, HCI_UNREGISTER) || hdev->suspended)
                return 0;
 
        /* If powering down don't attempt to suspend */
@@ -2843,7 +2843,7 @@ int hci_resume_dev(struct hci_dev *hdev)
 
        /* Resume should only act on when powered. */
        if (!hdev_is_powered(hdev) ||
-           hci_dev_test_flag(hdev, HCI_UNREGISTER))
+           hci_dev_test_flag(hdev, HCI_UNREGISTER) || !hdev->suspended)
                return 0;
 
Quoted 4 lines

net/bluetooth/hci_core.c int hci_resume_dev(struct hci_dev *hdev) · line 2849

Quoted 3 lines
net/bluetooth/hci_core.c +0 -0
        /* If powering down don't attempt to resume */

No change in behavior with this change.

Quoted 9 lines

Ok, I guess we can rule out system suspend then, does commenting out the call to hci_suspend_dev makes it works again? If it does it means the device is suspending and it appears the likes of HCI_FLT_CONN_SETUP either doesn't work or is not being set to the controller to allow incoming connections, since it is an Audio device I think the problem is that we don't set HCI_CONN_FLAG_REMOTE_WAKEUP, only input device do set it, so we may need to treat device suspend and system suspend differently.

The following makes it work again.

net/bluetooth/hci_core.c +0 -0
index 7860750ec..33fd65d49 100644

net/bluetooth/hci_core.c int hci_suspend_dev(struct hci_dev *hdev) · line 2815

Quoted 8 lines
net/bluetooth/hci_core.c +2 -0
@@ -2808,6 +2808,8 @@ int hci_suspend_dev(struct hci_dev *hdev)
 {
        int ret;
 
+       return 0;
+
        bt_dev_dbg(hdev, "");
 
        /* Suspend should only act on when powered. */

Can you try with the following changes:

https://gist.github.com/Vudentz/52c0cf8b9472a03b8eb447951be13811

Signature · 1 line
Luiz Augusto von Dentz
#9 lore raw
Quoted 107 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 104 lines · Heiner Kallweit
Quoted 78 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 70 lines · Heiner Kallweit
Quoted 68 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 31 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 16 lines · Heiner Kallweit
Quoted 9 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 5 lines · Heiner Kallweit

Since linux-next from Oct 4th my bt speaker fails to connect if I switch it on. It just hangs trying. Manually connecting it via bluetoothctl works though. With this patch reverted it auto-connects again.
If you need additional details, please let me know.

Quoted 5 lines

I suspect something is trying to suspend the controller then, it shouldn't be USB auto-suspend since that should behave as it previously but if there is something externally (aka. userspace) trying to suspend then it will force it to suspend.

Quoted 6 lines

On the host side it's a combined WiFi/BT PCIe adapter (RTL8822CE). Runtime PM is enabled, so this may kick in. I'm not aware of any userspace tool which may try to suspend the WiFi/BT adapter. Disabling Runtime PM may be a workaround, but I don't think that's the actual solution.

Well I assume it still using USB as transport, not PCIe, otherwise it wouldn't be using btusb. Regarding runtime PM, I assume it still means PMSG_IS_AUTO Documentation/driver-api/usb/power-management.rst:

Quoted 7 lines

'External suspend calls should never be allowed to fail in this way, only autosuspend calls. The driver can tell them apart by applying the :c:func:PMSG_IS_AUTO macro to the message argument to the ``suspend`` method; it will return True for internal PM events'

--
Luiz Augusto von Dentz

Perhaps there is a double call to the likes of hci_suspend_dev due to system suspend and device suspend acting together, so maybe we need something like the following:

net/bluetooth/hci_core.c +2 -2
index 779c4aeaef22..c257759ae2f4 100644
@@ -2812,7 +2812,7 @@ int hci_suspend_dev(struct hci_dev *hdev)
 
        /* Suspend should only act on when powered. */
        if (!hdev_is_powered(hdev) ||
-           hci_dev_test_flag(hdev, HCI_UNREGISTER))
+           hci_dev_test_flag(hdev, HCI_UNREGISTER) || hdev->suspended)
                return 0;
 
        /* If powering down don't attempt to suspend */
@@ -2843,7 +2843,7 @@ int hci_resume_dev(struct hci_dev *hdev)
 
        /* Resume should only act on when powered. */
        if (!hdev_is_powered(hdev) ||
-           hci_dev_test_flag(hdev, HCI_UNREGISTER))
+           hci_dev_test_flag(hdev, HCI_UNREGISTER) || !hdev->suspended)
                return 0;
 
Quoted 4 lines

net/bluetooth/hci_core.c int hci_resume_dev(struct hci_dev *hdev) · line 2849

Quoted 3 lines
net/bluetooth/hci_core.c +0 -0
        /* If powering down don't attempt to resume */

No change in behavior with this change.

Quoted 9 lines

Ok, I guess we can rule out system suspend then, does commenting out the call to hci_suspend_dev makes it works again? If it does it means the device is suspending and it appears the likes of HCI_FLT_CONN_SETUP either doesn't work or is not being set to the controller to allow incoming connections, since it is an Audio device I think the problem is that we don't set HCI_CONN_FLAG_REMOTE_WAKEUP, only input device do set it, so we may need to treat device suspend and system suspend differently.

The following makes it work again.

net/bluetooth/hci_core.c +2 -0
index 7860750ec..33fd65d49 100644
@@ -2808,6 +2808,8 @@ int hci_suspend_dev(struct hci_dev *hdev)
 {
        int ret;
 
+       return 0;
+
        bt_dev_dbg(hdev, "");
 
Quoted 7 lines

net/bluetooth/hci_core.c int hci_suspend_dev(struct hci_dev *hdev) · line 2815

Quoted 2 lines
net/bluetooth/hci_core.c +0 -0
        /* Suspend should only act on when powered. */

Can you try with the following changes:

https://gist.github.com/Vudentz/52c0cf8b9472a03b8eb447951be13811

In this patch all tabs have been replaced with spaces, therefore it didn't apply and I had to apply the changes manually. Unfortunately the changes don't fix the issue for me.

#10 lore raw
In reply to Luiz Augusto von Dentz
Quoted 26 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 16 lines · Heiner Kallweit
Quoted 9 lines · Luiz Augusto von Dentz

Hi Heiner,

Quoted 5 lines · Heiner Kallweit

Since linux-next from Oct 4th my bt speaker fails to connect if I switch it on. It just hangs trying. Manually connecting it via bluetoothctl works though. With this patch reverted it auto-connects again.
If you need additional details, please let me know.

Quoted 5 lines

I suspect something is trying to suspend the controller then, it shouldn't be USB auto-suspend since that should behave as it previously but if there is something externally (aka. userspace) trying to suspend then it will force it to suspend.

Quoted 6 lines

On the host side it's a combined WiFi/BT PCIe adapter (RTL8822CE). Runtime PM is enabled, so this may kick in. I'm not aware of any userspace tool which may try to suspend the WiFi/BT adapter. Disabling Runtime PM may be a workaround, but I don't think that's the actual solution.

Quoted 2 lines

Well I assume it still using USB as transport, not PCIe, otherwise it wouldn't be using btusb. Regarding runtime PM, I assume it still means

Right, it's a M.2 adapter which utilizes PCIe and USB.

Quoted 7 lines

PMSG_IS_AUTO Documentation/driver-api/usb/power-management.rst:

'External suspend calls should never be allowed to fail in this way, only autosuspend calls. The driver can tell them apart by applying the :c:func:PMSG_IS_AUTO macro to the message argument to the ``suspend`` method; it will return True for internal PM events'