Skip to contentSkip to conversation

tcp: for tcp westwood implementation

PATCH In review Hwang Jae-Hyun 2 participants 2 messages Dec 28, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tcp: for tcp westwood implementation

From: Jae-Hyun Hwang <[email protected]>

Current net/ipv4/tcp_westwood.c seems to be unnatural when compared with Westwood papers.
Since Linux TCP calls '.ssthresh' interface whenever packet loss is detected,
it is more natural that the interface points to 'tcp_westwood_bw_rttmin' function, not Reno's function.
This patch also enables Westwood to perform its algorithm when CA_EVENT_LOSS event is generated as explained in the papers.

---

--- linux-2.6.32.2/net/ipv4/tcp_westwood.c.orig 2009-12-28 13:35:42.000000000 +0900
+++ linux-2.6.32.2/net/ipv4/tcp_westwood.c 2009-12-28
13:36:54.000000000 +0900
@@ -232,12 +232,7 @@ static void tcp_westwood_event(struct so

                westwood_fast_bw(sk);
                break;

- case CA_EVENT_COMPLETE_CWR:
- tp->snd_cwnd = tp->snd_ssthresh =
tcp_westwood_bw_rttmin(sk);
- break;
-
case CA_EVENT_FRTO:

-               tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
                /* Update RTT_min when next ack arrives */
                w->reset_rtt_min = 1;
                break;

@@ -274,9 +269,8 @@ static void tcp_westwood_info(struct soc

static struct tcp_congestion_ops tcp_westwood = {

        .init           = tcp_westwood_init,
-       .ssthresh       = tcp_reno_ssthresh,
+       .ssthresh       = tcp_westwood_bw_rttmin,
        .cong_avoid     = tcp_reno_cong_avoid,
-       .min_cwnd       = tcp_westwood_bw_rttmin,
        .cwnd_event     = tcp_westwood_event,
        .get_info       = tcp_westwood_info,
        .pkts_acked     = tcp_westwood_pkts_acked,

--

maintainer
#1 lore raw

Annyoung-haseyo,

Your patch was damaged by your email client (long lines were chopped up with newlines, etc.), as such it is not usable.

Please fix this up and resubmit your patch.