Skip to contentSkip to conversation

mm/vmalloc: fix build error

PATCH In review Peng Li 2 participants 2 messages Nov 18, 2025 – Nov 21, 2025

Subsystems (2)
lore
Share & tools
lore

Peng Li

author
#0 lore raw

PATCH 1/1 mm/vmalloc: fix build error

From: Peng Li <[email protected]>

commit 056b93566a35 ("mm/vmalloc: warn only once when vmalloc detect invalid gfp flags") modify the function call from WARN to WARN_ONCE.

WARN_ONCE input parameter format error, missing ',' tag. Resulting in the following compilation errors:

mm/vmalloc.c:3940:19: error: expected ‘)’ before ‘invalid_mask’
3940 | invalid_mask, &invalid_mask, flags, &flags);

After adding the "," tag, the compilation passed.

---
 mm/vmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/vmalloc.c +1 -1
index d78c4d09d6ea..0469ba2c230e 100644
@@ -3936,7 +3936,7 @@ static gfp_t vmalloc_fix_flags(gfp_t flags)
 	gfp_t invalid_mask = flags & ~GFP_VMALLOC_SUPPORTED;
 
 	flags &= GFP_VMALLOC_SUPPORTED;
-	WARN_ONCE(1, "Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n"
+	WARN_ONCE(1, "Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n",
 		  invalid_mask, &invalid_mask, flags, &flags);
 	return flags;
 }
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Peng Li

From: Peng Li <[email protected]>

commit 056b93566a35 ("mm/vmalloc: warn only once when vmalloc detect invalid gfp flags") modify the function call from WARN to WARN_ONCE.

WARN_ONCE input parameter format error, missing ',' tag. Resulting in the following compilation errors:

mm/vmalloc.c:3940:19: error: expected ‘)’ before ‘invalid_mask’
3940 | invalid_mask, &invalid_mask, flags, &flags);

Quoted 6 lines

After adding the "," tag, the compilation passed.

---
 mm/vmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

thanks,

Signature · 1 line
John Hubbard
Quoted 14 lines
mm/vmalloc.c +1 -1
index d78c4d09d6ea..0469ba2c230e 100644
@@ -3936,7 +3936,7 @@ static gfp_t vmalloc_fix_flags(gfp_t flags)
 	gfp_t invalid_mask = flags & ~GFP_VMALLOC_SUPPORTED;
 
 	flags &= GFP_VMALLOC_SUPPORTED;
-	WARN_ONCE(1, "Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n"
+	WARN_ONCE(1, "Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n",
 		  invalid_mask, &invalid_mask, flags, &flags);
 	return flags;
 }