Bug in twl4030backupbatt_voltage()

In the omap tree, commit f91fd98be045bec9c18e13110f22dafd44cb84b5 fixed a bug with the use of function twl4030_madc_conversion() relating to the local variable 'struct twl4030_madc_request req' not being fully initialised.

The same problem appears to be in the function twl4030backupbatt_voltage() which is in drivers/power/twl4030_bci_battery.c

Quoted 7 lines · Adrian Hunter

In the omap tree, commit f91fd98be045bec9c18e13110f22dafd44cb84b5 fixed a bug with the use of function twl4030_madc_conversion() relating to the local variable 'struct twl4030_madc_request req' not being fully initialised.

The same problem appears to be in the function twl4030backupbatt_voltage() which is in drivers/power/twl4030_bci_battery.c

Thanks, I'll initialize it to NULL. Wouldn't it have been easier just to write a patch instead of the description above? :)

Quoted 9 lines · Tony Lindgren

Quoted 7 lines · Adrian Hunter

In the omap tree, commit f91fd98be045bec9c18e13110f22dafd44cb84b5 fixed a bug with the use of function twl4030_madc_conversion() relating to the local variable 'struct twl4030_madc_request req' not being fully initialised.

The same problem appears to be in the function twl4030backupbatt_voltage() which is in drivers/power/twl4030_bci_battery.c

Quoted 2 lines

Thanks, I'll initialize it to NULL. Wouldn't it have been easier just to write a patch instead of the description above? :)

Apparently.

There is also req.do_avg which should be zero, if you assume the programmer's intent was to have uninitialised members set to zero.

----- Original Message -----
From: "Adrian Hunter" <[email protected]>
To: "Tony Lindgren" <[email protected]>
Cc: <[email protected]>; <[email protected]>
Sent: Wednesday, September 10, 2008 12:58 PM
Subject: Re: Bug in twl4030backupbatt_voltage()

Quoted 13 lines

Quoted 11 lines · Tony Lindgren

Quoted 7 lines · Adrian Hunter

In the omap tree, commit f91fd98be045bec9c18e13110f22dafd44cb84b5 fixed a bug with the use of function twl4030_madc_conversion() relating to the local variable 'struct twl4030_madc_request req' not being fully initialised.

The same problem appears to be in the function twl4030backupbatt_voltage() which is in drivers/power/twl4030_bci_battery.c

Thanks, I'll initialize it to NULL. Wouldn't it have been easier just to write a patch instead of the description above? :)

Quoted 4 lines

Apparently.

There is also req.do_avg which should be zero, if you assume the programmer's intent was to have uninitialised members set to zero.

I guess, I did not look at all the other members of the "twl4030_madc_request" structure. I might have missed it. The do_avg and func_cb fields can both be set to NULL.

Quoted 22 lines

----- Original Message -----
From: "Adrian Hunter" <[email protected]>
To: "Tony Lindgren" <[email protected]>
Cc: <[email protected]>; <[email protected]>
Sent: Wednesday, September 10, 2008 12:58 PM
Subject: Re: Bug in twl4030backupbatt_voltage()

Quoted 13 lines

Quoted 11 lines · Tony Lindgren

Quoted 7 lines · Adrian Hunter

In the omap tree, commit f91fd98be045bec9c18e13110f22dafd44cb84b5 fixed a bug with the use of function twl4030_madc_conversion() relating to the local variable 'struct twl4030_madc_request req' not being fully initialised.

The same problem appears to be in the function twl4030backupbatt_voltage() which is in drivers/power/twl4030_bci_battery.c

Thanks, I'll initialize it to NULL. Wouldn't it have been easier just to write a patch instead of the description above? :)

Quoted 6 lines

Quoted 4 lines

Apparently.

There is also req.do_avg which should be zero, if you assume the programmer's intent was to have uninitialised members set to zero.

I guess, I did not look at all the other members of the "twl4030_madc_request" structure. I might have missed it. The do_avg and func_cb fields can both be set to NULL.

Can you please check the code and send a patch?

Thanks,

Tony