Skip to contentSkip to conversation

arm: dts: agilex: Enable QSPI

PATCH RESEND Superseded Ley Foon Tan 3 participants 10 messages Mar 27, 2020 – Mar 31, 2020 Arm (32-bit)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 arm: dts: agilex: Enable QSPI

Enable QSPI for Agilex SoC devkit.

---
 arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi +4 -0
index 1908be4b8b27..241c0efab14c 100644
@@ -37,3 +37,7 @@
 	u-boot,dm-pre-reloc;
 };
 
+&qspi {
+	status = "okay";
+}
+
Signature · 1 line
2.19.0
#1 lore raw

PATCH RESEND 1/1 arm: dts: agilex: Enable QSPI

Quoted 12 lines · Ley Foon Tan

Enable QSPI for Agilex SoC devkit.

---
 arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi +0 -0
index 1908be4b8b27..241c0efab14c 100644

arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi line 42

Quoted 6 lines
arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi +3 -0
@@ -37,3 +37,7 @@
 	u-boot,dm-pre-reloc;
 };
 
+&qspi {
+	status = "okay";
+}

Is this for master or next ?

#2 lore raw

PATCH RESEND 1/1 arm: dts: agilex: Enable QSPI

Quoted 18 lines · Ley Foon Tan

Review

Quoted 8 lines

Enable QSPI for Agilex SoC devkit.

---
 arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

b/arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi

Quoted 7 lines

index 1908be4b8b27..241c0efab14c 100644

arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi +0 -0
@@ -37,3 +37,7 @@
 	u-boot,dm-pre-reloc;
 };
 
Quoted 5 lines

arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi line 42

Quoted 3 lines
arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi +3 -0
+&qspi {
+	status = "okay";
+}

Is this for master or next ?

Will it be too late for master? If yes, then for next.

Regards
Ley Foon

#3 lore raw

PATCH RESEND 1/1 arm: dts: agilex: Enable QSPI

Quoted 18 lines · Ley Foon
Quoted 18 lines · Ley Foon Tan

Review

Quoted 8 lines

Enable QSPI for Agilex SoC devkit.

---
 arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

b/arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi

Quoted 7 lines

index 1908be4b8b27..241c0efab14c 100644

arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi +0 -0
@@ -37,3 +37,7 @@
 	u-boot,dm-pre-reloc;
 };
 
Quoted 6 lines
Quoted 5 lines

arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi line 42

Quoted 3 lines
arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi +3 -0
+&qspi {
+	status = "okay";
+}

Is this for master or next ?

Will it be too late for master? If yes, then for next.

It's late, but if you feel adventurous and think this is gonna work fine, then I can put it into master. This is isolated to agilex, so I don't mind either way.

#4 lore raw

PATCH RESEND 1/1 arm: dts: agilex: Enable QSPI

Quoted 35 lines

-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: Monday, March 30, 2020 9:29 AM
To: Tan, Ley Foon <[email protected]>; u-boot at lists.denx.de
Cc: Ley Foon Tan <[email protected]>; See, Chin Liang <[email protected]>; Simon Goldschmidt <[email protected]>
Subject: Re: [PATCH RESEND] arm: dts: agilex: Enable QSPI

Quoted 23 lines · Ley Foon
Quoted 23 lines · Ley Foon Tan

Review

Quoted 8 lines

Enable QSPI for Agilex SoC devkit.

---
 arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

b/arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi

arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi line 42

Quoted 10 lines

index 1908be4b8b27..241c0efab14c 100644

arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi +3 -0
@@ -37,3 +37,7 @@
 	u-boot,dm-pre-reloc;
 };
 
+&qspi {
+	status = "okay";
+}

Is this for master or next ?

Quoted 4 lines
Quoted 1 line

Will it be too late for master? If yes, then for next.

It's late, but if you feel adventurous and think this is gonna work fine, then I can put it into master. This is isolated to agilex, so I don't mind either way.

Tested on Agilex board. Master should be okay.
Thanks.

Regards
Ley Foon

#5 lore raw

PATCH RESEND 1/1 arm: dts: agilex: Enable QSPI

Quoted 35 lines · Ley Foon
Quoted 35 lines

-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: Monday, March 30, 2020 9:29 AM
To: Tan, Ley Foon <[email protected]>; u-boot at lists.denx.de
Cc: Ley Foon Tan <[email protected]>; See, Chin Liang <[email protected]>; Simon Goldschmidt <[email protected]>
Subject: Re: [PATCH RESEND] arm: dts: agilex: Enable QSPI

Quoted 23 lines · Ley Foon
Quoted 23 lines · Ley Foon Tan

Review

Quoted 8 lines

Enable QSPI for Agilex SoC devkit.

---
 arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

b/arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi

arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi line 42

Quoted 10 lines

index 1908be4b8b27..241c0efab14c 100644

arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi +3 -0
@@ -37,3 +37,7 @@
 	u-boot,dm-pre-reloc;
 };
 
+&qspi {
+	status = "okay";
+}

Is this for master or next ?

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Will it be too late for master? If yes, then for next.

It's late, but if you feel adventurous and think this is gonna work fine, then I can put it into master. This is isolated to agilex, so I don't mind either way.

Tested on Agilex board. Master should be okay.
Thanks.

Then master it is.

#6 lore raw

PATCH RESEND 1/1 arm: dts: agilex: Enable QSPI

Quoted 49 lines

-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: Monday, March 30, 2020 9:47 AM
To: Tan, Ley Foon <[email protected]>; u-boot at lists.denx.de
Cc: Ley Foon Tan <[email protected]>; See, Chin Liang <[email protected]>; Simon Goldschmidt <[email protected]>
Subject: Re: [PATCH RESEND] arm: dts: agilex: Enable QSPI

Quoted 37 lines · Ley Foon
Quoted 37 lines

-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: Monday, March 30, 2020 9:29 AM
To: Tan, Ley Foon <[email protected]>; u-boot at lists.denx.de
Cc: Ley Foon Tan <[email protected]>; See, Chin Liang <[email protected]>; Simon Goldschmidt <[email protected]>
Subject: Re: [PATCH RESEND] arm: dts: agilex: Enable QSPI

Quoted 24 lines · Ley Foon
Quoted 18 lines · Ley Foon Tan

Review

Quoted 8 lines

Enable QSPI for Agilex SoC devkit.

---
 arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

b/arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi

Quoted 7 lines

index 1908be4b8b27..241c0efab14c 100644

arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi +0 -0
@@ -37,3 +37,7 @@
 	u-boot,dm-pre-reloc;
 };
 
Quoted 5 lines

arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi line 42

Quoted 3 lines
arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi +3 -0
+&qspi {
+	status = "okay";
+}

Is this for master or next ?

Will it be too late for master? If yes, then for next.

Quoted 7 lines
Quoted 2 lines
Quoted 2 lines

It's late, but if you feel adventurous and think this is gonna work fine, then I can put it into master. This is isolated to agilex, so I don't mind

either way.

Quoted 2 lines

Tested on Agilex board. Master should be okay.
Thanks.

Then master it is.

Thanks!

Regards
Ley Foon

#7 lore raw

PATCH RESEND 1/1 arm: dts: agilex: Enable QSPI

In reply to Marek Vasut
Quoted 36 lines · Marek Vasut
Quoted 35 lines · Ley Foon
Quoted 35 lines

-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: Monday, March 30, 2020 9:29 AM
To: Tan, Ley Foon <[email protected]>; u-boot at lists.denx.de
Cc: Ley Foon Tan <[email protected]>; See, Chin Liang <[email protected]>; Simon Goldschmidt <[email protected]>
Subject: Re: [PATCH RESEND] arm: dts: agilex: Enable QSPI

Quoted 23 lines · Ley Foon
Quoted 23 lines · Ley Foon Tan

Review

Quoted 8 lines

Enable QSPI for Agilex SoC devkit.

---
 arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

b/arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi

arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi line 42

Quoted 10 lines

index 1908be4b8b27..241c0efab14c 100644

arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi +3 -0
@@ -37,3 +37,7 @@
 	u-boot,dm-pre-reloc;
 };
 
+&qspi {
+	status = "okay";
+}

Is this for master or next ?

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Will it be too late for master? If yes, then for next.

It's late, but if you feel adventurous and think this is gonna work fine, then I can put it into master. This is isolated to agilex, so I don't mind either way.

Tested on Agilex board. Master should be okay.
Thanks.

Then master it is.

The u-boot-socfpga/master build fails when I apply this patch, so I'll be dropping it for now:

+Error: arch/arm/dts/.socfpga_agilex_socdk.dtb.pre.tmp:141.57-142.1 syntax error
+FATAL ERROR: Unable to parse input tree
+make[3]: *** [arch/arm/dts/socfpga_agilex_socdk.dtb] Error 1 +make[2]: *** [arch-dtbs] Error 2
+make[1]: *** [dts/dt.dtb] Error 2
+make: *** [sub-make] Error 2

#8 lore raw

PATCH RESEND 1/1 arm: dts: agilex: Enable QSPI

Quoted 37 lines
Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
Quoted 22 lines · Ley Foon Tan

Review

Quoted 8 lines

Enable QSPI for Agilex SoC devkit.

---
 arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

b/arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi

arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi line 42

Quoted 10 lines

index 1908be4b8b27..241c0efab14c 100644

arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi +3 -0
@@ -37,3 +37,7 @@
 	u-boot,dm-pre-reloc;
 };
 
+&qspi {
+	status = "okay";
+}

Is this for master or next ?

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line

Will it be too late for master? If yes, then for next.

It's late, but if you feel adventurous and think this is gonna work fine, then I can put it into master. This is isolated to agilex, so I don't

mind either way.

Quoted 4 lines
Quoted 2 lines

Tested on Agilex board. Master should be okay.
Thanks.

Then master it is.

The u-boot-socfpga/master build fails when I apply this patch, so I'll be dropping it for now:

+Error: arch/arm/dts/.socfpga_agilex_socdk.dtb.pre.tmp:141.57-142.1 syntax error

Review

Quoted 5 lines
(quoted diff) +5 -0
+FATAL ERROR: Unable to parse input tree
+make[3]: *** [arch/arm/dts/socfpga_agilex_socdk.dtb] Error 1
+make[2]: *** [arch-dtbs] Error 2
+make[1]: *** [dts/dt.dtb] Error 2
+make: *** [sub-make] Error 2

I've fixed it in local, but forgot regenerate the patch. Will send v2 patch. Sorry about this.

Thanks.

Regards
Ley Foon

#9 lore raw

PATCH RESEND 1/1 arm: dts: agilex: Enable QSPI

Quoted 35 lines · Ley Foon
Quoted 35 lines
Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
Quoted 22 lines · Ley Foon Tan

Review

Quoted 8 lines

Enable QSPI for Agilex SoC devkit.

---
 arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

b/arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi

arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi line 42

Quoted 10 lines

index 1908be4b8b27..241c0efab14c 100644

arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi +3 -0
@@ -37,3 +37,7 @@
 	u-boot,dm-pre-reloc;
 };
 
+&qspi {
+	status = "okay";
+}

Is this for master or next ?

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line

Will it be too late for master? If yes, then for next.

It's late, but if you feel adventurous and think this is gonna work fine, then I can put it into master. This is isolated to agilex, so I don't

mind either way.

Quoted 4 lines
Quoted 2 lines

Tested on Agilex board. Master should be okay.
Thanks.

Then master it is.

The u-boot-socfpga/master build fails when I apply this patch, so I'll be dropping it for now:

Quoted 9 lines

Review

Quoted 7 lines

+Error: arch/arm/dts/.socfpga_agilex_socdk.dtb.pre.tmp:141.57-142.1 syntax error

(quoted diff) +5 -0
+FATAL ERROR: Unable to parse input tree
+make[3]: *** [arch/arm/dts/socfpga_agilex_socdk.dtb] Error 1
+make[2]: *** [arch-dtbs] Error 2
+make[1]: *** [dts/dt.dtb] Error 2
+make: *** [sub-make] Error 2

I've fixed it in local, but forgot regenerate the patch. Will send v2 patch. Sorry about this.

OK