Skip to contentSkip to conversation

iw_cxgb4: set correct FetchBurstMax for QPs

PATCH In review Steve Wise 2 participants 5 messages Feb 3, 2017 – Feb 6, 2017 Stable branch

lore
Share & tools
lore

Steve Wise

author
#0 lore raw

PATCH 1/1 iw_cxgb4: set correct FetchBurstMax for QPs

I forgot to add the stable Cc tag when I submitted this, but it is important to get this patch into 4.9.x:

commit b414fa01c31318383ae29d9d23cb9ca4184bbd86

Author: Steve Wise <[email protected]>
Date:   Thu Dec 15 08:09:35 2016 -0800

iw_cxgb4: set correct FetchBurstMax for QPs

The current QP FetchBurstMax value is 256B, which is incorrect since a WR can exceed that value. The result being a partial WR fetched by hardware, and a fatal "bad WR" error posted by the SGE.

So bump the FetchBurstMax to 512B.

I'm not sure if this is the correct way to request this, but I think I'm following _option_2 from Documentation/stable_kernel_rules.txt.

Thanks,

Steve.

maintainer
#1 lore raw
Quoted 14 lines · Steve Wise

I forgot to add the stable Cc tag when I submitted this, but it is important to get this patch into 4.9.x:

commit b414fa01c31318383ae29d9d23cb9ca4184bbd86

Author: Steve Wise <[email protected]>
Date:   Thu Dec 15 08:09:35 2016 -0800

iw_cxgb4: set correct FetchBurstMax for QPs

The current QP FetchBurstMax value is 256B, which is incorrect since a WR can exceed that value. The result being a partial WR fetched by hardware, and a fatal "bad WR" error posted by the SGE.

Quoted 7 lines

So bump the FetchBurstMax to 512B.

I'm not sure if this is the correct way to request this, but I think I'm following _option_2 from Documentation/stable_kernel_rules.txt.

Now queued up. Are you sure this isn't also needed in the 4.4-stable tree?

thanks,

greg k-h

author
#2 lore raw
Quoted 13 lines
Quoted 13 lines

commit b414fa01c31318383ae29d9d23cb9ca4184bbd86

Author: Steve Wise <[email protected]>
Date:   Thu Dec 15 08:09:35 2016 -0800

iw_cxgb4: set correct FetchBurstMax for QPs

The current QP FetchBurstMax value is 256B, which is incorrect since a WR can exceed that value. The result being a partial WR fetched by hardware, and a fatal "bad WR" error posted by the SGE.

So bump the FetchBurstMax to 512B.

Quoted 9 lines
Quoted 5 lines

I'm not sure if this is the correct way to request this, but I think I'm following _option_2 from Documentation/stable_kernel_rules.txt.

Now queued up. Are you sure this isn't also needed in the 4.4-stable tree?

Hey Greg, At first, I didn't think it is needed because, while the bug is indeed present in that code, it is only exposed (and causes problems) with
the new T6 hardware. But now I think I'd like the fix pulled in 4.4-stable
to avoid any issues if T6 support is pulled into that base.

Thanks!

Steve

maintainer
#3 lore raw
Quoted 19 lines · Steve Wise
Quoted 19 lines
Quoted 18 lines

commit b414fa01c31318383ae29d9d23cb9ca4184bbd86

Author: Steve Wise <[email protected]>
Date:   Thu Dec 15 08:09:35 2016 -0800

iw_cxgb4: set correct FetchBurstMax for QPs

The current QP FetchBurstMax value is 256B, which is incorrect since a WR can exceed that value. The result being a partial WR fetched by hardware, and a fatal "bad WR" error posted by the SGE.

So bump the FetchBurstMax to 512B.

I'm not sure if this is the correct way to request this, but I think I'm following _option_2 from Documentation/stable_kernel_rules.txt.

Quoted 8 lines
Quoted 3 lines

Now queued up. Are you sure this isn't also needed in the 4.4-stable tree?

Hey Greg, At first, I didn't think it is needed because, while the bug is indeed present in that code, it is only exposed (and causes problems) with
the new T6 hardware. But now I think I'd like the fix pulled in 4.4-stable
to avoid any issues if T6 support is pulled into that base.

How would I pull "T6" support into that kernel? I'm guessing that's a much larger issue and isn't something that would normally happen in a stable kernel release?

thanks,

greg k-h

author
#4 lore raw
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

Now queued up. Are you sure this isn't also needed in the 4.4-stable tree?

Quoted 8 lines
Quoted 4 lines

Hey Greg, At first, I didn't think it is needed because, while the bug is indeed present in that code, it is only exposed (and causes problems) with
the new T6 hardware. But now I think I'd like the fix pulled in 4.4-stable
to avoid any issues if T6 support is pulled into that base.

How would I pull "T6" support into that kernel? I'm guessing that's a much larger issue and isn't something that would normally happen in a stable kernel release?

I guess that won't happen. To enable the T6 adapter several commits to drivers/net/ethernet/chelsio/cxgb4 and drivers/infiniband/hw/cxgb4 would have to flow into stable, and I guess that will not happen. Ok, so no 4.4-stable.

Thanks,

Steve.