Skip to contentSkip to conversation

regulator: s5m8767: Add missing breaks

PATCH Applied Axel Lin 3 participants 6 messages Jan 12, 2012

Subsystems (2)
Voltage and current regulator framework Samsung multifunction PMIC device drivers
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/2 regulator: s5m8767: Add missing breaks

Signed-off-by Axel Lin <[email protected]>

---
This patch is against Mark's regulator tree (for-next-next branch).

 drivers/regulator/s5m8767.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/regulator/s5m8767.c +4 -0
index b3d356f..4061012 100644
@@ -742,15 +742,19 @@ static __devinit int s5m8767_pmic_probe(struct platform_device *pdev)
 		case 15:
 			s5m_reg_update(s5m8767->iodev, S5M8767_REG_DVSRAMP,
 					0xc0, 0xf0);
+			break;
 		case 25:
 			s5m_reg_update(s5m8767->iodev, S5M8767_REG_DVSRAMP,
 					0xd0, 0xf0);
+			break;
 		case 50:
 			s5m_reg_update(s5m8767->iodev, S5M8767_REG_DVSRAMP,
 					0xe0, 0xf0);
+			break;
 		case 100:
 			s5m_reg_update(s5m8767->iodev, S5M8767_REG_DVSRAMP,
 					0xf0, 0xf0);
+			break;
 		default:
 			s5m_reg_update(s5m8767->iodev, S5M8767_REG_DVSRAMP,
 					0x90, 0xf0);
Signature · 1 line
1.7.5.4
author
#1 lore raw

PATCH 2/2 regulator: s5m8767: Remove redundant MODULE_ALIAS

The MODULE_DEVICE_TABLE will setup the modalias, thus adding a MODULE_ALIAS for an entry already in s5m8767_pmic_id is redundant.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/regulator/s5m8767.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/regulator/s5m8767.c +0 -1
index 4061012..caf0117 100644
@@ -835,4 +835,3 @@ module_exit(s5m8767_pmic_exit);
 MODULE_AUTHOR("Sangbeom Kim <[email protected]>");
 MODULE_DESCRIPTION("SAMSUNG S5M8767 Regulator Driver");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:s5m8767-pmic");
Signature · 1 line
1.7.5.4
#4 lore raw
Quoted 2 lines · Sangbeom Kim

During normal test, I can't detect the problem. But It should add break to apply proper ramp slope.

Looking at the code you're unlikely to see a problem as the failure will be to ramp more slowly which will just reduce performance rather than cause crashes or anything like ramping too quickly can.