Skip to contentSkip to conversation

x86/viridian: Reword HV_X64_MSR_CRASH_CTL print message

PATCH In review Andrew Cooper 3 participants 9 messages Sep 13, 2019 – Sep 18, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/viridian: Reword HV_X64_MSR_CRASH_CTL print message

Message such as:

(XEN) d3v0 VIRIDIAN CRASH: 51 1 ffff9700e146b000 1000 204

have confused many people into thinking the the problem is a bug in the viridian code. The prefix was intended to signify the use of the viridian crash-reporting interface.

Replace the VIRIDIAN prefix with 'reported' to reduce the confusion to non-xen-developers trying to interpret the message.

---
CC: Jan Beulich <[email protected]>
CC: Wei Liu <[email protected]>
CC: Roger Pau Monné <[email protected]>
CC: Paul Durrant <[email protected]>

This wants backporting to every stable tree which has viridian crash interface support.

---
 xen/arch/x86/hvm/viridian/viridian.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xen/arch/x86/hvm/viridian/viridian.c +1 -1
index 4b06b78a27..f98c8e7753 100644
@@ -357,7 +357,7 @@ int guest_wrmsr_viridian(struct vcpu *v, uint32_t idx, uint64_t val)
         d->shutdown_code = SHUTDOWN_crash;
         spin_unlock(&d->shutdown_lock);
 
-        gprintk(XENLOG_WARNING, "VIRIDIAN CRASH: %lx %lx %lx %lx %lx\n",
+        gprintk(XENLOG_WARNING, "reported CRASH: %lx %lx %lx %lx %lx\n",
                 vv->crash_param[0], vv->crash_param[1], vv->crash_param[2],
                 vv->crash_param[3], vv->crash_param[4]);
         break;
Signature · 7 lines
2.11.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#1 lore raw
Quoted 10 lines

-----Original Message-----
From: Andrew Cooper <[email protected]>
Sent: 13 September 2019 17:04
To: Xen-devel <[email protected]>
Cc: Andrew Cooper <[email protected]>; Jan Beulich <[email protected]>; Wei Liu <[email protected]>; Roger Pau Monne <[email protected]>; Paul Durrant <[email protected]>
Subject: [PATCH] x86/viridian: Reword HV_X64_MSR_CRASH_CTL print message

Message such as:

Quoted 8 lines

(XEN) d3v0 VIRIDIAN CRASH: 51 1 ffff9700e146b000 1000 204

have confused many people into thinking the the problem is a bug in the viridian code. The prefix was intended to signify the use of the viridian crash-reporting interface.

Replace the VIRIDIAN prefix with 'reported' to reduce the confusion to non-xen-developers trying to interpret the message.

This is a message that is peculiar to Windows VMs, so how about "Windows VM CRASH"?

Paul

Quoted 28 lines

---
CC: Jan Beulich <[email protected]>
CC: Wei Liu <[email protected]>
CC: Roger Pau Monné <[email protected]>
CC: Paul Durrant <[email protected]>

This wants backporting to every stable tree which has viridian crash interface support.

---
 xen/arch/x86/hvm/viridian/viridian.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xen/arch/x86/hvm/viridian/viridian.c +1 -2
index 4b06b78a27..f98c8e7753 100644
@@ -357,7 +357,7 @@ int guest_wrmsr_viridian(struct vcpu *v, uint32_t idx, uint64_t val)
         d->shutdown_code = SHUTDOWN_crash;
         spin_unlock(&d->shutdown_lock);
 
-        gprintk(XENLOG_WARNING, "VIRIDIAN CRASH: %lx %lx %lx %lx %lx\n",
+        gprintk(XENLOG_WARNING, "reported CRASH: %lx %lx %lx %lx %lx\n",
                 vv->crash_param[0], vv->crash_param[1], vv->crash_param[2],
                 vv->crash_param[3], vv->crash_param[4]);
         break;
--
Quoted 1 line

2.11.0

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#2 lore raw
Quoted 12 lines · Paul Durrant
Quoted 12 lines

-----Original Message-----
From: Andrew Cooper <[email protected]>
Sent: 13 September 2019 17:04
To: Xen-devel <[email protected]>
Cc: Andrew Cooper <[email protected]>; Jan Beulich <[email protected]>; Wei Liu <[email protected]>; Roger Pau Monne <[email protected]>; Paul Durrant <[email protected]>
Subject: [PATCH] x86/viridian: Reword HV_X64_MSR_CRASH_CTL print message

Message such as:

(XEN) d3v0 VIRIDIAN CRASH: 51 1 ffff9700e146b000 1000 204

Quoted 7 lines
Quoted 6 lines

have confused many people into thinking the the problem is a bug in the viridian code. The prefix was intended to signify the use of the viridian crash-reporting interface.

Replace the VIRIDIAN prefix with 'reported' to reduce the confusion to non-xen-developers trying to interpret the message.

This is a message that is peculiar to Windows VMs, so how about "Windows VM CRASH"?

I presume you mean particular, but no - it isn't windows which is the exclusive user of this interface.  Linux has a driver to use it when running under HyperV.

~Andrew

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#3 lore raw
Quoted 25 lines

-----Original Message-----
From: Andrew Cooper <[email protected]>
Sent: 16 September 2019 13:48
To: Paul Durrant <[email protected]>; Xen-devel <[email protected]>
Cc: Jan Beulich <[email protected]>; Wei Liu <[email protected]>; Roger Pau Monne <[email protected]>
Subject: Re: [PATCH] x86/viridian: Reword HV_X64_MSR_CRASH_CTL print message

Quoted 5 lines · Paul Durrant
Quoted 5 lines

-----Original Message-----
From: Andrew Cooper <[email protected]>
Sent: 13 September 2019 17:04
To: Xen-devel <[email protected]>
Cc: Andrew Cooper <[email protected]>; Jan Beulich <[email protected]>; Wei Liu

<[email protected]>;

Quoted 11 lines
Quoted 11 lines

Roger Pau Monne <[email protected]>; Paul Durrant <[email protected]>
Subject: [PATCH] x86/viridian: Reword HV_X64_MSR_CRASH_CTL print message

Message such as:

(XEN) d3v0 VIRIDIAN CRASH: 51 1 ffff9700e146b000 1000 204

have confused many people into thinking the the problem is a bug in the viridian code. The prefix was intended to signify the use of the viridian crash-reporting interface.

Quoted 7 lines
Quoted 3 lines
Quoted 2 lines

Replace the VIRIDIAN prefix with 'reported' to reduce the confusion to non-xen-developers trying to interpret the message.

This is a message that is peculiar to Windows VMs, so how about "Windows VM CRASH"?

I presume you mean particular, but no - it isn't windows which is the exclusive user of this interface.  Linux has a driver to use it when running under HyperV.

Hmm, that's a bit odd. I thought the crash codes are Windows specific. Perhaps they can be distinguished in some way. All the same, the log line needs to lead people to some way of decoding the magic numbers I think. How about:

"VIRIDIAN REPORTED CRASH"

?

Paul

Quoted 2 lines

~Andrew

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#4 lore raw
Quoted 25 lines · Paul Durrant
Quoted 25 lines

-----Original Message-----
From: Andrew Cooper <[email protected]>
Sent: 16 September 2019 13:48
To: Paul Durrant <[email protected]>; Xen-devel <[email protected]>
Cc: Jan Beulich <[email protected]>; Wei Liu <[email protected]>; Roger Pau Monne <[email protected]>
Subject: Re: [PATCH] x86/viridian: Reword HV_X64_MSR_CRASH_CTL print message

Quoted 5 lines · Paul Durrant
Quoted 5 lines

-----Original Message-----
From: Andrew Cooper <[email protected]>
Sent: 13 September 2019 17:04
To: Xen-devel <[email protected]>
Cc: Andrew Cooper <[email protected]>; Jan Beulich <[email protected]>; Wei Liu

<[email protected]>;

Quoted 11 lines
Quoted 11 lines

Roger Pau Monne <[email protected]>; Paul Durrant <[email protected]>
Subject: [PATCH] x86/viridian: Reword HV_X64_MSR_CRASH_CTL print message

Message such as:

(XEN) d3v0 VIRIDIAN CRASH: 51 1 ffff9700e146b000 1000 204

have confused many people into thinking the the problem is a bug in the viridian code. The prefix was intended to signify the use of the viridian crash-reporting interface.

Quoted 7 lines
Quoted 6 lines
Quoted 3 lines
Quoted 2 lines

Replace the VIRIDIAN prefix with 'reported' to reduce the confusion to non-xen-developers trying to interpret the message.

This is a message that is peculiar to Windows VMs, so how about "Windows VM CRASH"?

I presume you mean particular, but no - it isn't windows which is the exclusive user of this interface.  Linux has a driver to use it when running under HyperV.

Hmm, that's a bit odd. I thought the crash codes are Windows specific. Perhaps they can be distinguished in some way.

Linux sets its own guest OS identifier, which is some function of HV_LINUX_VENDOR_ID.

Quoted 5 lines

All the same, the log line needs to lead people to some way of decoding the magic numbers I think. How about:

"VIRIDIAN REPORTED CRASH"

?

That is still just as confusing to read.

There is no way to decode the numbers without knowing what OS is running, and simply saying "Viridian" doesn't help with that.

~Andrew

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#5 lore raw

On Mon, 16 Sep 2019 at 14:13, Andrew Cooper <[email protected]> wrote:
[...]

Quoted 13 lines
Quoted 7 lines
Quoted 6 lines
Quoted 3 lines
Quoted 2 lines

Replace the VIRIDIAN prefix with 'reported' to reduce the confusion to non-xen-developers trying to interpret the message.

This is a message that is peculiar to Windows VMs, so how about "Windows VM CRASH"?

I presume you mean particular, but no - it isn't windows which is the exclusive user of this interface. Linux has a driver to use it when running under HyperV.

Hmm, that's a bit odd. I thought the crash codes are Windows specific. Perhaps they can be distinguished in some way.

Linux sets its own guest OS identifier, which is some function of HV_LINUX_VENDOR_ID.

Quoted 2 lines

All the same, the log line needs to lead people to some way of decoding the magic numbers I think. How about:

Quoted 9 lines
Quoted 3 lines

"VIRIDIAN REPORTED CRASH"

?

That is still just as confusing to read.

There is no way to decode the numbers without knowing what OS is running, and simply saying "Viridian" doesn't help with that.

Would it make sense to call dump_guest_os_id here as well? Seeing that it is only printed when it was first set.

Wei.

Quoted 1 line

~Andrew

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#6 lore raw
Quoted 29 lines

-----Original Message-----
From: Wei Liu <[email protected]>
Sent: 16 September 2019 14:29
To: Andrew Cooper <[email protected]>
Cc: Paul Durrant <[email protected]>; Xen-devel <[email protected]>; Jan Beulich <[email protected]>; Wei Liu <[email protected]>; Roger Pau Monne <[email protected]>
Subject: Re: [PATCH] x86/viridian: Reword HV_X64_MSR_CRASH_CTL print message

On Mon, 16 Sep 2019 at 14:13, Andrew Cooper <[email protected]> wrote:
[...]

Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
Quoted 3 lines
Quoted 2 lines

Replace the VIRIDIAN prefix with 'reported' to reduce the confusion to non-xen-developers trying to interpret the message.

This is a message that is peculiar to Windows VMs, so how about "Windows VM CRASH"?

I presume you mean particular, but no - it isn't windows which is the exclusive user of this interface. Linux has a driver to use it when running under HyperV.

Hmm, that's a bit odd. I thought the crash codes are Windows specific. Perhaps they can be

distinguished in some way.

Quoted 5 lines

Linux sets its own guest OS identifier, which is some function of HV_LINUX_VENDOR_ID.

Quoted 1 line

All the same, the log line needs to lead people to some way of decoding the magic numbers I

think. How about:

Quoted 5 lines
Quoted 4 lines

"VIRIDIAN REPORTED CRASH"

?

Quoted 8 lines
Quoted 5 lines

That is still just as confusing to read.

There is no way to decode the numbers without knowing what OS is running, and simply saying "Viridian" doesn't help with that.

Would it make sense to call dump_guest_os_id here as well? Seeing that it is only printed when it was first set.

Yes, that's not a bad idea.

Paul

Quoted 4 lines

Wei.

Quoted 1 line

~Andrew

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#7 lore raw
Quoted 26 lines · Paul Durrant
Quoted 26 lines

-----Original Message-----
From: Wei Liu <[email protected]>
Sent: 16 September 2019 14:29
To: Andrew Cooper <[email protected]>
Cc: Paul Durrant <[email protected]>; Xen-devel <[email protected]>; Jan Beulich <[email protected]>; Wei Liu <[email protected]>; Roger Pau Monne <[email protected]>
Subject: Re: [PATCH] x86/viridian: Reword HV_X64_MSR_CRASH_CTL print message

On Mon, 16 Sep 2019 at 14:13, Andrew Cooper <[email protected]> wrote:
[...]

Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
Quoted 3 lines
Quoted 2 lines

Replace the VIRIDIAN prefix with 'reported' to reduce the confusion to non-xen-developers trying to interpret the message.

This is a message that is peculiar to Windows VMs, so how about "Windows VM CRASH"?

I presume you mean particular, but no - it isn't windows which is the exclusive user of this interface. Linux has a driver to use it when running under HyperV.

Hmm, that's a bit odd. I thought the crash codes are Windows specific. Perhaps they can be

distinguished in some way.

Quoted 4 lines

Linux sets its own guest OS identifier, which is some function of HV_LINUX_VENDOR_ID.

Quoted 1 line

All the same, the log line needs to lead people to some way of decoding the magic numbers I

think. How about:

Quoted 3 lines
Quoted 3 lines

"VIRIDIAN REPORTED CRASH"

?

Quoted 8 lines
Quoted 7 lines
Quoted 5 lines

That is still just as confusing to read.

There is no way to decode the numbers without knowing what OS is running, and simply saying "Viridian" doesn't help with that.

Would it make sense to call dump_guest_os_id here as well? Seeing that it is only printed when it was first set.

Yes, that's not a bad idea.

This is as maybe, but still doesn't help with ambiguity because you can't expect people to recognise guest-id's by their hex value.  It also doesn't help with the confusion of having the word viridian in the printed string.

~Andrew

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#8 lore raw
Quoted 33 lines · Andrew Cooper
Quoted 31 lines · Paul Durrant
Quoted 31 lines

-----Original Message-----
From: Wei Liu <[email protected]>
Sent: 16 September 2019 14:29
To: Andrew Cooper <[email protected]>
Cc: Paul Durrant <[email protected]>; Xen-devel <[email protected]>; Jan Beulich <[email protected]>; Wei Liu <[email protected]>; Roger Pau Monne <[email protected]>
Subject: Re: [PATCH] x86/viridian: Reword HV_X64_MSR_CRASH_CTL print message

On Mon, 16 Sep 2019 at 14:13, Andrew Cooper <[email protected]> wrote:
[...]

Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
Quoted 3 lines
Quoted 2 lines

Replace the VIRIDIAN prefix with 'reported' to reduce the confusion to non-xen-developers trying to interpret the message.

This is a message that is peculiar to Windows VMs, so how about "Windows VM CRASH"?

I presume you mean particular, but no - it isn't windows which is the exclusive user of this interface. Linux has a driver to use it when running under HyperV.

Hmm, that's a bit odd. I thought the crash codes are Windows specific. Perhaps they can be

distinguished in some way.

Quoted 4 lines

Linux sets its own guest OS identifier, which is some function of HV_LINUX_VENDOR_ID.

Quoted 1 line

All the same, the log line needs to lead people to some way of decoding the magic numbers I

think. How about:

Quoted 8 lines
Quoted 3 lines

"VIRIDIAN REPORTED CRASH"

?

That is still just as confusing to read.

There is no way to decode the numbers without knowing what OS is running, and simply saying "Viridian" doesn't help with that.

Quoted 9 lines
Quoted 3 lines
Quoted 2 lines

Would it make sense to call dump_guest_os_id here as well? Seeing that it is only printed when it was first set.

Yes, that's not a bad idea.

This is as maybe, but still doesn't help with ambiguity because you can't expect people to recognise guest-id's by their hex value. It also doesn't help with the confusion of having the word viridian in the printed string.

I look closer today. They can be interpreted at least for Linux. It is useful information to have. If we want to print crash control values at all, OS information shouldn't be omitted.

I don't really have an opinion on whether the viridian prefix is useful or not.

Wei.

Quoted 1 line

~Andrew

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel