Convert qcom,spmi-pmic bindings from .txt to .yaml
v4 cover Convert qcom,spmi-pmic bindings from .txt to .yaml
This patch series does the following:
- converts the qcom,spmi-pmic bindings from .txt to .yaml format
- Sorted the compatible strings
- Adds PM6150 and PM6150L subtypes.
Changes from V3:
- Fixed compilation error in .yaml file.
Changes from V2:
- Addressed Stephen Boyd and Rob Herring comments.
Kiran Gunda (2):
mfd: qcom-spmi-pmic: Convert bindings to .yaml format
mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l
.../devicetree/bindings/mfd/qcom,spmi-pmic.txt | 80 ------------- .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 129 +++++++++++++++++++++ drivers/mfd/qcom-spmi-pmic.c | 4 + 3 files changed, 133 insertions(+), 80 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt create mode 100644 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH v4 1/2 mfd: qcom-spmi-pmic: Convert bindings to .yaml format
Convert the bindings from .txt to .yaml format.
--- .../devicetree/bindings/mfd/qcom,spmi-pmic.txt | 80 ------------- .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 127 +++++++++++++++++++++ 2 files changed, 127 insertions(+), 80 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt create mode 100644 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt deleted +0 -80
@@ -1,80 +0,0 @@ - Qualcomm SPMI PMICs multi-function device bindings - -The Qualcomm SPMI series presently includes PM8941, PM8841 and PMA8084 -PMICs. These PMICs use a QPNP scheme through SPMI interface. -QPNP is effectively a partitioning scheme for dividing the SPMI extended -register space up into logical pieces, and set of fixed register -locations/definitions within these regions, with some of these regions -specifically used for interrupt handling. - -The QPNP PMICs are used with the Qualcomm Snapdragon series SoCs, and are -interfaced to the chip via the SPMI (System Power Management Interface) bus. -Support for multiple independent functions are implemented by splitting the -16-bit SPMI slave address space into 256 smaller fixed-size regions, 256 bytes -each. A function can consume one or more of these fixed-size register regions. - -Required properties: -- compatible: Should contain one of: - "qcom,pm8941", - "qcom,pm8841", - "qcom,pma8084", - "qcom,pm8019", - "qcom,pm8226", - "qcom,pm8110", - "qcom,pma8084", - "qcom,pmi8962", - "qcom,pmd9635", - "qcom,pm8994", - "qcom,pmi8994", - "qcom,pm8916", - "qcom,pm8004", - "qcom,pm8909", - "qcom,pm8950", - "qcom,pmi8950", - "qcom,pm8998", - "qcom,pmi8998", - "qcom,pm8005", - or generalized "qcom,spmi-pmic". -- reg: Specifies the SPMI USID slave address for this device. - For more information see: - Documentation/devicetree/bindings/spmi/spmi.yaml - -Required properties for peripheral child nodes: -- compatible: Should contain "qcom,xxx", where "xxx" is a peripheral name. - -Optional properties for peripheral child nodes: -- interrupts: Interrupts are specified as a 4-tuple. For more information - see: - Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt -- interrupt-names: Corresponding interrupt name to the interrupts property - -Each child node of SPMI slave id represents a function of the PMIC. In the -example below the rtc device node represents a peripheral of pm8941 -SID = 0. The regulator device node represents a peripheral of pm8941 SID = 1. - -Example: - - spmi { - compatible = "qcom,spmi-pmic-arb"; - - pm8941@0 { - compatible = "qcom,pm8941", "qcom,spmi-pmic"; - reg = <0x0 SPMI_USID>; - - rtc { - compatible = "qcom,rtc"; - interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>; - interrupt-names = "alarm"; - }; - }; - - pm8941@1 { - compatible = "qcom,pm8941", "qcom,spmi-pmic"; - reg = <0x1 SPMI_USID>; - - regulator { - compatible = "qcom,regulator"; - regulator-name = "8941_boost"; - }; - }; - };
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml new file +127 -0
127 lines not on this page · raw message
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH V4 1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format
Quoting Kiran Gunda (2020-12-18 00:14:51)
Quoted 102 lines
Convert the bindings from .txt to .yaml format.
Signed-off-by Kiran Gunda <[email protected]>--- .../devicetree/bindings/mfd/qcom,spmi-pmic.txt | 80 ------------- .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 127 +++++++++++++++++++++ 2 files changed, 127 insertions(+), 80 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt create mode 100644 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yamlDocumentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt deleted +0
-80@@ -1,80 +0,0 @@ - Qualcomm SPMI PMICs multi-function device bindings - -The Qualcomm SPMI series presently includes PM8941, PM8841 and PMA8084 -PMICs. These PMICs use a QPNP scheme through SPMI interface. -QPNP is effectively a partitioning scheme for dividing the SPMI extended -register space up into logical pieces, and set of fixed register -locations/definitions within these regions, with some of these regions -specifically used for interrupt handling. - -The QPNP PMICs are used with the Qualcomm Snapdragon series SoCs, and are -interfaced to the chip via the SPMI (System Power Management Interface) bus. -Support for multiple independent functions are implemented by splitting the -16-bit SPMI slave address space into 256 smaller fixed-size regions, 256 bytes -each. A function can consume one or more of these fixed-size register regions. - -Required properties: -- compatible: Should contain one of: - "qcom,pm8941", - "qcom,pm8841", - "qcom,pma8084", - "qcom,pm8019", - "qcom,pm8226", - "qcom,pm8110", - "qcom,pma8084", - "qcom,pmi8962", - "qcom,pmd9635", - "qcom,pm8994", - "qcom,pmi8994", - "qcom,pm8916", - "qcom,pm8004", - "qcom,pm8909", - "qcom,pm8950", - "qcom,pmi8950", - "qcom,pm8998", - "qcom,pmi8998", - "qcom,pm8005", - or generalized "qcom,spmi-pmic". -- reg: Specifies the SPMI USID slave address for this device. - For more information see: - Documentation/devicetree/bindings/spmi/spmi.yaml - -Required properties for peripheral child nodes: -- compatible: Should contain "qcom,xxx", where "xxx" is a peripheral name. - -Optional properties for peripheral child nodes: -- interrupts: Interrupts are specified as a 4-tuple. For more information - see: - Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt -- interrupt-names: Corresponding interrupt name to the interrupts property - -Each child node of SPMI slave id represents a function of the PMIC. In the -example below the rtc device node represents a peripheral of pm8941 -SID = 0. The regulator device node represents a peripheral of pm8941 SID = 1. - -Example: - - spmi { - compatible = "qcom,spmi-pmic-arb"; - - pm8941@0 { - compatible = "qcom,pm8941", "qcom,spmi-pmic"; - reg = <0x0 SPMI_USID>; - - rtc { - compatible = "qcom,rtc"; - interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>; - interrupt-names = "alarm"; - }; - }; - - pm8941@1 { - compatible = "qcom,pm8941", "qcom,spmi-pmic"; - reg = <0x1 SPMI_USID>; - - regulator { - compatible = "qcom,regulator"; - regulator-name = "8941_boost"; - }; - }; - };Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml new file +0
-0
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml line 10
Quoted 10 lines
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml new file +10
-0@@ -0,0 +1,127 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/qcom,spmi-pmic.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm SPMI PMICs multi-function device bindings + +maintainers: + - Stephen Boyd <[email protected]>
Someone at Qualcomm should be the maintainer here. Maybe you?
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml line 13
Quoted 3 lines
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml new file +3
-0+ +description: | + The Qualcomm SPMI PMICs use a QPNP scheme through SPMI interface.
What is QPNP?
Quoted 49 lines
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml new file +49
-0+ QPNP is effectively a partitioning scheme for dividing the SPMI extended + register space up into logical pieces, and set of fixed register + locations/definitions within these regions, with some of these regions + specifically used for interrupt handling. + + The QPNP PMICs are used with the Qualcomm Snapdragon series SoCs, and are + interfaced to the chip via the SPMI (System Power Management Interface) bus. + Support for multiple independent functions are implemented by splitting the + 16-bit SPMI slave address space into 256 smaller fixed-size regions, 256 bytes + each. A function can consume one or more of these fixed-size register regions. + +properties: + spmi_bus: + type: object + description: SPMI bus node + +patternProperties: + "^pmic@[0-9]$": + description: Child PMIC nodes + type: object + + properties: + compatible: + items: + - enum: + # Sorted based on subtype ID the device reports + - qcom,pm8941 + - qcom,pm8841 + - qcom,pma8084 + - qcom,pm8019 + - qcom,pm8226 + - qcom,pm8110 + - qcom,pma8084 + - qcom,pmi8962 + - qcom,pmd9635 + - qcom,pm8994 + - qcom,pmi8994 + - qcom,pm8916 + - qcom,pm8004 + - qcom,pm8909 + - qcom,pm8950 + - qcom,pmi8950 + - qcom,pm8998 + - qcom,pmi8998 + - qcom,pm8005 + - qcom,pm660l + - qcom,pm660 + + - enum:
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml line 72
Quoted 10 lines
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml new file +10
-0+ - qcom,spmi-pmic + + reg: + maxItems: 1 + description: + Specifies the SPMI USID slave address for this device. + For more information see bindings/spmi/spmi.txt + + patternProperties: + "@[0-9a-f]$":
Is that @ sign supposed to be a ^ sign? I thought the child nodes of a pmic node were [a-zA-Z0-9-] or some sort of regex like that. Certainly not an address that doesn't exist. They look to be things like 'rtc' or 'regulator'.
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml line 84
Quoted 12 lines
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml new file +12
-0+ description: + Each child node of SPMI slave id represents a function of the PMIC. + In the example below the rtc device node represents a peripheral of + pm8941 SID = 0. The regulator device node represents a peripheral of + pm8941 SID = 1. + type: object + + properties: + interrupts: + maxItems: 4 + description: + Interrupts are specified as a 4-tuple. For more information
Seems like minItems is also 4 though, so should be a const 4 instead? But then this is about how many interrupts there are, which would be 1 or 2? It really can't be known in case there are many interrupts for a child node so not sure we need to specify anything.
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml line 89
Quoted 5 lines
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml new file +5
-0+ see bindings/spmi/qcom,spmi-pmic-arb.txt + + interrupt-names: + description: + Corresponding interrupt name to the interrupts property
I suspect we should drop these two properties and leave them up to the binding for the function, like rtc, or regualator, etc.
Quoted 38 lines
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml new file +38
-0+ + required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/spmi/spmi.h> + + spmi_bus { + compatible = "qcom,spmi-pmic-arb"; + #address-cells = <2>; + #size-cells = <0>; + + pmic@0 { + compatible = "qcom,pm8941"; + reg = <0x0 SPMI_USID>; + + rtc { + compatible = "qcom,rtc"; + interrupts = <0x0 0x61 0x1 0x1>; + interrupt-names = "alarm"; + }; + }; + + pmic@1 { + compatible = "qcom,pm8941"; + reg = <0x1 SPMI_USID>; + + regulator { + compatible = "qcom,regulator"; + regulator-name = "8941_boost"; + }; + }; + }; +...
Re: [PATCH V4 1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format
Quoted 136 lines · Stephen Boyd
Quoting Kiran Gunda (2020-12-18 00:14:51)
Quoted 122 lines
Convert the bindings from .txt to .yaml format.
Signed-off-by Kiran Gunda <[email protected]>--- .../devicetree/bindings/mfd/qcom,spmi-pmic.txt | 80 ------------- .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 127 +++++++++++++++++++++ 2 files changed, 127 insertions(+), 80 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt create mode 100644
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yamlDocumentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt deleted +0
-3@@ -1,80 +0,0 @@ - Qualcomm SPMI PMICs multi-function device bindings - -The Qualcomm SPMI series presently includes PM8941, PM8841 andPMA8084
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt deleted +0
-2-PMICs. These PMICs use a QPNP scheme through SPMI interface. -QPNP is effectively a partitioning scheme for dividing the SPMIextended
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt deleted +0
-2-register space up into logical pieces, and set of fixed register -locations/definitions within these regions, with some of theseregions
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt deleted +0
-3-specifically used for interrupt handling. - -The QPNP PMICs are used with the Qualcomm Snapdragon series SoCs, andare
-interfaced to the chip via the SPMI (System Power Management Interface) bus.
-Support for multiple independent functions are implemented by splitting the
-16-bit SPMI slave address space into 256 smaller fixed-size regions, 256 bytes
-each. A function can consume one or more of these fixed-size register regions.Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt deleted +0
-24- -Required properties: -- compatible: Should contain one of: - "qcom,pm8941", - "qcom,pm8841", - "qcom,pma8084", - "qcom,pm8019", - "qcom,pm8226", - "qcom,pm8110", - "qcom,pma8084", - "qcom,pmi8962", - "qcom,pmd9635", - "qcom,pm8994", - "qcom,pmi8994", - "qcom,pm8916", - "qcom,pm8004", - "qcom,pm8909", - "qcom,pm8950", - "qcom,pmi8950", - "qcom,pm8998", - "qcom,pmi8998", - "qcom,pm8005", - or generalized "qcom,spmi-pmic". -- reg: Specifies the SPMI USID slave address for thisdevice.
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt deleted +0
-5- For more information see: - Documentation/devicetree/bindings/spmi/spmi.yaml - -Required properties for peripheral child nodes: -- compatible: Should contain "qcom,xxx", where "xxx" is aperipheral name.
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt deleted +0
-3- -Optional properties for peripheral child nodes: -- interrupts: Interrupts are specified as a 4-tuple. For moreinformation
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt deleted +0
-2- see: -
Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt-- interrupt-names: Corresponding interrupt name to the interrupts propertyDocumentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt deleted +0
-2- -Each child node of SPMI slave id represents a function of the PMIC.In the
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt deleted +0
-2-example below the rtc device node represents a peripheral of pm8941 -SID = 0. The regulator device node represents a peripheral of pm8941SID = 1.
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt deleted +0
-13- -Example: - - spmi { - compatible = "qcom,spmi-pmic-arb"; - - pm8941@0 { - compatible = "qcom,pm8941", "qcom,spmi-pmic"; - reg = <0x0 SPMI_USID>; - - rtc { - compatible = "qcom,rtc"; - interrupts = <0x0 0x61 0x1
IRQ_TYPE_EDGE_RISING>;Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt deleted +0
-14- interrupt-names = "alarm"; - }; - }; - - pm8941@1 { - compatible = "qcom,pm8941", "qcom,spmi-pmic"; - reg = <0x1 SPMI_USID>; - - regulator { - compatible = "qcom,regulator"; - regulator-name = "8941_boost"; - }; - }; - };Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml new file +0
-0Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml line 10
Quoted 10 lines
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml new file +10
-0@@ -0,0 +1,127 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/qcom,spmi-pmic.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm SPMI PMICs multi-function device bindings + +maintainers: + - Stephen Boyd <[email protected]>Someone at Qualcomm should be the maintainer here. Maybe you?
Quoted 6 lines
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml line 13
Quoted 3 lines
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml new file +3
-0+ +description: | + The Qualcomm SPMI PMICs use a QPNP scheme through SPMI interface.What is QPNP?
Qualcomm Plug And Play.
Quoted 63 lines
Quoted 63 lines
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml new file +1
-0+ QPNP is effectively a partitioning scheme for dividing the SPMIextended
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml new file +2
-0+ register space up into logical pieces, and set of fixed register + locations/definitions within these regions, with some of theseregions
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml new file +3
-0+ specifically used for interrupt handling. + + The QPNP PMICs are used with the Qualcomm Snapdragon series SoCs,and are
+ interfaced to the chip via the SPMI (System Power Management Interface) bus.
+ Support for multiple independent functions are implemented by splitting the
+ 16-bit SPMI slave address space into 256 smaller fixed-size regions, 256 bytes
+ each. A function can consume one or more of these fixed-size register regions.Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml new file +46
-0+ +properties: + spmi_bus: + type: object + description: SPMI bus node + +patternProperties: + "^pmic@[0-9]$": + description: Child PMIC nodes + type: object + + properties: + compatible: + items: + - enum: + # Sorted based on subtype ID the device reports + - qcom,pm8941 + - qcom,pm8841 + - qcom,pma8084 + - qcom,pm8019 + - qcom,pm8226 + - qcom,pm8110 + - qcom,pma8084 + - qcom,pmi8962 + - qcom,pmd9635 + - qcom,pm8994 + - qcom,pmi8994 + - qcom,pm8916 + - qcom,pm8004 + - qcom,pm8909 + - qcom,pm8950 + - qcom,pmi8950 + - qcom,pm8998 + - qcom,pmi8998 + - qcom,pm8005 + - qcom,pm660l + - qcom,pm660 + + - enum: + - qcom,spmi-pmic + + reg: + maxItems: 1 + description: + Specifies the SPMI USID slave address for this device. + For more information see bindings/spmi/spmi.txt
Quoted 9 lines
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml line 72
Quoted 3 lines
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml new file +3
-0+ + patternProperties: + "@[0-9a-f]$":Is that @ sign supposed to be a ^ sign? I thought the child nodes of a pmic node were [a-zA-Z0-9-] or some sort of regex like that. Certainly not an address that doesn't exist. They look to be things like 'rtc' or 'regulator'.
Will fix it in next series.
Quoted 22 lines
Quoted 15 lines
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml new file +2
-0+ description: + Each child node of SPMI slave id represents a function ofthe PMIC.
+ In the example below the rtc device node represents a
peripheral of
+ pm8941 SID = 0. The regulator device node represents a
peripheral ofDocumentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml new file +8
-0+ pm8941 SID = 1. + type: object + + properties: + interrupts: + maxItems: 4 + description: + Interrupts are specified as a 4-tuple. For moreQuoted 1 line
information
Seems like minItems is also 4 though, so should be a const 4 instead? But then this is about how many interrupts there are, which would be 1 or 2? It really can't be known in case there are many interrupts for a child node so not sure we need to specify anything.
Quoted 9 lines
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml line 89
Quoted 5 lines
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml new file +5
-0+ see bindings/spmi/qcom,spmi-pmic-arb.txt + + interrupt-names: + description: + Corresponding interrupt name to the interrupts propertyI suspect we should drop these two properties and leave them up to the binding for the function, like rtc, or regualator, etc.
Okay. I will remove these properties.
Quoted 38 lines
Quoted 38 lines
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml new file +38
-0+ + required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/spmi/spmi.h> + + spmi_bus { + compatible = "qcom,spmi-pmic-arb"; + #address-cells = <2>; + #size-cells = <0>; + + pmic@0 { + compatible = "qcom,pm8941"; + reg = <0x0 SPMI_USID>; + + rtc { + compatible = "qcom,rtc"; + interrupts = <0x0 0x61 0x1 0x1>; + interrupt-names = "alarm"; + }; + }; + + pmic@1 { + compatible = "qcom,pm8941"; + reg = <0x1 SPMI_USID>; + + regulator { + compatible = "qcom,regulator"; + regulator-name = "8941_boost"; + }; + }; + }; +...
Re: [PATCH V4 1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format
In reply to Kiran GundaQuoted 9 lines · Kiran Gunda
Convert the bindings from .txt to .yaml format.
Signed-off-by Kiran Gunda <[email protected]>--- .../devicetree/bindings/mfd/qcom,spmi-pmic.txt | 80 ------------- .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 127 +++++++++++++++++++++ 2 files changed, 127 insertions(+), 80 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt create mode 100644 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
What are the other patches that I was not cc'ed on?
Generally it's a bad idea to send only some patches of a set to some maintainers. Best for everyone to have full visibility.
Also looks like you're missing a cover-letter [PATCH 0/4] which adds to the opaqueness/confusion.
Signature · 4 lines
Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH V4 1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format
Quoted 16 lines · Lee Jones
Quoted 12 lines · Kiran Gunda
Convert the bindings from .txt to .yaml format.
Signed-off-by Kiran Gunda <[email protected]>--- .../devicetree/bindings/mfd/qcom,spmi-pmic.txt | 80 ------------- .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 127 +++++++++++++++++++++ 2 files changed, 127 insertions(+), 80 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt create mode 100644Quoted 1 line
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
Quoted 5 lines
What are the other patches that I was not cc'ed on?
Generally it's a bad idea to send only some patches of a set to some maintainers. Best for everyone to have full visibility.
I ran the get_maintainer.pl script. Not sure how it is missed. Anyways I will add you in the next post.
Quoted 2 lines
Also looks like you're missing a cover-letter [PATCH 0/4] which adds to the opaqueness/confusion.
I have introduced the cover letter from V3 series. That's why the earlier notes are missing from cover letter. Let me add them in next series.
PATCH v4 2/2 mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l
In reply to Kiran GundaAdd the compatibles and PMIC ids for pm6150 and pm6150l PMICs found on SC7180 based platforms.
--- Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 ++ drivers/mfd/qcom-spmi-pmic.c | 4 ++++ 2 files changed, 6 insertions(+)
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml +2 -0
@@ -58,6 +58,8 @@ patternProperties: - qcom,pm8005 - qcom,pm660l - qcom,pm660 + - qcom,pm6150l + - qcom,pm6150 - enum: - qcom,spmi-pmic
drivers/mfd/qcom-spmi-pmic.c +4 -0
@@ -38,6 +38,8 @@#define PM8005_SUBTYPE 0x18#define PM660L_SUBTYPE 0x1A#define PM660_SUBTYPE 0x1B +#define PM6150L_SUBTYPE 0x1F +#define PM6150_SUBTYPE 0x28static const struct of_device_id pmic_spmi_id_table[] = { { .compatible ="qcom,spmi-pmic" , .data = (void *)COMMON_SUBTYPE },
@@ -61,6 +63,8 @@ static const struct of_device_id pmic_spmi_id_table[] = { { .compatible = "qcom,pm8005", .data = (void *)PM8005_SUBTYPE }, { .compatible = "qcom,pm660l", .data = (void *)PM660L_SUBTYPE }, { .compatible = "qcom,pm660", .data = (void *)PM660_SUBTYPE }, + { .compatible = "qcom,pm6150l", .data = (void *)PM6150L_SUBTYPE }, + { .compatible = "qcom,pm6150", .data = (void *)PM6150_SUBTYPE }, { } };
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH V4 2/2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l
Quoting Kiran Gunda (2020-12-18 00:14:52)
Quoted 5 lines
Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs found on SC7180 based platforms.
Signed-off-by Kiran Gunda <[email protected]>---
Re: [PATCH V4 2/2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l
In reply to Kiran GundaQuoted 8 lines · Kiran Gunda
Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs found on SC7180 based platforms.
Signed-off-by Kiran Gunda <[email protected]>--- Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 ++ drivers/mfd/qcom-spmi-pmic.c | 4 ++++ 2 files changed, 6 insertions(+)
I can't apply this until the file has been converted.
In the mean time:
For my own reference (apply this as-is to your sign-off block):
Signature · 4 lines
Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog