hwmon: Remove I2C_CLASS_HWMON from drivers w/o detect() and address_list
Subsystems (2)
PATCH 1/1 hwmon: Remove I2C_CLASS_HWMON from drivers w/o detect() and address_list
Class-based I2C probing requires detect() and address_list to be set in the I2C client driver, see checks in i2c_detect(). It's misleading to declare I2C_CLASS_HWMON support if this precondition isn't met.
--- drivers/hwmon/adm1177.c | 1 - drivers/hwmon/ds1621.c | 1 - drivers/hwmon/ds620.c | 1 - drivers/hwmon/ina209.c | 1 - drivers/hwmon/ina238.c | 1 - drivers/hwmon/max127.c | 1 - drivers/hwmon/max31760.c | 1 - drivers/hwmon/max31790.c | 1 - drivers/hwmon/max31827.c | 1 - drivers/hwmon/max6621.c | 1 - drivers/hwmon/max6697.c | 1 - drivers/hwmon/occ/p8_i2c.c | 1 - drivers/hwmon/pmbus/ir36021.c | 1 - drivers/hwmon/powr1220.c | 1 - drivers/hwmon/sbrmi.c | 1 - drivers/hwmon/sbtsi_temp.c | 1 - drivers/hwmon/w83773g.c | 1 - 17 files changed, 17 deletions(-)
drivers/hwmon/adm1177.c +0 -1
@@ -250,7 +250,6 @@ static const struct of_device_id adm1177_dt_ids[] = {MODULE_DEVICE_TABLE (of, adm1177_dt_ids);static struct i2c_driver adm1177_driver = { - .class =I2C_CLASS_HWMON , .driver = { .name ="adm1177" , .of_match_table = adm1177_dt_ids,
drivers/hwmon/ds1621.c +0 -1
@@ -380,7 +380,6 @@ MODULE_DEVICE_TABLE(i2c, ds1621_id);/* This is the driver that will be inserted */ static struct i2c_driver ds1621_driver = { - .class =I2C_CLASS_HWMON , .driver = { .name ="ds1621" , },
drivers/hwmon/ds620.c +0 -1
@@ -241,7 +241,6 @@ MODULE_DEVICE_TABLE(i2c, ds620_id);/* This is the driver that will be inserted */ static struct i2c_driver ds620_driver = { - .class =I2C_CLASS_HWMON , .driver = { .name ="ds620" , },
drivers/hwmon/ina209.c +0 -1
@@ -589,7 +589,6 @@ MODULE_DEVICE_TABLE(of, ina209_of_match);/* This is the driver that will be inserted */ static struct i2c_driver ina209_driver = { - .class =I2C_CLASS_HWMON , .driver = { .name ="ina209" , .of_match_table =of_match_ptr (ina209_of_match),
drivers/hwmon/ina238.c +0 -1
@@ -629,7 +629,6 @@ static const struct of_device_id __maybe_unused ina238_of_match[] = {MODULE_DEVICE_TABLE (of, ina238_of_match);static struct i2c_driver ina238_driver = { - .class =I2C_CLASS_HWMON , .driver = { .name ="ina238" , .of_match_table =of_match_ptr (ina238_of_match),
drivers/hwmon/max127.c +0 -1
@@ -335,7 +335,6 @@ static const struct i2c_device_id max127_id[] = {MODULE_DEVICE_TABLE (i2c, max127_id);static struct i2c_driver max127_driver = { - .class =I2C_CLASS_HWMON , .driver = { .name ="max127" , },
drivers/hwmon/max31760.c +0 -1
@@ -578,7 +578,6 @@ static DEFINE_SIMPLE_DEV_PM_OPS(max31760_pm_ops, max31760_suspend, max31760_resume);static struct i2c_driver max31760_driver = { - .class =I2C_CLASS_HWMON , .driver = { .name ="max31760" , .of_match_table = max31760_of_match,
drivers/hwmon/max31790.c +0 -1
@@ -543,7 +543,6 @@ static const struct i2c_device_id max31790_id[] = {MODULE_DEVICE_TABLE (i2c, max31790_id);static struct i2c_driver max31790_driver = { - .class =I2C_CLASS_HWMON , .probe = max31790_probe, .driver = { .name ="max31790" ,
drivers/hwmon/max31827.c +0 -1
@@ -652,7 +652,6 @@ static const struct of_device_id max31827_of_match[] = {MODULE_DEVICE_TABLE (of, max31827_of_match);static struct i2c_driver max31827_driver = { - .class =I2C_CLASS_HWMON , .driver = { .name ="max31827" , .of_match_table = max31827_of_match,
drivers/hwmon/max6621.c +0 -1
@@ -549,7 +549,6 @@ static const struct of_device_id __maybe_unused max6621_of_match[] = {MODULE_DEVICE_TABLE (of, max6621_of_match);static struct i2c_driver max6621_driver = { - .class =I2C_CLASS_HWMON , .driver = { .name =MAX6621_DRV_NAME , .of_match_table =of_match_ptr (max6621_of_match),
drivers/hwmon/max6697.c +0 -1
@@ -780,7 +780,6 @@ static const struct of_device_id __maybe_unused max6697_of_match[] = {MODULE_DEVICE_TABLE (of, max6697_of_match);static struct i2c_driver max6697_driver = { - .class =I2C_CLASS_HWMON , .driver = { .name ="max6697" , .of_match_table =of_match_ptr (max6697_of_match),
drivers/hwmon/occ/p8_i2c.c +0 -1
@@ -241,7 +241,6 @@ static const struct of_device_id p8_i2c_occ_of_match[] = {MODULE_DEVICE_TABLE (of, p8_i2c_occ_of_match);static struct i2c_driver p8_i2c_occ_driver = { - .class =I2C_CLASS_HWMON , .driver = { .name ="occ-hwmon" , .of_match_table = p8_i2c_occ_of_match,
drivers/hwmon/pmbus/ir36021.c +0 -1
@@ -63,7 +63,6 @@ static const struct of_device_id __maybe_unused ir36021_of_id[] = {MODULE_DEVICE_TABLE (of, ir36021_of_id);static struct i2c_driver ir36021_driver = { - .class =I2C_CLASS_HWMON , .driver = { .name ="ir36021" , .of_match_table =of_match_ptr (ir36021_of_id),
drivers/hwmon/powr1220.c +0 -1
@@ -323,7 +323,6 @@ static const struct i2c_device_id powr1220_ids[] = {MODULE_DEVICE_TABLE (i2c, powr1220_ids);static struct i2c_driver powr1220_driver = { - .class =I2C_CLASS_HWMON , .driver = { .name ="powr1220" , },
drivers/hwmon/sbrmi.c +0 -1
@@ -342,7 +342,6 @@ static const struct of_device_id __maybe_unused sbrmi_of_match[] = {MODULE_DEVICE_TABLE (of, sbrmi_of_match);static struct i2c_driver sbrmi_driver = { - .class =I2C_CLASS_HWMON , .driver = { .name ="sbrmi" , .of_match_table =of_match_ptr (sbrmi_of_match),
drivers/hwmon/sbtsi_temp.c +0 -1
@@ -232,7 +232,6 @@ static const struct of_device_id __maybe_unused sbtsi_of_match[] = {MODULE_DEVICE_TABLE (of, sbtsi_of_match);static struct i2c_driver sbtsi_driver = { - .class =I2C_CLASS_HWMON , .driver = { .name ="sbtsi" , .of_match_table =of_match_ptr (sbtsi_of_match),
drivers/hwmon/w83773g.c +0 -1
@@ -290,7 +290,6 @@ static int w83773_probe(struct i2c_client *client) }static struct i2c_driver w83773_driver = { - .class =I2C_CLASS_HWMON , .driver = { .name ="w83773g" , .of_match_table =of_match_ptr (w83773_of_match),
Signature · 1 line
2.43.0
Quoted 17 lines · Heiner Kallweit
Class-based I2C probing requires
detect()andaddress_listto be set in the I2C client driver, see checks ini2c_detect(). It's misleading to declareI2C_CLASS_HWMONsupport if this precondition isn't met.Signed-off-by Heiner Kallweit <[email protected]>--- drivers/hwmon/adm1177.c | 1 - drivers/hwmon/ds1621.c | 1 - drivers/hwmon/ds620.c | 1 - drivers/hwmon/ina209.c | 1 - drivers/hwmon/ina238.c | 1 - drivers/hwmon/max127.c | 1 - drivers/hwmon/max31760.c | 1 - drivers/hwmon/max31790.c | 1 - drivers/hwmon/max31827.c | 1 - drivers/hwmon/max6621.c | 1 -
Quoted 9 lines
drivers/hwmon/max6697.c | 1 - drivers/hwmon/occ/p8_i2c.c | 1 - drivers/hwmon/pmbus/ir36021.c | 1 - drivers/hwmon/powr1220.c | 1 - drivers/hwmon/sbrmi.c | 1 - drivers/hwmon/sbtsi_temp.c | 1 - drivers/hwmon/w83773g.c | 1 - 17 files changed, 17 deletions(-)
It seems MAINTAINERS needs to be updated.
Daniel Matyas ([email protected])
The email address you entered couldn't be found. Please check the recipient's email address and try to resend the message. If the problem continues, please contact your email admin.
Ibrahim Tilki ([email protected])
The email address you entered couldn't be found. Please check the recipient's email address and try to resend the message. If the problem continues, please contact your email admin.
Hennerich, Michael
maintainerQuoted 46 lines
-----Original Message-----
From: Heiner Kallweit <[email protected]>
Sent: Samstag, 27. Januar 2024 16:11
To: Hennerich, Michael <[email protected]>; Jean Delvare <[email protected]>; Guenter Roeck <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] hwmon: RemoveI2C_CLASS_HWMONfrom drivers w/odetect()andaddress_listQuoted 17 lines · Heiner Kallweit
Class-based I2C probing requires
detect()andaddress_listto be set in the I2C client driver, see checks ini2c_detect(). It's misleading to declareI2C_CLASS_HWMONsupport if this precondition isn't met.Signed-off-by Heiner Kallweit <[email protected]>--- drivers/hwmon/adm1177.c | 1 - drivers/hwmon/ds1621.c | 1 - drivers/hwmon/ds620.c | 1 - drivers/hwmon/ina209.c | 1 - drivers/hwmon/ina238.c | 1 - drivers/hwmon/max127.c | 1 - drivers/hwmon/max31760.c | 1 - drivers/hwmon/max31790.c | 1 - drivers/hwmon/max31827.c | 1 - drivers/hwmon/max6621.c | 1 -Quoted 9 lines
drivers/hwmon/max6697.c | 1 - drivers/hwmon/occ/p8_i2c.c | 1 - drivers/hwmon/pmbus/ir36021.c | 1 - drivers/hwmon/powr1220.c | 1 - drivers/hwmon/sbrmi.c | 1 - drivers/hwmon/sbtsi_temp.c | 1 - drivers/hwmon/w83773g.c | 1 - 17 files changed, 17 deletions(-)It seems
MAINTAINERSneeds to be updated.Daniel Matyas ([email protected]) The email address you entered couldn't be found. Please check the recipient's email address and try to resend the message. If the problem continues, please contact your email admin.
Quoted 4 lines
Ibrahim Tilki ([email protected]) The email address you entered couldn't be found. Please check the recipient's email address and try to resend the message. If the problem continues, please contact your email admin.
Right - thanks for pointing out.
We'll send a MAINTAINERS patch shortly.
-Michael
Quoted 46 lines · Michael
Quoted 46 lines
-----Original Message-----
From: Heiner Kallweit <[email protected]>
Sent: Samstag, 27. Januar 2024 16:11
To: Hennerich, Michael <[email protected]>; Jean Delvare <[email protected]>; Guenter Roeck <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] hwmon: RemoveI2C_CLASS_HWMONfrom drivers w/odetect()andaddress_listQuoted 17 lines · Heiner Kallweit
Class-based I2C probing requires
detect()andaddress_listto be set in the I2C client driver, see checks ini2c_detect(). It's misleading to declareI2C_CLASS_HWMONsupport if this precondition isn't met.Signed-off-by Heiner Kallweit <[email protected]>--- drivers/hwmon/adm1177.c | 1 - drivers/hwmon/ds1621.c | 1 - drivers/hwmon/ds620.c | 1 - drivers/hwmon/ina209.c | 1 - drivers/hwmon/ina238.c | 1 - drivers/hwmon/max127.c | 1 - drivers/hwmon/max31760.c | 1 - drivers/hwmon/max31790.c | 1 - drivers/hwmon/max31827.c | 1 - drivers/hwmon/max6621.c | 1 -Quoted 9 lines
drivers/hwmon/max6697.c | 1 - drivers/hwmon/occ/p8_i2c.c | 1 - drivers/hwmon/pmbus/ir36021.c | 1 - drivers/hwmon/powr1220.c | 1 - drivers/hwmon/sbrmi.c | 1 - drivers/hwmon/sbtsi_temp.c | 1 - drivers/hwmon/w83773g.c | 1 - 17 files changed, 17 deletions(-)It seems
MAINTAINERSneeds to be updated.Daniel Matyas ([email protected]) The email address you entered couldn't be found. Please check the recipient's email address and try to resend the message. If the problem continues, please contact your email admin.
Quoted 8 lines
Quoted 4 lines
Ibrahim Tilki ([email protected]) The email address you entered couldn't be found. Please check the recipient's email address and try to resend the message. If the problem continues, please contact your email admin.
Right - thanks for pointing out.
We'll send aMAINTAINERSpatch shortly.
Günter did that on your behalf already:
linux-next: 10e70ab10802 ("MAINTAINERS: Drop entries for hwmon devices with unreachable maintainers")
Quoted 2 lines
-Michael
Heiner
Quoted 16 lines · Heiner Kallweit
Class-based I2C probing requires
detect()andaddress_listto be set in the I2C client driver, see checks ini2c_detect(). It's misleading to declareI2C_CLASS_HWMONsupport if this precondition isn't met.Signed-off-by Heiner Kallweit <[email protected]>--- drivers/hwmon/adm1177.c | 1 - drivers/hwmon/ds1621.c | 1 - drivers/hwmon/ds620.c | 1 - drivers/hwmon/ina209.c | 1 - drivers/hwmon/ina238.c | 1 - drivers/hwmon/max127.c | 1 - drivers/hwmon/max31760.c | 1 - drivers/hwmon/max31790.c | 1 - drivers/hwmon/max31827.c | 1 -
Quoted 8 lines
drivers/hwmon/max6621.c | 1 - drivers/hwmon/max6697.c | 1 - drivers/hwmon/occ/p8_i2c.c | 1 - drivers/hwmon/pmbus/ir36021.c | 1 - drivers/hwmon/powr1220.c | 1 - drivers/hwmon/sbrmi.c | 1 - drivers/hwmon/sbtsi_temp.c | 1 - drivers/hwmon/w83773g.c | 1 -
Applied.
Thanks,
Guenter
Guenter Roeck
maintainerQuoted 16 lines · Heiner Kallweit
Class-based I2C probing requires
detect()andaddress_listto be set in the I2C client driver, see checks ini2c_detect(). It's misleading to declareI2C_CLASS_HWMONsupport if this precondition isn't met.Signed-off-by Heiner Kallweit <[email protected]>--- drivers/hwmon/adm1177.c | 1 - drivers/hwmon/ds1621.c | 1 - drivers/hwmon/ds620.c | 1 - drivers/hwmon/ina209.c | 1 - drivers/hwmon/ina238.c | 1 - drivers/hwmon/max127.c | 1 - drivers/hwmon/max31760.c | 1 - drivers/hwmon/max31790.c | 1 - drivers/hwmon/max31827.c | 1 -
Quoted 8 lines
drivers/hwmon/max6621.c | 1 - drivers/hwmon/max6697.c | 1 - drivers/hwmon/occ/p8_i2c.c | 1 - drivers/hwmon/pmbus/ir36021.c | 1 - drivers/hwmon/powr1220.c | 1 - drivers/hwmon/sbrmi.c | 1 - drivers/hwmon/sbtsi_temp.c | 1 - drivers/hwmon/w83773g.c | 1 -
Follow-up question: You did not drop the class from drivers/hwmon/adt7410.c and drivers/hwmon/emc2305.c. Is that because of the address_list in those drivers ?
As far as I can see, both address_list and I2C_CLASS_HWMON are useless in those drivers and could be dropped as well. Am I missing something ?
Thanks,
Guenter
Quoted 26 lines · Guenter Roeck
Quoted 16 lines · Heiner Kallweit
Class-based I2C probing requires
detect()andaddress_listto be set in the I2C client driver, see checks ini2c_detect(). It's misleading to declareI2C_CLASS_HWMONsupport if this precondition isn't met.Signed-off-by Heiner Kallweit <[email protected]>---
drivers/hwmon/adm1177.c | 1 -
drivers/hwmon/ds1621.c | 1 -
drivers/hwmon/ds620.c | 1 -drivers/hwmon/ina209.c | 1 - drivers/hwmon/ina238.c | 1 - drivers/hwmon/max127.c | 1 - drivers/hwmon/max31760.c | 1 - drivers/hwmon/max31790.c | 1 - drivers/hwmon/max31827.c | 1 -Quoted 8 lines
drivers/hwmon/max6621.c | 1 -
drivers/hwmon/max6697.c | 1 -
drivers/hwmon/occ/p8_i2c.c | 1 -
drivers/hwmon/pmbus/ir36021.c| 1 -
drivers/hwmon/powr1220.c | 1 -
drivers/hwmon/sbrmi.c | 1 -
drivers/hwmon/sbtsi_temp.c | 1 -
drivers/hwmon/w83773g.c | 1 -
Quoted 4 lines
Follow-up question: You did not drop the class from
drivers/hwmon/adt7410.canddrivers/hwmon/emc2305.c. Is that because of theaddress_listin those drivers ?
Yes. If address_list is set, this shows a certain intention to support I2C class-based probing. Then the question is whether adding the missing detect() implementation may be the more appropriate action.
Quoted 6 lines
As far as I can see, both
address_listandI2C_CLASS_HWMONare useless in those drivers and could be dropped as well. Am I missing something ?Thanks,
Guenter
Heiner
Guenter Roeck
maintainerQuoted 27 lines · Heiner Kallweit
Quoted 26 lines · Guenter Roeck
Quoted 24 lines · Heiner Kallweit
Class-based I2C probing requires
detect()andaddress_listto be set in the I2C client driver, see checks ini2c_detect(). It's misleading to declareI2C_CLASS_HWMONsupport if this precondition isn't met.Signed-off-by Heiner Kallweit <[email protected]>--- drivers/hwmon/adm1177.c | 1 - drivers/hwmon/ds1621.c | 1 - drivers/hwmon/ds620.c | 1 - drivers/hwmon/ina209.c | 1 - drivers/hwmon/ina238.c | 1 - drivers/hwmon/max127.c | 1 - drivers/hwmon/max31760.c | 1 - drivers/hwmon/max31790.c | 1 - drivers/hwmon/max31827.c | 1 - drivers/hwmon/max6621.c | 1 - drivers/hwmon/max6697.c | 1 - drivers/hwmon/occ/p8_i2c.c | 1 - drivers/hwmon/pmbus/ir36021.c | 1 - drivers/hwmon/powr1220.c | 1 - drivers/hwmon/sbrmi.c | 1 - drivers/hwmon/sbtsi_temp.c | 1 - drivers/hwmon/w83773g.c | 1 -
Quoted 8 lines
Quoted 4 lines
Follow-up question: You did not drop the class from
drivers/hwmon/adt7410.canddrivers/hwmon/emc2305.c. Is that because of theaddress_listin those drivers ?Yes. If
address_listis set, this shows a certain intention to support I2C class-based probing. Then the question is whether adding the missingdetect()implementation may be the more appropriate action.
My understanding is that class based auto-detection is in the process of being phased out. With that in mind, it would not make much sense to add it to existing drivers. Anyone trying to add it now would have to explain why it is suddenly needed but wasn't needed before. I think that train has left the station.
On top of that, at least for adt7410/adt7420, I don't see a reliable means to auto-detect those chips. Trying to do so for a 10+ year old driver would only add (lots of) risk for little if any gain.
Those two drivers actually claim in their documentation that the address ranges would be scanned. That should be dropped as well since it does not match reality.
Thanks,
Guenter
Quoted 37 lines · Guenter Roeck
Quoted 27 lines · Heiner Kallweit
Quoted 26 lines · Guenter Roeck
Quoted 24 lines · Heiner Kallweit
Class-based I2C probing requires
detect()andaddress_listto be set in the I2C client driver, see checks ini2c_detect(). It's misleading to declareI2C_CLASS_HWMONsupport if this precondition isn't met.Signed-off-by Heiner Kallweit <[email protected]>---
drivers/hwmon/adm1177.c | 1 -
drivers/hwmon/ds1621.c | 1 -
drivers/hwmon/ds620.c | 1 -drivers/hwmon/ina209.c | 1 - drivers/hwmon/ina238.c | 1 - drivers/hwmon/max127.c | 1 - drivers/hwmon/max31760.c | 1 - drivers/hwmon/max31790.c | 1 - drivers/hwmon/max31827.c | 1 -drivers/hwmon/max6621.c | 1 -
drivers/hwmon/max6697.c | 1 -
drivers/hwmon/occ/p8_i2c.c | 1 -
drivers/hwmon/pmbus/ir36021.c| 1 -
drivers/hwmon/powr1220.c | 1 -
drivers/hwmon/sbrmi.c | 1 -
drivers/hwmon/sbtsi_temp.c | 1 -
drivers/hwmon/w83773g.c | 1 -Quoted 8 lines
Quoted 4 lines
Follow-up question: You did not drop the class from
drivers/hwmon/adt7410.canddrivers/hwmon/emc2305.c. Is that because of theaddress_listin those drivers ?Yes. If
address_listis set, this shows a certain intention to support I2C class-based probing. Then the question is whether adding the missingdetect()implementation may be the more appropriate action.
Quoted 6 lines
My understanding is that class based auto-detection is in the process of being phased out. With that in mind, it would not make much sense to add it to existing drivers. Anyone trying to add it now would have to explain why it is suddenly needed but wasn't needed before. I think that train has left the station.
Good, then I'll send a patch for these two drivers too.
Quoted 8 lines
On top of that, at least for adt7410/adt7420, I don't see a reliable means to auto-detect those chips. Trying to do so for a 10+ year old driver would only add (lots of) risk for little if any gain.
Those two drivers actually claim in their documentation that the address ranges would be scanned. That should be dropped as well since it does not match reality.
For emc2305 that's right. Documentation/hwmon/adt7410.rst however states "Addresses scanned: None", so here I wouldn't see a need for a change.
Quoted 3 lines
Thanks,
Guenter
Heiner
Guenter Roeck
maintainerQuoted 50 lines · Heiner Kallweit
Quoted 37 lines · Guenter Roeck
Quoted 27 lines · Heiner Kallweit
Quoted 26 lines · Guenter Roeck
Quoted 24 lines · Heiner Kallweit
Class-based I2C probing requires
detect()andaddress_listto be set in the I2C client driver, see checks ini2c_detect(). It's misleading to declareI2C_CLASS_HWMONsupport if this precondition isn't met.Signed-off-by Heiner Kallweit <[email protected]>--- drivers/hwmon/adm1177.c | 1 - drivers/hwmon/ds1621.c | 1 - drivers/hwmon/ds620.c | 1 - drivers/hwmon/ina209.c | 1 - drivers/hwmon/ina238.c | 1 - drivers/hwmon/max127.c | 1 - drivers/hwmon/max31760.c | 1 - drivers/hwmon/max31790.c | 1 - drivers/hwmon/max31827.c | 1 - drivers/hwmon/max6621.c | 1 - drivers/hwmon/max6697.c | 1 - drivers/hwmon/occ/p8_i2c.c | 1 - drivers/hwmon/pmbus/ir36021.c | 1 - drivers/hwmon/powr1220.c | 1 - drivers/hwmon/sbrmi.c | 1 - drivers/hwmon/sbtsi_temp.c | 1 - drivers/hwmon/w83773g.c | 1 -Quoted 8 lines
Quoted 4 lines
Follow-up question: You did not drop the class from
drivers/hwmon/adt7410.canddrivers/hwmon/emc2305.c. Is that because of theaddress_listin those drivers ?Yes. If
address_listis set, this shows a certain intention to support I2C class-based probing. Then the question is whether adding the missingdetect()implementation may be the more appropriate action.Quoted 6 lines
My understanding is that class based auto-detection is in the process of being phased out. With that in mind, it would not make much sense to add it to existing drivers. Anyone trying to add it now would have to explain why it is suddenly needed but wasn't needed before. I think that train has left the station.
Good, then I'll send a patch for these two drivers too.
Quoted 4 lines
On top of that, at least for adt7410/adt7420, I don't see a reliable means to auto-detect those chips. Trying to do so for a 10+ year old driver would only add (lots of) risk for little if any gain.
Quoted 7 lines
Quoted 4 lines
Those two drivers actually claim in their documentation that the address ranges would be scanned. That should be dropped as well since it does not match reality.
For emc2305 that's right.
Documentation/hwmon/adt7410.rsthowever states "Addresses scanned: None", so here I wouldn't see a need for a change.
Ah, yes. You are correct. I thought I saw it for both. No idea what I looked at.
Thanks,
Guenter