ARM: S3C64XX: Use fixed IRQ bases to avoid conflicts on Cragganmore
Subsystems (3)
PATCH 1/1 ARM: S3C64XX: Use fixed IRQ bases to avoid conflicts on Cragganmore
There are two PMICs on Cragganmore, currently one dynamically assign its IRQ base and the other uses a fixed base. It is possible for the statically assigned PMIC to fail if its IRQ is taken by the dynamically assigned one. Fix this by statically assigning both the IRQ bases.
--- arch/arm/mach-s3c64xx/crag6410.h | 1 + arch/arm/mach-s3c64xx/mach-crag6410.c | 1 + 2 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/mach-s3c64xx/crag6410.h +1 -0
@@ -14,6 +14,7 @@#include <mach/gpio-samsung.h> #define GLENFARCLAS_PMIC_IRQ_BASE IRQ_BOARD_START +#define BANFF_PMIC_IRQ_BASE (IRQ_BOARD_START + 64)#define PCA935X_GPIO_BASE GPIO_BOARD_START#define CODEC_GPIO_BASE (GPIO_BOARD_START + 8)
arch/arm/mach-s3c64xx/mach-crag6410.c +1 -0
@@ -554,6 +554,7 @@ static struct wm831x_touch_pdata touch_pdata = {static struct wm831x_pdata crag_pmic_pdata = { .wm831x_num =1 , + .irq_base =BANFF_PMIC_IRQ_BASE , .gpio_base =BANFF_PMIC_GPIO_BASE , .soft_shutdown = true,
Signature · 1 line
1.7.2.5
Quoted 6 lines · Charles Keepax
There are two PMICs on Cragganmore, currently one dynamically assign its IRQ base and the other uses a fixed base. It is possible for the statically assigned PMIC to fail if its IRQ is taken by the dynamically assigned one. Fix this by statically assigning both the IRQ bases.
Signed-off-by Charles Keepax <[email protected]>
This probably wants to go to stable as well.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150322/9eb8281e/attachment.sig>
Quoted 11 lines · Mark Brown
Quoted 6 lines · Charles Keepax
There are two PMICs on Cragganmore, currently one dynamically assign its IRQ base and the other uses a fixed base. It is possible for the statically assigned PMIC to fail if its IRQ is taken by the dynamically assigned one. Fix this by statically assigning both the IRQ bases.
Signed-off-by Charles Keepax <[email protected]>Reviwed-by Mark Brown <[email protected]>
Thanks for your review.
Quoted 1 line
This probably wants to go to stable as well.
OK, I'll.
Thanks,
Kukjin