arm64: dts: ti: k3-j784s4-mcu-wakeup: Configure wkup_uart0 with clock settings
Subsystems (2)
PATCH RESEND 1/1 arm64: dts: ti: k3-j784s4-mcu-wakeup: Configure wkup_uart0 with clock settings
From: Bhavya Kapoor <[email protected]>
This commit adds the assigned-clocks and assigned-clock-parents properties for wkup_uart0 in J784S4. Specifically, the assigned-clocks property is set to reference the clock identified by "wkup_usart_mcupll_bypass_out0", ensuring the UART operates with the correct clock source.
The assigned-clock-parents property specifies "wkup_usart_clksel_out0" as the parent clock. This configuration is critical for establishing the proper clocking hierarchy, enabling the UART device to function reliably across different baud rates.
---
Link to v1: https://lore.kernel.org/all/[email protected]/
arch/arm64/boot/dts/ti/k3-j784s4-j742s2-mcu-wakeup-common.dtsi | 2 ++ 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/ti/k3-j784s4-j742s2-mcu-wakeup-common.dtsi +2 -0
@@ -310,6 +310,8 @@ wkup_uart0: serial@42300000 { interrupts = <GIC_SPI 897 IRQ_TYPE_LEVEL_HIGH>; clocks = <&k3_clks 397 0>; clock-names = "fclk"; + assigned-clocks = <&k3_clks 397 0>; + assigned-clock-parents = <&k3_clks 397 1>; power-domains = <&k3_pds 397 TI_SCI_PD_EXCLUSIVE>; status = "disabled"; };
Signature · 1 line
2.34.1
Hi Udit,
Quoted 6 lines · Udit Kumar
From: Bhavya Kapoor <[email protected]>
This commit adds the assigned-clocks and assigned-clock-parents properties for
wkup_uart0in J784S4. Specifically, the assigned-clocks property is set to reference the clock identified by "wkup_usart_mcupll_bypass_out0",
Documentation says "WKUP_UART0_FCLK_CLK" for device id 397 and clock id 0...?
https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/j784s4/clocks.html
Quoted 9 lines
ensuring the UART operates with the
correct clock source.The assigned-clock-parents property specifies "
wkup_usart_clksel_out0" as the parent clock. This configuration is critical for establishing the proper clocking hierarchy, enabling the UART device to function reliably across different baud rates.Signed-off-by Bhavya Kapoor <[email protected]>
Do you need to add your Sign off?
Thanks,
Beleswar
Quoted 19 lines
---
Link to v1: https://lore.kernel.org/all/[email protected]/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-mcu-wakeup-common.dtsi | 2 ++ 1 file changed, 2 insertions(+)arch/arm64/boot/dts/ti/k3-j784s4-j742s2-mcu-wakeup-common.dtsi +2
-0@@ -310,6 +310,8 @@ wkup_uart0: serial@42300000 { interrupts = <GIC_SPI 897 IRQ_TYPE_LEVEL_HIGH>; clocks = <&k3_clks 397 0>; clock-names = "fclk"; + assigned-clocks = <&k3_clks 397 0>; + assigned-clock-parents = <&k3_clks 397 1>; power-domains = <&k3_pds 397 TI_SCI_PD_EXCLUSIVE>; status = "disabled"; };
arch/arm64/boot/dts/ti/k3-j784s4-j742s2-mcu-wakeup-common.dtsi
Quoted 21 lines · Udit Kumar
From: Bhavya Kapoor <[email protected]>
This commit adds the assigned-clocks and assigned-clock-parents properties for
wkup_uart0in J784S4. Specifically, the assigned-clocks property is set to reference the clock identified by "wkup_usart_mcupll_bypass_out0", ensuring the UART operates with the correct clock source.The assigned-clock-parents property specifies "
wkup_usart_clksel_out0" as the parent clock. This configuration is critical for establishing the proper clocking hierarchy, enabling the UART device to function reliably across different baud rates.Signed-off-by Bhavya Kapoor <[email protected]>---
Link to v1: https://lore.kernel.org/all/[email protected]/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-mcu-wakeup-common.dtsi | 2 ++ 1 file changed, 2 insertions(+)arch/arm64/boot/dts/ti/k3-j784s4-j742s2-mcu-wakeup-common.dtsi +0
-0
Also $Subject line needs to be correct for k3-j784s4-j742s2-mcu-wakeup-common.dtsi file.
Thanks,
Beleswar
Quoted 12 lines
index
52e2965a3bf5..1146bc5990ea100644arch/arm64/boot/dts/ti/k3-j784s4-j742s2-mcu-wakeup-common.dtsi +2
-0@@ -310,6 +310,8 @@ wkup_uart0: serial@42300000 { interrupts = <GIC_SPI 897 IRQ_TYPE_LEVEL_HIGH>; clocks = <&k3_clks 397 0>; clock-names = "fclk"; + assigned-clocks = <&k3_clks 397 0>; + assigned-clock-parents = <&k3_clks 397 1>; power-domains = <&k3_pds 397 TI_SCI_PD_EXCLUSIVE>; status = "disabled"; };
Nishanth Menon
maintainerQuoted 8 lines · Udit Kumar
From: Bhavya Kapoor <[email protected]>
This commit adds the assigned-clocks and assigned-clock-parents properties for
wkup_uart0in J784S4. Specifically, the assigned-clocks property is set to reference the clock identified by "wkup_usart_mcupll_bypass_out0", ensuring the UART operates with the correct clock source.
Quoted 4 lines
The assigned-clock-parents property specifies "
wkup_usart_clksel_out0" as the parent clock. This configuration is critical for establishing the proper clocking hierarchy, enabling the UART device to function reliably across different baud rates.
Please fix the commit message - not clear what specifically in the clock hierarchy does permit the multiple baud rates.
Quoted 2 lines
Signed-off-by Bhavya Kapoor <[email protected]>
You need to add your SoB.
Quoted 2 lines
---
Link to v1: https://lore.kernel.org/all/[email protected]/
Also as Baleswar stated, the $subject needs to be fixed.
Quoted 20 lines
arch/arm64/boot/dts/ti/k3-j784s4-j742s2-mcu-wakeup-common.dtsi | 2 ++ 1 file changed, 2 insertions(+)arch/arm64/boot/dts/ti/k3-j784s4-j742s2-mcu-wakeup-common.dtsi +2
-0@@ -310,6 +310,8 @@ wkup_uart0: serial@42300000 { interrupts = <GIC_SPI 897 IRQ_TYPE_LEVEL_HIGH>; clocks = <&k3_clks 397 0>; clock-names = "fclk"; + assigned-clocks = <&k3_clks 397 0>; + assigned-clock-parents = <&k3_clks 397 1>; power-domains = <&k3_pds 397 TI_SCI_PD_EXCLUSIVE>; status = "disabled"; };Signature · 1 line
2.34.1
Signature · 3 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Quoted 9 lines · Nishanth Menon
Quoted 8 lines · Udit Kumar
From: Bhavya Kapoor <[email protected]>
This commit adds the assigned-clocks and assigned-clock-parents properties for
wkup_uart0in J784S4. Specifically, the assigned-clocks property is set to reference the clock identified by "wkup_usart_mcupll_bypass_out0", ensuring the UART operates with the correct clock source.
Quoted 6 lines
Quoted 4 lines
The assigned-clock-parents property specifies "
wkup_usart_clksel_out0" as the parent clock. This configuration is critical for establishing the proper clocking hierarchy, enabling the UART device to function reliably across different baud rates.Please fix the commit message - not clear what specifically in the clock hierarchy does permit the multiple baud rates.
Thanks for review.
will address in v2, commit message and other comments as well
Quoted 25 lines
Quoted 2 lines
Signed-off-by Bhavya Kapoor <[email protected]>You need to add your SoB.
Quoted 2 lines
---
Link to v1: https://lore.kernel.org/all/[email protected]/Also as Baleswar stated, the $subject needs to be fixed.
Quoted 19 lines
arch/arm64/boot/dts/ti/k3-j784s4-j742s2-mcu-wakeup-common.dtsi | 2 ++ 1 file changed, 2 insertions(+)arch/arm64/boot/dts/ti/k3-j784s4-j742s2-mcu-wakeup-common.dtsi +2
-0@@ -310,6 +310,8 @@ wkup_uart0: serial@42300000 { interrupts = <GIC_SPI 897 IRQ_TYPE_LEVEL_HIGH>; clocks = <&k3_clks 397 0>; clock-names = "fclk"; + assigned-clocks = <&k3_clks 397 0>; + assigned-clock-parents = <&k3_clks 397 1>; power-domains = <&k3_pds 397 TI_SCI_PD_EXCLUSIVE>; status = "disabled"; };Signature · 1 line
2.34.1
Hello Nishanth
Quoted 9 lines · Nishanth Menon
Quoted 8 lines · Udit Kumar
From: Bhavya Kapoor <[email protected]>
This commit adds the assigned-clocks and assigned-clock-parents properties for
wkup_uart0in J784S4. Specifically, the assigned-clocks property is set to reference the clock identified by "wkup_usart_mcupll_bypass_out0", ensuring the UART operates with the correct clock source.
Quoted 6 lines
Quoted 4 lines
The assigned-clock-parents property specifies "
wkup_usart_clksel_out0" as the parent clock. This configuration is critical for establishing the proper clocking hierarchy, enabling the UART device to function reliably across different baud rates.Please fix the commit message - not clear what specifically in the clock hierarchy does permit the multiple baud rates.
need your advise here .
unlike other UART of main domain. wkup_uart currently has two parents clock (clock-1 is at 96Mhz and clock-0 is at 19.2 Mhz).
By default, current fw selects clock-1 as parent.
Let me know, if explicitly we need to set parent as clock-1.
If yes then i will roll out v2 with current message , if no then please drop this patch
Thanks
Udit
Quoted 6 lines
Quoted 2 lines
Signed-off-by Bhavya Kapoor <[email protected]>You need to add your SoB.
Quoted 2 lines
---
Link to v1: https://lore.kernel.org/all/[email protected]/[..]
Nishanth Menon
maintainerQuoted 24 lines · Udit
Hello Nishanth
Quoted 9 lines · Nishanth Menon
Quoted 8 lines · Udit Kumar
From: Bhavya Kapoor <[email protected]>
This commit adds the assigned-clocks and assigned-clock-parents properties for
wkup_uart0in J784S4. Specifically, the assigned-clocks property is set to reference the clock identified by "wkup_usart_mcupll_bypass_out0", ensuring the UART operates with the correct clock source.Quoted 6 lines
Quoted 4 lines
The assigned-clock-parents property specifies "
wkup_usart_clksel_out0" as the parent clock. This configuration is critical for establishing the proper clocking hierarchy, enabling the UART device to function reliably across different baud rates.Please fix the commit message - not clear what specifically in the clock hierarchy does permit the multiple baud rates.
need your advise here .
unlike other UART of main domain.
wkup_uartcurrently has two parents clock (clock-1 is at 96Mhz and clock-0 is at 19.2 Mhz).
Quoted 6 lines
By default, current fw selects clock-1 as parent.
Let me know, if explicitly we need to set parent as clock-1.
If yes then i will roll out v2 with current message , if no then please drop this patch
I personally do not see a need for the patch, then.
Quoted 11 lines
Thanks
Udit
Quoted 6 lines
Quoted 2 lines
Signed-off-by Bhavya Kapoor <[email protected]>You need to add your SoB.
Quoted 2 lines
---
Link to v1: https://lore.kernel.org/all/[email protected]/[..]
Signature · 3 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D