sigprocmask.2: s/kernel_sigset_t/sigset_t/
Hi Michael,
AFAICT, the syscalls [rt_]sigprocmask use '[old_]sigset_t' (there's the '__user' modifier too), so 'kernel_' should be removed from the types, shouldn't it?
Thanks,
Alex
[[
SYNOPSIS
#include <signal.h>
/* Prototype for the glibc wrapper function */
int sigprocmask(int how, const sigset_t *restrict set,
sigset_t *restrict oldset);
/* Prototype for the underlying system call */
int rt_sigprocmask(int how, const kernel_sigset_t *set,
kernel_sigset_t *oldset, size_t sigsetsize);
/* Prototype for the legacy system call (deprecated) */
int sigprocmask(int how, const old_kernel_sigset_t *set,
old_kernel_sigset_t *oldset); Feature Test Macro Requirements for glibc (see fea‐
ture_test_macros(7)):
sigprocmask():
_POSIX_C_SOURCE
]]
.../linux$ grep_syscall rt_sigprocmaskkernel/signal.c:3050:
SYSCALL_DEFINE4(rt_sigprocmask, int, how, sigset_t __user *, nset,
sigset_t __user *, oset, size_t, sigsetsize)kernel/signal.c:3081:
COMPAT_SYSCALL_DEFINE4(rt_sigprocmask, int, how, compat_sigset_t __user *, nset,
compat_sigset_t __user *, oset, compat_size_t, sigsetsize)include/linux/compat.h:698:
asmlinkage long compat_sys_rt_sigprocmask(int how, compat_sigset_t __user *set,
compat_sigset_t __user *oset, compat_size_t sigsetsize); include/linux/syscalls.h:696: asmlinkage long sys_rt_sigprocmask(int how, sigset_t __user *set, sigset_t __user *oset, size_t sigsetsize);
.../linux$ grep_syscall sigprocmaskkernel/compat.c:40:
COMPAT_SYSCALL_DEFINE3(sigprocmask, int, how,
compat_old_sigset_t __user *, nset, compat_old_sigset_t __user *, oset)kernel/signal.c:4236:
SYSCALL_DEFINE3(sigprocmask, int, how, old_sigset_t __user *, nset,
old_sigset_t __user *, oset)include/linux/compat.h:882:
asmlinkage long compat_sys_sigprocmask(int how, compat_old_sigset_t __user *nset,
compat_old_sigset_t __user *oset); include/linux/syscalls.h:1136: asmlinkage long sys_sigprocmask(int how, old_sigset_t __user *set, old_sigset_t __user *oset);
.../linux$
Signature · 3 lines
Alejandro Colomar Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ http://www.alejandro-colomar.es/
Hi Alex,
Quoted 5 lines · Alejandro Colomar (man-pages)
Hi Michael,
AFAICT, the syscalls [rt_]sigprocmask use '[old_]sigset_t' (there's the '
__user' modifier too), so 'kernel_' should be removed from the types, shouldn't it?
Looks like you're right. Will you send a patch?
Thanks,
Michael
Quoted 59 lines
[[
SYNOPSIS#include <signal.h> /* Prototype for the glibc wrapper function */ int sigprocmask(int how, const sigset_t *restrict set, sigset_t *restrict oldset); /* Prototype for the underlying system call */ int rt_sigprocmask(int how, const kernel_sigset_t *set, kernel_sigset_t *oldset, size_t sigsetsize); /* Prototype for the legacy system call (deprecated) */ int sigprocmask(int how, const old_kernel_sigset_t *set, old_kernel_sigset_t *oldset);Feature Test Macro Requirements for glibc (see fea‐
ture_test_macros(7)):
sigprocmask():
_POSIX_C_SOURCE]]
.../linux$
grep_syscallrt_sigprocmaskkernel/signal.c:3050:
SYSCALL_DEFINE4(rt_sigprocmask, int, how,sigset_t__user*, nset,
sigset_t__user*, oset,size_t, sigsetsize)kernel/signal.c:3081:
COMPAT_SYSCALL_DEFINE4(rt_sigprocmask, int, how,compat_sigset_t__user*, nset,
compat_sigset_t__user*, oset,compat_size_t, sigsetsize)include/linux/compat.h:698:
asmlinkage long compat_sys_rt_sigprocmask(int how,compat_sigset_t__user*set,compat_sigset_t __user *oset, compat_size_t sigsetsize); include/linux/syscalls.h:696: asmlinkage long sys_rt_sigprocmask(int how, sigset_t __user *set, sigset_t __user *oset, size_t sigsetsize);.../linux$
grep_syscallsigprocmaskkernel/compat.c:40:
COMPAT_SYSCALL_DEFINE3(sigprocmask, int, how,
compat_old_sigset_t__user*, nset,compat_old_sigset_t__user*, oset)kernel/signal.c:4236:
SYSCALL_DEFINE3(sigprocmask, int, how,old_sigset_t__user*, nset,
old_sigset_t__user*, oset)include/linux/compat.h:882:
asmlinkage long compat_sys_sigprocmask(int how,compat_old_sigset_t__user*nset,compat_old_sigset_t __user *oset); include/linux/syscalls.h:1136: asmlinkage long sys_sigprocmask(int how, old_sigset_t __user *set, old_sigset_t __user *oset);.../linux$
Signature · 3 lines
Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/
Quoted 10 lines · Michael Kerrisk (man-pages)
Hi Alex,
Quoted 5 lines · Alejandro Colomar (man-pages)
Hi Michael,
AFAICT, the syscalls [rt_]sigprocmask use '[old_]sigset_t' (there's the '
__user' modifier too), so 'kernel_' should be removed from the types, shouldn't it?Looks like you're right. Will you send a patch?
Yup!
Cheers,
Alex
Signature · 3 lines
Alejandro Colomar Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ http://www.alejandro-colomar.es/
Quoted 9 lines · Michael Kerrisk (man-pages)
Hi Alex,
Quoted 5 lines · Alejandro Colomar (man-pages)
Hi Michael,
AFAICT, the syscalls [rt_]sigprocmask use '[old_]sigset_t' (there's the '
__user' modifier too), so 'kernel_' should be removed from the types, shouldn't it?
Quoted 5 lines
Looks like you're right. Will you send a patch?
Thanks,
Michael
Hi Michael,
I was wrong!
Thanks,
Alex
[[
C library/kernel differences
The kernel's definition of sigset_t differs in size from that used by the C library. In this manual page, the for‐ mer is referred to as kernel_sigset_t (it is nevertheless named sigset_t in the kernel sources).
The glibc wrapper function for sigprocmask() silently ig‐ nores attempts to block the two real-time signals that are used internally by the NPTL threading implementation. See nptl(7) for details.
The original Linux system call was named sigprocmask(). However, with the addition of real-time signals in Linux 2.2, the fixed-size, 32-bit sigset_t (referred to as old_kernel_sigset_t in this manual page) type supported by
that system call was no longer fit for purpose. Conse‐
quently, a new system call, rt_sigprocmask(), was added to support an enlarged sigset_t type (referred to as ker‐ nel_sigset_t in this manual page). The new system call takes a fourth argument, size_t sigsetsize, which specifies the size in bytes of the signal sets in set and oldset. This argument is currently required to have a fixed archi‐ tecture specific value (equal to sizeof(kernel_sigset_t)).
The glibc sigprocmask() wrapper function hides these de‐ tails from us, transparently calling rt_sigprocmask() when the kernel provides it.
]]
Signature · 3 lines
Alejandro Colomar Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ http://www.alejandro-colomar.es/
Quoted 12 lines · Alejandro Colomar (man-pages)
Quoted 11 lines · Michael Kerrisk (man-pages)
Hi Alex,
Quoted 5 lines · Alejandro Colomar (man-pages)
Hi Michael,
AFAICT, the syscalls [rt_]sigprocmask use '[old_]sigset_t' (there's the '
__user' modifier too), so 'kernel_' should be removed from the types, shouldn't it?Looks like you're right. Will you send a patch?
Quoted 7 lines
Quoted 3 lines
Thanks,
Michael
Hi Michael,
I was wrong!
D'oh! I should read the manual page!
Cheers,
Michael
Quoted 32 lines
[[
C library/kernel differences
The kernel's definition ofsigset_tdiffers in size from that used by the C library. In this manual page, the for‐ mer is referred to askernel_sigset_t(it is nevertheless namedsigset_tin the kernel sources).The glibc wrapper function for
sigprocmask()silently ig‐ nores attempts to block the two real-time signals that are used internally by the NPTL threading implementation. See nptl(7) for details.The original Linux system call was named
sigprocmask(). However, with the addition of real-time signals in Linux 2.2, the fixed-size, 32-bitsigset_t(referred to asold_kernel_sigset_tin this manual page) type supported by
that system call was no longer fit for purpose. Conse‐
quently, a new system call,rt_sigprocmask(), was added to support an enlargedsigset_ttype (referred to as ker‐nel_sigset_tin this manual page). The new system call takes a fourth argument,size_tsigsetsize, which specifies the size in bytes of the signal sets in set and oldset. This argument is currently required to have a fixed archi‐ tecture specific value (equal tosizeof(kernel_sigset_t)).The glibc
sigprocmask()wrapper function hides these de‐ tails from us, transparently callingrt_sigprocmask()when the kernel provides it.
]]
Signature · 3 lines
Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/