Skip to contentSkip to conversation

i915/gem_(linear, tiled)_blits: Randomise buffer contents

PATCH In review Nirmoy Das 5 participants 9 messages Jan 18, 2023 – Jan 23, 2023

lore
Share & tools
lore

Nirmoy Das

author
#0 lore raw

PATCH 1/1 i915/gem_(linear, tiled)_blits: Randomise buffer contents

From: Chris Wilson <[email protected]>

Currently, we use an incrementing value for the buffer contents, starting the next buffer from the final value of the last. This means that the value of corresponding dwords between two buffers is offset by a single bit. In order to differentiate between an error in copying between two buffers from single bit memory errors, we need to randomise the offset between those two buffers.

---
 tests/i915/gem_linear_blits.c        | 7 ++-----
 tests/i915/gem_render_linear_blits.c | 8 +++++---
 tests/i915/gem_render_tiled_blits.c  | 8 +++++---
 tests/i915/gem_tiled_blits.c         | 6 ++----
 4 files changed, 14 insertions(+), 15 deletions(-)
tests/i915/gem_linear_blits.c +2 -5
index d02751be9..fac25095f 100644
@@ -184,7 +184,6 @@ static void run_test(int fd, int count, bool do_relocs)
 {
 	uint32_t *handle, *start_val;
 	uint64_t *offset, ahnd;
-	uint32_t start = 0;
 	int i;
 
 	ahnd = intel_allocator_open(fd, 0, do_relocs ?
@@ -197,13 +196,11 @@ static void run_test(int fd, int count, bool do_relocs)
 	start_val = handle + count;
 
 	for (i = 0; i < count; i++) {
-		handle[i] = create_bo(fd, start);
+		start_val[i] = rand();
+		handle[i] = create_bo(fd, start_val[i]);
 
 		offset[i] = intel_allocator_alloc(ahnd, handle[i],
 						  sizeof(linear), ALIGNMENT);
-
-		start_val[i] = start;
-		start += 1024 * 1024 / 4;
 	}
 
 	for (i = 0; i < count; i++) {
tests/i915/gem_render_linear_blits.c +5 -3
index d40593c64..c2f2c0788 100644
@@ -79,7 +79,6 @@ static void run_test (int fd, int count)
 	struct intel_bb *ibb;
 	uint32_t *start_val;
 	struct intel_buf *bufs;
-	uint32_t start = 0;
 	int i, j;
 
 	render_copy = igt_get_render_copyfunc(intel_get_drm_devid(fd));
@@ -92,11 +91,14 @@ static void run_test (int fd, int count)
 	start_val = malloc(sizeof(*start_val)*count);
 
 	for (i = 0; i < count; i++) {
+		uint32_t val;
+
 		intel_buf_init(bops, &bufs[i], WIDTH, HEIGHT, 32, 0,
 			       I915_TILING_NONE, I915_COMPRESSION_NONE);
-		start_val[i] = start;
+		val = rand();
+		start_val[i] = val;
 		for (j = 0; j < WIDTH*HEIGHT; j++)
-			linear[j] = start++;
+			linear[j] = val++;
 		gem_write(fd, bufs[i].handle, 0, linear, sizeof(linear));
 	}
 
tests/i915/gem_render_tiled_blits.c +5 -3
index 52d67b768..eae06a332 100644
@@ -97,7 +97,6 @@ static void run_test (int fd, int count)
 	struct intel_bb *ibb;
 	uint32_t *start_val;
 	struct intel_buf *bufs;
-	uint32_t start = 0;
 	int i, j;
 	uint32_t devid;
 
@@ -127,18 +126,21 @@ static void run_test (int fd, int count)
 
 	for (i = 0; i < count; i++) {
 		uint32_t tiling = I915_TILING_X + (random() & 1);
+		uint32_t val;
 		uint32_t *ptr;
 
 		intel_buf_init(bops, &bufs[i], WIDTH, HEIGHT, 32, 0,
 			       tiling, I915_COMPRESSION_NONE);
-		start_val[i] = start;
 
 		ptr = gem_mmap__gtt(fd, bufs[i].handle,
 				    bufs[i].surface[0].size, PROT_WRITE);
 		gem_set_domain(fd, bufs[i].handle,
 			       I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
+
+		val = rand();
+		start_val[i] = val;
 		for (j = 0; j < WIDTH*HEIGHT; j++)
-			ptr[j] = start++;
+			ptr[j] = val++;
 
 		munmap(ptr, bufs[i].surface[0].size);
 	}
tests/i915/gem_tiled_blits.c +2 -4
index cc44d0f10..5e7ed0c4e 100644
@@ -128,7 +128,6 @@ static void run_test(int fd, int count)
 	struct buf_ops *bops;
 	struct intel_buf **bo;
 	uint32_t *bo_start_val;
-	uint32_t start = 0;
 	int i;
 
 	bops = buf_ops_create(fd);
@@ -138,9 +137,8 @@ static void run_test(int fd, int count)
 	bo_start_val = malloc(sizeof(uint32_t)*count);
 
 	for (i = 0; i < count; i++) {
-		bo[i] = create_bo(bops, ibb, start);
-		bo_start_val[i] = start;
-		start += 1024 * 1024 / 4;
+		bo_start_val[i] = rand();
+		bo[i] = create_bo(bops, ibb, bo_start_val[i]);
 	}
 
 	for (i = 0; i < count + 1; i++) {
Signature · 1 line
2.39.0
Reviewed-by Nirmoy Das on v1 1/1
#1 lore raw
Quoted 9 lines · Nirmoy Das

From: Chris Wilson <[email protected]>

Currently, we use an incrementing value for the buffer contents, starting the next buffer from the final value of the last. This means that the value of corresponding dwords between two buffers is offset by a single bit. In order to differentiate between an error in copying between two buffers from single bit memory errors, we need to randomise the offset between those two buffers.

Quoted 3 lines
Quoted 124 lines
---
  tests/i915/gem_linear_blits.c        | 7 ++-----
  tests/i915/gem_render_linear_blits.c | 8 +++++---
  tests/i915/gem_render_tiled_blits.c  | 8 +++++---
  tests/i915/gem_tiled_blits.c         | 6 ++----
  4 files changed, 14 insertions(+), 15 deletions(-)
tests/i915/gem_linear_blits.c +2 -5
index d02751be9..fac25095f 100644
@@ -184,7 +184,6 @@ static void run_test(int fd, int count, bool do_relocs)
  {
  	uint32_t *handle, *start_val;
  	uint64_t *offset, ahnd;
-	uint32_t start = 0;
  	int i;
 
  	ahnd = intel_allocator_open(fd, 0, do_relocs ?
@@ -197,13 +196,11 @@ static void run_test(int fd, int count, bool do_relocs)
  	start_val = handle + count;
 
  	for (i = 0; i < count; i++) {
-		handle[i] = create_bo(fd, start);
+		start_val[i] = rand();
+		handle[i] = create_bo(fd, start_val[i]);
 
  		offset[i] = intel_allocator_alloc(ahnd, handle[i],
  						  sizeof(linear), ALIGNMENT);
-
-		start_val[i] = start;
-		start += 1024 * 1024 / 4;
  	}
 
  	for (i = 0; i < count; i++) {
tests/i915/gem_render_linear_blits.c +5 -3
index d40593c64..c2f2c0788 100644
@@ -79,7 +79,6 @@ static void run_test (int fd, int count)
  	struct intel_bb *ibb;
  	uint32_t *start_val;
  	struct intel_buf *bufs;
-	uint32_t start = 0;
  	int i, j;
 
  	render_copy = igt_get_render_copyfunc(intel_get_drm_devid(fd));
@@ -92,11 +91,14 @@ static void run_test (int fd, int count)
  	start_val = malloc(sizeof(*start_val)*count);
 
  	for (i = 0; i < count; i++) {
+		uint32_t val;
+
  		intel_buf_init(bops, &bufs[i], WIDTH, HEIGHT, 32, 0,
  			       I915_TILING_NONE, I915_COMPRESSION_NONE);
-		start_val[i] = start;
+		val = rand();
+		start_val[i] = val;
  		for (j = 0; j < WIDTH*HEIGHT; j++)
-			linear[j] = start++;
+			linear[j] = val++;
  		gem_write(fd, bufs[i].handle, 0, linear, sizeof(linear));
  	}
 
tests/i915/gem_render_tiled_blits.c +5 -3
index 52d67b768..eae06a332 100644
@@ -97,7 +97,6 @@ static void run_test (int fd, int count)
  	struct intel_bb *ibb;
  	uint32_t *start_val;
  	struct intel_buf *bufs;
-	uint32_t start = 0;
  	int i, j;
  	uint32_t devid;
 
@@ -127,18 +126,21 @@ static void run_test (int fd, int count)
 
  	for (i = 0; i < count; i++) {
  		uint32_t tiling = I915_TILING_X + (random() & 1);
+		uint32_t val;
  		uint32_t *ptr;
 
  		intel_buf_init(bops, &bufs[i], WIDTH, HEIGHT, 32, 0,
  			       tiling, I915_COMPRESSION_NONE);
-		start_val[i] = start;
 
  		ptr = gem_mmap__gtt(fd, bufs[i].handle,
  				    bufs[i].surface[0].size, PROT_WRITE);
  		gem_set_domain(fd, bufs[i].handle,
  			       I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
+
+		val = rand();
+		start_val[i] = val;
  		for (j = 0; j < WIDTH*HEIGHT; j++)
-			ptr[j] = start++;
+			ptr[j] = val++;
 
  		munmap(ptr, bufs[i].surface[0].size);
  	}
tests/i915/gem_tiled_blits.c +2 -4
index cc44d0f10..5e7ed0c4e 100644
@@ -128,7 +128,6 @@ static void run_test(int fd, int count)
  	struct buf_ops *bops;
  	struct intel_buf **bo;
  	uint32_t *bo_start_val;
-	uint32_t start = 0;
  	int i;
 
  	bops = buf_ops_create(fd);
@@ -138,9 +137,8 @@ static void run_test(int fd, int count)
  	bo_start_val = malloc(sizeof(uint32_t)*count);
 
  	for (i = 0; i < count; i++) {
-		bo[i] = create_bo(bops, ibb, start);
-		bo_start_val[i] = start;
-		start += 1024 * 1024 / 4;
+		bo_start_val[i] = rand();
+		bo[i] = create_bo(bops, ibb, bo_start_val[i]);
  	}
 
  	for (i = 0; i < count + 1; i++) {
#2 lore raw
Quoted 11 lines · Nirmoy
Quoted 9 lines · Nirmoy Das

From: Chris Wilson <[email protected]>

Currently, we use an incrementing value for the buffer contents, starting the next buffer from the final value of the last. This means that the value of corresponding dwords between two buffers is offset by a single bit. In order to differentiate between an error in copying between two buffers from single bit memory errors, we need to randomise the offset between those two buffers.

Quoted 4 lines
Quoted 3 lines

Is this allowed - I mean giving r-b to own s-b? I understand you're upstreaming this patch but I'm not sure is acceptable.

--
Zbigniew

Quoted 109 lines
Quoted 109 lines
---
  tests/i915/gem_linear_blits.c        | 7 ++-----
  tests/i915/gem_render_linear_blits.c | 8 +++++---
  tests/i915/gem_render_tiled_blits.c  | 8 +++++---
  tests/i915/gem_tiled_blits.c         | 6 ++----
  4 files changed, 14 insertions(+), 15 deletions(-)
tests/i915/gem_linear_blits.c +2 -5
index d02751be9..fac25095f 100644
@@ -184,7 +184,6 @@ static void run_test(int fd, int count, bool do_relocs)
  {
  	uint32_t *handle, *start_val;
  	uint64_t *offset, ahnd;
-	uint32_t start = 0;
  	int i;
  	ahnd = intel_allocator_open(fd, 0, do_relocs ?
@@ -197,13 +196,11 @@ static void run_test(int fd, int count, bool do_relocs)
  	start_val = handle + count;
  	for (i = 0; i < count; i++) {
-		handle[i] = create_bo(fd, start);
+		start_val[i] = rand();
+		handle[i] = create_bo(fd, start_val[i]);
  		offset[i] = intel_allocator_alloc(ahnd, handle[i],
  						  sizeof(linear), ALIGNMENT);
-
-		start_val[i] = start;
-		start += 1024 * 1024 / 4;
  	}
  	for (i = 0; i < count; i++) {
tests/i915/gem_render_linear_blits.c +5 -3
index d40593c64..c2f2c0788 100644
@@ -79,7 +79,6 @@ static void run_test (int fd, int count)
  	struct intel_bb *ibb;
  	uint32_t *start_val;
  	struct intel_buf *bufs;
-	uint32_t start = 0;
  	int i, j;
  	render_copy = igt_get_render_copyfunc(intel_get_drm_devid(fd));
@@ -92,11 +91,14 @@ static void run_test (int fd, int count)
  	start_val = malloc(sizeof(*start_val)*count);
  	for (i = 0; i < count; i++) {
+		uint32_t val;
+
  		intel_buf_init(bops, &bufs[i], WIDTH, HEIGHT, 32, 0,
  			       I915_TILING_NONE, I915_COMPRESSION_NONE);
-		start_val[i] = start;
+		val = rand();
+		start_val[i] = val;
  		for (j = 0; j < WIDTH*HEIGHT; j++)
-			linear[j] = start++;
+			linear[j] = val++;
  		gem_write(fd, bufs[i].handle, 0, linear, sizeof(linear));
  	}
tests/i915/gem_render_tiled_blits.c +5 -3
index 52d67b768..eae06a332 100644
@@ -97,7 +97,6 @@ static void run_test (int fd, int count)
  	struct intel_bb *ibb;
  	uint32_t *start_val;
  	struct intel_buf *bufs;
-	uint32_t start = 0;
  	int i, j;
  	uint32_t devid;
@@ -127,18 +126,21 @@ static void run_test (int fd, int count)
  	for (i = 0; i < count; i++) {
  		uint32_t tiling = I915_TILING_X + (random() & 1);
+		uint32_t val;
  		uint32_t *ptr;
  		intel_buf_init(bops, &bufs[i], WIDTH, HEIGHT, 32, 0,
  			       tiling, I915_COMPRESSION_NONE);
-		start_val[i] = start;
  		ptr = gem_mmap__gtt(fd, bufs[i].handle,
  				    bufs[i].surface[0].size, PROT_WRITE);
  		gem_set_domain(fd, bufs[i].handle,
  			       I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
+
+		val = rand();
+		start_val[i] = val;
  		for (j = 0; j < WIDTH*HEIGHT; j++)
-			ptr[j] = start++;
+			ptr[j] = val++;
  		munmap(ptr, bufs[i].surface[0].size);
  	}
tests/i915/gem_tiled_blits.c +2 -4
index cc44d0f10..5e7ed0c4e 100644
@@ -128,7 +128,6 @@ static void run_test(int fd, int count)
  	struct buf_ops *bops;
  	struct intel_buf **bo;
  	uint32_t *bo_start_val;
-	uint32_t start = 0;
  	int i;
  	bops = buf_ops_create(fd);
@@ -138,9 +137,8 @@ static void run_test(int fd, int count)
  	bo_start_val = malloc(sizeof(uint32_t)*count);
  	for (i = 0; i < count; i++) {
-		bo[i] = create_bo(bops, ibb, start);
-		bo_start_val[i] = start;
-		start += 1024 * 1024 / 4;
+		bo_start_val[i] = rand();
+		bo[i] = create_bo(bops, ibb, bo_start_val[i]);
  	}
  	for (i = 0; i < count + 1; i++) {
#3 lore raw
Quoted 12 lines · Zbigniew Kempczyński
Quoted 11 lines · Nirmoy
Quoted 9 lines · Nirmoy Das

From: Chris Wilson <[email protected]>

Currently, we use an incrementing value for the buffer contents, starting the next buffer from the final value of the last. This means that the value of corresponding dwords between two buffers is offset by a single bit. In order to differentiate between an error in copying between two buffers from single bit memory errors, we need to randomise the offset between those two buffers.

Quoted 7 lines
Quoted 4 lines
Quoted 3 lines

Is this allowed - I mean giving r-b to own s-b? I understand you're upstreaming this patch but I'm not sure is acceptable.

It's fine. S-o-b just means you have the right to submit it for contribution.

Signature · 1 line
Petri Latvala
Quoted 113 lines

--
Zbigniew

Quoted 109 lines
Quoted 109 lines
---
  tests/i915/gem_linear_blits.c        | 7 ++-----
  tests/i915/gem_render_linear_blits.c | 8 +++++---
  tests/i915/gem_render_tiled_blits.c  | 8 +++++---
  tests/i915/gem_tiled_blits.c         | 6 ++----
  4 files changed, 14 insertions(+), 15 deletions(-)
tests/i915/gem_linear_blits.c +2 -5
index d02751be9..fac25095f 100644
@@ -184,7 +184,6 @@ static void run_test(int fd, int count, bool do_relocs)
  {
  	uint32_t *handle, *start_val;
  	uint64_t *offset, ahnd;
-	uint32_t start = 0;
  	int i;
  	ahnd = intel_allocator_open(fd, 0, do_relocs ?
@@ -197,13 +196,11 @@ static void run_test(int fd, int count, bool do_relocs)
  	start_val = handle + count;
  	for (i = 0; i < count; i++) {
-		handle[i] = create_bo(fd, start);
+		start_val[i] = rand();
+		handle[i] = create_bo(fd, start_val[i]);
  		offset[i] = intel_allocator_alloc(ahnd, handle[i],
  						  sizeof(linear), ALIGNMENT);
-
-		start_val[i] = start;
-		start += 1024 * 1024 / 4;
  	}
  	for (i = 0; i < count; i++) {
tests/i915/gem_render_linear_blits.c +5 -3
index d40593c64..c2f2c0788 100644
@@ -79,7 +79,6 @@ static void run_test (int fd, int count)
  	struct intel_bb *ibb;
  	uint32_t *start_val;
  	struct intel_buf *bufs;
-	uint32_t start = 0;
  	int i, j;
  	render_copy = igt_get_render_copyfunc(intel_get_drm_devid(fd));
@@ -92,11 +91,14 @@ static void run_test (int fd, int count)
  	start_val = malloc(sizeof(*start_val)*count);
  	for (i = 0; i < count; i++) {
+		uint32_t val;
+
  		intel_buf_init(bops, &bufs[i], WIDTH, HEIGHT, 32, 0,
  			       I915_TILING_NONE, I915_COMPRESSION_NONE);
-		start_val[i] = start;
+		val = rand();
+		start_val[i] = val;
  		for (j = 0; j < WIDTH*HEIGHT; j++)
-			linear[j] = start++;
+			linear[j] = val++;
  		gem_write(fd, bufs[i].handle, 0, linear, sizeof(linear));
  	}
tests/i915/gem_render_tiled_blits.c +5 -3
index 52d67b768..eae06a332 100644
@@ -97,7 +97,6 @@ static void run_test (int fd, int count)
  	struct intel_bb *ibb;
  	uint32_t *start_val;
  	struct intel_buf *bufs;
-	uint32_t start = 0;
  	int i, j;
  	uint32_t devid;
@@ -127,18 +126,21 @@ static void run_test (int fd, int count)
  	for (i = 0; i < count; i++) {
  		uint32_t tiling = I915_TILING_X + (random() & 1);
+		uint32_t val;
  		uint32_t *ptr;
  		intel_buf_init(bops, &bufs[i], WIDTH, HEIGHT, 32, 0,
  			       tiling, I915_COMPRESSION_NONE);
-		start_val[i] = start;
  		ptr = gem_mmap__gtt(fd, bufs[i].handle,
  				    bufs[i].surface[0].size, PROT_WRITE);
  		gem_set_domain(fd, bufs[i].handle,
  			       I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
+
+		val = rand();
+		start_val[i] = val;
  		for (j = 0; j < WIDTH*HEIGHT; j++)
-			ptr[j] = start++;
+			ptr[j] = val++;
  		munmap(ptr, bufs[i].surface[0].size);
  	}
tests/i915/gem_tiled_blits.c +2 -4
index cc44d0f10..5e7ed0c4e 100644
@@ -128,7 +128,6 @@ static void run_test(int fd, int count)
  	struct buf_ops *bops;
  	struct intel_buf **bo;
  	uint32_t *bo_start_val;
-	uint32_t start = 0;
  	int i;
  	bops = buf_ops_create(fd);
@@ -138,9 +137,8 @@ static void run_test(int fd, int count)
  	bo_start_val = malloc(sizeof(uint32_t)*count);
  	for (i = 0; i < count; i++) {
-		bo[i] = create_bo(bops, ibb, start);
-		bo_start_val[i] = start;
-		start += 1024 * 1024 / 4;
+		bo_start_val[i] = rand();
+		bo[i] = create_bo(bops, ibb, bo_start_val[i]);
  	}
  	for (i = 0; i < count + 1; i++) {
#4 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for i915/gem_(linear, tiled)_blits: Randomise buffer contents

In reply to Nirmoy Das
== Series Details ==

== Series Details ==

Series: i915/gem_(linear, tiled)_blits: Randomise buffer contents
URL : https://patchwork.freedesktop.org/series/113024/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12599 -> IGTPW_8362
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/index.html

Participating hosts (44 -> 43)
------------------------------

Missing (1): fi-snb-2520m

Known issues
------------

Here are the changes found in IGTPW_8362 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-n3050: [PASS][1] -> [FAIL][2] ([i915#6298])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/fi-bsw-n3050/igt@kms_cursor_legacy@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/fi-bsw-n3050/igt@kms_cursor_legacy@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@requests:
- {bat-rpls-2}: [INCOMPLETE][3] ([i915#4983] / [i915#6257]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/bat-rpls-2/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/bat-rpls-2/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@slpc:
- {bat-rpls-1}: [DMESG-FAIL][5] ([i915#6367]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/bat-rpls-1/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/bat-rpls-1/igt@i915_selftest@[email protected]
- {bat-rplp-1}: [DMESG-FAIL][7] ([i915#6367]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/bat-rplp-1/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/bat-rplp-1/igt@i915_selftest@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7121 -> IGTPW_8362

CI-20190529: 20190529
CI_DRM_12599: 52aad5ad870672dc91502248cb7c76202d02dafc @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8362: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/index.html
IGT_7121: aa16e81259f59734230d441905b9d0f605e4a4b5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/index.html

#5 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for i915/gem_(linear, tiled)_blits: Randomise buffer contents

In reply to Nirmoy Das
== Series Details ==

== Series Details ==

Series: i915/gem_(linear, tiled)_blits: Randomise buffer contents
URL : https://patchwork.freedesktop.org/series/113024/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12599_full -> IGTPW_8362_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/index.html

Participating hosts (13 -> 10)
------------------------------

Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_8362_full:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@kms_cursor_crc@cursor-onscreen-256x85@pipe-a-hdmi-a-1:
- {shard-dg1}: NOTRUN -> [FAIL][1] +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-dg1-14/igt@kms_cursor_crc@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
- {shard-dg1}: [PASS][2] -> [FAIL][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-dg1-16/igt@kms_plane@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-dg1-14/igt@kms_plane@[email protected]

Known issues
------------

Here are the changes found in IGTPW_8362_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][4] -> [FAIL][5] ([i915#2846])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-glk9/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-glk8/igt@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][6] -> [FAIL][7] ([i915#2842])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-apl3/igt@gem_exec_fair@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-apl7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][8] -> [FAIL][9] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-glk2/igt@gem_exec_fair@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-glk6/igt@gem_exec_fair@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- shard-glk: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4613])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-glk9/igt@[email protected]

* igt@gem_lmem_swapping@verify-ccs:
- shard-apl: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4613])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-apl7/igt@[email protected]

* igt@gem_userptr_blits@access-control:
- shard-glk: NOTRUN -> [SKIP][12] ([fdo#109271]) +28 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-glk7/igt@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-apl: [PASS][13] -> [DMESG-WARN][14] ([i915#5566] / [i915#716])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-apl7/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-apl1/igt@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- shard-apl: [PASS][15] -> [DMESG-FAIL][16] ([i915#5334])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-apl2/igt@i915_selftest@live@gt_heartbeat.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-apl7/igt@i915_selftest@live@gt_heartbeat.html

* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#3886]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-glk6/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-apl: [PASS][18] -> [FAIL][19] ([i915#2346])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-apl1/igt@kms_cursor_legacy@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-apl7/igt@kms_cursor_legacy@[email protected]
- shard-glk: [PASS][20] -> [FAIL][21] ([i915#2346])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-glk1/igt@kms_cursor_legacy@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-glk4/igt@kms_cursor_legacy@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][22] -> [FAIL][23] ([i915#79])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-glk5/igt@kms_flip@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-glk1/igt@kms_flip@[email protected]

* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-dp-1:
- shard-apl: NOTRUN -> [SKIP][24] ([fdo#109271]) +42 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-apl7/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-dp-1.html

* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf:
- shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#658])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-apl1/igt@[email protected]

* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-glk: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#658]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-glk4/igt@[email protected]

* igt@runner@aborted:
- shard-apl: NOTRUN -> [FAIL][27] ([fdo#109271] / [i915#4312])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-apl1/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}: [FAIL][28] ([i915#6268]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-rkl-2/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-rkl-2/igt@[email protected]

* igt@gem_eio@in-flight-suspend:
- {shard-rkl}: [FAIL][30] ([fdo#103375]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-rkl-3/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-rkl-1/igt@[email protected]

* igt@gem_eio@kms:
- {shard-dg1}: [FAIL][32] ([i915#5784]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-dg1-16/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-dg1-15/igt@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [FAIL][34] ([i915#2842]) -> [PASS][35] +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-glk2/igt@gem_exec_fair@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-glk5/igt@gem_exec_fair@[email protected]
- {shard-rkl}: [FAIL][36] ([i915#2842]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-rkl-2/igt@gem_exec_fair@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-rkl-5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][38] ([i915#2842]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-apl2/igt@gem_exec_fair@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-apl3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_reloc@basic-wc-read-noreloc:
- {shard-rkl}: [SKIP][40] ([i915#3281]) -> [PASS][41] +12 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-rkl-2/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-rkl-5/igt@[email protected]

* igt@gem_pread@bench:
- {shard-rkl}: [SKIP][42] ([i915#3282]) -> [PASS][43] +8 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-rkl-4/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-rkl-5/igt@[email protected]

* igt@gen9_exec_parse@shadow-peek:
- {shard-rkl}: [SKIP][44] ([i915#2527]) -> [PASS][45] +2 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-rkl-4/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-rkl-5/igt@[email protected]

* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [SKIP][46] ([fdo#109271]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-apl2/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-apl6/igt@[email protected]

* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-dg1}: [SKIP][48] ([i915#1397]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-dg1-18/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-dg1-14/igt@[email protected]

* igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- {shard-tglu}: [SKIP][50] ([i915#7651]) -> [PASS][51] +4 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-tglu-6/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-tglu-8/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
- {shard-rkl}: [SKIP][52] ([i915#1849] / [i915#4098]) -> [PASS][53] +10 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-rkl-5/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-rkl-6/igt@[email protected]

* igt@kms_properties@plane-properties-atomic:
- {shard-tglu}: [SKIP][54] ([i915#1849]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-tglu-6/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-tglu-3/igt@[email protected]

* igt@kms_psr@primary_blt:
- {shard-rkl}: [SKIP][56] ([i915#1072]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-rkl-2/igt@kms_psr@primary_blt.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-rkl-6/igt@kms_psr@primary_blt.html

* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- {shard-rkl}: [SKIP][58] ([i915#5461]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-rkl-4/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-rkl-6/igt@[email protected]

* igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-a:
- {shard-rkl}: [SKIP][60] ([i915#4098]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-rkl-3/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-a.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-rkl-6/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-a.html

* igt@kms_universal_plane@universal-plane-pipe-d-sanity:
- {shard-tglu}: [SKIP][62] ([fdo#109274]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-tglu-6/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-tglu-8/igt@[email protected]

* igt@kms_vblank@pipe-a-ts-continuation-modeset:
- shard-snb: [SKIP][64] ([fdo#109271]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-snb4/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-snb4/igt@[email protected]
- {shard-tglu}: [SKIP][66] ([i915#1845] / [i915#7651]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-tglu-6/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-tglu-3/igt@[email protected]

* igt@kms_vblank@pipe-b-query-idle:
- {shard-rkl}: [SKIP][68] ([i915#1845] / [i915#4098]) -> [PASS][69] +22 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-rkl-4/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-rkl-6/igt@[email protected]

* igt@perf@gen12-unprivileged-single-ctx-counters:
- {shard-rkl}: [SKIP][70] ([fdo#109289]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-rkl-5/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-rkl-3/igt@[email protected]

* igt@perf@non-zero-reason:
- shard-glk: [FAIL][72] -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-glk1/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-glk4/igt@[email protected]

* igt@perf@stress-open-close:
- shard-glk: [INCOMPLETE][74] ([i915#5213]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12599/shard-glk7/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/shard-glk9/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7678]: https://gitlab.freedesktop.org/drm/intel/issues/7678
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7121 -> IGTPW_8362
* Piglit: piglit_4509 -> None

CI-20190529: 20190529
CI_DRM_12599: 52aad5ad870672dc91502248cb7c76202d02dafc @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8362: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/index.html
IGT_7121: aa16e81259f59734230d441905b9d0f605e4a4b5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8362/index.html

#6 lore raw
In reply to Nirmoy Das

ping

Quoted 136 lines · Nirmoy Das

From: Chris Wilson <[email protected]>

Currently, we use an incrementing value for the buffer contents, starting the next buffer from the final value of the last. This means that the value of corresponding dwords between two buffers is offset by a single bit. In order to differentiate between an error in copying between two buffers from single bit memory errors, we need to randomise the offset between those two buffers.

---
  tests/i915/gem_linear_blits.c        | 7 ++-----
  tests/i915/gem_render_linear_blits.c | 8 +++++---
  tests/i915/gem_render_tiled_blits.c  | 8 +++++---
  tests/i915/gem_tiled_blits.c         | 6 ++----
  4 files changed, 14 insertions(+), 15 deletions(-)
tests/i915/gem_linear_blits.c +2 -5
index d02751be9..fac25095f 100644
@@ -184,7 +184,6 @@ static void run_test(int fd, int count, bool do_relocs)
  {
  	uint32_t *handle, *start_val;
  	uint64_t *offset, ahnd;
-	uint32_t start = 0;
  	int i;
 
  	ahnd = intel_allocator_open(fd, 0, do_relocs ?
@@ -197,13 +196,11 @@ static void run_test(int fd, int count, bool do_relocs)
  	start_val = handle + count;
 
  	for (i = 0; i < count; i++) {
-		handle[i] = create_bo(fd, start);
+		start_val[i] = rand();
+		handle[i] = create_bo(fd, start_val[i]);
 
  		offset[i] = intel_allocator_alloc(ahnd, handle[i],
  						  sizeof(linear), ALIGNMENT);
-
-		start_val[i] = start;
-		start += 1024 * 1024 / 4;
  	}
 
  	for (i = 0; i < count; i++) {
tests/i915/gem_render_linear_blits.c +5 -3
index d40593c64..c2f2c0788 100644
@@ -79,7 +79,6 @@ static void run_test (int fd, int count)
  	struct intel_bb *ibb;
  	uint32_t *start_val;
  	struct intel_buf *bufs;
-	uint32_t start = 0;
  	int i, j;
 
  	render_copy = igt_get_render_copyfunc(intel_get_drm_devid(fd));
@@ -92,11 +91,14 @@ static void run_test (int fd, int count)
  	start_val = malloc(sizeof(*start_val)*count);
 
  	for (i = 0; i < count; i++) {
+		uint32_t val;
+
  		intel_buf_init(bops, &bufs[i], WIDTH, HEIGHT, 32, 0,
  			       I915_TILING_NONE, I915_COMPRESSION_NONE);
-		start_val[i] = start;
+		val = rand();
+		start_val[i] = val;
  		for (j = 0; j < WIDTH*HEIGHT; j++)
-			linear[j] = start++;
+			linear[j] = val++;
  		gem_write(fd, bufs[i].handle, 0, linear, sizeof(linear));
  	}
 
tests/i915/gem_render_tiled_blits.c +5 -3
index 52d67b768..eae06a332 100644
@@ -97,7 +97,6 @@ static void run_test (int fd, int count)
  	struct intel_bb *ibb;
  	uint32_t *start_val;
  	struct intel_buf *bufs;
-	uint32_t start = 0;
  	int i, j;
  	uint32_t devid;
 
@@ -127,18 +126,21 @@ static void run_test (int fd, int count)
 
  	for (i = 0; i < count; i++) {
  		uint32_t tiling = I915_TILING_X + (random() & 1);
+		uint32_t val;
  		uint32_t *ptr;
 
  		intel_buf_init(bops, &bufs[i], WIDTH, HEIGHT, 32, 0,
  			       tiling, I915_COMPRESSION_NONE);
-		start_val[i] = start;
 
  		ptr = gem_mmap__gtt(fd, bufs[i].handle,
  				    bufs[i].surface[0].size, PROT_WRITE);
  		gem_set_domain(fd, bufs[i].handle,
  			       I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
+
+		val = rand();
+		start_val[i] = val;
  		for (j = 0; j < WIDTH*HEIGHT; j++)
-			ptr[j] = start++;
+			ptr[j] = val++;
 
  		munmap(ptr, bufs[i].surface[0].size);
  	}
tests/i915/gem_tiled_blits.c +2 -4
index cc44d0f10..5e7ed0c4e 100644
@@ -128,7 +128,6 @@ static void run_test(int fd, int count)
  	struct buf_ops *bops;
  	struct intel_buf **bo;
  	uint32_t *bo_start_val;
-	uint32_t start = 0;
  	int i;
 
  	bops = buf_ops_create(fd);
@@ -138,9 +137,8 @@ static void run_test(int fd, int count)
  	bo_start_val = malloc(sizeof(uint32_t)*count);
 
  	for (i = 0; i < count; i++) {
-		bo[i] = create_bo(bops, ibb, start);
-		bo_start_val[i] = start;
-		start += 1024 * 1024 / 4;
+		bo_start_val[i] = rand();
+		bo[i] = create_bo(bops, ibb, bo_start_val[i]);
  	}
 
  	for (i = 0; i < count + 1; i++) {
#7 lore raw
Quoted 1 line · Nirmoy

ping

Sorry for the delay:

--
Zbigniew

Quoted 123 lines · Nirmoy Das
Quoted 121 lines

From: Chris Wilson <[email protected]>

Currently, we use an incrementing value for the buffer contents, starting the next buffer from the final value of the last. This means that the value of corresponding dwords between two buffers is offset by a single bit. In order to differentiate between an error in copying between two buffers from single bit memory errors, we need to randomise the offset between those two buffers.

---
  tests/i915/gem_linear_blits.c        | 7 ++-----
  tests/i915/gem_render_linear_blits.c | 8 +++++---
  tests/i915/gem_render_tiled_blits.c  | 8 +++++---
  tests/i915/gem_tiled_blits.c         | 6 ++----
  4 files changed, 14 insertions(+), 15 deletions(-)
tests/i915/gem_linear_blits.c +2 -5
index d02751be9..fac25095f 100644
@@ -184,7 +184,6 @@ static void run_test(int fd, int count, bool do_relocs)
  {
  	uint32_t *handle, *start_val;
  	uint64_t *offset, ahnd;
-	uint32_t start = 0;
  	int i;
  	ahnd = intel_allocator_open(fd, 0, do_relocs ?
@@ -197,13 +196,11 @@ static void run_test(int fd, int count, bool do_relocs)
  	start_val = handle + count;
  	for (i = 0; i < count; i++) {
-		handle[i] = create_bo(fd, start);
+		start_val[i] = rand();
+		handle[i] = create_bo(fd, start_val[i]);
  		offset[i] = intel_allocator_alloc(ahnd, handle[i],
  						  sizeof(linear), ALIGNMENT);
-
-		start_val[i] = start;
-		start += 1024 * 1024 / 4;
  	}
  	for (i = 0; i < count; i++) {
tests/i915/gem_render_linear_blits.c +5 -3
index d40593c64..c2f2c0788 100644
@@ -79,7 +79,6 @@ static void run_test (int fd, int count)
  	struct intel_bb *ibb;
  	uint32_t *start_val;
  	struct intel_buf *bufs;
-	uint32_t start = 0;
  	int i, j;
  	render_copy = igt_get_render_copyfunc(intel_get_drm_devid(fd));
@@ -92,11 +91,14 @@ static void run_test (int fd, int count)
  	start_val = malloc(sizeof(*start_val)*count);
  	for (i = 0; i < count; i++) {
+		uint32_t val;
+
  		intel_buf_init(bops, &bufs[i], WIDTH, HEIGHT, 32, 0,
  			       I915_TILING_NONE, I915_COMPRESSION_NONE);
-		start_val[i] = start;
+		val = rand();
+		start_val[i] = val;
  		for (j = 0; j < WIDTH*HEIGHT; j++)
-			linear[j] = start++;
+			linear[j] = val++;
  		gem_write(fd, bufs[i].handle, 0, linear, sizeof(linear));
  	}
tests/i915/gem_render_tiled_blits.c +5 -3
index 52d67b768..eae06a332 100644
@@ -97,7 +97,6 @@ static void run_test (int fd, int count)
  	struct intel_bb *ibb;
  	uint32_t *start_val;
  	struct intel_buf *bufs;
-	uint32_t start = 0;
  	int i, j;
  	uint32_t devid;
@@ -127,18 +126,21 @@ static void run_test (int fd, int count)
  	for (i = 0; i < count; i++) {
  		uint32_t tiling = I915_TILING_X + (random() & 1);
+		uint32_t val;
  		uint32_t *ptr;
  		intel_buf_init(bops, &bufs[i], WIDTH, HEIGHT, 32, 0,
  			       tiling, I915_COMPRESSION_NONE);
-		start_val[i] = start;
  		ptr = gem_mmap__gtt(fd, bufs[i].handle,
  				    bufs[i].surface[0].size, PROT_WRITE);
  		gem_set_domain(fd, bufs[i].handle,
  			       I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
+
+		val = rand();
+		start_val[i] = val;
  		for (j = 0; j < WIDTH*HEIGHT; j++)
-			ptr[j] = start++;
+			ptr[j] = val++;
  		munmap(ptr, bufs[i].surface[0].size);
  	}
tests/i915/gem_tiled_blits.c +2 -4
index cc44d0f10..5e7ed0c4e 100644
@@ -128,7 +128,6 @@ static void run_test(int fd, int count)
  	struct buf_ops *bops;
  	struct intel_buf **bo;
  	uint32_t *bo_start_val;
-	uint32_t start = 0;
  	int i;
  	bops = buf_ops_create(fd);
@@ -138,9 +137,8 @@ static void run_test(int fd, int count)
  	bo_start_val = malloc(sizeof(uint32_t)*count);
  	for (i = 0; i < count; i++) {
-		bo[i] = create_bo(bops, ibb, start);
-		bo_start_val[i] = start;
-		start += 1024 * 1024 / 4;
+		bo_start_val[i] = rand();
+		bo[i] = create_bo(bops, ibb, bo_start_val[i]);
  	}
  	for (i = 0; i < count + 1; i++) {
#8 lore raw
Quoted 3 lines · Zbigniew Kempczyński
Quoted 1 line · Nirmoy

ping

Sorry for the delay:

No problem.

Quoted 2 lines

Thanks,

Nirmoy

Quoted 126 lines

--
Zbigniew

Quoted 122 lines · Nirmoy Das
Quoted 121 lines

From: Chris Wilson <[email protected]>

Currently, we use an incrementing value for the buffer contents, starting the next buffer from the final value of the last. This means that the value of corresponding dwords between two buffers is offset by a single bit. In order to differentiate between an error in copying between two buffers from single bit memory errors, we need to randomise the offset between those two buffers.

---
   tests/i915/gem_linear_blits.c        | 7 ++-----
   tests/i915/gem_render_linear_blits.c | 8 +++++---
   tests/i915/gem_render_tiled_blits.c  | 8 +++++---
   tests/i915/gem_tiled_blits.c         | 6 ++----
   4 files changed, 14 insertions(+), 15 deletions(-)
tests/i915/gem_linear_blits.c +2 -5
index d02751be9..fac25095f 100644
@@ -184,7 +184,6 @@ static void run_test(int fd, int count, bool do_relocs)
   {
   	uint32_t *handle, *start_val;
   	uint64_t *offset, ahnd;
-	uint32_t start = 0;
   	int i;
   	ahnd = intel_allocator_open(fd, 0, do_relocs ?
@@ -197,13 +196,11 @@ static void run_test(int fd, int count, bool do_relocs)
   	start_val = handle + count;
   	for (i = 0; i < count; i++) {
-		handle[i] = create_bo(fd, start);
+		start_val[i] = rand();
+		handle[i] = create_bo(fd, start_val[i]);
   		offset[i] = intel_allocator_alloc(ahnd, handle[i],
   						  sizeof(linear), ALIGNMENT);
-
-		start_val[i] = start;
-		start += 1024 * 1024 / 4;
   	}
   	for (i = 0; i < count; i++) {
tests/i915/gem_render_linear_blits.c +5 -3
index d40593c64..c2f2c0788 100644
@@ -79,7 +79,6 @@ static void run_test (int fd, int count)
   	struct intel_bb *ibb;
   	uint32_t *start_val;
   	struct intel_buf *bufs;
-	uint32_t start = 0;
   	int i, j;
   	render_copy = igt_get_render_copyfunc(intel_get_drm_devid(fd));
@@ -92,11 +91,14 @@ static void run_test (int fd, int count)
   	start_val = malloc(sizeof(*start_val)*count);
   	for (i = 0; i < count; i++) {
+		uint32_t val;
+
   		intel_buf_init(bops, &bufs[i], WIDTH, HEIGHT, 32, 0,
   			       I915_TILING_NONE, I915_COMPRESSION_NONE);
-		start_val[i] = start;
+		val = rand();
+		start_val[i] = val;
   		for (j = 0; j < WIDTH*HEIGHT; j++)
-			linear[j] = start++;
+			linear[j] = val++;
   		gem_write(fd, bufs[i].handle, 0, linear, sizeof(linear));
   	}
tests/i915/gem_render_tiled_blits.c +5 -3
index 52d67b768..eae06a332 100644
@@ -97,7 +97,6 @@ static void run_test (int fd, int count)
   	struct intel_bb *ibb;
   	uint32_t *start_val;
   	struct intel_buf *bufs;
-	uint32_t start = 0;
   	int i, j;
   	uint32_t devid;
@@ -127,18 +126,21 @@ static void run_test (int fd, int count)
   	for (i = 0; i < count; i++) {
   		uint32_t tiling = I915_TILING_X + (random() & 1);
+		uint32_t val;
   		uint32_t *ptr;
   		intel_buf_init(bops, &bufs[i], WIDTH, HEIGHT, 32, 0,
   			       tiling, I915_COMPRESSION_NONE);
-		start_val[i] = start;
   		ptr = gem_mmap__gtt(fd, bufs[i].handle,
   				    bufs[i].surface[0].size, PROT_WRITE);
   		gem_set_domain(fd, bufs[i].handle,
   			       I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
+
+		val = rand();
+		start_val[i] = val;
   		for (j = 0; j < WIDTH*HEIGHT; j++)
-			ptr[j] = start++;
+			ptr[j] = val++;
   		munmap(ptr, bufs[i].surface[0].size);
   	}
tests/i915/gem_tiled_blits.c +2 -4
index cc44d0f10..5e7ed0c4e 100644
@@ -128,7 +128,6 @@ static void run_test(int fd, int count)
   	struct buf_ops *bops;
   	struct intel_buf **bo;
   	uint32_t *bo_start_val;
-	uint32_t start = 0;
   	int i;
   	bops = buf_ops_create(fd);
@@ -138,9 +137,8 @@ static void run_test(int fd, int count)
   	bo_start_val = malloc(sizeof(uint32_t)*count);
   	for (i = 0; i < count; i++) {
-		bo[i] = create_bo(bops, ibb, start);
-		bo_start_val[i] = start;
-		start += 1024 * 1024 / 4;
+		bo_start_val[i] = rand();
+		bo[i] = create_bo(bops, ibb, bo_start_val[i]);
   	}
   	for (i = 0; i < count + 1; i++) {