drm/xe/hwmon: report a single fan for DG2 instead of two
Subsystems (5)
RFC PATCH 1/1 drm/xe/hwmon: report a single fan for DG2 instead of two
xe_hwmon_pcode_read_fan_control() currently hardcodes *uval = 2 when queried with FSC_READ_NUM_FANS on DG2. This causes fan2_input to be exposed via sysfs, but on the tested Arc A750 LE (DG2 G10, PCI ID 0x56a1) fan2_input reads 0 RPM permanently while fan1_input correctly reports ~800 RPM with both physical fan physically spinning.
The RPM is calculated delta-based from a tach pulse counter:
rotations = (reg_val - fi->reg_val_prev) / 2;
so a constant-zero RPM means the register at offset 0x138170 (BMG_FAN_2_SPEED) simply does not accumulate pulses on DG2 silicon. The i915 driver does not expose fan2 on DG2 at all -- it only maps PCU_PWM_FAN_SPEED (0x138140, identical to BMG_FAN_1_SPEED), consistent with the observation that only one fan tach register is wired on DG2.
Report a single fan for DG2 to keep the phantom fan2_input out of sysfs. Battlemage paths are unchanged.
Tested on Arc A750 LE (DG2 G10): with this patch applied, fan2_input no longer appears in /sys/class/hwmon/hwmonX/ and sensors xe-pci-0300 shows fan1 only.
---
Open questions for reviewers: this is verified only on DG2 G10. Owners of G11 (e.g. ASRock Challenger A750) and G12 (e.g. Sparkle Titan A750 with three physical fans) -- does fan2_input or fan3_input ever read non-zero in your setup? If so, the right fix is a per-subplatform table rather than a flat 1.
drivers/gpu/drm/xe/xe_hwmon.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/gpu/drm/xe/xe_hwmon.c +8 -2
@@ -860,9 +860,15 @@ static int xe_hwmon_pcode_read_fan_control(const struct xe_hwmon *hwmon, u32 sub {struct xe_tile *root_tile =xe_device_get_root_tile (hwmon->xe); -/* Platforms that don't return correct value */ +/* +* The PCODE FAN_SPEED_CONTROL subcommands return an error on DG2, so we +* answer the FSC_READ_NUM_FANS query here. DG2 only wires a single fan +* tachometer register (BMG_FAN_1_SPEED == 0x138140, shared with i915's +* PCU_PWM_FAN_SPEED); BMG_FAN_2/3_SPEED read 0 on DG2 silicon. Reporting +* one fan keeps a phantom fan2_input that always reads 0 out of sysfs. +*/ if (hwmon->xe->info.platform ==XE_DG2 && subcmd ==FSC_READ_NUM_FANS ) { - *uval =2 ; + *uval =1 ;return 0 ; }
Signature · 1 line
2.43.0
[email protected]
AI reviewSashiko has reviewed this patch and found no issues. It looks great!
Quoted 19 lines
xe_hwmon_pcode_read_fan_control()currently hardcodes *uval = 2 when queried withFSC_READ_NUM_FANSon DG2. This causesfan2_inputto be exposed via sysfs, but on the tested Arc A750 LE (DG2 G10, PCI ID0x56a1)fan2_inputreads 0 RPM permanently whilefan1_inputcorrectly reports ~800 RPM with both physical fan physically spinning.The RPM is calculated delta-based from a tach pulse counter:
rotations = (reg_val - fi->reg_val_prev) / 2;so a constant-zero RPM means the register at offset
0x138170(BMG_FAN_2_SPEED) simply does not accumulate pulses on DG2 silicon. The i915 driver does not expose fan2 on DG2 at all -- it only mapsPCU_PWM_FAN_SPEED(0x138140, identical toBMG_FAN_1_SPEED), consistent with the observation that only one fan tach register is wired on DG2.Report a single fan for DG2 to keep the phantom
fan2_inputout of sysfs. Battlemage paths are unchanged.
Quoted 6 lines
Tested on Arc A750 LE (DG2 G10): with this patch applied,
fan2_inputno longer appears in/sys/class/hwmon/hwmonX/andsensors xe-pci-0300shows fan1 only.Fixes 28f79ac609de ("drm/xe/hwmon: expose fan speed")Signed-off-by Zhan Wei <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Quoted 8 lines · Zhan Wei
xe_hwmon_pcode_read_fan_control()currently hardcodes *uval = 2 when queried withFSC_READ_NUM_FANSon DG2. This causesfan2_inputto be exposed via sysfs, but on the tested Arc A750 LE (DG2 G10, PCI ID0x56a1)fan2_inputreads 0 RPM permanently whilefan1_inputcorrectly reports ~800 RPM with both physical fan physically spinning.The RPM is calculated delta-based from a tach pulse counter:
Quoted 7 lines
rotations = (reg_val - fi->reg_val_prev) / 2;so a constant-zero RPM means the register at offset
0x138170(BMG_FAN_2_SPEED) simply does not accumulate pulses on DG2 silicon. The i915 driver does not expose fan2 on DG2 at all -- it only mapsPCU_PWM_FAN_SPEED(0x138140, identical toBMG_FAN_1_SPEED), consistent with the observation that only one fan tach register is wired on DG2.
i915 is for legacy cards (like DG1) which only has a single channel in hardware. I just happen to extend the support to DG2 for the folks that might be using it.
Quoted 7 lines
Report a single fan for DG2 to keep the phantom
fan2_inputout of sysfs. Battlemage paths are unchanged.Tested on Arc A750 LE (DG2 G10): with this patch applied,
fan2_inputno longer appears in/sys/class/hwmon/hwmonX/andsensors xe-pci-0300shows fan1 only.
Quoted 8 lines
Fixes 28f79ac609de ("drm/xe/hwmon: expose fan speed")Signed-off-by Zhan Wei <[email protected]>---
Open questions for reviewers: this is verified only on DG2 G10. Owners of G11 (e.g. ASRock Challenger A750) and G12 (e.g. Sparkle Titan A750 with three physical fans) -- doesfan2_inputorfan3_inputever read non-zero in your setup? If so, the right fix is a per-subplatform table rather than a flat 1.
There's no straight answer here :)
root@DUT2147DG2FRD:/home/gta# cat /sys/class/drm/card0/device/device 0x56a1
root@DUT2147DG2FRD:/home/gta# sensors xe-pci-0300 xe-pci-0300 Adapter: PCI adapter pkg: 758.00 mV fan1: 636 RPM fan2: 652 RPM pkg: +47.0°C vram: +50.0°C pkg: N/A (max = 190.00 W) pkg: 14.37 kJ
The way this works is upto the OEMs how they design their cards. Some reuse a single channel for multiple physical fans while some use 1:1 mapped multiple channels for each fan.
This is unfortunately not possible to figure out from the driver without FSC_READ_NUM_FANS command (which has been found to be not working on some cards and hence the hardcoded value).
Raag
Quoted 28 lines
drivers/gpu/drm/xe/xe_hwmon.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)drivers/gpu/drm/xe/xe_hwmon.c +8
-2@@ -860,9 +860,15 @@ static int xe_hwmon_pcode_read_fan_control(const struct xe_hwmon *hwmon, u32 sub {struct xe_tile *root_tile =xe_device_get_root_tile (hwmon->xe); -/* Platforms that don't return correct value */ +/* +* The PCODE FAN_SPEED_CONTROL subcommands return an error on DG2, so we +* answer the FSC_READ_NUM_FANS query here. DG2 only wires a single fan +* tachometer register (BMG_FAN_1_SPEED == 0x138140, shared with i915's +* PCU_PWM_FAN_SPEED); BMG_FAN_2/3_SPEED read 0 on DG2 silicon. Reporting +* one fan keeps a phantom fan2_input that always reads 0 out of sysfs. +*/ if (hwmon->xe->info.platform ==XE_DG2 && subcmd ==FSC_READ_NUM_FANS ) { - *uval =2 ; + *uval =1 ;return 0 ; }Signature · 1 line
2.43.0
Thanks for the detailed explanation -- that make sense
I can think of two paths forward:
1) Have fan_input_read() return -ENODATA if one channel has started reporting pulses but another remains silent for, say, 30 seconds. This way the phantom entry still appears in sysfs but userspace tools like sensors can handle the "no data" case gracefully instead of showing a misleading 0 RPM.
2) Drop the code change entirely and instead add a short note in Documentation/gpu/xe/xe_hwmon.rst explaining that on DG2 boards where the OEM routes multiple physical fans through a shared tach line, fan{2,3}_input may read 0, so future contributors don't end up re-attempting the same v1 patch I just sent.
What do you think?
Quoted 93 lines · Raag Jadav <[email protected]> 于2026年5月27日周三 21:53写道:
Quoted 8 lines · Zhan Wei
xe_hwmon_pcode_read_fan_control()currently hardcodes *uval = 2 when queried withFSC_READ_NUM_FANSon DG2. This causesfan2_inputto be exposed via sysfs, but on the tested Arc A750 LE (DG2 G10, PCI ID0x56a1)fan2_inputreads 0 RPM permanently whilefan1_inputcorrectly reports ~800 RPM with both physical fan physically spinning.The RPM is calculated delta-based from a tach pulse counter:
Quoted 7 lines
rotations = (reg_val - fi->reg_val_prev) / 2;so a constant-zero RPM means the register at offset
0x138170(BMG_FAN_2_SPEED) simply does not accumulate pulses on DG2 silicon. The i915 driver does not expose fan2 on DG2 at all -- it only mapsPCU_PWM_FAN_SPEED(0x138140, identical toBMG_FAN_1_SPEED), consistent with the observation that only one fan tach register is wired on DG2.i915 is for legacy cards (like DG1) which only has a single channel in hardware. I just happen to extend the support to DG2 for the folks that might be using it.
Quoted 7 lines
Report a single fan for DG2 to keep the phantom
fan2_inputout of sysfs. Battlemage paths are unchanged.Tested on Arc A750 LE (DG2 G10): with this patch applied,
fan2_inputno longer appears in/sys/class/hwmon/hwmonX/andsensors xe-pci-0300shows fan1 only.Quoted 8 lines
Fixes 28f79ac609de ("drm/xe/hwmon: expose fan speed")Signed-off-by Zhan Wei <[email protected]>---
Open questions for reviewers: this is verified only on DG2 G10. Owners of G11 (e.g. ASRock Challenger A750) and G12 (e.g. Sparkle Titan A750 with three physical fans) -- doesfan2_inputorfan3_inputever read non-zero in your setup? If so, the right fix is a per-subplatform table rather than a flat 1.There's no straight answer here :)
root@DUT2147DG2FRD:/home/gta# cat /sys/class/drm/card0/device/device 0x56a1root@DUT2147DG2FRD:/home/gta# sensors xe-pci-0300 xe-pci-0300 Adapter: PCI adapter pkg: 758.00 mV fan1: 636 RPM fan2: 652 RPM pkg: +47.0°C vram: +50.0°C pkg: N/A (max = 190.00 W) pkg: 14.37 kJThe way this works is upto the OEMs how they design their cards. Some reuse a single channel for multiple physical fans while some use 1:1 mapped multiple channels for each fan.
This is unfortunately not possible to figure out from the driver without
FSC_READ_NUM_FANScommand (which has been found to be not working on some cards and hence the hardcoded value).Raag
Quoted 28 lines
drivers/gpu/drm/xe/xe_hwmon.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)drivers/gpu/drm/xe/xe_hwmon.c +8
-3@@ -860,9 +860,15 @@ static int xe_hwmon_pcode_read_fan_control(const struct xe_hwmon *hwmon, u32 sub {struct xe_tile *root_tile =xe_device_get_root_tile (hwmon->xe); -/* Platforms that don't return correct value */ +/* +* The PCODE FAN_SPEED_CONTROL subcommands return an error on DG2, so we +* answer the FSC_READ_NUM_FANS query here. DG2 only wires a single fan +* tachometer register (BMG_FAN_1_SPEED == 0x138140, shared with i915's +* PCU_PWM_FAN_SPEED); BMG_FAN_2/3_SPEED read 0 on DG2 silicon. Reporting +* one fan keeps a phantom fan2_input that always reads 0 out of sysfs. +*/ if (hwmon->xe->info.platform ==XE_DG2 && subcmd ==FSC_READ_NUM_FANS ) { - *uval =2 ; + *uval =1 ;return 0 ; } --2.43.0
Quoted 9 lines · 占wei
Thanks for the detailed explanation -- that make sense
I can think of two paths forward:
1) Have
fan_input_read()return-ENODATAif one channel has started reporting pulses but another remains silent for, say, 30 seconds. This way the phantom entry still appears in sysfs but userspace tools likesensorscan handle the "no data" case gracefully instead of showing a misleading 0 RPM.
Sounds a bit over engineered solution with its own caveats because
a) We assume that both channels are monitored simultaneously and first channel actually reports non-zero value for 30 seconds (or whatever trivial value we device) continuously, which is not guaranteed.
b) This means the output of one channel depends on another and I'm doubtful if maintainers would be okay with such hacks.
Quoted 5 lines
2) Drop the code change entirely and instead add a short note in
Documentation/gpu/xe/xe_hwmon.rstexplaining that on DG2 boards where the OEM routes multiple physical fans through a shared tach line, fan{2,3}_input may read 0, so future contributors don't end up re-attempting the same v1 patch I just sent.
This one makes more sense to me though.
Raag
Patchwork
CI✗ LGCI.VerificationFailed: failure for drm/xe/hwmon: report a single fan for DG2 instead of two
In reply to Zhan Wei== Series Details ==
== Series Details ==
Series: drm/xe/hwmon: report a single fan for DG2 instead of two
URL : https://patchwork.freedesktop.org/series/167465/
State : failure
== Summary ==
Address '[email protected]' is not on the allowlist, which prevents CI from being triggered for this patch. If you want Intel GFX CI to accept this address, please contact the script maintainers at [email protected]. Exception occurred during validation, bailing out!
Build URL: http://intel-gfx-ci-public.igk.intel.com:8080/job/xe_pw_trigger/1172273/ (on master)
PATCH v2 1/1 drm/xe/hwmon: document DG2 fan speed reporting quirk
In reply to Zhan WeiThe number of fanN_input attributes on DG2 is hardcoded to two because FSC_READ_NUM_FANS returns an incorrect value on some boards. How the physical fans map onto the tach channels is left to the board vendor:
some OEMs route multiple physical fans through a single shared tach line, in which case the unwired channel's pulse counter never accumulates and fanN_input reads a constant 0 RPM.
This is expected behaviour for such boards rather than a driver fault, and the driver has no reliable way to distinguish a shared-tach layout from a genuinely silent fan. Document this so the flat DG2 fan count is not mistaken for a bug and "fixed" by lowering it, which would hide a working fan2 on boards that do wire two tach lines.
---
v1 -> v2: Drop the code change. As pointed out in review, the same PCI
device ID ships with both shared-tach (multiple physical fans on one channel) and 1:1 fan wiring, and FSC_READ_NUM_FANS is unreliable on some boards, so the DG2 fan count cannot be lowered without hiding a working fan2 on boards that do wire two tach lines. Document the behaviour instead of changing the reported fan count.
v1: https://lore.kernel.org/intel-xe/[email protected]/
Documentation/gpu/xe/index.rst | 1 + Documentation/gpu/xe/xe_hwmon.rst | 48 +++++++++++++++++++++++++++++++ 2 files changed, 49 insertions(+) create mode 100644 Documentation/gpu/xe/xe_hwmon.rst
Documentation/gpu/xe/index.rst +1 -0
@@ -30,3 +30,4 @@ DG2, etc is provided to prototype the driver. xe-drm-usage-stats.rst xe_configfs xe_gt_stats + xe_hwmon
Documentation/gpu/xe/xe_hwmon.rst new file +48 -0
48 lines not on this page · raw message
Signature · 1 line
2.43.0
Re: [PATCH v2] drm/xe/hwmon: document DG2 fan speed reporting quirk
+Cc Raag, who authored the fan support and reviewed v1.
Thanks for your help, this v2 drops the code change and documents the DG2 shared-tach behaviour instead, per your feedback on v1.
Quoted 96 lines · Zhan Wei <[email protected]> 于2026年5月29日周五 21:50写道:
The number of
fanN_inputattributes on DG2 is hardcoded to two becauseFSC_READ_NUM_FANSreturns an incorrect value on some boards. How the physical fans map onto the tach channels is left to the board vendor:
some OEMs route multiple physical fans through a single shared tach line, in which case the unwired channel's pulse counter never accumulates andfanN_inputreads a constant 0 RPM.This is expected behaviour for such boards rather than a driver fault, and the driver has no reliable way to distinguish a shared-tach layout from a genuinely silent fan. Document this so the flat DG2 fan count is not mistaken for a bug and "fixed" by lowering it, which would hide a working fan2 on boards that do wire two tach lines.
Signed-off-by Zhan Wei <[email protected]>---
v1 -> v2: Drop the code change. As pointed out in review, the same PCI
device ID ships with both shared-tach (multiple physical fans on one channel) and 1:1 fan wiring, andFSC_READ_NUM_FANSis unreliable on some boards, so the DG2 fan count cannot be lowered without hiding a working fan2 on boards that do wire two tach lines. Document the behaviour instead of changing the reported fan count.v1: https://lore.kernel.org/intel-xe/[email protected]/
Documentation/gpu/xe/index.rst | 1 + Documentation/gpu/xe/xe_hwmon.rst | 48 +++++++++++++++++++++++++++++++ 2 files changed, 49 insertions(+) create mode 100644 Documentation/gpu/xe/xe_hwmon.rstDocumentation/gpu/xe/index.rst +1
-0@@ -30,3 +30,4 @@ DG2, etc is provided to prototype the driver. xe-drm-usage-stats.rst xe_configfs xe_gt_stats + xe_hwmonDocumentation/gpu/xe/xe_hwmon.rst new file +48
-1@@ -0,0 +1,48 @@ +.. SPDX-License-Identifier: (GPL-2.0+ OR MIT) + +================= +Xe HWMON support +================= + +The xe driver exposes hardware monitoring sensors (power, energy, +temperature, voltage and fan speed) through the kernel hwmon subsystem, +typically consumed via ``/sys/class/hwmon/hwmonX/`` or tools such as +``sensors``. + +Fan speed reporting +=================== + +Fan speed (``fanN_input``) is reported in RPM and computed from a tach +pulse counter: the driver reads an accumulating pulse register, divides +the delta between two subsequent readings by two pulses per rotation, +and time-averages the result. + +Number of fan channels +----------------------- + +The number of ``fanN_input`` attributes exposed in sysfs is the fan +count returned by the ``FSC_READ_NUM_FANS`` pcode command. On DG2 this +command has been found to return an incorrect value on some boards, so +the driver hardcodes a fan count of two there. As a result up to +``fan1_input`` and ``fan2_input`` are always exposed on DG2 regardless +of how many tach lines are actually wired. + +Zero RPM on DG2 is not necessarily a bug +---------------------------------------- + +How physical fans map onto the tach channels is left to the board +vendor. Some OEMs route several physical fans through a single shared +tach line, while others wire each fan to its own channel 1:1. The +driver has no reliable way to tell these layouts apart, and the same PCI +device ID can ship in either configuration. + +When a channel has no tach line driving it, its pulse counter never +accumulates, so the corresponding ``fanN_input`` reads a constant 0 RPM. +On DG2 this is most often seen on ``fan2_input`` for boards that drive +both physical fans from a single tach line. This is expected behaviour +for such boards, not a driver fault, and reflects the board wiring +rather than a missing or stalled fan. + +For this reason the fan count on DG2 is intentionally left at a flat +value rather than tracked per board: there is no driver-visible signal +that distinguishes a shared-tach layout from a genuinely silent fan. --2.43.0
Re: [PATCH v2] drm/xe/hwmon: document DG2 fan speed reporting quirk
Quoted 4 lines · 占wei
+Cc Raag, who authored the fan support and reviewed v1.
Thanks for your help, this v2 drops the code change and documents the DG2 shared-tach behaviour instead, per your feedback on v1.
IMO it's a bit verbose to have a dedicated doc for this. Just add a small comment in the existing ABI doc[1] under fan channel description.
[1] Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon
Raag
Quoted 97 lines
Quoted 96 lines · Zhan Wei <[email protected]> 于2026年5月29日周五 21:50写道:
The number of
fanN_inputattributes on DG2 is hardcoded to two becauseFSC_READ_NUM_FANSreturns an incorrect value on some boards. How the physical fans map onto the tach channels is left to the board vendor:
some OEMs route multiple physical fans through a single shared tach line, in which case the unwired channel's pulse counter never accumulates andfanN_inputreads a constant 0 RPM.This is expected behaviour for such boards rather than a driver fault, and the driver has no reliable way to distinguish a shared-tach layout from a genuinely silent fan. Document this so the flat DG2 fan count is not mistaken for a bug and "fixed" by lowering it, which would hide a working fan2 on boards that do wire two tach lines.
Signed-off-by Zhan Wei <[email protected]>---
v1 -> v2: Drop the code change. As pointed out in review, the same PCI
device ID ships with both shared-tach (multiple physical fans on one channel) and 1:1 fan wiring, andFSC_READ_NUM_FANSis unreliable on some boards, so the DG2 fan count cannot be lowered without hiding a working fan2 on boards that do wire two tach lines. Document the behaviour instead of changing the reported fan count.v1: https://lore.kernel.org/intel-xe/[email protected]/
Documentation/gpu/xe/index.rst | 1 + Documentation/gpu/xe/xe_hwmon.rst | 48 +++++++++++++++++++++++++++++++ 2 files changed, 49 insertions(+) create mode 100644 Documentation/gpu/xe/xe_hwmon.rstDocumentation/gpu/xe/index.rst +1
-0@@ -30,3 +30,4 @@ DG2, etc is provided to prototype the driver. xe-drm-usage-stats.rst xe_configfs xe_gt_stats + xe_hwmonDocumentation/gpu/xe/xe_hwmon.rst new file +48
-1@@ -0,0 +1,48 @@ +.. SPDX-License-Identifier: (GPL-2.0+ OR MIT) + +================= +Xe HWMON support +================= + +The xe driver exposes hardware monitoring sensors (power, energy, +temperature, voltage and fan speed) through the kernel hwmon subsystem, +typically consumed via ``/sys/class/hwmon/hwmonX/`` or tools such as +``sensors``. + +Fan speed reporting +=================== + +Fan speed (``fanN_input``) is reported in RPM and computed from a tach +pulse counter: the driver reads an accumulating pulse register, divides +the delta between two subsequent readings by two pulses per rotation, +and time-averages the result. + +Number of fan channels +----------------------- + +The number of ``fanN_input`` attributes exposed in sysfs is the fan +count returned by the ``FSC_READ_NUM_FANS`` pcode command. On DG2 this +command has been found to return an incorrect value on some boards, so +the driver hardcodes a fan count of two there. As a result up to +``fan1_input`` and ``fan2_input`` are always exposed on DG2 regardless +of how many tach lines are actually wired. + +Zero RPM on DG2 is not necessarily a bug +---------------------------------------- + +How physical fans map onto the tach channels is left to the board +vendor. Some OEMs route several physical fans through a single shared +tach line, while others wire each fan to its own channel 1:1. The +driver has no reliable way to tell these layouts apart, and the same PCI +device ID can ship in either configuration. + +When a channel has no tach line driving it, its pulse counter never +accumulates, so the corresponding ``fanN_input`` reads a constant 0 RPM. +On DG2 this is most often seen on ``fan2_input`` for boards that drive +both physical fans from a single tach line. This is expected behaviour +for such boards, not a driver fault, and reflects the board wiring +rather than a missing or stalled fan. + +For this reason the fan count on DG2 is intentionally left at a flat +value rather than tracked per board: there is no driver-visible signal +that distinguishes a shared-tach layout from a genuinely silent fan. --2.43.0
PATCH v3 1/1 drm/xe/hwmon: document DG2 fan speed reporting quirk
On DG2 the driver always shows two fan channels, because the FSC_READ_NUM_FANS command does not work on some cards. OEMs decide how the fans map to tach channels, so two fans can share one tach line. When that happens, the second channel reads 0 RPM even though the fan is spinning.
Note this on the fan2_input ABI entry so the steady 0 RPM is not mistaken for a driver bug.
---
v3:
- Drop the dedicated Documentation/gpu/xe/xe_hwmon.rst doc and the index.rst hunk; add a short note under the fan2_input entry in the existing ABI doc instead, per Raag's feedback.
v2: https://lore.kernel.org/intel-xe/[email protected]/
- Drop the code change that reported a single fan on DG2; document the shared-tach behaviour instead, per review feedback on v1.
v1: https://lore.kernel.org/intel-xe/[email protected]/
Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon | 7 +++++++ 1 file changed, 7 insertions(+)
Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon +7 -0
@@ -251,6 +251,13 @@ Description: RO. Fan 2 speed in RPM. Only supported for particular Intel Xe graphics platforms. + On DG2 the driver always shows two fan channels, because the + FSC_READ_NUM_FANS command does not work on some cards. OEMs + decide how the fans map to tach channels, so two fans can share + one tach line. When that happens, the second channel + reads 0 RPM even though the fan is spinning. This is normal, not + a bug. + What: /sys/bus/pci/drivers/xe/.../hwmon/hwmon<i>/fan3_input Date: March 2025 KernelVersion: 6.16
Signature · 1 line
2.43.0
Re: [PATCH v3] drm/xe/hwmon: document DG2 fan speed reporting quirk
Quoted 8 lines · Zhan Wei
On DG2 the driver always shows two fan channels, because the
FSC_READ_NUM_FANScommand does not work on some cards. OEMs decide how the fans map to tach channels, so two fans can share one tach line. When that happens, the second channel reads 0 RPM even though the fan is spinning.Note this on the
fan2_inputABI entry so the steady 0 RPM is not mistaken for a driver bug.
Quoted 1 line
Signed-off-by Zhan Wei <[email protected]>
PATCH v4 1/1 drm/xe/hwmon: document DG2 fan speed reporting quirk
On DG2 the driver always shows two fan channels, because the FSC_READ_NUM_FANS command does not work on some cards. OEMs decide how the fans map to tach channels, so two fans can share one tach line. When that happens, the second channel reads 0 RPM even though the fan is spinning.
Note this on the fan2_input ABI entry so the steady 0 RPM is not mistaken for a driver bug.
---
v4:
- Add Fixes: tag and collect Reviewed-by from Raag.
v3: https://lore.kernel.org/intel-xe/[email protected]/
- Drop the dedicated Documentation/gpu/xe/xe_hwmon.rst doc and the index.rst hunk; add a short note under the fan2_input entry in the existing ABI doc instead, per Raag's feedback.
v2: https://lore.kernel.org/intel-xe/[email protected]/
- Drop the code change that reported a single fan on DG2; document the shared-tach behaviour instead, per review feedback on v1.
v1: https://lore.kernel.org/intel-xe/[email protected]/
Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon | 7 +++++++ 1 file changed, 7 insertions(+)
Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon +7 -0
@@ -251,6 +251,13 @@ Description: RO. Fan 2 speed in RPM. Only supported for particular Intel Xe graphics platforms. + On DG2 the driver always shows two fan channels, because the + FSC_READ_NUM_FANS command does not work on some cards. OEMs + decide how the fans map to tach channels, so two fans can share + one tach line. When that happens, the second channel + reads 0 RPM even though the fan is spinning. This is normal, not + a bug. + What: /sys/bus/pci/drivers/xe/.../hwmon/hwmon<i>/fan3_input Date: March 2025 KernelVersion: 6.16
Signature · 1 line
2.43.0
Re: [PATCH v4] drm/xe/hwmon: document DG2 fan speed reporting quirk
Quoted 6 lines · Zhan Wei
On DG2 the driver always shows two fan channels, because the
FSC_READ_NUM_FANScommand does not work on some cards. OEMs decide how the fans map to tach channels, so two fans can share one tach line. When that happens, the second channel reads 0 RPM even though the fan is spinning.
Quoted 6 lines
Note this on the
fan2_inputABI entry so the steady 0 RPM is not mistaken for a driver bug.Fixes 28f79ac609de ("drm/xe/hwmon: expose fan speed")Signed-off-by Zhan Wei <[email protected]>Reviewed-by Raag Jadav <[email protected]>
This one seems got lost in the noise. Any takers?
Raag
Vivi, Rodrigo
maintainerRe: [PATCH v4] drm/xe/hwmon: document DG2 fan speed reporting quirk
Quoted 9 lines · Raag Jadav
Quoted 8 lines · Zhan Wei
On DG2 the driver always shows two fan channels, because the
FSC_READ_NUM_FANScommand does not work on some cards. OEMs decide how
the fans map to tach channels, so two fans can share one tach line. When that happens, the second channel reads 0 RPM even though the fan
is spinning.
Quoted 8 lines
Quoted 6 lines
Note this on the
fan2_inputABI entry so the steady 0 RPM is not mistaken for a driver bug.Fixes 28f79ac609de ("drm/xe/hwmon: expose fan speed")Signed-off-by Zhan Wei <[email protected]>Reviewed-by Raag Jadav <[email protected]>This one seems got lost in the noise. Any takers?
pushed, thanks for patch, review, and heads up.
Quoted 2 lines
Raag
Patchwork
CI✗ LGCI.VerificationFailed: failure for drm/xe/hwmon: report a single fan for DG2 instead of two (rev3)
In reply to Zhan Wei== Series Details ==
== Series Details ==
Series: drm/xe/hwmon: report a single fan for DG2 instead of two (rev3)
URL : https://patchwork.freedesktop.org/series/167465/
State : failure
== Summary ==
Address '[email protected]' is not on the allowlist, which prevents CI from being triggered for this patch. If you want Intel GFX CI to accept this address, please contact the script maintainers at [email protected]. Exception occurred during validation, bailing out!
Build URL: http://intel-gfx-ci-public.igk.intel.com:8080/job/xe_pw_trigger/1177062/ (on master)
Patchwork
CI✗ LGCI.VerificationFailed: failure for drm/xe/hwmon: report a single fan for DG2 instead of two (rev4)
In reply to Zhan Wei== Series Details ==
== Series Details ==
Series: drm/xe/hwmon: report a single fan for DG2 instead of two (rev4)
URL : https://patchwork.freedesktop.org/series/167465/
State : failure
== Summary ==
Address '[email protected]' is not on the allowlist, which prevents CI from being triggered for this patch. If you want Intel GFX CI to accept this address, please contact the script maintainers at [email protected]. Exception occurred during validation, bailing out!
Build URL: http://intel-gfx-ci-public.igk.intel.com:8080/job/xe_pw_trigger/1178476/ (on master)