ARM: DTS: correct the capability string for mmc0

PATCH New Naveen Krishna Chatradhi 3 participants 4 messages Jun 23, 2014 – Jun 25, 2014

Subsystems (2)

Device tree bindings Arm Samsung Exynos

lore

Share & tools

lore

Naveen Krishna Chatradhi

author

2014-06-23 11:20 UTC #0 lore raw

PATCH 1/1 ARM: DTS: correct the capability string for mmc0

MMC capability for HS200 is parsed in mmc/core/host.c as dts string "mmc-hs200-1_8v".

This patch corrects the dts string for Exynos5420 based peach-pit and Exynos5800 based peach-pi boards.

Signed-off-by Naveen Krishna Chatradhi <[email protected]>

---
 arch/arm/boot/dts/exynos5420-peach-pit.dts |    2 +-
 arch/arm/boot/dts/exynos5800-peach-pi.dts  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

arch/arm/boot/dts/exynos5420-peach-pit.dts +1 -1

index 7649982..7dea480 100644
@@ -173,7 +173,7 @@
 	status = "okay";
 	num-slots = <1>;
 	broken-cd;
-	caps2-mmc-hs200-1_8v;
+	mmc-hs200-1_8v;
 	supports-highspeed;
 	non-removable;
 	card-detect-delay = <200>;

arch/arm/boot/dts/exynos5800-peach-pi.dts +1 -1

index 2c2c137..bb3ee76 100644
@@ -171,7 +171,7 @@
 	status = "okay";
 	num-slots = <1>;
 	broken-cd;
-	caps2-mmc-hs200-1_8v;
+	mmc-hs200-1_8v;
 	supports-highspeed;
 	non-removable;
 	card-detect-delay = <200>;

Signature · 1 line

1.7.9.5

Kukjin Kim

Applied

2014-06-23 11:36 UTC #1 lore raw

PATCH 1/1 ARM: DTS: correct the capability string for mmc0

Quoted 42 lines · Naveen Krishna Chatradhi

MMC capability for HS200 is parsed in mmc/core/host.c as dts string "mmc-hs200-1_8v".
This patch corrects the dts string for Exynos5420 based peach-pit and Exynos5800 based peach-pi boards.
Signed-off-by Naveen Krishna Chatradhi <[email protected]>
---
 arch/arm/boot/dts/exynos5420-peach-pit.dts |    2 +-
 arch/arm/boot/dts/exynos5800-peach-pi.dts  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/exynos5420- renamed from arch/arm/boot/dts/exynos5420-peach-pit.dts +0 -0
peach-pit.dts
index 7649982..7dea480 100644
arch/arm/boot/dts/exynos5420-peach-pit.dts +1 -1
@@ -173,7 +173,7 @@
 	status = "okay";
 	num-slots = <1>;
 	broken-cd;
-	caps2-mmc-hs200-1_8v;
+	mmc-hs200-1_8v;
 	supports-highspeed;
 	non-removable;
 	card-detect-delay = <200>;
arch/arm/boot/dts/exynos5800- renamed from arch/arm/boot/dts/exynos5800-peach-pi.dts +0 -0
peach-pi.dts
index 2c2c137..bb3ee76 100644
arch/arm/boot/dts/exynos5800-peach-pi.dts +1 -2
@@ -171,7 +171,7 @@
 	status = "okay";
 	num-slots = <1>;
 	broken-cd;
-	caps2-mmc-hs200-1_8v;
+	mmc-hs200-1_8v;
 	supports-highspeed;
 	non-removable;
 	card-detect-delay = <200>;
--

Quoted 1 line

1.7.9.5

Applied, thanks.

- Kukjin

Doug Anderson

2014-06-24 21:33 UTC #2 lore raw

PATCH 1/1 ARM: DTS: correct the capability string for mmc0

Hi,

Quoted 38 lines · Kukjin Kim

Quoted 37 lines · Naveen Krishna Chatradhi
MMC capability for HS200 is parsed in mmc/core/host.c as dts string "mmc-hs200-1_8v".
This patch corrects the dts string for Exynos5420 based peach-pit and Exynos5800 based peach-pi boards.
Signed-off-by Naveen Krishna Chatradhi <[email protected]>
---
 arch/arm/boot/dts/exynos5420-peach-pit.dts |    2 +-
 arch/arm/boot/dts/exynos5800-peach-pi.dts  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/exynos5420- renamed from arch/arm/boot/dts/exynos5420-peach-pit.dts +0 -0
peach-pit.dts
index 7649982..7dea480 100644
arch/arm/boot/dts/exynos5420-peach-pit.dts +1 -1
@@ -173,7 +173,7 @@
      status = "okay";
      num-slots = <1>;
      broken-cd;
-     caps2-mmc-hs200-1_8v;
+     mmc-hs200-1_8v;
      supports-highspeed;
      non-removable;
      card-detect-delay = <200>;
arch/arm/boot/dts/exynos5800- renamed from arch/arm/boot/dts/exynos5800-peach-pi.dts +0 -0
peach-pi.dts
index 2c2c137..bb3ee76 100644
arch/arm/boot/dts/exynos5800-peach-pi.dts +0 -1
@@ -171,7 +171,7 @@
      status = "okay";
      num-slots = <1>;
      broken-cd;
-     caps2-mmc-hs200-1_8v;

Quoted 8 lines

Quoted 6 lines
arch/arm/boot/dts/exynos5800-peach-pi.dts +1 -1
+     mmc-hs200-1_8v;
      supports-highspeed;
      non-removable;
      card-detect-delay = <200>;
--
1.7.9.5
Applied, thanks.

As an FYI: this patch (while correct) will likely cause sporadic boot failures until Sonny and my patches land:

* https://patchwork.kernel.org/patch/4323921/
mmc: dw_mmc: Make sure we don't get stuck when we get an error

* https://patchwork.kernel.org/patch/4213211/
mmc: dw_mmc: change to use recommended reset procedure

In the very least we got sporadic boot failures locally when we enabled hs200 and didn't have the "don't get stuck" patch. I will also note that it would have been nice had this patch title included the words exynos and/or pit/pi in it.

-Doug

Kukjin Kim

2014-06-25 11:19 UTC #3 lore raw

PATCH 1/1 ARM: DTS: correct the capability string for mmc0

Quoted 3 lines · Doug Anderson

Hi,

Hi,

Quoted 50 lines · Kukjin Kim

Quoted 8 lines
Quoted 7 lines · Naveen Krishna Chatradhi
MMC capability for HS200 is parsed in mmc/core/host.c as dts string "mmc-hs200-1_8v".
This patch corrects the dts string for Exynos5420 based peach-pit and Exynos5800 based peach-pi boards.
Quoted 7 lines
Review
Quoted 7 lines
Signed-off-by Naveen Krishna Chatradhi <[email protected]>
---
 arch/arm/boot/dts/exynos5420-peach-pit.dts |    2 +-
 arch/arm/boot/dts/exynos5800-peach-pi.dts  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0
b/arch/arm/boot/dts/exynos5420-
Quoted 6 lines
Quoted 6 lines
peach-pit.dts
index 7649982..7dea480 100644
arch/arm/boot/dts/exynos5420-peach-pit.dts +0 -0
@@ -173,7 +173,7 @@
      status = "okay";
Quoted 8 lines
Review
Quoted 8 lines
arch/arm/boot/dts/exynos5420-peach-pit.dts +1 -1
      num-slots = <1>;
      broken-cd;
-     caps2-mmc-hs200-1_8v;
+     mmc-hs200-1_8v;
      supports-highspeed;
      non-removable;
      card-detect-delay = <200>;
(quoted diff) +0 -0
b/arch/arm/boot/dts/exynos5800-
Quoted 9 lines
Quoted 9 lines
peach-pi.dts
index 2c2c137..bb3ee76 100644
arch/arm/boot/dts/exynos5800-peach-pi.dts +0 -1
@@ -171,7 +171,7 @@
      status = "okay";
      num-slots = <1>;
      broken-cd;
-     caps2-mmc-hs200-1_8v;
Quoted 8 lines
Quoted 6 lines
arch/arm/boot/dts/exynos5800-peach-pi.dts +1 -1
+     mmc-hs200-1_8v;
      supports-highspeed;
      non-removable;
      card-detect-delay = <200>;
--
1.7.9.5
Applied, thanks.

Quoted 3 lines

As an FYI: this patch (while correct) will likely cause sporadic boot failures until Sonny and my patches land:

Thanks for your kindly information.

As I replied on other patch, I will holding on until followings land.

Quoted 11 lines

* https://patchwork.kernel.org/patch/4323921/
mmc: dw_mmc: Make sure we don't get stuck when we get an error
* https://patchwork.kernel.org/patch/4213211/
mmc: dw_mmc: change to use recommended reset procedure
In the very least we got sporadic boot failures locally when we enabled hs200 and didn't have the "don't get stuck" patch. I will also note that it would have been nice had this patch title included the words exynos and/or pit/pi in it.

Yes, as you can see log, I always change the subject with some my rule is similar with your suggestion when I apply into samsung tree ;-)

Thanks,
Kukjin