Skip to contentSkip to conversation

Add CONFIG_GICV3 for ARCH_QEMU

PATCH In review Chan Kim 3 participants 3 messages Jun 5, 2023 – Jun 21, 2023 Arm (32-bit)

lore
Share & tools
lore

Chan Kim

author
#0 lore raw

PATCH 1/1 Add CONFIG_GICV3 for ARCH_QEMU

I'm trying sending a patch for the first time.
I found when running u-boot qemu_arm64_defconfig on qemu-6.2.0's arm64 virt machine, we need CONFIG_GICV3.
And for the GICV3 related to be compiled, we need to add GICD_BASE, GICR_BASE defined by the qemu arm64 virt machine.

arch/arm/Kconfig +1 -0
index 99264a6478..437857b188 100644
@@ -1044,6 +1044,7 @@ config ARCH_QEMU
 	select DM_SERIAL
 	select OF_CONTROL
 	select PL01X_SERIAL
+	select GICV3
 	imply CMD_DM
 	imply DM_RNG
 	imply DM_RTC
include/configs/qemu-arm.h +1 -0
index e296f39879..979ae1815d 100644
@@ -11,4 +11,6 @@
 
 /* For timer, QEMU emulates an ARMv7/ARMv8 architected timer */
 
+#define GICD_BASE		0x8000000	/* 24MHz, FPGA runs at 5MHz

*/
+#define GICR_BASE 0x80a0000 /* 24MHz, FPGA runs at 5MHz
*/
#endif /* __CONFIG_H */

Thanks!
Chan Kim

#1 lore raw

Hi Chan,

Quoted 36 lines · Chan Kim

I'm trying sending a patch for the first time.
I found when running u-boot qemu_arm64_defconfig on qemu-6.2.0's arm64 virt machine, we need CONFIG_GICV3.
And for the GICV3 related to be compiled, we need to add GICD_BASE, GICR_BASE defined by the qemu arm64 virt machine.

arch/arm/Kconfig +1 -0
index 99264a6478..437857b188 100644
@@ -1044,6 +1044,7 @@ config ARCH_QEMU
        select DM_SERIAL
        select OF_CONTROL
        select PL01X_SERIAL
+       select GICV3
        imply CMD_DM
        imply DM_RNG
        imply DM_RTC
include/configs/qemu-arm.h +2 -0
index e296f39879..979ae1815d 100644
@@ -11,4 +11,6 @@
 
 /* For timer, QEMU emulates an ARMv7/ARMv8 architected timer */
 
+#define GICD_BASE              0x8000000       /* 24MHz, FPGA runs at 5MHz
 */
+#define GICR_BASE              0x80a0000       /* 24MHz, FPGA runs at 5MHz

*/
#endif /* __CONFIG_H */

Quoted 2 lines

Thanks!
Chan Kim

Thank you for the fix!

This patch is corrupt. You could try using 'patman' to send your patches.

Also, for your commit message, say something like "Without CONFIG_xxx Linux does not boot on board xxx. Add this to resolve the problem"

You don't want things like "I'm trying to send" in the git history.

Regards,
Simon

Quoted 4 lines
#2 lore raw
In reply to Chan Kim
Quoted 7 lines · Chan Kim

I'm trying sending a patch for the first time.
I found when running u-boot qemu_arm64_defconfig on qemu-6.2.0's arm64 virt machine, we need CONFIG_GICV3.
And for the GICV3 related to be compiled, we need to add GICD_BASE, GICR_BASE defined by the qemu arm64 virt machine.

So I think some more investigation or explanation is needed here. These changes cause the way we currently run the qemu arm64 platform in CI to no longer boot. See
https://source.denx.de/u-boot/u-boot-test-hooks/-/blob/master/bin/travis-ci/conf.qemu_arm64_na
for details on how that is.

Signature · 1 line
Tom