Skip to contentSkip to conversation

i40e: Register multi-function device to provide RDMA

PATCH New Shiraz Saleem 2 participants 2 messages Oct 17, 2019 – Oct 25, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i40e: Register multi-function device to provide RDMA

From: Mustafa Ismail <[email protected]>

Register multi-function devices (MFD) for the RDMA platform function (irdma) driver to bind to. It realizes a single RDMA driver capable of working with multiple LAN drivers over multi-generation Intel HW supporting RDMA. There is also no load ordering dependencies between i40e and irdma.

Summary of changes:
* Support to add/remove MFD devices
* Add 2 new client ops.
* i40e_client_device_register() which is called during RDMA probe() per PF. Validate client drv OPs and schedule service task to call open()
* i40e_client_device_unregister() called during RDMA remove() per PF. Call client close() and release_qvlist.
* The global register/unregister calls exported for i40iw are retained until i40iw is removed from the kernel.

---
 drivers/infiniband/hw/i40iw/Makefile          |   1 -
 drivers/infiniband/hw/i40iw/i40iw.h           |   2 +-
 drivers/net/ethernet/intel/Kconfig            |   1 +
 drivers/net/ethernet/intel/i40e/i40e.h        |   3 +-
 drivers/net/ethernet/intel/i40e/i40e_client.c | 138 ++++++++++++++--
 drivers/net/ethernet/intel/i40e/i40e_client.h | 203 -----------------------
 include/linux/net/intel/i40e_client.h         | 224 ++++++++++++++++++++++++++
 7 files changed, 350 insertions(+), 222 deletions(-)
 delete mode 100644 drivers/net/ethernet/intel/i40e/i40e_client.h
 create mode 100644 include/linux/net/intel/i40e_client.h
drivers/infiniband/hw/i40iw/Makefile +0 -1
index 8942f82..34da9eb 100644
@@ -1,5 +1,4 @@
 # SPDX-License-Identifier: GPL-2.0
-ccflags-y :=  -I $(srctree)/drivers/net/ethernet/intel/i40e
 
 obj-$(CONFIG_INFINIBAND_I40IW) += i40iw.o
 
drivers/infiniband/hw/i40iw/i40iw.h +1 -1
index 8feec35..3197e35 100644
@@ -57,7 +57,7 @@
 #include "i40iw_d.h"
 #include "i40iw_hmc.h"
 
-#include <i40e_client.h>
+#include <linux/net/intel/i40e_client.h>
 #include "i40iw_type.h"
 #include "i40iw_p.h"
 #include <rdma/i40iw-abi.h>
drivers/net/ethernet/intel/Kconfig +1 -0
index 154e2e8..5d4603c 100644
@@ -241,6 +241,7 @@ config I40E
 	tristate "Intel(R) Ethernet Controller XL710 Family support"
 	imply PTP_1588_CLOCK
 	depends on PCI
+	select MFD_CORE
 	---help---
 	  This driver supports Intel(R) Ethernet Controller XL710 Family of
 	  devices.  For more information on how to identify your adapter, go
drivers/net/ethernet/intel/i40e/i40e.h +2 -1
index 2af9f63..ed7c721 100644
@@ -38,7 +38,7 @@
 #include <net/xdp_sock.h>
 #include "i40e_type.h"
 #include "i40e_prototype.h"
-#include "i40e_client.h"
+#include <linux/net/intel/i40e_client.h>
 #include <linux/avf/virtchnl.h>
 #include "i40e_virtchnl_pf.h"
 #include "i40e_txrx.h"
@@ -655,6 +655,7 @@ struct i40e_pf {
 	u16 last_sw_conf_valid_flags;
 	/* List to keep previous DDP profiles to be rolled back in the future */
 	struct list_head ddp_old_prof;
+	int peer_idx;
 };
 
 /**
drivers/net/ethernet/intel/i40e/i40e_client.c +122 -16

207 lines not on this page · raw message

drivers/net/ethernet/intel/i40e/i40e_client.h deleted +0 -203

203 lines not on this page · raw message

include/linux/net/intel/i40e_client.h new file +224 -0

224 lines not on this page · raw message

Signature · 1 line
1.8.3.1
#1 lore raw

PATCH 1/1 i40e: Register multi-function device to provide RDMA

Quoted 30 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Shiraz Saleem
Sent: Thursday, October 17, 2019 9:40 AM
To: intel-wired-lan at lists.osuosl.org
Cc: Ismail, Mustafa <[email protected]>; Saleem, Shiraz <[email protected]>
Subject: [Intel-wired-lan] [PATCH] i40e: Register multi-function device to provide RDMA

From: Mustafa Ismail <[email protected]>

Register multi-function devices (MFD) for the RDMA platform function (irdma) driver to bind to. It realizes a single RDMA driver capable of working with multiple LAN drivers over multi-generation Intel HW supporting RDMA. There is also no load ordering dependencies between i40e and irdma.

Summary of changes:
* Support to add/remove MFD devices
* Add 2 new client ops.
* i40e_client_device_register() which is called during RDMA probe() per PF. Validate client drv OPs and schedule service task to call open()
* i40e_client_device_unregister() called during RDMA remove() per PF. Call client close() and release_qvlist.
* The global register/unregister calls exported for i40iw are retained until i40iw is removed from the kernel.

Quoted 12 lines
---
 drivers/infiniband/hw/i40iw/Makefile          |   1 -
 drivers/infiniband/hw/i40iw/i40iw.h           |   2 +-
 drivers/net/ethernet/intel/Kconfig            |   1 +
 drivers/net/ethernet/intel/i40e/i40e.h        |   3 +-
 drivers/net/ethernet/intel/i40e/i40e_client.c | 138 ++++++++++++++--
drivers/net/ethernet/intel/i40e/i40e_client.h | 203 -----------------------
 include/linux/net/intel/i40e_client.h         | 224
++++++++++++++++++++++++++
 7 files changed, 350 insertions(+), 222 deletions(-)  delete mode 100644
drivers/net/ethernet/intel/i40e/i40e_client.h
 create mode 100644 include/linux/net/intel/i40e_client.h