Acceptance Tests: clean up of temporary dirs and MAINTAINERS entry
cover Acceptance Tests: clean up of temporary dirs and MAINTAINERS entry
This is a reply to an issue[1] reported by Peter, and while at it, an update of the MAINTAINERS entry so other people now the status and where to go for help with regards to the acceptance tests' infrastructure.
[1] https://lists.gnu.org/archive/html/qemu-devel/2021-08/msg00349.html
Cleber Rosa (2):
Acceptance Tests: add standard clean up at test tearDown() Acceptance Tests: updates to the MAINTAINERS file
MAINTAINERS | 6 +++--- tests/acceptance/avocado_qemu/__init__.py | 1 + 2 files changed, 4 insertions(+), 3 deletions(-)
Signature · 1 line
2.31.1
PATCH 1/2 Acceptance Tests: add standard clean up at test tearDown()
The avocado.Test class, used as the basis of the avocado_qemu.Test class, performs a clean of temporary directories up as part of its own tearDown() implementation.
But the avocado_qemu.Test class is currently missing the same clean up, as it implemented its own tearDown() method without resorting to the upper class behavior.
This brings avocado_qemu.Test behavior in sync with the standard avocado.Test behavior and prevents temporary directories from cluttering the test results directory (unless instructed to do so with Avocado's "--keep-tmp" option).
--- tests/acceptance/avocado_qemu/__init__.py | 1 + 1 file changed, 1 insertion(+)
tests/acceptance/avocado_qemu/__init__.py +1 -0
@@ -276,6 +276,7 @@ def tearDown(self): for vm in self._vms.values(): vm.shutdown() self._sd = None + super(Test, self).tearDown() def fetch_asset(self, name, asset_hash=None, algorithm=None,
Signature · 1 line
2.31.1
Re: [PATCH 1/2] Acceptance Tests: add standard clean up at test tearDown()
Quoted 14 lines · Cleber Rosa
The avocado.Test class, used as the basis of the avocado_qemu.Test class, performs a clean of temporary directories up as part of its own
tearDown()implementation.But the avocado_qemu.Test class is currently missing the same clean up, as it implemented its own
tearDown()method without resorting to the upper class behavior.This brings avocado_qemu.Test behavior in sync with the standard avocado.Test behavior and prevents temporary directories from cluttering the test results directory (unless instructed to do so with Avocado's "--keep-tmp" option).
Quoted 6 lines
Reported-by Peter Maydell <[email protected]>Signed-off-by Cleber Rosa <[email protected]>--- tests/acceptance/avocado_qemu/__init__.py | 1 + 1 file changed, 1 insertion(+)
Re: [PATCH 1/2] Acceptance Tests: add standard clean up at test tearDown()
In reply to Cleber RosaHi,
Quoted 7 lines · Cleber Rosa
The avocado.Test class, used as the basis of the avocado_qemu.Test class, performs a clean of temporary directories up as part of its own
tearDown()implementation.But the avocado_qemu.Test class is currently missing the same clean up, as it implemented its own
tearDown()method without resorting to the upper class behavior.
Good catch Peter!
Quoted 17 lines
This brings avocado_qemu.Test behavior in sync with the standard avocado.Test behavior and prevents temporary directories from cluttering the test results directory (unless instructed to do so with Avocado's "--keep-tmp" option).
Reported-by Peter Maydell <[email protected]>Signed-off-by Cleber Rosa <[email protected]>--- tests/acceptance/avocado_qemu/__init__.py | 1 + 1 file changed, 1 insertion(+)tests/acceptance/avocado_qemu/__init__.py +0
-0
tests/acceptance/avocado_qemu/__init__.py def tearDown(self): · line 279
Quoted 4 lines
tests/acceptance/avocado_qemu/__init__.py +1
-0@@ -276,6 +276,7 @@ def tearDown(self): for vm in self._vms.values(): vm.shutdown() self._sd = None + super(Test, self).tearDown()
Could you use the new form of super [1] to make the pylint happier?
[1] https://www.python.org/dev/peps/pep-3135/
Thanks!
- Wainer
Quoted 3 lines
tests/acceptance/avocado_qemu/__init__.py +0
-0def fetch_asset(self, name, asset_hash=None, algorithm=None,
PATCH 2/2 Acceptance Tests: updates to the MAINTAINERS file
In reply to Cleber RosaThe tests/acceptance directory is currently lacking a maintainer entry, even though I've been performing that role (of course with help from many others). Thus, its status is, even more now, Maintained.
This also removes the currently broken Trello board link, which was make unavailable unintentionally by a third party.
--- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
MAINTAINERS +3 -3
@@ -3418,11 +3418,11 @@ F: tests/tcg/Makefile F: tests/tcg/Makefile.include Acceptance (Integration) Testing with the Avocado framework -W: https://trello.com/b/6Qi1pxVn/avocado-qemu -R: Cleber Rosa <[email protected]> +M: Cleber Rosa <[email protected]> R: Philippe Mathieu-Daudé <[email protected]> R: Wainer dos Santos Moschetta <[email protected]> -S: Odd Fixes +S: Maintained +F: tests/Makefile.include F: tests/acceptance/ Documentation
Signature · 1 line
2.31.1
Re: [PATCH 2/2] Acceptance Tests: updates to the MAINTAINERS file
Quoted 5 lines · Cleber Rosa
The tests/acceptance directory is currently lacking a maintainer entry, even though I've been performing that role (of course with help from many others). Thus, its status is, even more now, Maintained.
Quoted 8 lines
This also removes the currently broken Trello board link, which was make unavailable unintentionally by a third party.
Signed-off-by Cleber Rosa <[email protected]>--- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Philippe Mathieu-Daudé
Reviewed-byRe: [PATCH 2/2] Acceptance Tests: updates to the MAINTAINERS file
Quoted 9 lines · Willian Rampazzo
Quoted 8 lines · Cleber Rosa
The tests/acceptance directory is currently lacking a maintainer entry, even though I've been performing that role (of course with help from many others). Thus, its status is, even more now, Maintained.
This also removes the currently broken Trello board link, which was make unavailable unintentionally by a third party.
Quoted 7 lines
Quoted 5 lines
Signed-off-by Cleber Rosa <[email protected]>--- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)Reviewed-by Willian Rampazzo <[email protected]>
Willian you could send an extra patch to add yourself a R: tag.
Re: [PATCH 2/2] Acceptance Tests: updates to the MAINTAINERS file
Quoted 17 lines · Philippe Mathieu-Daudé
Quoted 15 lines · Willian Rampazzo
Quoted 13 lines · Cleber Rosa
The tests/acceptance directory is currently lacking a maintainer entry, even though I've been performing that role (of course with help from many others). Thus, its status is, even more now, Maintained.
This also removes the currently broken Trello board link, which was make unavailable unintentionally by a third party.
Signed-off-by Cleber Rosa <[email protected]>--- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Quoted 3 lines
Quoted 1 line
Reviewed-by Willian Rampazzo <[email protected]>Willian you could send an extra patch to add yourself a R: tag.
Ack!
Re: [PATCH 2/2] Acceptance Tests: updates to the MAINTAINERS file
In reply to Cleber RosaHi,
Quoted 3 lines · Cleber Rosa
The tests/acceptance directory is currently lacking a maintainer entry, even though I've been performing that role (of course with help from many others). Thus, its status is, even more now, Maintained.
yay!
Quoted 3 lines
This also removes the currently broken Trello board link, which was make unavailable unintentionally by a third party.
I can still access the link. Anyway, maybe we could migrate the cards (not everything, just those which still make sense) to the GitLab's Issues tracker?
Quoted 5 lines
Signed-off-by Cleber Rosa <[email protected]>--- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Quoted 20 lines
MAINTAINERS +3
-3@@ -3418,11 +3418,11 @@ F: tests/tcg/Makefile F: tests/tcg/Makefile.include Acceptance (Integration) Testing with the Avocado framework -W: https://trello.com/b/6Qi1pxVn/avocado-qemu -R: Cleber Rosa <[email protected]> +M: Cleber Rosa <[email protected]> R: Philippe Mathieu-Daudé <[email protected]> R: Wainer dos Santos Moschetta <[email protected]> -S: Odd Fixes +S: Maintained +F: tests/Makefile.include F: tests/acceptance/ Documentation
Re: [PATCH 2/2] Acceptance Tests: updates to the MAINTAINERS file
In reply to Cleber RosaQuoted 18 lines · Cleber Rosa
The tests/acceptance directory is currently lacking a maintainer entry, even though I've been performing that role (of course with help from many others). Thus, its status is, even more now, Maintained.
This also removes the currently broken Trello board link, which was make unavailable unintentionally by a third party.
Signed-off-by Cleber Rosa <[email protected]>--- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)MAINTAINERS +0
-0@@ -3418,11 +3418,11 @@ F: tests/tcg/Makefile F: tests/tcg/Makefile.include
MAINTAINERS F: tests/tcg/Makefile · line 3425
Quoted 10 lines
MAINTAINERS +3
-3Acceptance (Integration) Testing with the Avocado framework -W: https://trello.com/b/6Qi1pxVn/avocado-qemu -R: Cleber Rosa <[email protected]> +M: Cleber Rosa <[email protected]> R: Philippe Mathieu-Daudé <[email protected]> R: Wainer dos Santos Moschetta <[email protected]> -S: Odd Fixes +S: Maintained +F: tests/Makefile.include
Not sure whether we really should add tests/Makefile.include in this section, since there are only a couple of lines in there that are related to the "acceptance" tests... Anyway:
Cleber, now that the freeze period is over, could you collect the related patches on the list and send a pull request?
Thomas
Quoted 7 lines · Cleber Rosa
This is a reply to an issue[1] reported by Peter, and while at it, an update of the
MAINTAINERSentry so other people now the status and where to go for help with regards to the acceptance tests' infrastructure.[1] https://lists.gnu.org/archive/html/qemu-devel/2021-08/msg00349.html
Ping? I was reminded of this today, and it looks like the acceptance tests are still wasting gigabytes of everybody's disk space with non-cleaned-up tempfiles...
-- PMM
Quoted 8 lines · Peter Maydell
Quoted 6 lines · Cleber Rosa
This is a reply to an issue[1] reported by Peter, and while at it, an update of the
MAINTAINERSentry so other people now the status and where to go for help with regards to the acceptance tests' infrastructure.
Quoted 5 lines
Quoted 1 line
[1] https://lists.gnu.org/archive/html/qemu-devel/2021-08/msg00349.html
Ping? I was reminded of this today, and it looks like the acceptance tests are still wasting gigabytes of everybody's disk space with non-cleaned-up tempfiles...
Cleber will be out until next Wed. I took the bug fix patch and changed it based on Wainer's comment:
https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg05117.html
Quoted 3 lines
-- PMM