Skip to contentSkip to conversation

selftests/net/fib_tests: remove duplicate log test

PATCH Applied Hangbin Liu 3 participants 3 messages Jan 19, 2021 – Jan 20, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/net/fib_tests: remove duplicate log test

The previous test added an address with a specified metric and check if correspond route was created. I somehow added two logs for the same test. Remove the duplicated one.

Fixes 0d29169a708b ("selftests/net/fib_tests: update addr_metric_test for peer route testing")
---
 tools/testing/selftests/net/fib_tests.sh | 1 -
 1 file changed, 1 deletion(-)
tools/testing/selftests/net/fib_tests.sh +0 -1
index 84205c3a55eb..2b5707738609 100755
@@ -1055,7 +1055,6 @@ ipv6_addr_metric_test()
 
 	check_route6 "2001:db8:104::1 dev dummy2 proto kernel metric 260"
 	log_test $? 0 "Set metric with peer route on local side"
-	log_test $? 0 "User specified metric on local address"
 	check_route6 "2001:db8:104::2 dev dummy2 proto kernel metric 260"
 	log_test $? 0 "Set metric with peer route on peer side"
 
Signature · 1 line
2.26.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Hangbin Liu

The previous test added an address with a specified metric and check if correspond route was created. I somehow added two logs for the same test. Remove the duplicated one.

Fixes 0d29169a708b ("selftests/net/fib_tests: update addr_metric_test for peer route testing")
---
 tools/testing/selftests/net/fib_tests.sh | 1 -
 1 file changed, 1 deletion(-)
maintainer Applied
#2 lore raw
Quoted 13 lines · On Mon, 18 Jan 2021 20:03:12 -0700 David Ahern wrote:
Quoted 11 lines · Hangbin Liu

The previous test added an address with a specified metric and check if correspond route was created. I somehow added two logs for the same test. Remove the duplicated one.

Fixes 0d29169a708b ("selftests/net/fib_tests: update addr_metric_test for peer route testing")
---
 tools/testing/selftests/net/fib_tests.sh | 1 -
 1 file changed, 1 deletion(-)
Quoted 1 line

Applied, thanks!