KVM: SVM: Add tracepoint for cr_interception
PATCH 1/1 KVM: SVM: Add tracepoint for cr_interception
From: Haiwei Li <[email protected]>
Add trace_kvm_cr_write and trace_kvm_cr_read for svm.
--- arch/x86/kvm/svm/svm.c | 2 ++ 1 file changed, 2 insertions(+)
arch/x86/kvm/svm/svm.c +2 -0
@@ -2261,6 +2261,7 @@ static int cr_interception(struct vcpu_svm *svm)if (cr >=16 ) {/* mov to cr */ cr -=16 ; val =kvm_register_read (&svm->vcpu, reg); +trace_kvm_cr_write (cr, val);switch (cr) {case 0 :if (!check_selective_cr0_intercepted (svm, val))
@@ -2306,6 +2307,7 @@ static int cr_interception(struct vcpu_svm *svm)return 1 ; }kvm_register_write (&svm->vcpu, reg, val); +trace_kvm_cr_read (cr, val); }return kvm_complete_insn_gp (&svm->vcpu, err); }
--
2.18.4
arch/x86/kvm/svm/svm.c static int cr_interception(struct vcpu_svm *svm)
Quoted 14 lines · Haiwei Li
From: Haiwei Li <[email protected]>
Add
trace_kvm_cr_writeandtrace_kvm_cr_readfor svm.Signed-off-by Haiwei Li <[email protected]>--- arch/x86/kvm/svm/svm.c | 2 ++ 1 file changed, 2 insertions(+)arch/x86/kvm/svm/svm.c +0
-0@@ -2261,6 +2261,7 @@ static int cr_interception(struct vcpu_svm *svm)
There are two special cases when we go to emulate_on_interception() and these won't be logged but I don't think this is a must.
arch/x86/kvm/svm/svm.c static int cr_interception(struct vcpu_svm *svm) · line 2310
Quoted 12 lines
arch/x86/kvm/svm/svm.c +2
-0if (cr >=16 ) {/* mov to cr */ cr -=16 ; val =kvm_register_read (&svm->vcpu, reg); +trace_kvm_cr_write (cr, val);switch (cr) {case 0 :if (!check_selective_cr0_intercepted (svm, val))@@ -2306,6 +2307,7 @@ static int cr_interception(struct vcpu_svm *svm)return 1 ; }kvm_register_write (&svm->vcpu, reg, val); +trace_kvm_cr_read (cr, val);
The 'default:' case above does 'return 1;' so we won't get the trace but I understand you put trace_kvm_cr_read() here so you can log the returned 'val', #UD should be clearly visible.
Quoted 6 lines
arch/x86/kvm/svm/svm.c +0
-1}return kvm_complete_insn_gp (&svm->vcpu, err); } --2.18.4
Signature · 1 line
Vitaly
Quoted 37 lines · Vitaly Kuznetsov
arch/x86/kvm/svm/svm.c static int cr_interception(struct vcpu_svm *svm)
Quoted 14 lines · Haiwei Li
From: Haiwei Li <[email protected]>
Add
trace_kvm_cr_writeandtrace_kvm_cr_readfor svm.Signed-off-by Haiwei Li <[email protected]>--- arch/x86/kvm/svm/svm.c | 2 ++ 1 file changed, 2 insertions(+)arch/x86/kvm/svm/svm.c +0
-0@@ -2261,6 +2261,7 @@ static int cr_interception(struct vcpu_svm *svm)There are two special cases when we go to
emulate_on_interception()and these won't be logged but I don't think this is a must.arch/x86/kvm/svm/svm.c static int cr_interception(struct vcpu_svm *svm) · line 2310
Quoted 12 lines
arch/x86/kvm/svm/svm.c +2
-0if (cr >=16 ) {/* mov to cr */ cr -=16 ; val =kvm_register_read (&svm->vcpu, reg); +trace_kvm_cr_write (cr, val);switch (cr) {case 0 :if (!check_selective_cr0_intercepted (svm, val))@@ -2306,6 +2307,7 @@ static int cr_interception(struct vcpu_svm *svm)return 1 ; }kvm_register_write (&svm->vcpu, reg, val); +trace_kvm_cr_read (cr, val);The 'default:' case above does 'return 1;' so we won't get the trace but I understand you put
trace_kvm_cr_read()here so you can log the returned 'val', #UD should be clearly visible.
Quoted 8 lines
Quoted 6 lines
arch/x86/kvm/svm/svm.c +0
-1}return kvm_complete_insn_gp (&svm->vcpu, err); } --2.18.4
Reviewed-by Vitaly Kuznetsov <[email protected]>
Thanks a lot.
Quoted 1 line
Kindly ping. :)
Quoted 31 lines · Haiwei Li
From: Haiwei Li <[email protected]>
Add
trace_kvm_cr_writeandtrace_kvm_cr_readfor svm.Signed-off-by Haiwei Li <[email protected]>--- arch/x86/kvm/svm/svm.c | 2 ++ 1 file changed, 2 insertions(+)arch/x86/kvm/svm/svm.c +2
-0@@ -2261,6 +2261,7 @@ static int cr_interception(struct vcpu_svm *svm) if (cr >= 16) { /* mov to cr */ cr -= 16; val = kvm_register_read(&svm->vcpu, reg); + trace_kvm_cr_write(cr, val); switch (cr) { case 0: if (!check_selective_cr0_intercepted(svm, val))@@ -2306,6 +2307,7 @@ static int cr_interception(struct vcpu_svm *svm) return 1; } kvm_register_write(&svm->vcpu, reg, val); + trace_kvm_cr_read(cr, val); } return kvm_complete_insn_gp(&svm->vcpu, err); }Signature · 1 line
2.18.4
Quoted 6 lines · Haiwei Li
From: Haiwei Li <[email protected]>
Add
trace_kvm_cr_writeandtrace_kvm_cr_readfor svm.Signed-off-by Haiwei Li <[email protected]>