drm/amdgpu: fix documentation for amdgpu_gem_prime_export
Subsystems (4)
PATCH 1/6 drm/amdgpu: fix documentation for amdgpu_gem_prime_export
Drop extra function parameter.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 1 - 1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c +0 -1
@@ -321,7 +321,6 @@ const struct dma_buf_ops amdgpu_dmabuf_ops = {/** * amdgpu_gem_prime_export - &drm_driver.gem_prime_export implementation -* @dev: DRM device * @gobj: GEM BO * @flags: Flags such as DRM_CLOEXEC and DRM_RDWR. *
Signature · 6 lines
2.20.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20190919214527.10803-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org
PATCH 2/6 drm/amdgpu/mn: fix documentation for amdgpu_mn_read_lock
Document the new parameter.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c +1 -0
@@ -136,6 +136,7 @@ void amdgpu_mn_unlock(struct amdgpu_mn *mn)* amdgpu_mn_read_lock - take the read side lock for this notifier * * @amn: our notifier +* @blockable: is the notifier blockable */ static int amdgpu_mn_read_lock (struct amdgpu_mn *amn,bool blockable) {
Signature · 6 lines
2.20.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 3/6 drm/amdgpu/vm: fix up documentation in amdgpu_vm.c
In reply to a message not in the archiveMissing parameters, wrong comment type, etc.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +10 -7
@@ -342,7 +342,7 @@ static struct amdgpu_vm_pt *amdgpu_vm_pt_parent(struct amdgpu_vm_pt *pt) return container_of(parent->vm_bo, struct amdgpu_vm_pt, base); } -/** +/* * amdgpu_vm_pt_cursor - state for for_each_amdgpu_vm_pt */ struct amdgpu_vm_pt_cursor {
@@ -483,6 +483,7 @@ static void amdgpu_vm_pt_next(struct amdgpu_device *adev,* * @adev: amdgpu_device structure * @vm: amdgpu_vm structure +* @start: optional cursor to start with * @cursor: state to initialize * * Starts a deep first traversal of the PD/PT tree.
@@ -536,7 +537,7 @@ static void amdgpu_vm_pt_next_dfs(struct amdgpu_device *adev,amdgpu_vm_pt_ancestor (cursor); } -/** +/* * for_each_amdgpu_vm_pt_dfs_safe - safe deep first search of all PDs/PTs */ #define for_each_amdgpu_vm_pt_dfs_safe (adev, vm, start, cursor, entry) \
@@ -857,6 +858,7 @@ static void amdgpu_vm_bo_param(struct amdgpu_device *adev, struct amdgpu_vm *vm,* @adev: amdgpu_device pointer * @vm: VM to allocate page tables for * @cursor: Which page table to allocate +* @direct: use a direct update * * Make sure a specific page table or directory is allocated. *
@@ -1196,10 +1198,10 @@ uint64_t amdgpu_vm_map_gart(const dma_addr_t *pages_addr, uint64_t addr)return result; } -/* +/** * amdgpu_vm_update_pde - update a single level in the hierarchy * -* @param: parameters for the update +* @params: parameters for the update * @vm: requested vm * @entry: entry to update *
@@ -1223,7 +1225,7 @@ static int amdgpu_vm_update_pde(struct amdgpu_vm_update_params *params,return vm->update_funcs->update (params, bo, pde, pt,1 ,0 , flags); } -/* +/** * amdgpu_vm_invalidate_pds - mark all PDs as invalid * * @adev: amdgpu_device pointer
@@ -1242,7 +1244,7 @@ static void amdgpu_vm_invalidate_pds(struct amdgpu_device *adev,amdgpu_vm_bo_relocated (&entry->base); } -/* +/** * amdgpu_vm_update_pdes - make sure that all directories are valid * * @adev: amdgpu_device pointer
@@ -1294,7 +1296,7 @@ int amdgpu_vm_update_pdes(struct amdgpu_device *adev,return r; } -/** +/* * amdgpu_vm_update_flags - figure out flags for PTE updates * * Make sure to set the right flags for the PTEs at the desired level.
@@ -2815,6 +2817,7 @@ static int amdgpu_vm_check_clean_reserved(struct amdgpu_device *adev,* * @adev: amdgpu_device pointer * @vm: requested vm +* @pasid: pasid to use * * This only works on GFX VMs that don't have any BOs added and no * page tables allocated yet.
Signature · 6 lines
2.20.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20190919214527.10803-3-alexander.deucher-5C7GfCeVMHo@public.gmane.org
Re: [PATCH 3/6] drm/amdgpu/vm: fix up documentation in amdgpu_vm.c
Am 19.09.19 um 23:45 schrieb Alex Deucher:
Quoted 12 lines
Missing parameters, wrong comment type, etc.
Signed-off-by Alex Deucher <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c static struct amdgpu_vm_pt *amdgpu_vm_pt_parent(struct amdgpu_vm_pt *pt) · line 345
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +1
-1@@ -342,7 +342,7 @@ static struct amdgpu_vm_pt *amdgpu_vm_pt_parent(struct amdgpu_vm_pt *pt) return container_of(parent->vm_bo, struct amdgpu_vm_pt, base); } -/** +/*
Hui? That doesn't look correct to me, why shouldn't this be a documentation comment?
Christian.
Quoted 69 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +8
-6* amdgpu_vm_pt_cursor - state for for_each_amdgpu_vm_pt */ struct amdgpu_vm_pt_cursor {@@ -483,6 +483,7 @@ static void amdgpu_vm_pt_next(struct amdgpu_device *adev,* * @adev: amdgpu_device structure * @vm: amdgpu_vm structure +* @start: optional cursor to start with * @cursor: state to initialize * * Starts a deep first traversal of the PD/PT tree. @@ -536,7 +537,7 @@ static void amdgpu_vm_pt_next_dfs(struct amdgpu_device *adev,amdgpu_vm_pt_ancestor (cursor); } -/** +/* * for_each_amdgpu_vm_pt_dfs_safe - safe deep first search of all PDs/PTs */ #define for_each_amdgpu_vm_pt_dfs_safe (adev, vm, start, cursor, entry) \@@ -857,6 +858,7 @@ static void amdgpu_vm_bo_param(struct amdgpu_device *adev, struct amdgpu_vm *vm,* @adev: amdgpu_device pointer * @vm: VM to allocate page tables for * @cursor: Which page table to allocate +* @direct: use a direct update * * Make sure a specific page table or directory is allocated. * @@ -1196,10 +1198,10 @@ uint64_t amdgpu_vm_map_gart(const dma_addr_t *pages_addr, uint64_t addr)return result; } -/* +/** * amdgpu_vm_update_pde - update a single level in the hierarchy * -* @param: parameters for the update +* @params: parameters for the update * @vm: requested vm * @entry: entry to update * @@ -1223,7 +1225,7 @@ static int amdgpu_vm_update_pde(struct amdgpu_vm_update_params *params,return vm->update_funcs->update (params, bo, pde, pt,1 ,0 , flags); } -/* +/** * amdgpu_vm_invalidate_pds - mark all PDs as invalid * * @adev: amdgpu_device pointer @@ -1242,7 +1244,7 @@ static void amdgpu_vm_invalidate_pds(struct amdgpu_device *adev,amdgpu_vm_bo_relocated (&entry->base); } -/* +/** * amdgpu_vm_update_pdes - make sure that all directories are valid * * @adev: amdgpu_device pointer @@ -1294,7 +1296,7 @@ int amdgpu_vm_update_pdes(struct amdgpu_device *adev,return r; } -/** +/* * amdgpu_vm_update_flags - figure out flags for PTE updates * * Make sure to set the right flags for the PTEs at the desired level.
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c static int amdgpu_vm_check_clean_reserved(struct amdgpu_device *adev, · line 2823
Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +1
-0@@ -2815,6 +2817,7 @@ static int amdgpu_vm_check_clean_reserved(struct amdgpu_device *adev,* * @adev: amdgpu_device pointer * @vm: requested vm +* @pasid: pasid to use * * This only works on GFX VMs that don't have any BOs added and no * page tables allocated yet.
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 4/6 drm/amdgpu/ih: fix documentation in amdgpu_irq_dispatch
In reply to a message not in the archiveFix parameters.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c +1 -1
@@ -383,7 +383,7 @@ int amdgpu_irq_add_id(struct amdgpu_device *adev,* amdgpu_irq_dispatch - dispatch IRQ to IP blocks * * @adev: amdgpu device pointer -* @entry: interrupt vector pointer +* @ih: interrupt ring instance * * Dispatches IRQ to IP blocks. */
Signature · 6 lines
2.20.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 5/6 drm/amdgpu: fix documentation for amdgpu_pm.c
In reply to a message not in the archiveFix DOC link name, clean up formatting in pp_dpm_* section.
--- Documentation/gpu/amdgpu.rst | 6 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 13 +++++++++---- 2 files changed, 12 insertions(+), 7 deletions(-)
Documentation/gpu/amdgpu.rst +3 -3
@@ -130,11 +130,11 @@ pp_od_clk_voltage .. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c :doc: pp_od_clk_voltage -pp_dpm_sclk pp_dpm_mclk pp_dpm_pcie -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +pp_dpm_* +~~~~~~~~ .. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c - :doc: pp_dpm_sclk pp_dpm_mclk pp_dpm_pcie + :doc: pp_dpm_sclk pp_dpm_mclk pp_dpm_socclk pp_dpm_fclk pp_dpm_dcefclk pp_dpm_pcie pp_power_profile_mode ~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c +9 -4
@@ -805,8 +805,7 @@ static ssize_t amdgpu_get_pp_feature_status(struct device *dev, }/** -* DOC: pp_dpm_sclk pp_dpm_mclk pp_dpm_socclk pp_dpm_fclk pp_dpm_dcefclk -* pp_dpm_pcie +* DOC: pp_dpm_sclk pp_dpm_mclk pp_dpm_socclk pp_dpm_fclk pp_dpm_dcefclk pp_dpm_pcie * * The amdgpu driver provides a sysfs API for adjusting what power levels * are enabled for a given power state. The files pp_dpm_sclk, pp_dpm_mclk,
@@ -822,9 +821,15 @@ static ssize_t amdgpu_get_pp_feature_status(struct device *dev,* * To manually adjust these states, first select manual using * power_dpm_force_performance_level. -* Secondly,Enter a new value for each level by inputing a string that +* Secondly, enter a new value for each level by inputing a string that * contains " echo xx xx xx > pp_dpm_sclk/mclk/pcie" -* E.g., echo 4 5 6 to > pp_dpm_sclk will enable sclk levels 4, 5, and 6. +* E.g., +* +* .. code-block:: bash +* +* echo "4 5 6" > pp_dpm_sclk +* +* will enable sclk levels 4, 5, and 6. * * NOTE: change to the dcefclk max dpm level is not supported now */
Signature · 6 lines
2.20.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 6/6 drm/amdgpu/ras: fix and update the documentation for RAS
In reply to a message not in the archiveAdd new sections to amdgpu.rst, fix up formatting issues, add additional documentation to each section.
--- Documentation/gpu/amdgpu.rst | 24 ++++++++++- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 53 +++++++++++++++++++++---- 2 files changed, 68 insertions(+), 9 deletions(-)
Documentation/gpu/amdgpu.rst +22 -2
@@ -79,12 +79,32 @@ AMDGPU XGMI Support .. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c :internal: -AMDGPU RAS debugfs control interface -==================================== +AMDGPU RAS Support +================== + +RAS debugfs/sysfs Control and Error Injection Interfaces +-------------------------------------------------------- .. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c :doc: AMDGPU RAS debugfs control interface +RAS Error Count sysfs Interface +------------------------------- + +.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c + :doc: AMDGPU RAS sysfs Error Count Interface + +RAS EEPROM debugfs Interface +---------------------------- + +.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c + :doc: AMDGPU RAS debugfs EEPROM table reset interface + +RAS VRAM Bad Pages sysfs Interface +---------------------------------- + +.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c + :doc: AMDGPU RAS sysfs gpu_vram_bad_pages Interface .. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c :internal:
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +46 -7
81 lines not on this page · raw message
Signature · 6 lines
2.20.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx