Skip to contentSkip to conversation

MAINTAINERS: reorg PowerPC RAS code for better maintainability

PATCH In review Shivang Upadhyay 2 participants 4 messages Aug 19 – Aug 21

lore
Share & tools
lore
#0 lore raw

v3 cover MAINTAINERS: reorg PowerPC RAS code for better maintainability

Combining Fadump and MPIPL entries under PowerPC RAS section. Additionally adding myself as a reviewer, to help share the review workload.

--
ChangeLog:

v3:
Adding spapr_rtas.c file. As rtas_ras.c file is no longer there.

v2: https://lore.kernel.org/all/[email protected]/
Dropping the rtas_ras.c file refactor, as suggested by vaibhav.

v1: https://lore.kernel.org/all/[email protected]/

--
Shivang Upadhyay (2):
MAINTAINERS: add dedicated PowerPC RAS section
MAINTAINERS: add self as reviewer for PowerPC RAS

 MAINTAINERS | 33 ++++++++++++++++-----------------
 1 file changed, 16 insertions(+), 17 deletions(-)
Signature · 1 line
2.54.0
#1 lore raw

PATCH v3 1/2 MAINTAINERS: add dedicated PowerPC RAS section

Introduce a new "PowerPC RAS (Reliability, Availability and Serviceability)" entry in the PowerPC Machines block, replacing the existing Fadump/MPIPL sections. Retaining the maintainer and reviewer entries from Fadump/MPIPL sections for this broader umbrella.

Currently most of RAS related code sits in spapr_rtas.c, So Adding it to PowerPC RAS section. Additionally adding spapr_events.c, as it implements RTAS error logging infrastructure and spapr_pci_vfio.c, since its all EEH related code.

---
 MAINTAINERS | 32 +++++++++++++++-----------------
 1 file changed, 15 insertions(+), 17 deletions(-)
MAINTAINERS +15 -17
index b51f5c3e60..a2a80c789c 100644
@@ -1762,6 +1762,21 @@ F: include/hw/ppc/vof*
 F: pc-bios/vof/*
 F: pc-bios/vof*
 
+PowerPC RAS (Reliability, Availability and Serviceability)
+M: Aditya Gupta <[email protected]>
+R: Sourabh Jain <[email protected]>
+R: Hari Bathini <[email protected]>
+L: [email protected]
+S: Maintained
+F: hw/ppc/spapr_events.c
+F: hw/ppc/spapr_fadump.c
+F: hw/ppc/spapr_pci_vfio.c
+F: hw/ppc/spapr_rtas.c
+F: hw/ppc/pnv_mpipl.c
+F: include/hw/ppc/spapr_fadump.h
+F: include/hw/ppc/pnv_mpipl.h
+F: tests/functional/ppc64/test_fadump.py
+
 RISC-V Machines
 ---------------
 OpenTitan
@@ -3386,23 +3401,6 @@ F: scripts/coccinelle/remove_local_err.cocci
 F: scripts/coccinelle/use-error_fatal.cocci
 F: scripts/coccinelle/errp-guard.cocci
 
-Firmware Assisted Dump (fadump) for sPAPR (pseries)
-M: Aditya Gupta <[email protected]>
-R: Sourabh Jain <[email protected]>
-S: Maintained
-F: include/hw/ppc/spapr_fadump.h
-F: hw/ppc/spapr_fadump.c
-F: tests/functional/ppc64/test_fadump.py
-
-Memory-Preserving Initial Program Load (MPIPL) for PowerNV
-M: Aditya Gupta <[email protected]>
-R: Hari Bathini <[email protected]>
-R: Sourabh <[email protected]>
-S: Maintained
-F: include/hw/ppc/pnv_mpipl.h
-F: hw/ppc/pnv_mpipl.c
-F: tests/functional/ppc64/test_fadump.py
-
 GDB stub
 M: Alex Bennée <[email protected]>
 R: Philippe Mathieu-Daudé <[email protected]>
Signature · 1 line
2.54.0
Acked-by on v3 1/2
#2 lore raw

Re: [PATCH v3 1/2] MAINTAINERS: add dedicated PowerPC RAS section

Quoted 22 lines · Shivang Upadhyay

Introduce a new "PowerPC RAS (Reliability, Availability and Serviceability)" entry in the PowerPC Machines block, replacing the existing Fadump/MPIPL sections. Retaining the maintainer and reviewer entries from Fadump/MPIPL sections for this broader umbrella.

Currently most of RAS related code sits in spapr_rtas.c, So Adding it to PowerPC RAS section. Additionally adding spapr_events.c, as it implements RTAS error logging infrastructure and spapr_pci_vfio.c, since its all EEH related code.

---
  MAINTAINERS | 32 +++++++++++++++-----------------
  1 file changed, 15 insertions(+), 17 deletions(-)
MAINTAINERS +0 -0
index b51f5c3e60..a2a80c789c 100644

MAINTAINERS F: include/hw/ppc/vof* · line 1766

Quoted 5 lines
MAINTAINERS +1 -0
@@ -1762,6 +1762,21 @@ F: include/hw/ppc/vof*
  F: pc-bios/vof/*
  F: pc-bios/vof*
 
 
+PowerPC RAS (Reliability, Availability and Serviceability)

With the scope now expanded to include additional files, I’m not sure I’ll be able to review everything given my current workload. However, I should be able to review the FADump-specific patches.

With that said:

Quoted 42 lines
MAINTAINERS +14 -0
+M: Aditya Gupta <[email protected]>
+R: Sourabh Jain <[email protected]>
+R: Hari Bathini <[email protected]>
 
+L: [email protected]
+S: Maintained
+F: hw/ppc/spapr_events.c
+F: hw/ppc/spapr_fadump.c
+F: hw/ppc/spapr_pci_vfio.c
+F: hw/ppc/spapr_rtas.c
+F: hw/ppc/pnv_mpipl.c
+F: include/hw/ppc/spapr_fadump.h
+F: include/hw/ppc/pnv_mpipl.h
+F: tests/functional/ppc64/test_fadump.py
+
  RISC-V Machines

---------------
OpenTitan

MAINTAINERS +0 -17
@@ -3386,23 +3401,6 @@ F: scripts/coccinelle/remove_local_err.cocci
  F: scripts/coccinelle/use-error_fatal.cocci
  F: scripts/coccinelle/errp-guard.cocci
 
-Firmware Assisted Dump (fadump) for sPAPR (pseries)
-M: Aditya Gupta <[email protected]>
-R: Sourabh Jain <[email protected]>
-S: Maintained
-F: include/hw/ppc/spapr_fadump.h
-F: hw/ppc/spapr_fadump.c
-F: tests/functional/ppc64/test_fadump.py
-
-Memory-Preserving Initial Program Load (MPIPL) for PowerNV
-M: Aditya Gupta <[email protected]>
-R: Hari Bathini <[email protected]>
-R: Sourabh <[email protected]>
-S: Maintained
-F: include/hw/ppc/pnv_mpipl.h
-F: hw/ppc/pnv_mpipl.c
-F: tests/functional/ppc64/test_fadump.py
-
  GDB stub
  M: Alex Bennée <[email protected]>
  R: Philippe Mathieu-Daudé <[email protected]>
#3 lore raw

PATCH v3 2/2 MAINTAINERS: add self as reviewer for PowerPC RAS

In reply to Shivang Upadhyay

I have been contributing to Fadump, MPIPL as well as PowerNV for quite some time, and my daily work responsibilities includes taking care of PowerPC RAS features. I, therefore would like to step up as a reviewer to get notified of incoming changes in this area and help reviewing them.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index a2a80c789c..b06dd5c486 100644
@@ -1766,6 +1766,7 @@ PowerPC RAS (Reliability, Availability and Serviceability)
 M: Aditya Gupta <[email protected]>
 R: Sourabh Jain <[email protected]>
 R: Hari Bathini <[email protected]>
+R: Shivang Upadhyay <[email protected]>
 L: [email protected]
 S: Maintained
 F: hw/ppc/spapr_events.c
Signature · 1 line
2.54.0