dt: lm3532: Add lm3532 dt doc and update ti_lmu doc
Subsystems (3)
PATCH 1/4 dt: lm3532: Add lm3532 dt doc and update ti_lmu doc
Add the lm3532 device tree documentation.
Remove lm3532 device tree reference from the ti_lmu devicetree documentation.
With the addition of the dedicated lm3532 documentation the device can be removed from the ti_lmu.txt.
The reason for this is that the lm3532 dt documentation now defines the ability to control LED output strings against different control banks or groups multiple strings to be controlled by a single control bank.
Another addition was for ALS lighting control and configuration. The LM3532 has a feature that can take in the ALS reading from 2 separate ALS devices and adjust the brightness on the strings that are configured to support this feature.
Finally the device specific properties were moved to the parent node as these properties are not control bank configurable. These include the runtime ramp and the ALS configuration.
---
v5 - Moved ramping range to below property definition, updated keyboard label -
https://lore.kernel.org/patchwork/patch/1050412/
v4 - Appended "ti," to TI specific properties, add enable gpio documentation,
removed an example, moved ramp to optional parent properties - https://lore.kernel.org/patchwork/patch/1050122/
v3 - No changes - https://lore.kernel.org/patchwork/patch/1049026/
v2 - Fixed ramp-up and ramp-down properties, removed hard coded property values,
added ranges for variable properties, I did not change the label - https://lore.kernel.org/patchwork/patch/1048805/
.../devicetree/bindings/leds/leds-lm3532.txt | 101 ++++++++++++++++++ .../devicetree/bindings/mfd/ti-lmu.txt | 20 ---- 2 files changed, 101 insertions(+), 20 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3532.txt
Documentation/devicetree/bindings/leds/leds-lm3532.txt new file +101 -0
@@ -0,0 +1,101 @@ +* Texas Instruments - lm3532 White LED driver with ambient light sensing +capability. + +The LM3532 provides the 3 high-voltage, low-side current sinks. The device is +programmable over an I2C-compatible interface and has independent +current control for all three channels. The adaptive current regulation +method allows for different LED currents in each current sink thus allowing +for a wide variety of backlight and keypad applications. + +The main features of the LM3532 include dual ambient light sensor inputs +each with 32 internal voltage setting resistors, 8-bit logarithmic and linear +brightness control, dual external PWM brightness control inputs, and up to +1000:1 dimming ratio with programmable fade in and fade out settings. + +Required properties: + - compatible : "ti,lm3532" + - reg : I2C slave address + - #address-cells : 1 + - #size-cells : 0 + +Optional properties: + - enable-gpios : gpio pin to enable (active high)/disable the device. + - ramp-up-us - The Run time ramp rates/step are from one current + set-point to another after the device has reached its + initial target set point from turn-on + - ramp-down-us - The Run time ramp rates/step are from one current + set-point to another after the device has reached its + initial target set point from turn-on + Range for ramp settings: 8us - 65536us + +Optional properties if ALS mode is used: + - ti,als-vmin - Minimum ALS voltage defined in Volts + - ti,als-vmax - Maximum ALS voltage defined in Volts + Per the data sheet the max ALS voltage is 2V and the min is 0V + + - ti,als1-imp-sel - ALS1 impedance resistor selection in Ohms + - ti,als2-imp-sel - ALS2 impedance resistor selection in Ohms + Range for impedance select: 37000 Ohms - 1190 Ohms + Values above 37kohms will be set to the "High Impedance" setting + + - ti,als-avrg-time-us - Determines the length of time the device needs to + average the two ALS inputs. This is only used if + the input mode is LM3532_ALS_INPUT_AVRG. + Range: 17920us - 2293760us + - ti,als-input-mode - Determines how the device uses the attached ALS + devices. + 0x00 - ALS1 and ALS2 input average + 0x01 - ALS1 Input + 0x02 - ALS2 Input + 0x03 - Max of ALS1 and ALS2 + +Required child properties: + - reg : Indicates control bank the LED string is controlled by + - led-sources : see Documentation/devicetree/bindings/leds/common.txt + - ti,led-mode : Defines if the LED strings are manually controlled or + if the LED strings are controlled by the ALS. + 0x00 - LED strings are I2C controlled via full scale + brightness control register + 0x01 - LED strings are ALS controlled + +Optional LED child properties: + - label : see Documentation/devicetree/bindings/leds/common.txt + - linux,default-trigger : + see Documentation/devicetree/bindings/leds/common.txt + +Example: +led-controller@38 { + compatible = "ti,lm3532"; + #address-cells = <1>; + #size-cells = <0>; + reg = <0x38>; + + enable-gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>; + ramp-up-us = <1024>; + ramp-down-us = <65536>; + + ti,als-vmin = <0>; + ti,als-vmax = <2000>; + ti,als1-imp-sel = <4110>; + ti,als2-imp-sel = <2180>; + ti,als-avrg-time-us = <17920>; + ti,als-input-mode = <0x00>; + + lcd_backlight: led@0 { + reg = <0>; + led-sources = <2>; + ti,led-mode = <1>; + label = "backlight"; + linux,default-trigger = "backlight"; + }; + + led@1 { + reg = <1>; + led-sources = <1>; + ti,led-mode = <0>; + label = "platform::kbd_backlight"; + }; +}; + +For more product information please see the links below: +http://www.ti.com/product/LM3532
Documentation/devicetree/bindings/mfd/ti-lmu.txt +0 -20
@@ -4,7 +4,6 @@ TI LMU driver supports lighting devices below. Name Child nodes ------ --------------------------------- - LM3532 Backlight LM3631 Backlight and regulator LM3632 Backlight and regulator LM3633 Backlight, LED and fault monitor
@@ -13,7 +12,6 @@ TI LMU driver supports lighting devices below. Required properties: - compatible: Should be one of: - "ti,lm3532" "ti,lm3631" "ti,lm3632" "ti,lm3633"
@@ -23,7 +21,6 @@ Required properties: 0x11 for LM3632 0x29 for LM3631 0x36 for LM3633, LM3697 - 0x38 for LM3532 0x63 for LM3695 Optional property:
@@ -47,23 +44,6 @@ Optional nodes: [2] ../leds/leds-lm3633.txt [3] ../regulator/lm363x-regulator.txt -lm3532@38 { - compatible = "ti,lm3532"; - reg = <0x38>; - - enable-gpios = <&pioC 2 GPIO_ACTIVE_HIGH>; - - backlight { - compatible = "ti,lm3532-backlight"; - - lcd { - led-sources = <0 1 2>; - ramp-up-msec = <30>; - ramp-down-msec = <0>; - }; - }; -}; - lm3631@29 { compatible = "ti,lm3631"; reg = <0x29>;
Signature · 1 line
2.21.0.5.gaeb582a983
PATCH 2/4 ARM: dts: omap4-droid4: Update backlight dt properties
Update the properties for the lm3532 device node for droid4. With this change the backlight LED string and the keypad LED strings will be controlled separately.
---
v5 - No change - https://lore.kernel.org/patchwork/patch/1050409/
v4 - No change - https://lore.kernel.org/patchwork/patch/1050125/
v3 - updated keypad label on v1 comment - https://lore.kernel.org/patchwork/patch/1049023/
v2 - Fixed ramp-up and ramp-down properties, removed hard coded property values,
I did not change the label as it is undecided what it could be - https://lore.kernel.org/patchwork/patch/1048806/
arch/arm/boot/dts/omap4-droid4-xt894.dts | 26 ++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-)
arch/arm/boot/dts/omap4-droid4-xt894.dts +18 -8
@@ -383,20 +383,30 @@ }; &i2c1 { - lm3532@38 { + led-controller@38 { compatible = "ti,lm3532"; + #address-cells = <1>; + #size-cells = <0>; reg = <0x38>; enable-gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>; - lcd_backlight: backlight { - compatible = "ti,lm3532-backlight"; + ramp-up-us = <1024>; + ramp-down-us = <8193>; - lcd { - led-sources = <0 1 2>; - ramp-up-msec = <1>; - ramp-down-msec = <0>; - }; + lcd_backlight: led@0 { + reg = <0>; + led-sources = <2>; + ti,led-mode = <0>; + label = "backlight"; + linux,default-trigger = "backlight"; + }; + + led@1 { + reg = <1>; + led-sources = <1>; + ti,led-mode = <0>; + label = "platform::kbd_backlight"; }; }; };
Signature · 1 line
2.21.0.5.gaeb582a983
Re: [PATCH 2/4] ARM: dts: omap4-droid4: Update backlight dt properties
Hi,
Quoted 3 lines · Dan Murphy
Update the properties for the lm3532 device node for droid4. With this change the backlight LED string and the keypad LED strings will be controlled separately.
We also need the following incremental change to prevent panel-dsi-cm trying to use of_find_backlight_by_node(). We have ledtrig-backlight use FB_EVENT_BLANK, and I guess more events can be added there as needed.
There should be no dependency to the driver changes with this patch, so it's probably best that I queue this dts patch separately. I'll fold in the following change too assuming no more comments.
Regards,
Tony
8< -----------------
arch/arm/boot/dts/omap4-droid4-xt894.dts +0 -1
@@ -214,7 +214,6 @@ width-mm = <50>; height-mm = <89>; - backlight = <&lcd_backlight>; panel-timing { clock-frequency = <0>; /* Calculated by dsi */
Re: [PATCH 2/4] ARM: dts: omap4-droid4: Update backlight dt properties
In reply to Dan MurphyTony,
Quoted 34 lines · Dan Murphy
Update the properties for the lm3532 device node for droid4. With this change the backlight LED string and the keypad LED strings will be controlled separately.
Signed-off-by Dan Murphy <[email protected]>---
v5 - No change - https://lore.kernel.org/patchwork/patch/1050409/
v4 - No change - https://lore.kernel.org/patchwork/patch/1050125/
v3 - updated keypad label on v1 comment - https://lore.kernel.org/patchwork/patch/1049023/
v2 - Fixed ramp-up and ramp-down properties, removed hard coded property values,
I did not change the label as it is undecided what it could be - https://lore.kernel.org/patchwork/patch/1048806/arch/arm/boot/dts/omap4-droid4-xt894.dts | 26 ++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-)arch/arm/boot/dts/omap4-droid4-xt894.dts +3
-1@@ -383,20 +383,30 @@ }; &i2c1 { - lm3532@38 { + led-controller@38 { compatible = "ti,lm3532"; + #address-cells = <1>; + #size-cells = <0>; reg = <0x38>; enable-gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>;
arch/arm/boot/dts/omap4-droid4-xt894.dts line 399
Quoted 10 lines
arch/arm/boot/dts/omap4-droid4-xt894.dts +2
-7- lcd_backlight: backlight { - compatible = "ti,lm3532-backlight"; + ramp-up-us = <1024>; + ramp-down-us = <8193>; - lcd { - led-sources = <0 1 2>; - ramp-up-msec = <1>; - ramp-down-msec = <0>; - };
Since I'll be creating integration branch for this series, and it would be good to have this patch in it too, then I can do the amendments by myself:
arch/arm/boot/dts/omap4-droid4-xt894.dts line 401
Quoted 5 lines
arch/arm/boot/dts/omap4-droid4-xt894.dts +5
-0+ lcd_backlight: led@0 { + reg = <0>; + led-sources = <2>; + ti,led-mode = <0>; + label = "backlight";
s/backlight/:backlight/
arch/arm/boot/dts/omap4-droid4-xt894.dts line 409
Quoted 8 lines
arch/arm/boot/dts/omap4-droid4-xt894.dts +8
-0+ linux,default-trigger = "backlight"; + }; + + led@1 { + reg = <1>; + led-sources = <1>; + ti,led-mode = <0>; + label = "platform::kbd_backlight";
s/platform::kbd_backlight/:kbd_backlight/
and then send you a pull request.
Would you be OK with that?
Quoted 4 lines
arch/arm/boot/dts/omap4-droid4-xt894.dts +0
-0}; }; };
Signature · 2 lines
Best regards, Jacek Anaszewski
Tony Lindgren
Acked-byRe: [PATCH 2/4] ARM: dts: omap4-droid4: Update backlight dt properties
Quoted 56 lines · Jacek Anaszewski
Tony,
Quoted 30 lines · Dan Murphy
Update the properties for the lm3532 device node for droid4. With this change the backlight LED string and the keypad LED strings will be controlled separately.
Signed-off-by Dan Murphy <[email protected]>---
v5 - No change - https://lore.kernel.org/patchwork/patch/1050409/
v4 - No change - https://lore.kernel.org/patchwork/patch/1050125/
v3 - updated keypad label on v1 comment - https://lore.kernel.org/patchwork/patch/1049023/
v2 - Fixed ramp-up and ramp-down properties, removed hard coded property values,
I did not change the label as it is undecided what it could be - https://lore.kernel.org/patchwork/patch/1048806/arch/arm/boot/dts/omap4-droid4-xt894.dts | 26 ++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-)arch/arm/boot/dts/omap4-droid4-xt894.dts +3
-1@@ -383,20 +383,30 @@ }; &i2c1 { - lm3532@38 { + led-controller@38 { compatible = "ti,lm3532"; + #address-cells = <1>; + #size-cells = <0>; reg = <0x38>;arch/arm/boot/dts/omap4-droid4-xt894.dts line 395
Quoted 10 lines
arch/arm/boot/dts/omap4-droid4-xt894.dts +2
-7enable-gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>; - lcd_backlight: backlight { - compatible = "ti,lm3532-backlight"; + ramp-up-us = <1024>; + ramp-down-us = <8193>; - lcd { - led-sources = <0 1 2>; - ramp-up-msec = <1>; - ramp-down-msec = <0>; - };Since I'll be creating integration branch for this series, and it would be good to have this patch in it too, then I can do the amendments by myself:
arch/arm/boot/dts/omap4-droid4-xt894.dts line 397
Quoted 5 lines
arch/arm/boot/dts/omap4-droid4-xt894.dts +5
-0+ lcd_backlight: led@0 { + reg = <0>; + led-sources = <2>; + ti,led-mode = <0>; + label = "backlight";s/backlight/:backlight/
Quoted 10 lines
arch/arm/boot/dts/omap4-droid4-xt894.dts line 405
Quoted 8 lines
arch/arm/boot/dts/omap4-droid4-xt894.dts +8
-0+ linux,default-trigger = "backlight"; + }; + + led@1 { + reg = <1>; + led-sources = <1>; + ti,led-mode = <0>; + label = "platform::kbd_backlight";s/platform::kbd_backlight/:kbd_backlight/
Yes makes sense to me.
Quoted 3 lines
and then send you a pull request.
Would you be OK with that?
Sure go for it. Here's my ack for the changes:
And then for the one liner to fold in below:
8< -------------
arch/arm/boot/dts/omap4-droid4-xt894.dts +0 -1
@@ -214,7 +214,6 @@ width-mm = <50>; height-mm = <89>; - backlight = <&lcd_backlight>; panel-timing { clock-frequency = <0>; /* Calculated by dsi */
Re: [PATCH 2/4] ARM: dts: omap4-droid4: Update backlight dt properties
Quoted 88 lines · Tony Lindgren
Quoted 56 lines · Jacek Anaszewski
Tony,
Quoted 30 lines · Dan Murphy
Update the properties for the lm3532 device node for droid4. With this change the backlight LED string and the keypad LED strings will be controlled separately.
Signed-off-by Dan Murphy <[email protected]>---
v5 - No change - https://lore.kernel.org/patchwork/patch/1050409/
v4 - No change - https://lore.kernel.org/patchwork/patch/1050125/
v3 - updated keypad label on v1 comment - https://lore.kernel.org/patchwork/patch/1049023/
v2 - Fixed ramp-up and ramp-down properties, removed hard coded property values,
I did not change the label as it is undecided what it could be - https://lore.kernel.org/patchwork/patch/1048806/arch/arm/boot/dts/omap4-droid4-xt894.dts | 26 ++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-)arch/arm/boot/dts/omap4-droid4-xt894.dts +3
-1@@ -383,20 +383,30 @@ }; &i2c1 { - lm3532@38 { + led-controller@38 { compatible = "ti,lm3532"; + #address-cells = <1>; + #size-cells = <0>; reg = <0x38>;arch/arm/boot/dts/omap4-droid4-xt894.dts line 395
Quoted 10 lines
arch/arm/boot/dts/omap4-droid4-xt894.dts +2
-7enable-gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>; - lcd_backlight: backlight { - compatible = "ti,lm3532-backlight"; + ramp-up-us = <1024>; + ramp-down-us = <8193>; - lcd { - led-sources = <0 1 2>; - ramp-up-msec = <1>; - ramp-down-msec = <0>; - };Since I'll be creating integration branch for this series, and it would be good to have this patch in it too, then I can do the amendments by myself:
arch/arm/boot/dts/omap4-droid4-xt894.dts line 397
Quoted 5 lines
arch/arm/boot/dts/omap4-droid4-xt894.dts +5
-0+ lcd_backlight: led@0 { + reg = <0>; + led-sources = <2>; + ti,led-mode = <0>; + label = "backlight";s/backlight/:backlight/
Quoted 10 lines
arch/arm/boot/dts/omap4-droid4-xt894.dts line 405
Quoted 8 lines
arch/arm/boot/dts/omap4-droid4-xt894.dts +8
-0+ linux,default-trigger = "backlight"; + }; + + led@1 { + reg = <1>; + led-sources = <1>; + ti,led-mode = <0>; + label = "platform::kbd_backlight";s/platform::kbd_backlight/:kbd_backlight/
Yes makes sense to me.
Quoted 3 lines
and then send you a pull request.
Would you be OK with that?
Sure go for it. Here's my ack for the changes:
Acked-by Tony Lindgren <[email protected]>And then for the one liner to fold in below:
Signed-off-by Tony Lindgren <[email protected]>8< -------------
arch/arm/boot/dts/omap4-droid4-xt894.dts line 219
Quoted 7 lines
arch/arm/boot/dts/omap4-droid4-xt894.dts +0
-1@@ -214,7 +214,6 @@ width-mm = <50>; height-mm = <89>; - backlight = <&lcd_backlight>; panel-timing { clock-frequency = <0>; /* Calculated by dsi */
Folded in, thanks. Beside that, I also removed lcd_backlight DT labels from both DT bindings and dts, since it is now unused and misleading.
Signature · 2 lines
Best regards, Jacek Anaszewski
PATCH 3/4 mfd: ti-lmu: Remove LM3532 backlight driver references
In reply to Dan MurphyRemove the LM3532 backlight driver references from the ti-lmu code as dedicated driver support is available.
---
v5 - No changes - https://lore.kernel.org/patchwork/patch/1050411/
v4 - No changes - https://lore.kernel.org/patchwork/patch/1050123/
v3 - No changes - https://lore.kernel.org/patchwork/patch/1049025/
v2 - Removed LM3532 register definitions from ti-lmu-register - https://lore.kernel.org/patchwork/patch/1048808/
drivers/mfd/ti-lmu.c | 11 -------- include/linux/mfd/ti-lmu-register.h | 44 ----------------------------- include/linux/mfd/ti-lmu.h | 1 - 3 files changed, 56 deletions(-)
drivers/mfd/ti-lmu.c +0 -11
@@ -54,14 +54,6 @@ static void ti_lmu_disable_hw(void *data)gpiod_set_value (lmu->en_gpio,0 ); } -static const struct mfd_cell lm3532_devices[] = { - { - .name ="ti-lmu-backlight" , - .id =LM3532 , - .of_compatible ="ti,lm3532-backlight" , - }, -}; -#define LM363X_REGULATOR (_id) \ { \ .name = "lm363x-regulator", \
@@ -141,7 +133,6 @@ static const struct ti_lmu_data chip##_data = \ .max_register = max_reg, \ } \ -TI_LMU_DATA (lm3532,LM3532_MAX_REG );TI_LMU_DATA (lm3631,LM3631_MAX_REG );TI_LMU_DATA (lm3632,LM3632_MAX_REG );TI_LMU_DATA (lm3633,LM3633_MAX_REG );
@@ -211,7 +202,6 @@ static int ti_lmu_probe(struct i2c_client *cl, const struct i2c_device_id *id) }static const struct of_device_id ti_lmu_of_match[] = { - { .compatible ="ti,lm3532" , .data = &lm3532_data }, { .compatible ="ti,lm3631" , .data = &lm3631_data }, { .compatible ="ti,lm3632" , .data = &lm3632_data }, { .compatible ="ti,lm3633" , .data = &lm3633_data },
@@ -222,7 +212,6 @@ static const struct of_device_id ti_lmu_of_match[] = {MODULE_DEVICE_TABLE (of, ti_lmu_of_match);static const struct i2c_device_id ti_lmu_ids[] = { - {"lm3532" ,LM3532 }, {"lm3631" ,LM3631 }, {"lm3632" ,LM3632 }, {"lm3633" ,LM3633 },
include/linux/mfd/ti-lmu-register.h +0 -44
50 lines not on this page · raw message
include/linux/mfd/ti-lmu.h +0 -1
@@ -22,7 +22,6 @@#define LMU_EVENT_MONITOR_DONE 0x01enum ti_lmu_id { -LM3532 ,LM3631 ,LM3632 ,LM3633 ,
Signature · 1 line
2.21.0.5.gaeb582a983
Re: [PATCH 3/4] mfd: ti-lmu: Remove LM3532 backlight driver references
Hi Lee,
Can we have your ack for this going via LED tree, please?
Best regards,
Jacek Anaszewski
Quoted 16 lines · Dan Murphy
Remove the LM3532 backlight driver references from the ti-lmu code as dedicated driver support is available.
Signed-off-by Dan Murphy <[email protected]>---
v5 - No changes - https://lore.kernel.org/patchwork/patch/1050411/
v4 - No changes - https://lore.kernel.org/patchwork/patch/1050123/
v3 - No changes - https://lore.kernel.org/patchwork/patch/1049025/
v2 - Removed LM3532 register definitions from ti-lmu-register - https://lore.kernel.org/patchwork/patch/1048808/drivers/mfd/ti-lmu.c | 11 -------- include/linux/mfd/ti-lmu-register.h | 44 ----------------------------- include/linux/mfd/ti-lmu.h | 1 - 3 files changed, 56 deletions(-)
[...]
Re: [PATCH 3/4] mfd: ti-lmu: Remove LM3532 backlight driver references
Quoted 3 lines · Jacek Anaszewski
Hi Lee,
Can we have your ack for this going via LED tree, please?
Patch looks okay.
You can take it through the LED, but if you do I will need you to send me a pull-request to a minimised immutable branch please.
If you cannot do this, I can apply the set and provide the same to you.
If you choose the former:
Please let me know what you decide
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 3/4] mfd: ti-lmu: Remove LM3532 backlight driver references
Quoted 11 lines · Lee Jones
Quoted 3 lines · Jacek Anaszewski
Hi Lee,
Can we have your ack for this going via LED tree, please?
Patch looks okay.
You can take it through the LED, but if you do I will need you to send me a pull-request to a minimised immutable branch please.
Quoted 9 lines
If you cannot do this, I can apply the set and provide the same to you.
If you choose the former:
Acked-for-MFD-by Lee Jones <[email protected]>Please let me know what you decide
I've been exposing integration branches in the past, but after Linus' message [0] I have my doubts now. I wonder if it wouldn't make more sense if I just took the patches, and you'd cherry-pick them only in case such a need occurs. This way we would avoid this whole merge noise, which in an optimistic and very plausible case will not be needed at all.
[0] https://lkml.org/lkml/2017/4/19/1104
Signature · 2 lines
Best regards, Jacek Anaszewski
Re: [PATCH 3/4] mfd: ti-lmu: Remove LM3532 backlight driver references
Quoted 22 lines · Jacek Anaszewski
Quoted 11 lines · Lee Jones
Quoted 3 lines · Jacek Anaszewski
Hi Lee,
Can we have your ack for this going via LED tree, please?
Patch looks okay.
You can take it through the LED, but if you do I will need you to send me a pull-request to a minimised immutable branch please.
Quoted 9 lines
If you cannot do this, I can apply the set and provide the same to you.
If you choose the former:
Acked-for-MFD-by Lee Jones <[email protected]>Please let me know what you decide
Quoted 8 lines
I've been exposing integration branches in the past, but after Linus' message [0] I have my doubts now. I wonder if it wouldn't make more sense if I just took the patches, and you'd cherry-pick them only in case such a need occurs. This way we would avoid this whole merge noise, which in an optimistic and very plausible case will not be needed at all.
That email is 2 years old, and does not seem relevant to what we're trying to achieve. I've only ever had issues when *not* creating immutable branches for these, cross subsystem scenarios. The shared branches I create are always minimalist and never change.
I'm happy to take the patches and create a suitable pull-request for you if you are uncomfortable with the process. I just need your Ack to do so. Up to you.
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 3/4] mfd: ti-lmu: Remove LM3532 backlight driver references
Quoted 33 lines · Lee Jones
Quoted 22 lines · Jacek Anaszewski
Quoted 11 lines · Lee Jones
Quoted 3 lines · Jacek Anaszewski
Hi Lee,
Can we have your ack for this going via LED tree, please?
Patch looks okay.
You can take it through the LED, but if you do I will need you to send me a pull-request to a minimised immutable branch please.
Quoted 9 lines
If you cannot do this, I can apply the set and provide the same to you.
If you choose the former:
Acked-for-MFD-by Lee Jones <[email protected]>Please let me know what you decide
Quoted 8 lines
I've been exposing integration branches in the past, but after Linus' message [0] I have my doubts now. I wonder if it wouldn't make more sense if I just took the patches, and you'd cherry-pick them only in case such a need occurs. This way we would avoid this whole merge noise, which in an optimistic and very plausible case will not be needed at all.
Quoted 8 lines
That email is 2 years old, and does not seem relevant to what we're trying to achieve. I've only ever had issues when *not* creating immutable branches for these, cross subsystem scenarios. The shared branches I create are always minimalist and never change.
I'm happy to take the patches and create a suitable pull-request for you if you are uncomfortable with the process. I just need your Ack to do so. Up to you.
I don't have any problem with the process. The clear gain of cherry picking is more linear history. And the branch can be always created when such a need occurs in linux-next.
That being said, I will send you a pull request once we sort out the problem with obtaining a reference to the backlight node.
Signature · 2 lines
Best regards, Jacek Anaszewski
Re: [PATCH 3/4] mfd: ti-lmu: Remove LM3532 backlight driver references
Quoted 43 lines · Jacek Anaszewski
Quoted 33 lines · Lee Jones
Quoted 22 lines · Jacek Anaszewski
Quoted 11 lines · Lee Jones
Quoted 3 lines · Jacek Anaszewski
Hi Lee,
Can we have your ack for this going via LED tree, please?
Patch looks okay.
You can take it through the LED, but if you do I will need you to send me a pull-request to a minimised immutable branch please.
Quoted 9 lines
If you cannot do this, I can apply the set and provide the same to you.
If you choose the former:
Acked-for-MFD-by Lee Jones <[email protected]>Please let me know what you decide
Quoted 8 lines
I've been exposing integration branches in the past, but after Linus' message [0] I have my doubts now. I wonder if it wouldn't make more sense if I just took the patches, and you'd cherry-pick them only in case such a need occurs. This way we would avoid this whole merge noise, which in an optimistic and very plausible case will not be needed at all.
Quoted 8 lines
That email is 2 years old, and does not seem relevant to what we're trying to achieve. I've only ever had issues when *not* creating immutable branches for these, cross subsystem scenarios. The shared branches I create are always minimalist and never change.
I'm happy to take the patches and create a suitable pull-request for you if you are uncomfortable with the process. I just need your Ack to do so. Up to you.
Quoted 6 lines
I don't have any problem with the process. The clear gain of cherry picking is more linear history. And the branch can be always created when such a need occurs in linux-next.
That being said, I will send you a pull request once we sort out the problem with obtaining a reference to the backlight node.
Sounds good. Thanks Jacek.
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 3/4] mfd: ti-lmu: Remove LM3532 backlight driver references
In reply to Dan MurphyQuoted 2 lines · Dan Murphy
Remove the LM3532 backlight driver references from the ti-lmu code as dedicated driver support is available.
PATCH 4/4 leds: lm3532: Introduce the lm3532 LED driver
In reply to Dan MurphyIntroduce the Texas Instruments LM3532 White LED driver. The driver supports ALS configurability or manual brightness control.
The driver also supports associating LED strings with specific control banks in a group or as individually controlled strings.
---
v5 - Added mutex_destroy in remove - https://lore.kernel.org/patchwork/patch/1050410/
v4 - Updated code to DT doc changes appending "ti," to TI specific properties -
https://lore.kernel.org/patchwork/patch/1050124/
v3 - Removed switch case for register setting in favor of an algorithim (v1 comment),
https://lore.kernel.org/patchwork/patch/1049024/
v2 - Added look up tables for als_avg, als_imp and ramp times, fixed brightness control when ALS is in control, added property value checks to ensure the values are not out of bounds - https://lore.kernel.org/patchwork/patch/1048807/
drivers/leds/Kconfig | 10 + drivers/leds/Makefile | 1 + drivers/leds/leds-lm3532.c | 683 +++++++++++++++++++++++++++++++++++++ 3 files changed, 694 insertions(+) create mode 100644 drivers/leds/leds-lm3532.c
drivers/leds/Kconfig +10 -0
@@ -138,6 +138,16 @@ config LEDS_LM3530 controlled manually or using PWM input or using ambient light automatically. +config LEDS_LM3532 + tristate "LCD Backlight driver for LM3532" + depends on LEDS_CLASS + depends on I2C + help + This option enables support for the LCD backlight using + LM3532 ambient light sensor chip. This ALS chip can be + controlled manually or using PWM input or using ambient + light automatically. + config LEDS_LM3533 tristate "LED support for LM3533" depends on LEDS_CLASS
drivers/leds/Makefile +1 -0
@@ -18,6 +18,7 @@ obj-$(CONFIG_LEDS_BD2802) += leds-bd2802.o obj-$(CONFIG_LEDS_CPCAP) += leds-cpcap.o obj-$(CONFIG_LEDS_LOCOMO) += leds-locomo.o obj-$(CONFIG_LEDS_LM3530) += leds-lm3530.o +obj-$(CONFIG_LEDS_LM3532) += leds-lm3532.o obj-$(CONFIG_LEDS_LM3533) += leds-lm3533.o obj-$(CONFIG_LEDS_LM3642) += leds-lm3642.o obj-$(CONFIG_LEDS_MIKROTIK_RB532) += leds-rb532.o
drivers/leds/leds-lm3532.c new file +683 -0
683 lines not on this page · raw message
Signature · 1 line
2.21.0.5.gaeb582a983
Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver
Hi,
Quoted 6 lines · Dan Murphy
Introduce the Texas Instruments LM3532 White LED driver. The driver supports ALS configurability or manual brightness control.
The driver also supports associating LED strings with specific control banks in a group or as individually controlled strings.
Thanks for getting this driver done. I need help a bit using this though.. What's the glue to the drm driver?
I can control the backlight brightness just fine via /sys, and backlight shows up as the trigger in /sys/class/leds/lm3532:backlight, but /sys/class/backlight is empty and looks like drm can't find it.
Do I need to enable some additional driver(s) to get this to work with the drm driver?
Regards,
Tony
Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver
Tony
Quoted 13 lines · Tony Lindgren
Hi,
Quoted 6 lines · Dan Murphy
Introduce the Texas Instruments LM3532 White LED driver. The driver supports ALS configurability or manual brightness control.
The driver also supports associating LED strings with specific control banks in a group or as individually controlled strings.
Thanks for getting this driver done. I need help a bit using this though.. What's the glue to the drm driver?
Quoted 7 lines
I can control the backlight brightness just fine via /sys, and backlight shows up as the trigger in /sys/class/leds/lm3532:backlight, but
/sys/class/backlightis empty and looks like drm can't find it.Do I need to enable some additional driver(s) to get this to work with the drm driver?
Can you dump or point to the defconfig?
Dan
Quoted 4 lines
Regards,
Tony
Signature · 2 lines
------------------ Dan Murphy
Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver
Quoted 10 lines · Dan Murphy
Quoted 7 lines · Tony Lindgren
I can control the backlight brightness just fine via /sys, and backlight shows up as the trigger in /sys/class/leds/lm3532:backlight, but
/sys/class/backlightis empty and looks like drm can't find it.Do I need to enable some additional driver(s) to get this to work with the drm driver?
Can you dump or point to the defconfig?
This is just with the omap2plus_defconfig as in the droid4-pending-v5.0 test branch below [0]. That branch has Sebastian's drm patches. The branch also has the older ti-lmu patches that I reverted for testing before applying your new series and enabling it in .config.
The drm driver (drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c) just does:
backlight = of_parse_phandle(node, "backlight", 0);
...
That should still work the same, right?
Regards,
Tony
[0] https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git/log/?h=droid4-pending-v5.0
Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver
Quoted 17 lines · Tony Lindgren
Quoted 10 lines · Dan Murphy
Quoted 7 lines · Tony Lindgren
I can control the backlight brightness just fine via /sys, and backlight shows up as the trigger in /sys/class/leds/lm3532:backlight, but
/sys/class/backlightis empty and looks like drm can't find it.Do I need to enable some additional driver(s) to get this to work with the drm driver?
Can you dump or point to the defconfig?
This is just with the
omap2plus_defconfigas in the droid4-pending-v5.0 test branch below [0]. That branch has Sebastian's drm patches. The branch also has the older ti-lmu patches that I reverted for testing before applying your new series and enabling it in .config.
Quoted 7 lines
The drm driver (
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c) just does:backlight =
of_parse_phandle(node, "backlight", 0);
...That should still work the same, right?
Yes it should still work the same.
I did not change the node name.
So the DRM driver should find the node.
Dan
Quoted 8 lines
Regards,
Tony
[0] https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git/log/?h=droid4-pending-v5.0
Signature · 2 lines
------------------ Dan Murphy
Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver
Hi,
Quoted 21 lines · Dan Murphy
Quoted 20 lines · Tony Lindgren
Quoted 10 lines · Dan Murphy
Quoted 7 lines · Tony Lindgren
I can control the backlight brightness just fine via /sys, and backlight shows up as the trigger in /sys/class/leds/lm3532:backlight, but
/sys/class/backlightis empty and looks like drm can't find it.Do I need to enable some additional driver(s) to get this to work with the drm driver?
Can you dump or point to the defconfig?
This is just with the
omap2plus_defconfigas in the droid4-pending-v5.0 test branch below [0]. That branch has Sebastian's drm patches. The branch also has the older ti-lmu patches that I reverted for testing before applying your new series and enabling it in .config.The drm driver (
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c) just does:
Quoted 8 lines
Quoted 4 lines
backlight =
of_parse_phandle(node, "backlight", 0);
...That should still work the same, right?
Yes it should still work the same.
I did not change the node name.
So the DRM driver should find the node.
This will not work, since the next line tries to get it as a backlight device, but it's an LED device instead:
of_find_backlight_by_node(backlight);
I suppose the backlight device could be instantiated on top of the LED device somehow.
(sorry for slow responses; I'm quite busy right now)
-- Sebastian
Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver
Quoted 33 lines · Sebastian Reichel
Hi,
Quoted 21 lines · Dan Murphy
Quoted 20 lines · Tony Lindgren
Quoted 10 lines · Dan Murphy
Quoted 7 lines · Tony Lindgren
I can control the backlight brightness just fine via /sys, and backlight shows up as the trigger in /sys/class/leds/lm3532:backlight, but
/sys/class/backlightis empty and looks like drm can't find it.Do I need to enable some additional driver(s) to get this to work with the drm driver?
Can you dump or point to the defconfig?
This is just with the
omap2plus_defconfigas in the droid4-pending-v5.0 test branch below [0]. That branch has Sebastian's drm patches. The branch also has the older ti-lmu patches that I reverted for testing before applying your new series and enabling it in .config.The drm driver (
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c) just does:Quoted 8 lines
Quoted 4 lines
backlight =
of_parse_phandle(node, "backlight", 0);
...That should still work the same, right?
Yes it should still work the same.
I did not change the node name.
So the DRM driver should find the node.
Quoted 7 lines
This will not work, since the next line tries to get it as a backlight device, but it's an LED device instead:
of_find_backlight_by_node(backlight);I suppose the backlight device could be instantiated on top of the LED device somehow.
Hmm yeah I thought setting the ledtrig-backlight for it would do the trick. But after thinking about it there might be some backlight lifecycle issues with that where everything would need to be torn down for the panel to change the backlight trigger. I think the panel driver(s) assume the backlight to always be there at probe time. Well this is just based on just guessing.. I might be wrong.
I have no issues using of_find_backlight_by_node() like other panels.
Quoted 1 line
(sorry for slow responses; I'm quite busy right now)
No problem.
Regards,
Tony
Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver
Quoted 50 lines · Tony Lindgren
Quoted 33 lines · Sebastian Reichel
Hi,
Quoted 21 lines · Dan Murphy
Quoted 20 lines · Tony Lindgren
Quoted 10 lines · Dan Murphy
Quoted 7 lines · Tony Lindgren
I can control the backlight brightness just fine via /sys, and backlight shows up as the trigger in /sys/class/leds/lm3532:backlight, but
/sys/class/backlightis empty and looks like drm can't find it.Do I need to enable some additional driver(s) to get this to work with the drm driver?
Can you dump or point to the defconfig?
This is just with the
omap2plus_defconfigas in the droid4-pending-v5.0 test branch below [0]. That branch has Sebastian's drm patches. The branch also has the older ti-lmu patches that I reverted for testing before applying your new series and enabling it in .config.The drm driver (
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c) just does:Quoted 8 lines
Quoted 4 lines
backlight =
of_parse_phandle(node, "backlight", 0);
...That should still work the same, right?
Yes it should still work the same.
I did not change the node name.
So the DRM driver should find the node.Quoted 7 lines
This will not work, since the next line tries to get it as a backlight device, but it's an LED device instead:
of_find_backlight_by_node(backlight);I suppose the backlight device could be instantiated on top of the LED device somehow.
Hmm yeah I thought setting the ledtrig-backlight for it would do the trick. But after thinking about it there might be some backlight lifecycle issues with that where everything would need to be torn down for the panel to change the backlight trigger. I think the panel driver(s) assume the backlight to always be there at probe time. Well this is just based on just guessing.. I might be wrong.
Quoted 2 lines
I have no issues using
of_find_backlight_by_node()like other panels.
Oh sorry, I did not read the code before replying. I somehow thought of_find_backlight_by_node() should be used for LEDs but that's for backlight still :)
Looks like all we need to do is leave out the backlight line from dts, we don't need to do anything with of_find_backlight_by_node(). Having ledtrig-backlight configured means lm3532 will just use the notifier for FB_EVENT_BLANK.
I'll reply to the dts patch and ack the test, looks like we're good to go as far as I'm concerned.
Regards,
Tony
Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver
In reply to Dan MurphyQuoted 6 lines · Dan Murphy
Introduce the Texas Instruments LM3532 White LED driver. The driver supports ALS configurability or manual brightness control.
The driver also supports associating LED strings with specific control banks in a group or as individually controlled strings.
I'm seeing slightly different naming under /sys/class/leds:
lm3532:backlight
lm3532:platform::kbd_backlight
Not sure if this is correct with the the "platform" and "::" there for the kbd_backlight?
With the dts change I posted, I've tested this with linux-next and Sebastian's DSI command mode patches "[PATCHv6 0/4] omapdrm: DSI command mode panel support".
So feel free to add:
Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver
Hi Tony,
Thanks for the feedback.
Quoted 5 lines · Tony Lindgren
Quoted 4 lines · Dan Murphy
Introduce the Texas Instruments LM3532 White LED driver. The driver supports ALS configurability or manual brightness control.
Quoted 7 lines
Quoted 2 lines
The driver also supports associating LED strings with specific control banks in a group or as individually controlled strings.
I'm seeing slightly different naming under
/sys/class/leds:lm3532:backlight
lm3532:platform::kbd_backlight
The problem is in the "platform:" being a part of DT label property. It should not be included there if devicename section is added in the driver.
Quoted 12 lines
Not sure if this is correct with the the "platform" and "::" there for the
kbd_backlight?With the dts change I posted, I've tested this with linux-next and Sebastian's DSI command mode patches "[PATCHv6 0/4] omapdrm: DSI command mode panel support".
So feel free to add:
Tested-by Tony Lindgren <[email protected]>
Signature · 2 lines
Best regards, Jacek Anaszewski
Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver
Tony
Quoted 13 lines · Jacek Anaszewski
Hi Tony,
Thanks for the feedback.
Quoted 8 lines · Tony Lindgren
Quoted 6 lines · Dan Murphy
Introduce the Texas Instruments LM3532 White LED driver. The driver supports ALS configurability or manual brightness control.
The driver also supports associating LED strings with specific control banks in a group or as individually controlled strings.
Quoted 9 lines
Quoted 4 lines
I'm seeing slightly different naming under
/sys/class/leds:lm3532:backlight
lm3532:platform::kbd_backlightThe problem is in the "platform:" being a part of DT label property. It should not be included there if devicename section is added in the driver.
Feel free to make it whatever you want I am not married to the naming convention for Droid 4. It was a suggestion in the code review
https://lore.kernel.org/patchwork/patch/1048806/
<snip>
Signature · 2 lines
------------------ Dan Murphy
All
Quoted 21 lines · Dan Murphy
Add the lm3532 device tree documentation.
Remove lm3532 device tree reference from theti_lmudevicetree documentation.With the addition of the dedicated lm3532 documentation the device can be removed from the ti_lmu.txt.
The reason for this is that the lm3532 dt documentation now defines the ability to control LED output strings against different control banks or groups multiple strings to be controlled by a single control bank.
Another addition was for ALS lighting control and configuration. The LM3532 has a feature that can take in the ALS reading from 2 separate ALS devices and adjust the brightness on the strings that are configured to support this feature.
Finally the device specific properties were moved to the parent node as these properties are not control bank configurable. These include the runtime ramp and the ALS configuration.
Quoted 7 lines
Reviewed-by Rob Herring <[email protected]>Signed-off-by Dan Murphy <[email protected]>---
v5 - Moved ramping range to below property definition, updated keyboard label -
https://lore.kernel.org/patchwork/patch/1050412/
<snip>
I missed the v5 in $subject
But this patch set is v5
Dan
Signature · 2 lines
------------------ Dan Murphy
Quoted 34 lines · Dan Murphy
Add the lm3532 device tree documentation.
Remove lm3532 device tree reference from theti_lmudevicetree documentation.With the addition of the dedicated lm3532 documentation the device can be removed from the ti_lmu.txt.
The reason for this is that the lm3532 dt documentation now defines the ability to control LED output strings against different control banks or groups multiple strings to be controlled by a single control bank.
Another addition was for ALS lighting control and configuration. The LM3532 has a feature that can take in the ALS reading from 2 separate ALS devices and adjust the brightness on the strings that are configured to support this feature.
Finally the device specific properties were moved to the parent node as these properties are not control bank configurable. These include the runtime ramp and the ALS configuration.
Reviewed-by Rob Herring <[email protected]>Signed-off-by Dan Murphy <[email protected]>---
v5 - Moved ramping range to below property definition, updated keyboard label -
https://lore.kernel.org/patchwork/patch/1050412/v4 - Appended "ti," to TI specific properties, add enable gpio documentation,
removed an example, moved ramp to optional parent properties - https://lore.kernel.org/patchwork/patch/1050122/
v3 - No changes - https://lore.kernel.org/patchwork/patch/1049026/
v2 - Fixed ramp-up and ramp-down properties, removed hard coded property values,
added ranges for variable properties, I did not change the label - https://lore.kernel.org/patchwork/patch/1048805/
Quoted 4 lines
.../devicetree/bindings/leds/leds-lm3532.txt | 101 ++++++++++++++++++ .../devicetree/bindings/mfd/ti-lmu.txt | 20 ---- 2 files changed, 101 insertions(+), 20 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3532.txt
Same for this patch:
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Quoted 12 lines · Dan Murphy
Add the lm3532 device tree documentation.
Remove lm3532 device tree reference from theti_lmudevicetree documentation.With the addition of the dedicated lm3532 documentation the device can be removed from the ti_lmu.txt.
The reason for this is that the lm3532 dt documentation now defines the ability to control LED output strings against different control banks or groups multiple strings to be controlled by a single control bank.
Quoted 8 lines
Another addition was for ALS lighting control and configuration. The LM3532 has a feature that can take in the ALS reading from 2 separate ALS devices and adjust the brightness on the strings that are configured to support this feature.
Finally the device specific properties were moved to the parent node as these properties are not control bank configurable. These include the runtime ramp and the ALS configuration.
Hi Dan,
Quoted 17 lines · Dan Murphy
Add the lm3532 device tree documentation.
Remove lm3532 device tree reference from theti_lmudevicetree documentation.With the addition of the dedicated lm3532 documentation the device can be removed from the ti_lmu.txt.
The reason for this is that the lm3532 dt documentation now defines the ability to control LED output strings against different control banks or groups multiple strings to be controlled by a single control bank.
Another addition was for ALS lighting control and configuration. The LM3532 has a feature that can take in the ALS reading from 2 separate ALS devices and adjust the brightness on the strings that are configured to support this feature.
Quoted 7 lines
Finally the device specific properties were moved to the parent node as these properties are not control bank configurable. These include the runtime ramp and the ALS configuration.
Reviewed-by Rob Herring <[email protected]>Signed-off-by Dan Murphy <[email protected]>---
Thank you for your work on this set. Applied.
Signature · 2 lines
Best regards, Jacek Anaszewski