Skip to contentSkip to conversation

x86/cpuid: Half revert "x86/cpuid: Drop special_features[]"

PATCH In review Andrew Cooper 2 participants 2 messages Jun 8, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/cpuid: Half revert "x86/cpuid: Drop special_features[]"

xen-cpuid does print out the list of special features, and this is helpful to keep.

Fixes ba6950fb070 ("x86/cpuid: Drop special_features[]")

---
CC: Jan Beulich <[email protected]>
CC: Roger Pau Monné <[email protected]>
CC: Wei Liu <[email protected]>
CC: Sander Eikelenboom <[email protected]>

Note - this deliberately doesn't insert ifdefary, because it is pointless. It adds to constructing/parsing time, and nothing in Xen can gain access to this without an explicit introduction of INIT_SPECIAL_FEATURES again, which will be obvious during code review.

---
 xen/tools/gen-cpuid.py | 3 +++
 1 file changed, 3 insertions(+)
xen/tools/gen-cpuid.py +3 -0
index c6b5056a8d..b953648b65 100755
@@ -362,6 +362,8 @@ def write_results(state):
 
 #define INIT_KNOWN_FEATURES { \\\n%s\n}
 
+#define INIT_SPECIAL_FEATURES { \\\n%s\n}
+
 #define INIT_PV_DEF_FEATURES { \\\n%s\n}
 
 #define INIT_PV_MAX_FEATURES { \\\n%s\n}
@@ -382,6 +384,7 @@ def write_results(state):
 """ % (state.nr_entries,
        next(featureset_to_uint32s(state.common_1d, 1)),
        format_uint32s(state, state.names.keys(), 4),
+       format_uint32s(state, state.raw['!'], 4),
        format_uint32s(state, state.pv_def, 4),
        format_uint32s(state, state.pv_max, 4),
        format_uint32s(state, state.hvm_shadow_def, 4),
Signature · 1 line
2.11.0