Skip to contentSkip to conversation

tty: serial: add missing clk_put()

PATCH In review [email protected] 3 participants 3 messages Jul 18, 2023 1 message not in the archive TTY layer and serial drivers

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 tty: serial: add missing clk_put()

This patch fixes the following Coccinelle error:

./drivers/tty/serial/bcm63xx_uart.c:854:2-8: ERROR: missing clk_put; clk_get on line 849 and execution via conditional on line 853

---
 drivers/tty/serial/bcm63xx_uart.c | 1 +
 1 file changed, 1 insertion(+)
drivers/tty/serial/bcm63xx_uart.c +1 -0
index 55e82d0bf92d..7353b683952d 100644
@@ -851,6 +851,7 @@ static int bcm_uart_probe(struct platform_device *pdev)
         clk = of_clk_get(pdev->dev.of_node, 0);
 
     if (IS_ERR(clk))
+        clk_put(clk);
         return -ENODEV;
 
     port->iotype = UPIO_MEM;
#2 lore raw
Quoted 15 lines · On 18/07/2023 10:55, [email protected] wrote:

This patch fixes the following Coccinelle error:

./drivers/tty/serial/bcm63xx_uart.c:854:2-8: ERROR: missing clk_put; clk_get on line 849 and execution via conditional on line 853

---
  drivers/tty/serial/bcm63xx_uart.c | 1 +
  1 file changed, 1 insertion(+)
drivers/tty/serial/bcm63xx_uart.c +0 -0
index 55e82d0bf92d..7353b683952d 100644

drivers/tty/serial/bcm63xx_uart.c static int bcm_uart_probe(struct platform_device *pdev) · line 854

Quoted 4 lines
drivers/tty/serial/bcm63xx_uart.c +1 -0
@@ -851,6 +851,7 @@ static int bcm_uart_probe(struct platform_device *pdev)
          clk = of_clk_get(pdev->dev.of_node, 0);
 
      if (IS_ERR(clk))
+        clk_put(clk);

No!

First, calling clk_put() on the error pointer is incorrect. This will throw a warning in __clk_put(), but generally passing an error pointer to another function can cause different kinds of breakage.

Second, you have added the line, but this also moved the return statement out of the if condition. This way all bcm_uart_probe() calls will end up with -ENODEV return value.

Please stop blindly fixing the coccinelle warnings. Take care to read and understand the code.

Quoted 3 lines
drivers/tty/serial/bcm63xx_uart.c +0 -0
          return -ENODEV;
 
      port->iotype = UPIO_MEM;
Signature · 2 lines
With best wishes
Dmitry
maintainer
#3 lore raw
In reply to [email protected]
Quoted 16 lines · On Tue, Jul 18, 2023 at 03:55:23PM +0800, [email protected] wrote:

This patch fixes the following Coccinelle error:

./drivers/tty/serial/bcm63xx_uart.c:854:2-8: ERROR: missing clk_put; clk_get on line 849 and execution via conditional on line 853

---
 drivers/tty/serial/bcm63xx_uart.c | 1 +
 1 file changed, 1 insertion(+)
drivers/tty/serial/bcm63xx_uart.c +0 -0
index 55e82d0bf92d..7353b683952d 100644

drivers/tty/serial/bcm63xx_uart.c static int bcm_uart_probe(struct platform_device *pdev) · line 857

Quoted 7 lines
drivers/tty/serial/bcm63xx_uart.c +1 -0
@@ -851,6 +851,7 @@ static int bcm_uart_probe(struct platform_device *pdev)
         clk = of_clk_get(pdev->dev.of_node, 0);
 
     if (IS_ERR(clk))
+        clk_put(clk);
         return -ENODEV;
 
     port->iotype = UPIO_MEM;

Ran, as was pointed out before, you obviously didn't even test this patch, nor any of the other submissions you made.

Please take the time to learn C a bit better, and then start out in a part of the kernel where basic changes are accepted, like drivers/staging/ so that you can learn how to properly send patches (this was incorrectly sent as well.)

Then you can work up to attempting to fix other changes like this, if they are correct, and you will know how to properly test your changes instead of just making rote changes like this without understanding the implications of them.

best of luck!

greg k-h