Skip to contentSkip to conversation

sym53c8xx_2 error handler fix

PATCH Applied Tony Battersby 2 participants 2 messages Nov 1, 2004 – Nov 17, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sym53c8xx_2 error handler fix

The sym53c8xx_2 driver in lk 2.4.x is unmaintained. This is a backported fix from lk 2.6.x for a problem with the error handler never successfully completing an abort, bus reset, device reset, or host reset. This patch has been well tested at my company. Please apply.

drivers/scsi/sym53c8xx_2/sym_glue.c +0 -2
@@ -1149,7 +1149,6 @@
 	switch(to_do) {
 	default:
 	case SYM_EH_DO_IGNORE:
-		goto finish;
 		break;
 	case SYM_EH_DO_WAIT:
 #if LINUX_VERSION_CODE > LinuxVersionCode(2,3,0)
@@ -1193,7 +1192,6 @@
 		to_do = SYM_EH_DO_IGNORE;
 	}
 
-finish:
 	ep->to_do = to_do;
 	/* Complete the command with locks held as required by the driver */
 	if (to_do == SYM_EH_DO_COMPLETE)

Anthony J. Battersby
Cybernetics

#1 lore raw

Tony,

I've applied all of your patches. Thanks!

Quoted 27 lines · Tony Battersby

The sym53c8xx_2 driver in lk 2.4.x is unmaintained. This is a backported fix from lk 2.6.x for a problem with the error handler never successfully completing an abort, bus reset, device reset, or host reset. This patch has been well tested at my company. Please apply.

drivers/scsi/sym53c8xx_2/sym_glue.c +0 -2
@@ -1149,7 +1149,6 @@
 	switch(to_do) {
 	default:
 	case SYM_EH_DO_IGNORE:
-		goto finish;
 		break;
 	case SYM_EH_DO_WAIT:
 #if LINUX_VERSION_CODE > LinuxVersionCode(2,3,0)
@@ -1193,7 +1192,6 @@
 		to_do = SYM_EH_DO_IGNORE;
 	}
 
-finish:
 	ep->to_do = to_do;
 	/* Complete the command with locks held as required by the driver */
 	if (to_do == SYM_EH_DO_COMPLETE)

Anthony J. Battersby
Cybernetics