Skip to contentSkip to conversation

igc: Remove phy->type checking

PATCH New Sasha Neftin 2 participants 2 messages Jul 10, 2021 – Jul 20, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 igc: Remove phy->type checking

i225 devices have only one phy->type: copper. There is no point checking phy->type during the igc_has_link method from the watchdog that invoked every 2 seconds.
This patch comes to clean up these pointless checkings.

---
 drivers/net/ethernet/intel/igc/igc_main.c | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)
drivers/net/ethernet/intel/igc/igc_main.c +4 -11
index c8abd7fb70e5..722b79ba2abd 100644
@@ -5222,17 +5222,10 @@ bool igc_has_link(struct igc_adapter *adapter)
 	 * false until the igc_check_for_link establishes link
 	 * for copper adapters ONLY
 	 */
-	switch (hw->phy.media_type) {
-	case igc_media_type_copper:
-		if (!hw->mac.get_link_status)
-			return true;
-		hw->mac.ops.check_for_link(hw);
-		link_active = !hw->mac.get_link_status;
-		break;
-	default:
-	case igc_media_type_unknown:
-		break;
-	}
+	if (!hw->mac.get_link_status)
+		return true;
+	hw->mac.ops.check_for_link(hw);
+	link_active = !hw->mac.get_link_status;
 
 	if (hw->mac.type == igc_i225) {
 		if (!netif_carrier_ok(adapter->netdev)) {
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 igc: Remove phy->type checking

Quoted 10 lines · Sasha Neftin

i225 devices have only one phy->type: copper. There is no point checking phy->type during the igc_has_link method from the watchdog that invoked every 2 seconds.
This patch comes to clean up these pointless checkings.

---
  drivers/net/ethernet/intel/igc/igc_main.c | 15 ++++-----------
  1 file changed, 4 insertions(+), 11 deletions(-)