Skip to contentSkip to conversation

led: bcm6328: read base address in the parent node

PATCH New Philippe Reynes 2 participants 2 messages Jun 28, 2018 – Jun 29, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 led: bcm6328: read base address in the parent node

In the device tree, the address for the led is located in the parent node (for exemple leds), not in the led node (for exemple led at 0).

The commit "led: bcm6328: convert to use live dt" (sha1: 899455176058d673887a762aa38853188a030af4) change this behaviour and read the address in the led node.

We fix this by reading the base address for led in the parent node.

---
 drivers/led/led_bcm6328.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/led/led_bcm6328.c +1 -1
index a29e5a0..7be4bad 100644
@@ -173,7 +173,7 @@ static int bcm6328_led_probe(struct udevice *dev)
 		struct bcm6328_led_priv *priv = dev_get_priv(dev);
 		unsigned int pin;
 
-		priv->regs = dev_remap_addr(dev);
+		priv->regs = dev_remap_addr(dev_get_parent(dev));
 		if (!priv->regs)
 			return -EINVAL;
 
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 led: bcm6328: read base address in the parent node

Quoted 8 lines · Philippe Reynes

In the device tree, the address for the led is located in the parent node (for exemple leds), not in the led node (for exemple led at 0).

The commit "led: bcm6328: convert to use live dt" (sha1: 899455176058d673887a762aa38853188a030af4) change this behaviour and read the address in the led node.

Quoted 8 lines

We fix this by reading the base address for led in the parent node.

---
 drivers/led/led_bcm6328.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

applied to u-boot-mips, thanks.

Signature · 9 lines
- Daniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180629/279e8c37/attachment.sig>