libfdt: SPDX-License-Identifier: GPL-2.0+ BSD-2-Clause
PATCH 1/1 libfdt: SPDX-License-Identifier: GPL-2.0+ BSD-2-Clause
--- Licenses/README | 13 ++++++------ Licenses/bsd-2-clause.txt | 25 ++++++++++++++++++++++ lib/libfdt/fdt.c | 47 +----------------------------------------- lib/libfdt/fdt_empty_tree.c | 47 +----------------------------------------- lib/libfdt/fdt_ro.c | 47 +----------------------------------------- lib/libfdt/fdt_rw.c | 47 +----------------------------------------- lib/libfdt/fdt_strerror.c | 47 +----------------------------------------- lib/libfdt/fdt_sw.c | 47 +----------------------------------------- lib/libfdt/fdt_wip.c | 47 +----------------------------------------- lib/libfdt/libfdt_internal.h | 47 +----------------------------------------- 10 files changed, 40 insertions(+), 374 deletions(-) create mode 100644 Licenses/bsd-2-clause.txt
Licenses/README +7 -6
@@ -43,10 +43,11 @@ at [2]. [1] http://spdx.org/ [2] http://spdx.org/licenses/ -Full name SPDX Identifier OSI Approved File name URI +Full name SPDX Identifier OSI Approved File name URI ======================================================================================================================================= -GNU General Public License v2.0 only GPL-2.0 Y gpl-2.0.txt http://www.gnu.org/licenses/gpl-2.0.txt -GNU General Public License v2.0 or later GPL-2.0+ Y gpl-2.0.txt http://www.gnu.org/licenses/gpl-2.0.txt -GNU Library General Public License v2 or later LGPL-2.0+ Y lgpl-2.0.txt http://www.gnu.org/licenses/old-licenses/lgpl-2.0.txt -GNU Lesser General Public License v2.1 or later LGPL-2.1+ Y lgpl-2.1.txt http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt -eCos license version 2.0 eCos-2.0 eCos-2.0.txt http://www.gnu.org/licenses/ecos-license.html +GNU General Public License v2.0 only GPL-2.0 Y gpl-2.0.txt http://www.gnu.org/licenses/gpl-2.0.txt +GNU General Public License v2.0 or later GPL-2.0+ Y gpl-2.0.txt http://www.gnu.org/licenses/gpl-2.0.txt +GNU Library General Public License v2 or later LGPL-2.0+ Y lgpl-2.0.txt http://www.gnu.org/licenses/old-licenses/lgpl-2.0.txt +GNU Lesser General Public License v2.1 or later LGPL-2.1+ Y lgpl-2.1.txt http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt +eCos license version 2.0 eCos-2.0 eCos-2.0.txt http://www.gnu.org/licenses/ecos-license.html +BSD 2-Clause License BSD-2-Clause Y bsd-2-clause.txt https://spdx.org/licenses/BSD-2-Clause
Licenses/bsd-2-clause.txt new file +25 -0
@@ -0,0 +1,25 @@ +Redistribution and use in source and binary forms, with or +without modification, are permitted provided that the following +conditions are met: + +1. Redistributions of source code must retain the above + copyright notice, this list of conditions and the following + disclaimer. +2. Redistributions in binary form must reproduce the above + copyright notice, this list of conditions and the following + disclaimer in the documentation and/or other materials + provided with the distribution. + +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND +CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, +INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF +MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR +CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT +NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) +HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN +CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR +OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, +EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
lib/libfdt/fdt.c +1 -46
53 lines not on this page · raw message
lib/libfdt/fdt_empty_tree.c +1 -46
53 lines not on this page · raw message
lib/libfdt/fdt_ro.c +1 -46
53 lines not on this page · raw message
lib/libfdt/fdt_rw.c +1 -46
53 lines not on this page · raw message
lib/libfdt/fdt_strerror.c +1 -46
53 lines not on this page · raw message
lib/libfdt/fdt_sw.c +1 -46
53 lines not on this page · raw message
lib/libfdt/fdt_wip.c +1 -46
53 lines not on this page · raw message
lib/libfdt/libfdt_internal.h +1 -46
53 lines not on this page · raw message
Signature · 1 line
1.7.10.4
PATCH 1/1 libfdt: SPDX-License-Identifier: GPL-2.0+ BSD-2-Clause
Quoted 14 lines · Roger Meier
Signed-off-by Roger Meier <[email protected]>--- Licenses/README | 13 ++++++------ Licenses/bsd-2-clause.txt | 25 ++++++++++++++++++++++ lib/libfdt/fdt.c | 47 +----------------------------------------- lib/libfdt/fdt_empty_tree.c | 47 +----------------------------------------- lib/libfdt/fdt_ro.c | 47 +----------------------------------------- lib/libfdt/fdt_rw.c | 47 +----------------------------------------- lib/libfdt/fdt_strerror.c | 47 +----------------------------------------- lib/libfdt/fdt_sw.c | 47 +----------------------------------------- lib/libfdt/fdt_wip.c | 47 +----------------------------------------- lib/libfdt/libfdt_internal.h | 47 +----------------------------------------- 10 files changed, 40 insertions(+), 374 deletions(-) create mode 100644 Licenses/bsd-2-clause.txt
These are external imported sources. I don't think you should be changing them within u-boot other than anything necessary to build. That will make importing them from upstream more work and add noise to any real modifications that may have been made.
Rob
PATCH 1/1 libfdt: SPDX-License-Identifier: GPL-2.0+ BSD-2-Clause
Dear Rob,
Quoted 16 lines · In message <CAL_Jsq+z8=mvjnRCWRxD99fqhkgb_-qtsVZtzueDZqUoYkuXkw@mail.gmail.com>…
Quoted 14 lines · Roger Meier
Signed-off-by Roger Meier <[email protected]>--- Licenses/README | 13 ++++++------ Licenses/bsd-2-clause.txt | 25 ++++++++++++++++++++++ lib/libfdt/fdt.c | 47 +----------------------------------------- lib/libfdt/fdt_empty_tree.c | 47 +----------------------------------------- lib/libfdt/fdt_ro.c | 47 +----------------------------------------- lib/libfdt/fdt_rw.c | 47 +----------------------------------------- lib/libfdt/fdt_strerror.c | 47 +----------------------------------------- lib/libfdt/fdt_sw.c | 47 +----------------------------------------- lib/libfdt/fdt_wip.c | 47 +----------------------------------------- lib/libfdt/libfdt_internal.h | 47 +----------------------------------------- 10 files changed, 40 insertions(+), 374 deletions(-) create mode 100644 Licenses/bsd-2-clause.txt
Quoted 4 lines
These are external imported sources. I don't think you should be changing them within u-boot other than anything necessary to build. That will make importing them from upstream more work and add noise to any real modifications that may have been made.
You are right about the imported part, but then, this change is a trivial one when re-importing a new version. On the other hand, it significantly simplifies tasks like generating License Clearing Reports and such. If we would keep the full license headers for all code imported from Linux or other projects we would rather give up before even starting.
No, I think we should go on here and push this trhugh consequently, setting a precedent for other projects, hoping they will adapt this approach (and/or come up with even a better solution). From the feedback I've seen so far chances are not so bad.
Best regards,
Wolfgang Denk
Signature · 10 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Scotty: Captain, we din' can reference it! Kirk: Analysis, Mr. Spock? Spock: Captain, it doesn't appear in the symbol table. Kirk: Then it's of external origin? Spock: Affirmative. Kirk: Mr. Sulu, go to pass two. Sulu: Aye aye, sir, going to pass two.
PATCH 1/1 libfdt: SPDX-License-Identifier: GPL-2.0+ BSD-2-Clause
In reply to Roger MeierDear Roger,
Quoted 14 lines · In message <[email protected]> you wrote:
Signed-off-by Roger Meier <[email protected]>--- Licenses/README | 13 ++++++------ Licenses/bsd-2-clause.txt | 25 ++++++++++++++++++++++ lib/libfdt/fdt.c | 47 +----------------------------------------- lib/libfdt/fdt_empty_tree.c | 47 +----------------------------------------- lib/libfdt/fdt_ro.c | 47 +----------------------------------------- lib/libfdt/fdt_rw.c | 47 +----------------------------------------- lib/libfdt/fdt_strerror.c | 47 +----------------------------------------- lib/libfdt/fdt_sw.c | 47 +----------------------------------------- lib/libfdt/fdt_wip.c | 47 +----------------------------------------- lib/libfdt/libfdt_internal.h | 47 +----------------------------------------- 10 files changed, 40 insertions(+), 374 deletions(-) create mode 100644 Licenses/bsd-2-clause.txt
Thanks for pushing this forward.
I have but one comment:
Quoted 1 line
+BSD 2-Clause License BSD-2-Clause Y bsd-2-clause.txt https://spdx.org/licenses/BSD-2-Clause
I don;t really like picking up the original license text from a second source (SPDX here) - I'd rather refer to some "original" version published by the creator of the license.
Maybe we can find a better URI here?
Except for that:
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Time is an illusion perpetrated by the manufacturers of space.
PATCH 1/1 libfdt: SPDX-License-Identifier: GPL-2.0+ BSD-2-Clause
Hi Wolfgang
Quoted 31 lines
-----Urspr?ngliche Nachricht-----
Von: Wolfgang Denk [mailto:wd at denx.de]
Gesendet: Sonntag, 28. Juli 2013 00:13
An: Roger Meier
Cc: u-boot at lists.denx.de
Betreff: Re: [PATCH] libfdt: SPDX-License-Identifier: GPL-2.0+ BSD-2-ClauseDear Roger,
In message <[email protected]>
Quoted 14 lines · you
Signed-off-by Roger Meier <[email protected]>--- Licenses/README | 13 ++++++------ Licenses/bsd-2-clause.txt | 25 ++++++++++++++++++++++ lib/libfdt/fdt.c | 47 +----------------------------------------- lib/libfdt/fdt_empty_tree.c | 47 +----------------------------------------- lib/libfdt/fdt_ro.c | 47 +----------------------------------------- lib/libfdt/fdt_rw.c | 47 +----------------------------------------- lib/libfdt/fdt_strerror.c | 47 +----------------------------------------- lib/libfdt/fdt_sw.c | 47 +----------------------------------------- lib/libfdt/fdt_wip.c | 47 +----------------------------------------- lib/libfdt/libfdt_internal.h | 47 +----------------------------------------- 10 files changed, 40 insertions(+), 374 deletions(-) create mode 100644 Licenses/bsd-2-clause.txtThanks for pushing this forward.
I have but one comment:
Quoted 1 line
+BSD 2-Clause License BSD-2-Clause Y
Quoted 8 lines
bsd-2-clause.txt https://spdx.org/licenses/BSD-2-Clause
I don;t really like picking up the original license text from a second source (SPDX here) - I'd rather refer to some "original" version published by the creator of the license.
Maybe we can find a better URI here?
I agree, original version only we already have the SPDX Identifier.
It's a difficult task with BSD licenses and I found no original source yet. Official information from Berkeley University:
http://ipira.berkeley.edu/
ftp://ftp.cs.berkeley.edu/pub/4bsd/README.Impt.License.Change
Other sources or information:
http://www.linfo.org/bsdlicense.html
http://opensource.org/licenses/BSD-2-Clause
http://www.freebsd.org/copyright/license.html
should I rebase without an URL for BSD-2-Clause as long as we have the license in text form anyway?
Quoted 5 lines
Except for that:
Acked-by Wolfgang Denk <[email protected]>
Thanks!
-roger
PATCH 1/1 libfdt: SPDX-License-Identifier: GPL-2.0+ BSD-2-Clause
Dear Roger,
Quoted 9 lines · In message <[email protected]> you wrote:
Quoted 6 lines
I don;t really like picking up the original license text from a second source (SPDX here) - I'd rather refer to some "original" version published by the creator of the license.
Maybe we can find a better URI here?
I agree, original version only we already have the SPDX Identifier.
It's a difficult task with BSD licenses and I found no original source yet.
I agree - BSD and licenses has never been an easy task :-(
Quoted 2 lines
should I rebase without an URL for BSD-2-Clause as long as we have the license in text form anyway?
No. Please leave the SPDX reference as long as it's the best we can get.
Best regards,
Wolfgang Denk
Signature · 7 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
He had been eight years upon a project for extracting sunbeams out of
cucumbers, which were to be put in vials hermetically sealed, and let
out to warm the air in raw inclement summers. - Jonathan Swift
_Gulliver's Travels_ ``A Voyage to Laputa, etc.'' ch. 5PATCH 1/1 libfdt: SPDX-License-Identifier: GPL-2.0+ BSD-2-Clause
In reply to Roger MeierQuoted 14 lines · Roger Meier
Signed-off-by Roger Meier <[email protected]>--- Licenses/README | 13 ++++++------ Licenses/bsd-2-clause.txt | 25 ++++++++++++++++++++++ lib/libfdt/fdt.c | 47 +----------------------------------------- lib/libfdt/fdt_empty_tree.c | 47 +----------------------------------------- lib/libfdt/fdt_ro.c | 47 +----------------------------------------- lib/libfdt/fdt_rw.c | 47 +----------------------------------------- lib/libfdt/fdt_strerror.c | 47 +----------------------------------------- lib/libfdt/fdt_sw.c | 47 +----------------------------------------- lib/libfdt/fdt_wip.c | 47 +----------------------------------------- lib/libfdt/libfdt_internal.h | 47 +----------------------------------------- 10 files changed, 40 insertions(+), 374 deletions(-) create mode 100644 Licenses/bsd-2-clause.txt
For the record, this has been applied to u-boot/master for a while now, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130819/213a34ce/attachment.pgp>