ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons
Subsystems (2)
PATCH 1/5 ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons
Added GPIO buttons DT node to Arndale board file.
---
This series is based on for-next branch of Kukjin Kim's tree and added on top of the below patch:
https://patchwork.kernel.org/patch/2042451/
--- arch/arm/boot/dts/exynos5250-arndale.dts | 48 ++++++++++++++++++++++++++++++ 1 files changed, 48 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos5250-arndale.dts +48 -0
@@ -119,4 +119,52 @@ spi_2: spi at 12d40000 { status = "disabled"; }; + + gpio_keys { + compatible = "gpio-keys"; + #address-cells = <1>; + #size-cells = <0>; + + menu { + label = "SW-TACT2"; + gpios = <&gpx1 4 0 0x10000 2>; + linux,code = <139>; + gpio-key,wakeup; + }; + + home { + label = "SW-TACT3"; + gpios = <&gpx1 5 0 0x10000 2>; + linux,code = <102>; + gpio-key,wakeup; + }; + + up { + label = "SW-TACT4"; + gpios = <&gpx1 6 0 0x10000 2>; + linux,code = <103>; + gpio-key,wakeup; + }; + + down { + label = "SW-TACT5"; + gpios = <&gpx1 7 0 0x10000 2>; + linux,code = <108>; + gpio-key,wakeup; + }; + + back { + label = "SW-TACT6"; + gpios = <&gpx2 0 0 0x10000 2>; + linux,code = <158>; + gpio-key,wakeup; + }; + + wakeup { + label = "SW-TACT7"; + gpios = <&gpx2 1 0 0x10000 2>; + linux,code = <143>; + gpio-key,wakeup; + }; + }; };
Signature · 1 line
1.7.4.1
PATCH 2/5 ARM: dts: exynos5250-arndale: Add PMIC node entry
From: Amit Daniel Kachhap <[email protected]>
Added S5M8767 PMIC DT nodes to Arndale board.
--- arch/arm/boot/dts/exynos5250-arndale.dts | 213 +++++++++++++++++++++++++++++- 1 files changed, 212 insertions(+), 1 deletions(-)
arch/arm/boot/dts/exynos5250-arndale.dts +212 -1
@@ -25,7 +25,218 @@ }; i2c at 12C60000 { - status = "disabled"; + status = "okay"; + samsung,i2c-sda-delay = <100>; + samsung,i2c-max-bus-freq = <20000>; + samsung,i2c-slave-addr = <0x66>; + gpios = <&gpb3 0 2 3 0>, + <&gpb3 1 2 3 0>; + + s5m8767_pmic at 66 { + compatible = "samsung,s5m8767-pmic"; + reg = <0x66>; + + s5m8767,pmic-buck2-dvs-voltage = <1300000>; + s5m8767,pmic-buck3-dvs-voltage = <1100000>; + s5m8767,pmic-buck4-dvs-voltage = <1200000>; + s5m8767,pmic-buck-dvs-gpios = <&gpd1 0 1 0 0>, + <&gpd1 1 1 0 0>, + <&gpd1 2 1 0 0>; + s5m8767,pmic-buck-ds-gpios = <&gpx2 3 1 0 0>, + <&gpx2 4 1 0 0>, + <&gpx2 5 1 0 0>; + regulators { + ldo1_reg: LDO1 { + regulator-name = "VDD_ALIVE_1.0V"; + regulator-min-microvolt = <1100000>; + regulator-max-microvolt = <1100000>; + regulator-always-on; + regulator-boot-on; + op_mode = <1>; + }; + + ldo2_reg: LDO2 { + regulator-name = "VDD_28IO_DP_1.35V"; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo3_reg: LDO3 { + regulator-name = "VDD_COMMON1_1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo4_reg: LDO4 { + regulator-name = "VDD_IOPERI_1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo5_reg: LDO5 { + regulator-name = "VDD_EXT_1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo6_reg: LDO6 { + regulator-name = "VDD_MPLL_1.1V"; + regulator-min-microvolt = <1100000>; + regulator-max-microvolt = <1100000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo7_reg: LDO7 { + regulator-name = "VDD_XPLL_1.1V"; + regulator-min-microvolt = <1100000>; + regulator-max-microvolt = <1100000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo8_reg: LDO8 { + regulator-name = "VDD_COMMON2_1.0V"; + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <1000000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo9_reg: LDO9 { + regulator-name = "VDD_33ON_3.0V"; + regulator-min-microvolt = <3000000>; + regulator-max-microvolt = <3000000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo10_reg: LDO10 { + regulator-name = "VDD_COMMON3_1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo11_reg: LDO11 { + regulator-name = "VDD_ABB2_1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo12_reg: LDO12 { + regulator-name = "VDD_USB_3.0V"; + regulator-min-microvolt = <3000000>; + regulator-max-microvolt = <3000000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo13_reg: LDO13 { + regulator-name = "VDDQ_C2C_W_1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo14_reg: LDO14 { + regulator-name = "VDD18_ABB0_3_1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo15_reg: LDO15 { + regulator-name = "VDD10_COMMON4_1.0V"; + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <1000000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo16_reg: LDO16 { + regulator-name = "VDD18_HSIC_1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo17_reg: LDO17 { + regulator-name = "VDDQ_MMC2_3_2.8V"; + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo18_reg: LDO18 { + regulator-name = "VDD_33ON_2.8V"; + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; + regulator-always-on; + op_mode = <1>; + }; + + buck1_reg: BUCK1 { + regulator-name = "VDD_MIF_1.2V"; + regulator-min-microvolt = <950000>; + regulator-max-microvolt = <1200000>; + regulator-always-on; + regulator-boot-on; + op_mode = <1>; + }; + + buck2_reg: BUCK2 { + regulator-name = "vdd_arm"; + regulator-min-microvolt = <925000>; + regulator-max-microvolt = <1300000>; + regulator-always-on; + regulator-boot-on; + op_mode = <1>; + }; + + buck3_reg: BUCK3 { + regulator-name = "VDD_INT_1.0V"; + regulator-min-microvolt = <900000>; + regulator-max-microvolt = <1200000>; + regulator-always-on; + regulator-boot-on; + op_mode = <1>; + }; + + buck4_reg: BUCK4 { + regulator-name = "VDD_G3D_1.0V"; + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <1000000>; + regulator-always-on; + op_mode = <1>; + }; + + buck5_reg: BUCK5 { + regulator-name = "VDD_MEM_1.35V"; + regulator-min-microvolt = <750000>; + regulator-max-microvolt = <1355000>; + regulator-always-on; + regulator-boot-on; + op_mode = <1>; + }; + + }; + }; }; i2c at 12C70000 {
Signature · 1 line
1.7.4.1
PATCH 2/5 ARM: dts: exynos5250-arndale: Add PMIC node entry
Quoted 16 lines · Tushar Behera
From: Amit Daniel Kachhap <[email protected]>
Added S5M8767 PMIC DT nodes to Arndale board.
Signed-off-by Amit Daniel Kachhap <[email protected]>Signed-off-by Sachin Kamat <[email protected]>Signed-off-by Tushar Behera <[email protected]>--- arch/arm/boot/dts/exynos5250-arndale.dts | 213 +++++++++++++++++++++++++++++- 1 files changed, 212 insertions(+), 1 deletions(-)arch/arm/boot/dts/exynos5250-arndale.dts +0
-0
arch/arm/boot/dts/exynos5250-arndale.dts line 28
Quoted 5 lines
arch/arm/boot/dts/exynos5250-arndale.dts +1
-1@@ -25,7 +25,218 @@ }; i2c at 12C60000 { - status = "disabled"; + status = "okay";
Is there any need to change status "okay" here as in dtsi file it is by default okay ?
Quoted 223 lines
arch/arm/boot/dts/exynos5250-arndale.dts +211
-0+ samsung,i2c-sda-delay = <100>; + samsung,i2c-max-bus-freq = <20000>; + samsung,i2c-slave-addr = <0x66>; + gpios = <&gpb3 0 2 3 0>, + <&gpb3 1 2 3 0>; + + s5m8767_pmic at 66 { + compatible = "samsung,s5m8767-pmic"; + reg = <0x66>; + + s5m8767,pmic-buck2-dvs-voltage = <1300000>; + s5m8767,pmic-buck3-dvs-voltage = <1100000>; + s5m8767,pmic-buck4-dvs-voltage = <1200000>; + s5m8767,pmic-buck-dvs-gpios = <&gpd1 0 1 0 0>, + <&gpd1 1 1 0 0>, + <&gpd1 2 1 0 0>; + s5m8767,pmic-buck-ds-gpios = <&gpx2 3 1 0 0>, + <&gpx2 4 1 0 0>, + <&gpx2 5 1 0 0>; + regulators { + ldo1_reg: LDO1 { + regulator-name = "VDD_ALIVE_1.0V"; + regulator-min-microvolt = <1100000>; + regulator-max-microvolt = <1100000>; + regulator-always-on; + regulator-boot-on; + op_mode = <1>; + }; + + ldo2_reg: LDO2 { + regulator-name = "VDD_28IO_DP_1.35V"; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo3_reg: LDO3 { + regulator-name = "VDD_COMMON1_1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo4_reg: LDO4 { + regulator-name = "VDD_IOPERI_1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo5_reg: LDO5 { + regulator-name = "VDD_EXT_1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo6_reg: LDO6 { + regulator-name = "VDD_MPLL_1.1V"; + regulator-min-microvolt = <1100000>; + regulator-max-microvolt = <1100000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo7_reg: LDO7 { + regulator-name = "VDD_XPLL_1.1V"; + regulator-min-microvolt = <1100000>; + regulator-max-microvolt = <1100000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo8_reg: LDO8 { + regulator-name = "VDD_COMMON2_1.0V"; + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <1000000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo9_reg: LDO9 { + regulator-name = "VDD_33ON_3.0V"; + regulator-min-microvolt = <3000000>; + regulator-max-microvolt = <3000000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo10_reg: LDO10 { + regulator-name = "VDD_COMMON3_1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo11_reg: LDO11 { + regulator-name = "VDD_ABB2_1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo12_reg: LDO12 { + regulator-name = "VDD_USB_3.0V"; + regulator-min-microvolt = <3000000>; + regulator-max-microvolt = <3000000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo13_reg: LDO13 { + regulator-name = "VDDQ_C2C_W_1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo14_reg: LDO14 { + regulator-name = "VDD18_ABB0_3_1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo15_reg: LDO15 { + regulator-name = "VDD10_COMMON4_1.0V"; + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <1000000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo16_reg: LDO16 { + regulator-name = "VDD18_HSIC_1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo17_reg: LDO17 { + regulator-name = "VDDQ_MMC2_3_2.8V"; + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; + regulator-always-on; + op_mode = <1>; + }; + + ldo18_reg: LDO18 { + regulator-name = "VDD_33ON_2.8V"; + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; + regulator-always-on; + op_mode = <1>; + }; + + buck1_reg: BUCK1 { + regulator-name = "VDD_MIF_1.2V"; + regulator-min-microvolt = <950000>; + regulator-max-microvolt = <1200000>; + regulator-always-on; + regulator-boot-on; + op_mode = <1>; + }; + + buck2_reg: BUCK2 { + regulator-name = "vdd_arm"; + regulator-min-microvolt = <925000>; + regulator-max-microvolt = <1300000>; + regulator-always-on; + regulator-boot-on; + op_mode = <1>; + }; + + buck3_reg: BUCK3 { + regulator-name = "VDD_INT_1.0V"; + regulator-min-microvolt = <900000>; + regulator-max-microvolt = <1200000>; + regulator-always-on; + regulator-boot-on; + op_mode = <1>; + }; + + buck4_reg: BUCK4 { + regulator-name = "VDD_G3D_1.0V"; + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <1000000>; + regulator-always-on; + op_mode = <1>; + }; + + buck5_reg: BUCK5 { + regulator-name = "VDD_MEM_1.35V"; + regulator-min-microvolt = <750000>; + regulator-max-microvolt = <1355000>; + regulator-always-on; + regulator-boot-on; + op_mode = <1>; + }; + + }; + }; }; i2c at 12C70000 {Signature · 7 lines
1.7.4.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH 2/5 ARM: dts: exynos5250-arndale: Add PMIC node entry
Quoted 19 lines · Anil
Quoted 18 lines · Tushar Behera
From: Amit Daniel Kachhap <[email protected]>
Added S5M8767 PMIC DT nodes to Arndale board.
Signed-off-by Amit Daniel Kachhap <[email protected]>Signed-off-by Sachin Kamat <[email protected]>Signed-off-by Tushar Behera <[email protected]>--- arch/arm/boot/dts/exynos5250-arndale.dts | 213 +++++++++++++++++++++++++++++- 1 files changed, 212 insertions(+), 1 deletions(-)arch/arm/boot/dts/exynos5250-arndale.dts +0
-0@@ -25,7 +25,218 @@ };
Quoted 7 lines
arch/arm/boot/dts/exynos5250-arndale.dts line 28
Quoted 3 lines
arch/arm/boot/dts/exynos5250-arndale.dts +1
-1i2c at 12C60000 { - status = "disabled"; + status = "okay";Is there any need to change status "okay" here as in dtsi file it is by default okay ?
Right, there is no need for setting it as "okay" explicitly.
Signature · 1 line
Tushar Behera
PATCH 2/5 ARM: dts: exynos5250-arndale: Add PMIC node entry
The V2 of this patch is posted with comments suggested by Anil and some missing LDO's.
Thanks,
Amit Daniel
Quoted 36 lines · Tushar Behera
Quoted 19 lines · Anil
Quoted 18 lines · Tushar Behera
From: Amit Daniel Kachhap <[email protected]>
Added S5M8767 PMIC DT nodes to Arndale board.
Signed-off-by Amit Daniel Kachhap <[email protected]>Signed-off-by Sachin Kamat <[email protected]>Signed-off-by Tushar Behera <[email protected]>--- arch/arm/boot/dts/exynos5250-arndale.dts | 213 +++++++++++++++++++++++++++++- 1 files changed, 212 insertions(+), 1 deletions(-)arch/arm/boot/dts/exynos5250-arndale.dts +0
-0@@ -25,7 +25,218 @@ };Quoted 7 lines
arch/arm/boot/dts/exynos5250-arndale.dts line 28
Quoted 3 lines
arch/arm/boot/dts/exynos5250-arndale.dts +1
-1i2c at 12C60000 { - status = "disabled"; + status = "okay";Is there any need to change status "okay" here as in dtsi file it is by default okay ?
Right, there is no need for setting it as "okay" explicitly.
--
Tushar Behera
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 2/5 ARM: dts: exynos5250-arndale: Add PMIC node entry
Quoted 4 lines · amit daniel kachhap
The V2 of this patch is posted with comments suggested by Anil and some missing LDO's.
OK, I see.
- Kukjin
PATCH 3/5 ARM: dts: exynos5250-arndale: Add vmmc regulator support
In reply to Tushar BeheraFrom: Sachin Kamat <[email protected]>
Added vmmc regulator node to Arndale DT file.
--- arch/arm/boot/dts/exynos5250-arndale.dts | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos5250-arndale.dts +11 -0
@@ -280,6 +280,7 @@ samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <2 3>; samsung,dw-mshc-ddr-timing = <1 2>; + vmmc-supply = <&mmc_reg>; slot at 0 { reg = <0>;
@@ -304,6 +305,7 @@ samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <2 3>; samsung,dw-mshc-ddr-timing = <1 2>; + vmmc-supply = <&mmc_reg>; slot at 0 { reg = <0>;
@@ -378,4 +380,13 @@ gpio-key,wakeup; }; }; + + mmc_reg: voltage-regulator { + compatible = "regulator-fixed"; + regulator-name = "VDD_33ON_2.8V"; + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; + gpio = <&gpx1 1 0 0 2>; + enable-active-high; + }; };
Signature · 1 line
1.7.4.1
PATCH 4/5 ARM: dts: exynos5250-arndale: Add MFC codec support
In reply to Tushar BeheraFrom: Sachin Kamat <[email protected]>
Added MFC codec node to Arndale DT file.
--- arch/arm/boot/dts/exynos5250-arndale.dts | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos5250-arndale.dts +5 -0
@@ -24,6 +24,11 @@ bootargs = "console=ttySAC2,115200"; }; + codec at 11000000 { + samsung,mfc-r = <0x43000000 0x800000>; + samsung,mfc-l = <0x51000000 0x800000>; + }; + i2c at 12C60000 { status = "okay"; samsung,i2c-sda-delay = <100>;
Signature · 1 line
1.7.4.1
PATCH 5/5 ARM: dts: exynos5250-arndale: Add HDMI HPD and regulator node
In reply to Tushar BeheraFrom: Sachin Kamat <[email protected]>
Added HDMI hot plug and regulator nodes to Arndale DT file.
--- arch/arm/boot/dts/exynos5250-arndale.dts | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos5250-arndale.dts +12 -0
@@ -386,6 +386,13 @@ }; }; + hdmi { + hpd-gpio = <&gpx3 7 0xf 1 3>; + vdd_osc-supply = <&ldo10_reg>; + vdd_pll-supply = <&ldo8_reg>; + vdd-supply = <&ldo8_reg>; + }; + mmc_reg: voltage-regulator { compatible = "regulator-fixed"; regulator-name = "VDD_33ON_2.8V";
@@ -394,4 +401,9 @@ gpio = <&gpx1 1 0 0 2>; enable-active-high; }; + + reg_hdmi_en: fixedregulator at 0 { + compatible = "regulator-fixed"; + regulator-name = "hdmi-en"; + }; };
Signature · 1 line
1.7.4.1
PATCH 1/5 ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons
In reply to Tushar BeheraQuoted 17 lines · Tushar Behera
Added GPIO buttons DT node to Arndale board file.
Signed-off-by Tushar Behera <[email protected]>Signed-off-by Sachin Kamat <[email protected]>---
This series is based on for-next branch of Kukjin Kim's tree and added on top of the below patch:
https://patchwork.kernel.org/patch/2042451/--- arch/arm/boot/dts/exynos5250-arndale.dts | 48 ++++++++++++++++++++++++++++++ 1 files changed, 48 insertions(+), 0 deletions(-)arch/arm/boot/dts/exynos5250-arndale.dts +0
-0
arch/arm/boot/dts/exynos5250-arndale.dts line 126
Quoted 8 lines
arch/arm/boot/dts/exynos5250-arndale.dts +5
-0@@ -119,4 +119,52 @@ spi_2: spi at 12d40000 { status = "disabled"; }; + + gpio_keys { + compatible = "gpio-keys"; + #address-cells = <1>; + #size-cells = <0>;
Just want to understand why these properties are here? As these properties are for child dt node. But have not seen anyone is using here.
Sorry if I have misunderstood.
Quoted 53 lines
arch/arm/boot/dts/exynos5250-arndale.dts +43
-0+ + menu { + label = "SW-TACT2"; + gpios = <&gpx1 4 0 0x10000 2>; + linux,code = <139>; + gpio-key,wakeup; + }; + + home { + label = "SW-TACT3"; + gpios = <&gpx1 5 0 0x10000 2>; + linux,code = <102>; + gpio-key,wakeup; + }; + + up { + label = "SW-TACT4"; + gpios = <&gpx1 6 0 0x10000 2>; + linux,code = <103>; + gpio-key,wakeup; + }; + + down { + label = "SW-TACT5"; + gpios = <&gpx1 7 0 0x10000 2>; + linux,code = <108>; + gpio-key,wakeup; + }; + + back { + label = "SW-TACT6"; + gpios = <&gpx2 0 0 0x10000 2>; + linux,code = <158>; + gpio-key,wakeup; + }; + + wakeup { + label = "SW-TACT7"; + gpios = <&gpx2 1 0 0x10000 2>; + linux,code = <143>; + gpio-key,wakeup; + }; + }; };Signature · 7 lines
1.7.4.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH 1/5 ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons
Quoted 22 lines · Anil
Quoted 21 lines · Tushar Behera
Added GPIO buttons DT node to Arndale board file.
Signed-off-by Tushar Behera <[email protected]>Signed-off-by Sachin Kamat <[email protected]>---
This series is based on for-next branch of Kukjin Kim's tree and added on top of the below patch:
https://patchwork.kernel.org/patch/2042451/--- arch/arm/boot/dts/exynos5250-arndale.dts | 48 ++++++++++++++++++++++++++++++ 1 files changed, 48 insertions(+), 0 deletions(-)arch/arm/boot/dts/exynos5250-arndale.dts +1
-0@@ -119,4 +119,52 @@ spi_2: spi at 12d40000 { status = "disabled"; }; +
Quoted 9 lines
arch/arm/boot/dts/exynos5250-arndale.dts line 126
Quoted 4 lines
arch/arm/boot/dts/exynos5250-arndale.dts +4
-0+ gpio_keys { + compatible = "gpio-keys"; + #address-cells = <1>; + #size-cells = <0>;Just want to understand why these properties are here? As these properties are for child dt node. But have not seen anyone is using here.
That is how gpio_keys node entries are defined in other .dts files.
Signature · 1 line
Tushar Behera
PATCH 1/5 ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons
Hi Tushar
Quoted 33 lines · Tushar Behera
Quoted 22 lines · Anil
Quoted 21 lines · Tushar Behera
Added GPIO buttons DT node to Arndale board file.
Signed-off-by Tushar Behera <[email protected]>Signed-off-by Sachin Kamat <[email protected]>---
This series is based on for-next branch of Kukjin Kim's tree and added on top of the below patch:
https://patchwork.kernel.org/patch/2042451/--- arch/arm/boot/dts/exynos5250-arndale.dts | 48 ++++++++++++++++++++++++++++++ 1 files changed, 48 insertions(+), 0 deletions(-)arch/arm/boot/dts/exynos5250-arndale.dts +1
-0@@ -119,4 +119,52 @@ spi_2: spi at 12d40000 { status = "disabled"; }; +Quoted 9 lines
arch/arm/boot/dts/exynos5250-arndale.dts line 126
Quoted 4 lines
arch/arm/boot/dts/exynos5250-arndale.dts +4
-0+ gpio_keys { + compatible = "gpio-keys"; + #address-cells = <1>; + #size-cells = <0>;Just want to understand why these properties are here? As these properties are for child dt node. But have not seen anyone is using here.
Quoted 1 line
That is how
gpio_keysnode entries are defined in other .dts files.
I have gone through example for address-cells and size-cells in following link:
http://devicetree.org/mediawiki/index.php?title=Device_Tree_Usage&stable=1#CPU_addressing
which indicates that these fields are for child "reg". I think, here in child node there is no "reg". so there is no use of address-cells and size-cells propeties.
Correct me if I am wrong here?
Thanks
Manish Badarkhe
PATCH 1/5 ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons
Quoted 36 lines · Manish Badarkhe
Hi Tushar
Quoted 33 lines · Tushar Behera
Quoted 31 lines · Anil
Quoted 17 lines · Tushar Behera
Added GPIO buttons DT node to Arndale board file.
Signed-off-by Tushar Behera <[email protected]>Signed-off-by Sachin Kamat <[email protected]>---
This series is based on for-next branch of Kukjin Kim's tree and added on top of the below patch:
https://patchwork.kernel.org/patch/2042451/--- arch/arm/boot/dts/exynos5250-arndale.dts | 48 ++++++++++++++++++++++++++++++ 1 files changed, 48 insertions(+), 0 deletions(-)arch/arm/boot/dts/exynos5250-arndale.dts +0
-0arch/arm/boot/dts/exynos5250-arndale.dts line 126
Quoted 8 lines
arch/arm/boot/dts/exynos5250-arndale.dts +5
-0@@ -119,4 +119,52 @@ spi_2: spi at 12d40000 { status = "disabled"; }; + + gpio_keys { + compatible = "gpio-keys"; + #address-cells = <1>; + #size-cells = <0>;Just want to understand why these properties are here? As these properties are for child dt node. But have not seen anyone is using here.
Quoted 9 lines
Quoted 1 line
That is how
gpio_keysnode entries are defined in other .dts files.I have gone through example for address-cells and size-cells in following link:
http://devicetree.org/mediawiki/index.php?title=Device_Tree_Usage&stable=1#CPU_addressingwhich indicates that these fields are for child "reg". I think, here in child node there is no "reg". so there is no use of address-cells and size-cells propeties.
Please check Documentation/devicetree/bindings/gpio/gpio_keys.txt
And whether these properties are required or not, I will let device tree experts to comment on that.
As such, currently all node entries for gpio_keys use these properties.
Signature · 1 line
Tushar Behera
PATCH 1/5 ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons
Quoted 47 lines · Tushar Behera
Quoted 36 lines · Manish Badarkhe
Hi Tushar
Quoted 33 lines · Tushar Behera
Quoted 31 lines · Anil
Quoted 17 lines · Tushar Behera
Added GPIO buttons DT node to Arndale board file.
Signed-off-by Tushar Behera <[email protected]>Signed-off-by Sachin Kamat <[email protected]>---
This series is based on for-next branch of Kukjin Kim's tree and added on top of the below patch:
https://patchwork.kernel.org/patch/2042451/--- arch/arm/boot/dts/exynos5250-arndale.dts | 48 ++++++++++++++++++++++++++++++ 1 files changed, 48 insertions(+), 0 deletions(-)arch/arm/boot/dts/exynos5250-arndale.dts +0
-0arch/arm/boot/dts/exynos5250-arndale.dts line 126
Quoted 8 lines
arch/arm/boot/dts/exynos5250-arndale.dts +5
-0@@ -119,4 +119,52 @@ spi_2: spi at 12d40000 { status = "disabled"; }; + + gpio_keys { + compatible = "gpio-keys"; + #address-cells = <1>; + #size-cells = <0>;Just want to understand why these properties are here? As these properties are for child dt node. But have not seen anyone is using here.
Quoted 9 lines
Quoted 1 line
That is how
gpio_keysnode entries are defined in other .dts files.I have gone through example for address-cells and size-cells in following link:
http://devicetree.org/mediawiki/index.php?title=Device_Tree_Usage&stable=1#CPU_addressingwhich indicates that these fields are for child "reg". I think, here in child node there is no "reg". so there is no use of address-cells and size-cells propeties.
Quoted 6 lines
Please check
Documentation/devicetree/bindings/gpio/gpio_keys.txtAnd whether these properties are required or not, I will let device tree experts to comment on that.
As such, currently all node entries for
gpio_keysuse these properties.
you can just verify by a simple test.
delete the 2 lines. address-cells and size cells.
this will have no affect.
now with these 2 lines deleted lines add a dummy reg property with address and cell. dtb compiler will warn.
So I think what manish reffered is right.
There is also a reference of smdk4210 for kepads.
Quoted 8 lines
--
Tushar Behera_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH 1/5 ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons
+CC: David Jander <[email protected]>
+CC: Dmitry Torokhov <[email protected]>
Quoted 26 lines · Girish KS
Quoted 26 lines
Quoted 11 lines
Quoted 11 lines
Quoted 10 lines
arch/arm/boot/dts/exynos5250-arndale.dts line 126
Quoted 5 lines
arch/arm/boot/dts/exynos5250-arndale.dts +5
-0+ + gpio_keys { + compatible = "gpio-keys"; + #address-cells = <1>; + #size-cells = <0>;Just want to understand why these properties are here? As these properties are for child dt node. But have not seen anyone is using here.
Quoted 9 lines
Quoted 1 line
That is how
gpio_keysnode entries are defined in other .dts files.I have gone through example for address-cells and size-cells in following link:
http://devicetree.org/mediawiki/index.php?title=Device_Tree_Usage&stable=1#CPU_addressingwhich indicates that these fields are for child "reg". I think, here in child node there is no "reg". so there is no use of address-cells and size-cells propeties.
Please check
Documentation/devicetree/bindings/gpio/gpio_keys.txtAnd whether these properties are required or not, I will let device tree experts to comment on that.
Quoted 8 lines
Quoted 1 line
As such, currently all node entries for
gpio_keysuse these properties.you can just verify by a simple test.
delete the 2 lines. address-cells and size cells.
this will have no affect.
now with these 2 lines deleted lines add a dummy reg property with address and cell. dtb compiler will warn.
So I think what manish reffered is right.
There is also a reference of smdk4210 for kepads.
Right. Compilation is ok even after removing the address-cell and size-cell properties.
But since this is used across all the instances, I would like to know the view of the authors on this.
David, Dimitry,
Can you please let us know your opinion on this? If these properties are not required, then we can remove them from the documentation and from node entries in several other dts files.
Quoted 8 lines
Quoted 8 lines
--
Tushar Behera_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 1 line
Tushar Behera
PATCH 1/5 ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons
Quoted 44 lines · On Thursday 07 of February 2013 15:10:27 Tushar Behera wrote:
(quoted diff) +2
-0+CC: David Jander <[email protected]> +CC: Dmitry Torokhov <[email protected]>Quoted 29 lines · Girish KS
Quoted 21 lines
Quoted 12 lines
Quoted 11 lines
Quoted 9 lines
Review
Quoted 5 lines
(quoted diff) +5
-0+ + gpio_keys { + compatible = "gpio-keys"; + #address-cells = <1>; + #size-cells = <0>;Just want to understand why these properties are here? As these properties are for child dt node. But have not seen anyone is using here.
That is how
gpio_keysnode entries are defined in other .dts files.Quoted 8 lines
I have gone through example for address-cells and size-cells in following link:
http://devicetree.org/mediawiki/index.php?title=Device_Tree_Usage&s
table=1#CPU_addressingwhich indicates that these fields are for child "reg". I think, here in child node there is no "reg". so there is no use of address-cells and size-cells propeties.
Quoted 7 lines
Please check
Documentation/devicetree/bindings/gpio/gpio_keys.txtAnd whether these properties are required or not, I will let device tree experts to comment on that.
As such, currently all node entries for
gpio_keysuse these properties.Quoted 7 lines
you can just verify by a simple test.
delete the 2 lines. address-cells and size cells.
this will have no affect.
now with these 2 lines deleted lines add a dummy reg property with address and cell. dtb compiler will warn.
So I think what manish reffered is right.
There is also a reference of smdk4210 for kepads.Right. Compilation is ok even after removing the address-cell and size-cell properties.
Quoted 8 lines
But since this is used across all the instances, I would like to know the view of the authors on this.
David, Dimitry,
Can you please let us know your opinion on this? If these properties are not required, then we can remove them from the documentation and from node entries in several other dts files.
The #address-cells and #size-cells are used only together with reg properties of sub nodes. They define how many cells in reg specifier are used for registers address and length.
So, if you have #address-cells = <1> and #size-cells = <0>, then your reg specifier will be simply <addr>. You can get more complex specifiers using more address cells and size cells, like:
#address-cells = <3>;
#size-cells = <1>;
subdev at 1,2,3 {
reg = <1 2 3 0x1000>;
/* ... */
};If you don't intend to use reg property for child device addressing then you don't define #address-cells and #size-cells properties.
I think that the documentation of gpio_keys binding should be corrected and possibly also moved to bindings/input instead of bindings/gpio, as this directory is intended to be used for GPIO controllers, not GPIO consumers.
Best regards,
Signature · 3 lines
Tomasz Figa Samsung Poland R&D Center SW Solution Development, Linux Platform
PATCH 1/5 ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons
In reply to Tushar BeheraHi,
I'm wondering why Exynos5250 has not been migrated to use pinctrl yet.
Support for it in pinctrl-samsung driver has been already merged, but I don't see any pinctrl nodes in exynos5250.dtsi.
This is important because the legacy gpio-samsung support is going to be dropped, as it already happened in case of Exynos 4.
CC'ing Thomas Abraham as he might know something.
Best regards,
Signature · 3 lines
Tomasz Figa Samsung Poland R&D Center SW Solution Development, Linux Platform
Quoted 71 lines · On Thursday 07 of February 2013 10:45:25 Tushar Behera wrote:
Added GPIO buttons DT node to Arndale board file.
Signed-off-by Tushar Behera <[email protected]>Signed-off-by Sachin Kamat <[email protected]>---
This series is based on for-next branch of Kukjin Kim's tree and added on top of the below patch:
https://patchwork.kernel.org/patch/2042451/--- arch/arm/boot/dts/exynos5250-arndale.dts | 48++++++++++++++++++++++++++++++ 1 files changed, 48 insertions(+), 0 deletions(-)
(quoted diff) +0
-0
b/arch/arm/boot/dts/exynos5250-arndale.dtsindex 63572f9..9ce40df 100644arch/arm/boot/dts/exynos5250-arndale.dts +48
-0@@ -119,4 +119,52 @@ spi_2: spi at 12d40000 { status = "disabled"; }; + + gpio_keys { + compatible = "gpio-keys"; + #address-cells = <1>; + #size-cells = <0>; + + menu { + label = "SW-TACT2"; + gpios = <&gpx1 4 0 0x10000 2>; + linux,code = <139>; + gpio-key,wakeup; + }; + + home { + label = "SW-TACT3"; + gpios = <&gpx1 5 0 0x10000 2>; + linux,code = <102>; + gpio-key,wakeup; + }; + + up { + label = "SW-TACT4"; + gpios = <&gpx1 6 0 0x10000 2>; + linux,code = <103>; + gpio-key,wakeup; + }; + + down { + label = "SW-TACT5"; + gpios = <&gpx1 7 0 0x10000 2>; + linux,code = <108>; + gpio-key,wakeup; + }; + + back { + label = "SW-TACT6"; + gpios = <&gpx2 0 0 0x10000 2>; + linux,code = <158>; + gpio-key,wakeup; + }; + + wakeup { + label = "SW-TACT7"; + gpios = <&gpx2 1 0 0x10000 2>; + linux,code = <143>; + gpio-key,wakeup; + }; + }; };
PATCH 1/5 ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons
Quoted 5 lines · Tomasz Figa
Hi,
I'm wondering why Exynos5250 has not been migrated to use pinctrl yet.
Quoted 8 lines
Support for it in pinctrl-samsung driver has been already merged, but I don't see any pinctrl nodes in
exynos5250.dtsi.This is important because the legacy gpio-samsung support is going to be dropped, as it already happened in case of Exynos 4.
CC'ing Thomas Abraham as he might know something.
Tushar and all,
I agree with Tomasz's opinion to support pinctrl instead of gpio on exynos5250 stuff.
Please re-submit with using pinctrl is in samsung tree.
If any problems, please let us know.
Thanks.
- Kukjin
PATCH 1/5 ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons
Quoted 12 lines · Kukjin Kim
Quoted 11 lines · Tomasz Figa
Hi,
I'm wondering why Exynos5250 has not been migrated to use pinctrl yet.
Support for it in pinctrl-samsung driver has been already merged, but I don't see any pinctrl nodes in
exynos5250.dtsi.This is important because the legacy gpio-samsung support is going to be dropped, as it already happened in case of Exynos 4.
Quoted 9 lines
Quoted 2 lines
CC'ing Thomas Abraham as he might know something.
Tushar and all,
I agree with Tomasz's opinion to support pinctrl instead of gpio on exynos5250 stuff.
Please re-submit with using pinctrl is in samsung tree.
Ok. I will rebase the patchset on for-next branch and re-submit.
Signature · 1 line
Tushar Behera