Skip to contentSkip to conversation

Provider/rxe: Remove printf()

PATCH In review Bob Pearson 2 participants 3 messages Sep 29, 2021 – Sep 30, 2021 InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Provider/rxe: Remove printf()

Currently the rxe provider issues a print statement if it detects an invalid work request and also returns an error. A recently added python test case triggers such a message which is expected since the test is deliberately constructing invalid work requests.

This patch removes the print statement which has no practical use.

---
 providers/rxe/rxe.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
providers/rxe/rxe.c +1 -3
index 3533a325..42fc447c 100644
@@ -1513,10 +1513,8 @@ static int post_one_send(struct rxe_qp *qp, struct rxe_wq *sq,
 		length += ibwr->sg_list[i].length;
 
 	err = validate_send_wr(qp, ibwr, length);
-	if (err) {
-		printf("validate send failed\n");
+	if (err)
 		return err;
-	}
 
 	wqe = (struct rxe_send_wqe *)producer_addr(sq->queue);
 
Signature · 1 line
2.30.2
#1 lore raw
Quoted 11 lines · Bob Pearson

Currently the rxe provider issues a print statement if it detects an invalid work request and also returns an error. A recently added python test case triggers such a message which is expected since the test is deliberately constructing invalid work requests.

This patch removes the print statement which has no practical use.

---
 providers/rxe/rxe.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Please remove this "fprintf(stderr, "rxe: Failed to query sgid.\n");" line too.

Thanks

Quoted 20 lines
providers/rxe/rxe.c +1 -3
index 3533a325..42fc447c 100644
@@ -1513,10 +1513,8 @@ static int post_one_send(struct rxe_qp *qp, struct rxe_wq *sq,
 		length += ibwr->sg_list[i].length;
 
 	err = validate_send_wr(qp, ibwr, length);
-	if (err) {
-		printf("validate send failed\n");
+	if (err)
 		return err;
-	}
 
 	wqe = (struct rxe_send_wqe *)producer_addr(sq->queue);
 
Signature · 1 line
2.30.2
#2 lore raw
Quoted 13 lines · Leon Romanovsky
Quoted 11 lines · Bob Pearson

Currently the rxe provider issues a print statement if it detects an invalid work request and also returns an error. A recently added python test case triggers such a message which is expected since the test is deliberately constructing invalid work requests.

This patch removes the print statement which has no practical use.

---
 providers/rxe/rxe.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
Quoted 5 lines

Please remove this "fprintf(stderr, "rxe: Failed to query sgid.\n");" line too.

Thanks

NP

Quoted 20 lines
Quoted 20 lines
providers/rxe/rxe.c +1 -3
index 3533a325..42fc447c 100644
@@ -1513,10 +1513,8 @@ static int post_one_send(struct rxe_qp *qp, struct rxe_wq *sq,
 		length += ibwr->sg_list[i].length;
 
 	err = validate_send_wr(qp, ibwr, length);
-	if (err) {
-		printf("validate send failed\n");
+	if (err)
 		return err;
-	}
 
 	wqe = (struct rxe_send_wqe *)producer_addr(sq->queue);
 
Signature · 1 line
2.30.2