drm/i915: Missed "ret" initialization on gem_context_size
Subsystems (2)
PATCH 1/1 drm/i915: Missed "ret" initialization on gem_context_size
Although default case is a bug, being conservative on the initialization helps to shut up coverity scan.
Signed-off-by Rodrigo Vivi <[email protected]>
--- drivers/gpu/drm/i915/i915_gem_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_gem_context.c +1 -1
@@ -102,7 +102,7 @@ static int do_switch(struct i915_hw_context *to);static int get_context_size (struct drm_device *dev) {struct drm_i915_private *dev_priv = dev->dev_private; -int ret; +int ret =0 ;u32 reg;switch (INTEL_INFO (dev)->gen) {
Signature · 1 line
1.7.11.4
Quoted 2 lines · Rodrigo Vivi
Although default case is a bug, being conservative on the initialization helps to shut up coverity scan.
So many more issues would be resolved if you taught coverity that BUG() was noreturn. :-p
-Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre