ccache: expose control interface via 'make ccache-options'
PATCH 1/1 ccache: expose control interface via 'make ccache-options'
usage:
# set cache limit size make CCACHE_OPTIONS="--max-size=5G" ccache-options
# zero statistics counters make CCACHE_OPTIONS="--zero-stats" ccache-options
Change-Id: I0162a2612a9aa4afd49f6d93c9c36dce3e0c8228
--- package/ccache/ccache.mk | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
package/ccache/ccache.mk +4 -0
@@ -50,3 +50,7 @@ ccache-stats: host-ccache $(Q)$(CCACHE) -s endif +ifeq ($(BR2_CCACHE),y) +ccache-options: host-ccache + $(Q)$(CCACHE) $(CCACHE_OPTIONS) +endif
Signature · 1 line
1.7.8.6
PATCH 1/1 ccache: expose control interface via 'make ccache-options'
Quoted 25 lines · Tzu-Jung Lee
usage:
? ? ? ?# set cache limit size
? ? ? ?make CCACHE_OPTIONS="--max-size=5G" ccache-options? ? ? ?# zero statistics counters
? ? ? ?make CCACHE_OPTIONS="--zero-stats" ccache-optionsChange-Id: I0162a2612a9aa4afd49f6d93c9c36dce3e0c8228
---
?package/ccache/ccache.mk | ? ?4 ++++
?1 files changed, 4 insertions(+), 0 deletions(-)package/ccache/ccache.mk +0
-0@@ -50,3 +50,7 @@ ccache-stats: host-ccache? ? ? ?$(Q)$(CCACHE) -s
?endifpackage/ccache/ccache.mk +4
-1+ifeq ($(BR2_CCACHE),y) +ccache-options: host-ccache + ? ? ? $(Q)$(CCACHE) $(CCACHE_OPTIONS) +endif --
Quoted 2 lines
1.7.8.6
Hi Guys,
Any comment on this?
Regards,
Roy
A message that is not in the archive (sent off-list or not yet received): CAEvN+1jCAvFYsOkbv4Rf4g7YqZJe4Ty9cwpFMiAUTTAvh7mvQg@mail.gmail.com
PATCH 1/1 ccache: expose control interface via 'make ccache-options'
# Response to patchwork cleanup of week #1
This patch provides an easy way to operate on buildroot ccache such as changing the cache limit or showing statistics.
Without it, users would have to explicitly specify both the environment variable and the path of patched ccache, for example:
BUILDROOT_CACHE_DIR=~/.buildroot-ccache/ $PWD/host/usr/bin/ccache -s
.
Thanks.
Roy
Quoted 34 lines · Tzu-Jung Lee
---------- Forwarded message ----------
From: Tzu-Jung Lee <[email protected]>
Date: Mon, Jun 18, 2012 at 11:50 AM
Subject: [PATCH 1/1] ccache: expose control interface via 'make ccache-options'
To: buildroot at busybox.net
Cc: roylee17 at gmail.com, Tzu-Jung Lee <[email protected]>usage:
# set cache limit size make CCACHE_OPTIONS="--max-size=5G" ccache-options# zero statistics counters make CCACHE_OPTIONS="--zero-stats" ccache-optionsChange-Id: I0162a2612a9aa4afd49f6d93c9c36dce3e0c8228
--- package/ccache/ccache.mk | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)package/ccache/ccache.mk +4
-1@@ -50,3 +50,7 @@ ccache-stats: host-ccache $(Q)$(CCACHE) -s endif +ifeq ($(BR2_CCACHE),y) +ccache-options: host-ccache + $(Q)$(CCACHE) $(CCACHE_OPTIONS) +endif --1.7.8.6
PATCH 1/1 ccache: expose control interface via 'make ccache-options'
Quoted 8 lines · Tzu-Jung Lee
# Response to patchwork cleanup of week #1
This patch provides an easy way to operate on buildroot ccache such as changing the cache limit or showing statistics.
Without it, users would have to explicitly specify both the environment variable and the path of patched ccache, for example:
Quoted 21 lines
BUILDROOT_CACHE_DIR=~/.buildroot-ccache/ $PWD/host/usr/bin/ccache -s
.
Thanks.Roy
Quoted 14 lines · Tzu-Jung Lee
---------- Forwarded message ----------
From: Tzu-Jung Lee <[email protected]>
Date: Mon, Jun 18, 2012 at 11:50 AM
Subject: [PATCH 1/1] ccache: expose control interface via 'make ccache-options'
To: buildroot at busybox.net
Cc: roylee17 at gmail.com, Tzu-Jung Lee <[email protected]>usage:
# set cache limit size make CCACHE_OPTIONS="--max-size=5G" ccache-options# zero statistics counters make CCACHE_OPTIONS="--zero-stats" ccache-options
You should add this text to the documentation indocs/manual/ccache-support.txt
Quoted 2 lines
Quoted 2 lines
Change-Id: I0162a2612a9aa4afd49f6d93c9c36dce3e0c8228
Missing Signed-off-by line.
Otherwise looks good to me.
Regards,
Arnout
Quoted 24 lines
Quoted 17 lines
--- package/ccache/ccache.mk | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)package/ccache/ccache.mk +4
-1@@ -50,3 +50,7 @@ ccache-stats: host-ccache $(Q)$(CCACHE) -s endif +ifeq ($(BR2_CCACHE),y) +ccache-options: host-ccache + $(Q)$(CCACHE) $(CCACHE_OPTIONS) +endif --Quoted 1 line
1.7.8.6
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH v2 1/1 ccache: expose control interface via 'make ccache-options'
usage:
# set cache limit size make CCACHE_OPTIONS="--max-size=5G" ccache-options
# zero statistics counters make CCACHE_OPTIONS="--zero-stats" ccache-options
---
Add descriptions in the manual
docs/manual/ccache-support.txt | 11 +++++++++++ package/ccache/ccache.mk | 5 +++++ 2 files changed, 16 insertions(+)
docs/manual/ccache-support.txt +11 -0
@@ -23,3 +23,14 @@ remove this directory. You can get statistics on the cache (its size, number of hits, misses, etc.) by running +make ccache-stats+. + +The make target +cache-options+ and the +CCACHE_OPTIONS+ variable +provide more generic access to the ccache. For example + +----------------- +# set cache limit size +make CCACHE_OPTIONS="--max-size=5G" ccache-options + +# zero statistics counters +make CCACHE_OPTIONS="--zero-stats" ccache-options +-----------------
package/ccache/ccache.mk +5 -0
@@ -45,3 +45,8 @@ ifeq ($(BR2_CCACHE),y) ccache-stats: host-ccache $(Q)$(CCACHE) -s endif + +ifeq ($(BR2_CCACHE),y) +ccache-options: host-ccache + $(Q)$(CCACHE) $(CCACHE_OPTIONS) +endif
Signature · 1 line
1.8.3.2
PATCH v2 1/1 ccache: expose control interface via 'make ccache-options'
Hi Tzu-Jung,
Quoted 20 lines · Tzu-Jung Lee
usage:
# set cache limit size make CCACHE_OPTIONS="--max-size=5G" ccache-options# zero statistics counters make CCACHE_OPTIONS="--zero-stats" ccache-optionsSigned-off-by Tzu-Jung Lee <[email protected]>---
Add descriptions in the manualdocs/manual/ccache-support.txt | 11 +++++++++++ package/ccache/ccache.mk | 5 +++++ 2 files changed, 16 insertions(+)docs/manual/ccache-support.txt +0
-0
docs/manual/ccache-support.txt remove this directory. · line 27
Quoted 5 lines
docs/manual/ccache-support.txt +2
-0@@ -23,3 +23,14 @@ remove this directory. You can get statistics on the cache (its size, number of hits, misses, etc.) by running +make ccache-stats+. + +The make target +cache-options+ and the +CCACHE_OPTIONS+ variable
this should be ccache-options
Quoted 14 lines
docs/manual/ccache-support.txt +9
-0+provide more generic access to the ccache. For example + +----------------- +# set cache limit size +make CCACHE_OPTIONS="--max-size=5G" ccache-options + +# zero statistics counters +make CCACHE_OPTIONS="--zero-stats" ccache-options +-----------------package/ccache/ccache.mk +0
-0
package/ccache/ccache.mk ifeq ($(BR2_CCACHE),y)
Quoted 9 lines
package/ccache/ccache.mk +5
-1@@ -45,3 +45,8 @@ ifeq ($(BR2_CCACHE),y) ccache-stats: host-ccache $(Q)$(CCACHE) -s endif + +ifeq ($(BR2_CCACHE),y) +ccache-options: host-ccache + $(Q)$(CCACHE) $(CCACHE_OPTIONS) +endif --
Best regards,
Thomas
PATCH v3 1/1 ccache: expose control interface via 'make ccache-options'
In reply to Arnout Vandecappelleusage:
# set cache limit size make CCACHE_OPTIONS="--max-size=5G" ccache-options
# zero statistics counters make CCACHE_OPTIONS="--zero-stats" ccache-options
---
Fix a typo of manual in v2
docs/manual/ccache-support.txt | 11 +++++++++++ package/ccache/ccache.mk | 5 +++++ 2 files changed, 16 insertions(+)
docs/manual/ccache-support.txt +11 -0
@@ -23,3 +23,14 @@ remove this directory. You can get statistics on the cache (its size, number of hits, misses, etc.) by running +make ccache-stats+. + +The make target +ccache-options+ and the +CCACHE_OPTIONS+ variable +provide more generic access to the ccache. For example + +----------------- +# set cache limit size +make CCACHE_OPTIONS="--max-size=5G" ccache-options + +# zero statistics counters +make CCACHE_OPTIONS="--zero-stats" ccache-options +-----------------
package/ccache/ccache.mk +5 -0
@@ -45,3 +45,8 @@ ifeq ($(BR2_CCACHE),y) ccache-stats: host-ccache $(Q)$(CCACHE) -s endif + +ifeq ($(BR2_CCACHE),y) +ccache-options: host-ccache + $(Q)$(CCACHE) $(CCACHE_OPTIONS) +endif
Signature · 1 line
1.8.3.2
PATCH v3 1/1 ccache: expose control interface via 'make ccache-options'
Dear Tzu-Jung Lee,
Quoted 8 lines · Tzu-Jung Lee
usage:
# set cache limit size make CCACHE_OPTIONS="--max-size=5G" ccache-options# zero statistics counters make CCACHE_OPTIONS="--zero-stats" ccache-optionsSigned-off-by Tzu-Jung Lee <[email protected]>
Signature · 3 lines
Thomas Petazzoni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v3 1/1 ccache: expose control interface via 'make ccache-options'
In reply to Tzu-Jung LeeHi Tzu-Jung,
Quoted 39 lines · Tzu-Jung Lee
usage:
# set cache limit size make CCACHE_OPTIONS="--max-size=5G" ccache-options# zero statistics counters make CCACHE_OPTIONS="--zero-stats" ccache-optionsSigned-off-by Tzu-Jung Lee <[email protected]>---
Fix a typo of manual in v2docs/manual/ccache-support.txt | 11 +++++++++++ package/ccache/ccache.mk | 5 +++++ 2 files changed, 16 insertions(+)docs/manual/ccache-support.txt +11
-0@@ -23,3 +23,14 @@ remove this directory. You can get statistics on the cache (its size, number of hits, misses, etc.) by running +make ccache-stats+. + +The make target +ccache-options+ and the +CCACHE_OPTIONS+ variable +provide more generic access to the ccache. For example + +----------------- +# set cache limit size +make CCACHE_OPTIONS="--max-size=5G" ccache-options + +# zero statistics counters +make CCACHE_OPTIONS="--zero-stats" ccache-options +-----------------package/ccache/ccache.mk +0
-0
package/ccache/ccache.mk ifeq ($(BR2_CCACHE),y) · line 52
Quoted 8 lines
package/ccache/ccache.mk +5
-0@@ -45,3 +45,8 @@ ifeq ($(BR2_CCACHE),y) ccache-stats: host-ccache $(Q)$(CCACHE) -s endif + +ifeq ($(BR2_CCACHE),y) +ccache-options: host-ccache + $(Q)$(CCACHE) $(CCACHE_OPTIONS) +endif
I think this 'ifeq' block can be merged with the previous one containing ccache-stats.
Also, while testing I noticed the following: if you do not specify CCACHE_OPTIONS, ccache gives its help message, but it is unclear to the user that he should put those options in CCACHE_OPTIONS. Assume someone knows there is a make target ccache-options but did not read the manual.
Therefore, I would suggest to add a check inside the ccache-options recipe for a non-empty CCACHE_OPTIONS and give a warning message. Something like:
package/ccache/ccache.mk +3 -0
@@ -48,5 +48,11 @@ endif ifeq ($(BR2_CCACHE),y) ccache-options: host-ccache +ifeq ($(CCACHE_OPTIONS),) + $(Q)echo "Usage: make ccache-options CCACHE_OPTIONS=\"opts\"" + $(Q)echo "where 'opts' corresponds to one or more valid ccache
options" \
+ "(see ccache help text below)"
+ $(Q)echo
+endif
$(Q)$(CCACHE) $(CCACHE_OPTIONS)
endif
This makes the output:
$ make ccache-options Usage: make ccache-options CCACHE_OPTIONS="opts" where 'opts' corresponds to one or more valid ccache options (see ccache help text below)
Usage:
ccache [options]
ccache compiler [compiler options]
compiler [compiler options] (via symbolic link)
Options:
-c, --cleanup delete old files and recalculate size counters
(normally not needed as this is done automatically)
-C, --clear clear the cache completely
-F, --max-files=N set maximum number of files in cache to N (use 0 for
no limit)
-M, --max-size=SIZE set maximum size of cache to SIZE (use 0 for no
limit; available suffixes: G, M and K; default
suffix: G)
-s, --show-stats show statistics summary
-z, --zero-stats zero statistics counters
-h, --help print this help text
-V, --version print version and copyright information
See also <http://ccache.samba.org>.
make: *** [ccache-options] Error 1
Best regards,
Thomas
PATCH v4 1/1 ccache: expose control interface via 'make ccache-options'
usage:
# set cache limit size make CCACHE_OPTIONS="--max-size=5G" ccache-options
# zero statistics counters make CCACHE_OPTIONS="--zero-stats" ccache-options
---
Include the useful warning message suggested by Thomas.
We might need a separate patch to obsolete the ccache-stats later.
docs/manual/ccache-support.txt | 11 +++++++++++ package/ccache/ccache.mk | 11 +++++++++++ 2 files changed, 22 insertions(+)
docs/manual/ccache-support.txt +11 -0
@@ -23,3 +23,14 @@ remove this directory. You can get statistics on the cache (its size, number of hits, misses, etc.) by running +make ccache-stats+. + +The make target +ccache-options+ and the +CCACHE_OPTIONS+ variable +provide more generic access to the ccache. For example + +----------------- +# set cache limit size +make CCACHE_OPTIONS="--max-size=5G" ccache-options + +# zero statistics counters +make CCACHE_OPTIONS="--zero-stats" ccache-options +-----------------
package/ccache/ccache.mk +11 -0
@@ -45,3 +45,14 @@ ifeq ($(BR2_CCACHE),y) ccache-stats: host-ccache $(Q)$(CCACHE) -s endif + +ifeq ($(BR2_CCACHE),y) +ccache-options: host-ccache +ifeq ($(CCACHE_OPTIONS),) + $(Q)echo "Usage: make ccache-options CCACHE_OPTIONS=\"opts\"" + $(Q)echo "where 'opts' corresponds to one or more valid ccache options" \ + "(see ccache help text below)" + $(Q)echo +endif + $(Q)$(CCACHE) $(CCACHE_OPTIONS) +endif
Signature · 1 line
1.8.3.2
PATCH v4 1/1 ccache: expose control interface via 'make ccache-options'
Hi Tzu-Jung,
Quoted 45 lines · Tzu-Jung Lee
usage:
# set cache limit size make CCACHE_OPTIONS="--max-size=5G" ccache-options# zero statistics counters make CCACHE_OPTIONS="--zero-stats" ccache-optionsSigned-off-by Tzu-Jung Lee <[email protected]>---
Include the useful warning message suggested by Thomas.We might need a separate patch to obsolete the ccache-stats later.
docs/manual/ccache-support.txt| 11 +++++++++++package/ccache/ccache.mk| 11 +++++++++++2 files changed, 22 insertions(+)docs/manual/ccache-support.txt +0
-0@@ -23,3 +23,14 @@ remove this directory. You can get statistics on the cache (its size, number of hits,misses, etc.) by running +make ccache-stats+.
docs/manual/ccache-support.txt +11
-0+ +The make target +ccache-options+ and the +CCACHE_OPTIONS+ variable +provide more generic access to the ccache. For example + +----------------- +# set cache limit size +make CCACHE_OPTIONS="--max-size=5G" ccache-options + +# zero statistics counters +make CCACHE_OPTIONS="--zero-stats" ccache-options +-----------------package/ccache/ccache.mk +0
-0@@ -45,3 +45,14 @@ ifeq ($(BR2_CCACHE),y)ccache-stats: host-ccache
$(Q)$(CCACHE) -sendif
package/ccache/ccache.mk +1
-0+
package/ccache/ccache.mk ifeq ($(BR2_CCACHE),y) · line 58
Quoted 10 lines
package/ccache/ccache.mk +10
-0+ifeq ($(BR2_CCACHE),y) +ccache-options: host-ccache +ifeq ($(CCACHE_OPTIONS),) + $(Q)echo "Usage: make ccache-options CCACHE_OPTIONS=\"opts\"" + $(Q)echo "where 'opts' corresponds to one or more valid ccache options" \ + "(see ccache help text below)" + $(Q)echo +endif + $(Q)$(CCACHE) $(CCACHE_OPTIONS) +endif
Did you see my other comment about combining the ifeq statements of ccache-stats and ccache-options?
Best regards,
Thomas
PATCH v4 1/1 ccache: expose control interface via 'make ccache-options'
Hi Thomas,
Quoted 52 lines · Thomas De Schampheleire
Hi Tzu-Jung,
Quoted 49 lines · Tzu-Jung Lee
usage:
# set cache limit size make CCACHE_OPTIONS="--max-size=5G" ccache-options# zero statistics counters make CCACHE_OPTIONS="--zero-stats" ccache-optionsSigned-off-by Tzu-Jung Lee <[email protected]>---
Include the useful warning message suggested by Thomas.We might need a separate patch to obsolete the ccache-stats later.
docs/manual/ccache-support.txt| 11 +++++++++++package/ccache/ccache.mk| 11 +++++++++++2 files changed, 22 insertions(+)docs/manual/ccache-support.txt +0
-0@@ -23,3 +23,14 @@ remove this directory. You can get statistics on the cache (its size, number of hits,misses, etc.) by running +make ccache-stats+.
docs/manual/ccache-support.txt +11
-0+ +The make target +ccache-options+ and the +CCACHE_OPTIONS+ variable +provide more generic access to the ccache. For example + +----------------- +# set cache limit size +make CCACHE_OPTIONS="--max-size=5G" ccache-options + +# zero statistics counters +make CCACHE_OPTIONS="--zero-stats" ccache-options +-----------------package/ccache/ccache.mk +0
-0@@ -45,3 +45,14 @@ ifeq ($(BR2_CCACHE),y)ccache-stats: host-ccache
$(Q)$(CCACHE) -sendif
package/ccache/ccache.mk +5
-0+ +ifeq ($(BR2_CCACHE),y) +ccache-options: host-ccache +ifeq ($(CCACHE_OPTIONS),) + $(Q)echo "Usage: make ccache-options CCACHE_OPTIONS=\"opts\""
Quoted 8 lines
package/ccache/ccache.mk ifeq ($(BR2_CCACHE),y) · line 58
Quoted 6 lines
package/ccache/ccache.mk +6
-0+ $(Q)echo "where 'opts' corresponds to one or more valid ccache options" \ + "(see ccache help text below)" + $(Q)echo +endif + $(Q)$(CCACHE) $(CCACHE_OPTIONS) +endifDid you see my other comment about combining the ifeq statements of ccache-stats and ccache-options?
Yes, but I think it probably would be better as a separate patch, which:
1. either remove the ccache-stats code & and manual section
2. or issue warning about the obsolete usage.
So this patch alone don't affect those are currently using ccache-stats before they migrate to ccache-options.
thanks.
Roy
PATCH v4 1/1 ccache: expose control interface via 'make ccache-options'
Dear Tzu-Jung Lee,
Quoted 11 lines · Tzu-Jung Lee
Quoted 2 lines
Did you see my other comment about combining the ifeq statements of ccache-stats and ccache-options?
Yes, but I think it probably would be better as a separate patch, which:
1. either remove the ccache-stats code & and manual section
2. or issue warning about the obsolete usage.So this patch alone don't affect those are currently using ccache-stats before they migrate to ccache-options.
I believe there might be a misunderstanding here. You seem to think Thomas suggested to remove ccache-stats because ccache-options now allows to do the same.
But in fact, Thomas only suggested to change:
"""
ifeq ($(BR2_CCACHE),y)
ccache-stats:
...
endif
ifeq ($(BR2_CCACHE),y)
ccache-options:
...
endif
"""
by
"""
ifeq ($(BR2_CCACHE),y)
ccache-stats:
...
ccache-options:
...
endif
"""
i.e, ccache-stats continues to exist, the only difference with your implementation is that it sits under the same ifeq ($(BR2_CCACHE),y) condition. It's just a minor nit.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v4 1/1 ccache: expose control interface via 'make ccache-options'
Quoted 40 lines · Thomas Petazzoni
Dear Tzu-Jung Lee,
Quoted 11 lines · Tzu-Jung Lee
Quoted 2 lines
Did you see my other comment about combining the ifeq statements of ccache-stats and ccache-options?
Yes, but I think it probably would be better as a separate patch, which:
1. either remove the ccache-stats code & and manual section
2. or issue warning about the obsolete usage.So this patch alone don't affect those are currently using ccache-stats before they migrate to ccache-options.
I believe there might be a misunderstanding here. You seem to think Thomas suggested to remove ccache-stats because ccache-options now allows to do the same.
But in fact, Thomas only suggested to change:
"""
ifeq ($(BR2_CCACHE),y)
ccache-stats:...endif
ifeq ($(BR2_CCACHE),y)
ccache-options:...endif
"""by
"""
ifeq ($(BR2_CCACHE),y)
ccache-stats:...
Quoted 8 lines
ccache-options:
...endif
"""i.e, ccache-stats continues to exist, the only difference with your implementation is that it sits under the same ifeq ($(BR2_CCACHE),y) condition. It's just a minor nit.
Oops, my bad.
Could you help do the inline editing when you merge it?
thanks.
Roy
Quoted 8 lines
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
PATCH v4 1/1 ccache: expose control interface via 'make ccache-options'
Dear Tzu-Jung Lee,
Quoted 6 lines · Tzu-Jung Lee
Quoted 3 lines
i.e, ccache-stats continues to exist, the only difference with your implementation is that it sits under the same ifeq ($(BR2_CCACHE),y) condition. It's just a minor nit.
Oops, my bad.
Could you help do the inline editing when you merge it?
I'm not the maintainer, so I can't merge patches. But most likely, Peter Korsgaard can do it when merging your patch.
Thanks a lot for all your quick updates to this patch!
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v4 1/1 ccache: expose control interface via 'make ccache-options'
Quoted 8 lines · Thomas Petazzoni
Dear Tzu-Jung Lee,
Quoted 4 lines · Tzu-Jung Lee
Quoted 3 lines
i.e, ccache-stats continues to exist, the only difference with your implementation is that it sits under the same ifeq ($(BR2_CCACHE),y) condition. It's just a minor nit.
Quoted 7 lines
Quoted 2 lines
Oops, my bad.
Could you help do the inline editing when you merge it?I'm not the maintainer, so I can't merge patches. But most likely, Peter Korsgaard can do it when merging your patch.
Thanks a lot for all your quick updates to this patch!
Yes, I certainly agree with that!
PATCH v4 1/1 ccache: expose control interface via 'make ccache-options'
In reply to Tzu-Jung LeeQuoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Tzu-Jung" == Tzu-Jung Lee <[email protected]> writes:
usage:
# set cache limit size make CCACHE_OPTIONS="--max-size=5G" ccache-options# zero statistics counters make CCACHE_OPTIONS="--zero-stats" ccache-optionsSigned-off-by Tzu-Jung Lee <[email protected]>
Committed with the redundant ifeq removed as pointed out by Thomas, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 ccache: expose control interface via 'make ccache-options'
In reply to Tzu-Jung LeeDear Tzu-Jung Lee,
Quoted 9 lines · Tzu-Jung Lee
# Response to patchwork cleanup of week #1
This patch provides an easy way to operate on buildroot ccache such as changing the cache limit or showing statistics.
Without it, users would have to explicitly specify both the environment variable and the path of patched ccache, for example:
BUILDROOT_CACHE_DIR=~/.buildroot-ccache/ $PWD/host/usr/bin/ccache -s
Well, in the case of just passing "-s", we already have the ccache-stats target.
But I agree that for all other options, adding another ccache-<something> target would be impractical, so probably your proposal of CCACHE_OPTIONS makes sense.
Can you respin your patch on top of the latest master, and add an update to the manual (we already have a section about ccache support, see http://buildroot.org/downloads/manual/manual.html#ccache).
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com