Skip to contentSkip to conversation

hw/s390x/css: Remove double initialization

PATCH Applied Philippe Mathieu-Daudé 3 participants 3 messages Sep 7, 2020 – Sep 9, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/s390x/css: Remove double initialization

Fix eventual copy/paste mistake introduced in commit bc994b74ea ("s390x/css: Use static initialization for channel_subsys fields").

---
 hw/s390x/css.c | 1 -
 1 file changed, 1 deletion(-)
hw/s390x/css.c +0 -1
index 519dc91316d..9961cfe7bf6 100644
@@ -353,7 +353,6 @@ static ChannelSubSys channel_subsys = {
     .pending_crws = QTAILQ_HEAD_INITIALIZER(channel_subsys.pending_crws),
     .do_crw_mchk = true,
     .sei_pending = false,
-    .do_crw_mchk = true,
     .crws_lost = false,
     .chnmon_active = false,
     .indicator_addresses =
Signature · 1 line
2.26.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Philippe Mathieu-Daudé

Fix eventual copy/paste mistake introduced in commit bc994b74ea ("s390x/css: Use static initialization for channel_subsys fields").

---
 hw/s390x/css.c | 1 -
 1 file changed, 1 deletion(-)
hw/s390x/css.c +0 -0
index 519dc91316d..9961cfe7bf6 100644

hw/s390x/css.c static ChannelSubSys channel_subsys = { · line 358

Quoted 7 lines
hw/s390x/css.c +0 -1
@@ -353,7 +353,6 @@ static ChannelSubSys channel_subsys = {
     .pending_crws = QTAILQ_HEAD_INITIALIZER(channel_subsys.pending_crws),
     .do_crw_mchk = true,
     .sei_pending = false,
-    .do_crw_mchk = true,
     .crws_lost = false,
     .chnmon_active = false,
     .indicator_addresses =
#2 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 13 lines · On Mon, 7 Sep 2020 04:40:20 +0200 Philippe Mathieu-Daudé <[email protected]>…

Fix eventual copy/paste mistake introduced in commit bc994b74ea ("s390x/css: Use static initialization for channel_subsys fields").

---
 hw/s390x/css.c | 1 -
 1 file changed, 1 deletion(-)
hw/s390x/css.c +0 -0
index 519dc91316d..9961cfe7bf6 100644

hw/s390x/css.c static ChannelSubSys channel_subsys = { · line 358

Quoted 7 lines
hw/s390x/css.c +0 -1
@@ -353,7 +353,6 @@ static ChannelSubSys channel_subsys = {
     .pending_crws = QTAILQ_HEAD_INITIALIZER(channel_subsys.pending_crws),
     .do_crw_mchk = true,
     .sei_pending = false,
-    .do_crw_mchk = true,
     .crws_lost = false,
     .chnmon_active = false,
     .indicator_addresses =

Thanks, applied.