Skip to contentSkip to conversation

- Schedule mcdx for removal ? was: warning: #warning You have not edited mcdx.h

RFC roland 3 participants 4 messages Mar 22, 2007 – Mar 23, 2007

lore
Share & tools
lore

roland

author
#0 lore raw

anyway - i wonder if anybody is ever using 2.6.21+ on a system with one of those legacy mitsumi single-speed (LU-005/FX-001) and double-speed (FX-001D) cd-rom drives !?

iirc, these where the first drives available on the market (must have been around '94) and those were no ide/atapi compatible drives which had their own isa-bus controller.

i wonder if there still exist any of those devices in functional state in this world, at least not attached to some system being able to boot 2.6.21+ - so, maybe mcdx driver is something for Documentation/feature-removal-schedule.txt , being removed in 2.6.25 or so after being announced for some time (i.e. driver telling "i will be gone soon, go spend those $15 to get a new drive") ?

not 100% sure here, but there really may be nobody to complain about removing this one.....

regards
roland

ps:
hey, i just read discussions about removing RAW driver, so if THAT being discussed for removal, this one probably should have been removed already ! ;)

----- Original Message ----- From: "roland" <[email protected]>
To: <[email protected]>
Cc: <[email protected]>
Sent: Thursday, March 22, 2007 1:43 AM
Subject: warning: #warning You have not edited mcdx.h

Quoted 40 lines

while looking at some more warnings i got with allyesconfig i came across this really weird one:

In file included from drivers/cdrom/mcdx.c:78:
drivers/cdrom/mcdx.h:180:2: warning: #warning You have not edited mcdx.h drivers/cdrom/mcdx.h:181:2: warning: #warning Perhaps irq and i/o settings are wrong.

looking into the code :

#ifndef I_WAS_HERE
#ifndef MODULE
#warning You have not edited mcdx.h
#warning Perhaps irq and i/o settings are wrong.
#endif
#endif

and before:
/* *** make the following line uncommented, if you're sure,
* *** all configuration is done */
/* #define I_WAS_HERE */

huh?

is this file meant to be edited before compile ?

searched the list and came across some patch from adrian bunk:

[Patch] (new version) configure mcdx without editing mcdx.h

at http://marc.info/?l=linux-kernel&m=94772887906874&w=2
and http://marc.info/?l=linux-kernel&m=94724271712637&w=2
and http://marc.info/?l=linux-kernel&m=94699770112439&w=2

has this never been merged ?

regards
roland

#1 lore raw

Am Donnerstag, 22. März 2007 10:14 schrieb roland:

Quoted 6 lines

i wonder if there still exist any of those devices in functional state in this world, at least not attached to some system being able to boot 2.6.21+ - so, maybe mcdx driver is something for Documentation/feature-removal-schedule.txt , being removed in 2.6.25 or so after being announced for some time (i.e. driver telling "i will be gone soon, go spend those $15 to get a new drive") ?

Why? For the sake of sheer removal?

Regards
Oliver

Signature · 2 lines
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
This signature is a legal requirement
author
#2 lore raw

why not?

why should unused code be maintained to death ?

if there are discussions about removing features people are still using, i think it should be legitimate to discuss about removing drivers nobody needs anymore....

----- Original Message ----- From: "Oliver Neukum" <[email protected]>
To: "roland" <[email protected]>
Cc: <[email protected]>; <[email protected]>
Sent: Thursday, March 22, 2007 10:35 AM
Subject: Re: [RFC] - Schedule mcdx for removal ? was: warning: #warning You have not edited mcdx.h

Am Donnerstag, 22. März 2007 10:14 schrieb roland:

Quoted 6 lines

i wonder if there still exist any of those devices in functional state in this world, at least not attached to some system being able to boot 2.6.21+ - so, maybe mcdx driver is something for Documentation/feature-removal-schedule.txt , being removed in 2.6.25 or so after being announced for some time (i.e. driver telling "i will be gone soon, go spend those $15 to get a new drive") ?

Why? For the sake of sheer removal?

Regards
Oliver

Signature · 2 lines
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
This signature is a legal requirement 
#3 lore raw
Quoted 3 lines · roland

why not?

why should unused code be maintained to death ?

This driver hasn't been actively maintained for years - it's nearly zero-cost to carry such a driver in the kernel sources.

Quoted 3 lines

if there are discussions about removing features people are still using, i think it should be legitimate to discuss about removing drivers nobody needs anymore....

There's a difference between obsolete features and drivers for old
hardware: There's usually a replacement for the obsolete features.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed