drm/syncobj: Extend EXPORT_SYNC_FILE for timeline syncobjs
Subsystems (3)
PATCH 1/1 drm/syncobj: Extend EXPORT_SYNC_FILE for timeline syncobjs
From: Rob Clark <[email protected]>
Add support for exporting a dma_fence fd for a specific point on a timeline.
--- drivers/gpu/drm/drm_syncobj.c | 8 ++++++-- include/uapi/drm/drm.h | 2 ++ 2 files changed, 8 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_syncobj.c +6 -2
@@ -762,7 +762,7 @@ static int drm_syncobj_import_sync_file_fence(struct drm_file *file_private, }static int drm_syncobj_export_sync_file (struct drm_file *file_private, -int handle,int *p_fd) +int handle,u64 point,int *p_fd) {int ret;struct dma_fence *fence;
@@ -772,7 +772,7 @@ static int drm_syncobj_export_sync_file(struct drm_file *file_private,if (fd <0 )return fd; - ret =drm_syncobj_find_fence (file_private, handle,0 ,0 , &fence); + ret =drm_syncobj_find_fence (file_private, handle, point,0 , &fence);if (ret) goto err_put_fd;
@@ -882,8 +882,12 @@ drm_syncobj_handle_to_fd_ioctl(struct drm_device *dev, void *data,if (args->flags &DRM_SYNCOBJ_HANDLE_TO_FD_FLAGS_EXPORT_SYNC_FILE )return drm_syncobj_export_sync_file (file_private, args->handle, + args->point, &args->fd); +if (args->point) +return -EINVAL ; +return drm_syncobj_handle_to_fd (file_private, args->handle, &args->fd); }
include/uapi/drm/drm.h +2 -0
@@ -912,6 +912,8 @@ struct drm_syncobj_handle {__s32 fd;__u32 pad; + +__u64 point; };struct drm_syncobj_transfer {
Signature · 1 line
2.49.0
Am 26.03.25 um 15:39 schrieb Rob Clark:
Quoted 4 lines
From: Rob Clark <[email protected]>
Add support for exporting a
dma_fencefd for a specific point on a timeline.
Looks good on first glance. What's the userspace use case?
Regards,
Christian.
Quoted 55 lines
Signed-off-by Rob Clark <[email protected]>--- drivers/gpu/drm/drm_syncobj.c | 8 ++++++-- include/uapi/drm/drm.h | 2 ++ 2 files changed, 8 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_syncobj.c +6
-2@@ -762,7 +762,7 @@ static int drm_syncobj_import_sync_file_fence(struct drm_file *file_private, }static int drm_syncobj_export_sync_file (struct drm_file *file_private, -int handle,int *p_fd) +int handle,u64 point,int *p_fd) {int ret;struct dma_fence *fence;@@ -772,7 +772,7 @@ static int drm_syncobj_export_sync_file(struct drm_file *file_private,if (fd <0 )return fd; - ret =drm_syncobj_find_fence (file_private, handle,0 ,0 , &fence); + ret =drm_syncobj_find_fence (file_private, handle, point,0 , &fence);if (ret) goto err_put_fd;@@ -882,8 +882,12 @@ drm_syncobj_handle_to_fd_ioctl(struct drm_device *dev, void *data,if (args->flags &DRM_SYNCOBJ_HANDLE_TO_FD_FLAGS_EXPORT_SYNC_FILE )return drm_syncobj_export_sync_file (file_private, args->handle, + args->point, &args->fd); +if (args->point) +return -EINVAL ; +return drm_syncobj_handle_to_fd (file_private, args->handle, &args->fd); }include/uapi/drm/drm.h +2
-0@@ -912,6 +912,8 @@ struct drm_syncobj_handle {__s32 fd;__u32 pad; + +__u64 point; };struct drm_syncobj_transfer {
Quoted 8 lines · Christian König
Am 26.03.25 um 15:39 schrieb Rob Clark:
Quoted 4 lines
From: Rob Clark <[email protected]>
Add support for exporting a
dma_fencefd for a specific point on a timeline.Looks good on first glance. What's the userspace use case?
Timeline syncobj support for vtest/vpipe[1][2].. since core virglrender and drm native ctx works in terms of fences (since in the VM case, everything is a fence below the guest kernel uabi), we need to be able to turn a point on a timeline back into a fence fd. (Plus it seemed like an odd omission from the existing uabi.)
BR,
-R
[1] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33433
[2] https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/805
Quoted 60 lines
Regards,
Christian.Quoted 55 lines
Signed-off-by Rob Clark <[email protected]>--- drivers/gpu/drm/drm_syncobj.c | 8 ++++++-- include/uapi/drm/drm.h | 2 ++ 2 files changed, 8 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_syncobj.c +6
-2@@ -762,7 +762,7 @@ static int drm_syncobj_import_sync_file_fence(struct drm_file *file_private, }static int drm_syncobj_export_sync_file (struct drm_file *file_private, -int handle,int *p_fd) +int handle,u64 point,int *p_fd) {int ret;struct dma_fence *fence;@@ -772,7 +772,7 @@ static int drm_syncobj_export_sync_file(struct drm_file *file_private,if (fd <0 )return fd; - ret =drm_syncobj_find_fence (file_private, handle,0 ,0 , &fence); + ret =drm_syncobj_find_fence (file_private, handle, point,0 , &fence);if (ret) goto err_put_fd;@@ -882,8 +882,12 @@ drm_syncobj_handle_to_fd_ioctl(struct drm_device *dev, void *data,if (args->flags &DRM_SYNCOBJ_HANDLE_TO_FD_FLAGS_EXPORT_SYNC_FILE )return drm_syncobj_export_sync_file (file_private, args->handle, + args->point, &args->fd); +if (args->point) +return -EINVAL ; +return drm_syncobj_handle_to_fd (file_private, args->handle, &args->fd); }include/uapi/drm/drm.h +2
-0@@ -912,6 +912,8 @@ struct drm_syncobj_handle {__s32 fd;__u32 pad; + +__u64 point; };struct drm_syncobj_transfer {
Quoted 57 lines · Rob Clark
Quoted 8 lines · Christian König
Am 26.03.25 um 15:39 schrieb Rob Clark:
Quoted 4 lines
From: Rob Clark <[email protected]>
Add support for exporting a
dma_fencefd for a specific point on a timeline.Looks good on first glance. What's the userspace use case?
Timeline syncobj support for vtest/vpipe[1][2].. since core virglrender and drm native ctx works in terms of fences (since in the VM case, everything is a fence below the guest kernel uabi), we need to be able to turn a point on a timeline back into a fence fd. (Plus it seemed like an odd omission from the existing uabi.)
BR,
-R[1] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33433
[2] https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/805Quoted 33 lines
Regards,
Christian.Quoted 29 lines
Signed-off-by Rob Clark <[email protected]>--- drivers/gpu/drm/drm_syncobj.c | 8 ++++++-- include/uapi/drm/drm.h | 2 ++ 2 files changed, 8 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_syncobj.c +2
-2@@ -762,7 +762,7 @@ static int drm_syncobj_import_sync_file_fence(struct drm_file *file_private, }static int drm_syncobj_export_sync_file (struct drm_file *file_private, -int handle,int *p_fd) +int handle,u64 point,int *p_fd) {int ret;struct dma_fence *fence;@@ -772,7 +772,7 @@ static int drm_syncobj_export_sync_file(struct drm_file *file_private,if (fd <0 )return fd; - ret =drm_syncobj_find_fence (file_private, handle,0 ,0 , &fence); + ret =drm_syncobj_find_fence (file_private, handle, point,0 , &fence);if (ret) goto err_put_fd;
Quoted 6 lines
Quoted 6 lines
drivers/gpu/drm/drm_syncobj.c drm_syncobj_handle_to_fd_ioctl(struct drm_device *dev, void *data, · line 886
Quoted 6 lines
drivers/gpu/drm/drm_syncobj.c +1
-0@@ -882,8 +882,12 @@ drm_syncobj_handle_to_fd_ioctl(struct drm_device *dev, void *data,if (args->flags &DRM_SYNCOBJ_HANDLE_TO_FD_FLAGS_EXPORT_SYNC_FILE )return drm_syncobj_export_sync_file (file_private, args->handle, + args->point, &args->fd);
Hmm, maybe I should add DRM_SYNCOBJ_HANDLE_TO_FD_FLAGS_TIMELINE so that userspace gets a clean error on older kernels, rather than having the point param be silently ignored..
BR,
-R
Quoted 21 lines
Quoted 21 lines
Quoted 20 lines
drivers/gpu/drm/drm_syncobj.c +3
-0+if (args->point) +return -EINVAL ; +return drm_syncobj_handle_to_fd (file_private, args->handle, &args->fd); }include/uapi/drm/drm.h +2
-0@@ -912,6 +912,8 @@ struct drm_syncobj_handle {__s32 fd;__u32 pad; + +__u64 point; };struct drm_syncobj_transfer {
Am 26.03.25 um 21:46 schrieb Rob Clark:
Quoted 54 lines · Rob Clark
Quoted 53 lines
Quoted 6 lines · Christian König
Am 26.03.25 um 15:39 schrieb Rob Clark:
Quoted 4 lines
From: Rob Clark <[email protected]>
Add support for exporting a
dma_fencefd for a specific point on a timeline.Looks good on first glance. What's the userspace use case?
Timeline syncobj support for vtest/vpipe[1][2].. since core virglrender and drm native ctx works in terms of fences (since in the VM case, everything is a fence below the guest kernel uabi), we need to be able to turn a point on a timeline back into a fence fd. (Plus it seemed like an odd omission from the existing uabi.)
BR,
-R[1] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33433
[2] https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/805Quoted 33 lines
Regards,
Christian.Quoted 30 lines
Signed-off-by Rob Clark <[email protected]>--- drivers/gpu/drm/drm_syncobj.c | 8 ++++++-- include/uapi/drm/drm.h | 2 ++ 2 files changed, 8 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_syncobj.c +2
-2@@ -762,7 +762,7 @@ static int drm_syncobj_import_sync_file_fence(struct drm_file *file_private, }static int drm_syncobj_export_sync_file (struct drm_file *file_private, -int handle,int *p_fd) +int handle,u64 point,int *p_fd) {int ret;struct dma_fence *fence;@@ -772,7 +772,7 @@ static int drm_syncobj_export_sync_file(struct drm_file *file_private,if (fd <0 )return fd; - ret =drm_syncobj_find_fence (file_private, handle,0 ,0 , &fence); + ret =drm_syncobj_find_fence (file_private, handle, point,0 , &fence);if (ret) goto err_put_fd;@@ -882,8 +882,12 @@ drm_syncobj_handle_to_fd_ioctl(struct drm_device *dev, void *data,
Quoted 7 lines
Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/drm_syncobj.c drm_syncobj_handle_to_fd_ioctl(struct drm_device *dev, void *data, · line 886
Quoted 4 lines
drivers/gpu/drm/drm_syncobj.c +1
-0if (args->flags &DRM_SYNCOBJ_HANDLE_TO_FD_FLAGS_EXPORT_SYNC_FILE )return drm_syncobj_export_sync_file (file_private, args->handle, + args->point, &args->fd);Hmm, maybe I should add
DRM_SYNCOBJ_HANDLE_TO_FD_FLAGS_TIMELINEso that userspace gets a clean error on older kernels, rather than having the point param be silently ignored..
Sounds reasonable to me as well.
And please include the links to the userspace code in the commit message.
Apart from that looks totally reasonable to me.
Regards,
Christian.
Quoted 23 lines
BR,
-RQuoted 19 lines
Quoted 19 lines
Quoted 19 lines
drivers/gpu/drm/drm_syncobj.c +3
-0+if (args->point) +return -EINVAL ; +return drm_syncobj_handle_to_fd (file_private, args->handle, &args->fd); }include/uapi/drm/drm.h +2
-0@@ -912,6 +912,8 @@ struct drm_syncobj_handle {__s32 fd;__u32 pad; + +__u64 point; };struct drm_syncobj_transfer {