Skip to contentSkip to conversation

glfw: add packageconfig and wayland dependencies

PATCH In review [email protected] 5 participants 15 messages Apr 27, 2023 – May 2, 2023

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 glfw: add packageconfig and wayland dependencies

From: Randolph Sapp <[email protected]>

GLFW has the ability to use a wayland backend. This patch adds a config for it, but does not enable it by default because it has a dependency on extra-cmake-modules which is provided (most commonly) by meta-qt5-extra.

---
 meta-oe/recipes-core/glfw/glfw_3.3.bb | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
meta-oe/recipes-core/glfw/glfw_3.3.bb +12 -2
index b31bba6b6b..5b0d61241e 100644
@@ -20,7 +20,17 @@ EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DGLFW_BUILD_DOCS=OFF"
 
 CFLAGS += "-fPIC"
 
-DEPENDS = "libpng libglu zlib libxrandr libxinerama libxi libxcursor"
-REQUIRED_DISTRO_FEATURES = "x11 opengl"
+DEPENDS = "libpng libglu zlib"
+REQUIRED_DISTRO_FEATURES = "opengl"
+ANY_OF_DISTRO_FEATURES = "wayland x11"
+
+# upstream considers x11 and wayland backends mutually exclusive and will
+# prioritize wayland if it is enabled, but wayland has dependencies that cannot
+# be satisfied by this layer so it is disabled by default
+
+PACKAGECONFIG ??= "x11"
+
+PACKAGECONFIG[wayland] = "-DGLFW_USE_WAYLAND=ON,,wayland wayland-native wayland-protocols extra-cmake-modules libxkbcommon"
+PACKAGECONFIG[x11] = ",,libxrandr libxinerama libxi libxcursor"
 
 COMPATIBLE_HOST:libc-musl = "null"
Signature · 1 line
2.40.0
#1 lore raw
Quoted 23 lines · On Thu, Apr 27, 2023 at 9:47 AM <[email protected]> wrote:

From: Randolph Sapp <[email protected]>

GLFW has the ability to use a wayland backend. This patch adds a config for it, but does not enable it by default because it has a dependency on extra-cmake-modules which is provided (most commonly) by meta-qt5-extra.

---
 meta-oe/recipes-core/glfw/glfw_3.3.bb | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
meta-oe/recipes-core/glfw/glfw_3.3.bb +1 -2
index b31bba6b6b..5b0d61241e 100644
@@ -20,7 +20,17 @@ EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DGLFW_BUILD_DOCS=OFF"
 
 CFLAGS += "-fPIC"
 
-DEPENDS = "libpng libglu zlib libxrandr libxinerama libxi libxcursor"
-REQUIRED_DISTRO_FEATURES = "x11 opengl"
+DEPENDS = "libpng libglu zlib"

meta-oe/recipes-core/glfw/glfw_3.3.bb EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DGLFW_BUILD_DOCS=OFF" · line 33

Quoted 10 lines
meta-oe/recipes-core/glfw/glfw_3.3.bb +10 -0
+REQUIRED_DISTRO_FEATURES = "opengl"
+ANY_OF_DISTRO_FEATURES = "wayland x11"
+
+# upstream considers x11 and wayland backends mutually exclusive and will
+# prioritize wayland if it is enabled, but wayland has dependencies that cannot
+# be satisfied by this layer so it is disabled by default
+
+PACKAGECONFIG ??= "x11"
+
+PACKAGECONFIG[wayland] = "-DGLFW_USE_WAYLAND=ON,,wayland wayland-native wayland-protocols extra-cmake-modules libxkbcommon"

I wonder if extra-cmake-modules recipe is common enough to live in meta-oe

Quoted 6 lines
meta-oe/recipes-core/glfw/glfw_3.3.bb +1 -1
+PACKAGECONFIG[x11] = ",,libxrandr libxinerama libxi libxcursor"
 
 COMPATIBLE_HOST:libc-musl = "null"
--

2.40.0

#2 lore raw
Quoted 21 lines · Khem Raj
Quoted 20 lines · On Thu, Apr 27, 2023 at 9:47 AM <[email protected]> wrote:

From: Randolph Sapp <[email protected]>

GLFW has the ability to use a wayland backend. This patch adds a config for it, but does not enable it by default because it has a dependency on extra-cmake-modules which is provided (most commonly) by meta-qt5-extra.

---
  meta-oe/recipes-core/glfw/glfw_3.3.bb | 14 ++++++++++++--
  1 file changed, 12 insertions(+), 2 deletions(-)
meta-oe/recipes-core/glfw/glfw_3.3.bb +0 -0
index b31bba6b6b..5b0d61241e 100644
@@ -20,7 +20,17 @@ EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DGLFW_BUILD_DOCS=OFF"
 
  CFLAGS += "-fPIC"
 
Quoted 15 lines

meta-oe/recipes-core/glfw/glfw_3.3.bb EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DGLFW_BUILD_DOCS=OFF" · line 33

Quoted 13 lines
meta-oe/recipes-core/glfw/glfw_3.3.bb +11 -2
-DEPENDS = "libpng libglu zlib libxrandr libxinerama libxi libxcursor"
-REQUIRED_DISTRO_FEATURES = "x11 opengl"
+DEPENDS = "libpng libglu zlib"
+REQUIRED_DISTRO_FEATURES = "opengl"
+ANY_OF_DISTRO_FEATURES = "wayland x11"
+
+# upstream considers x11 and wayland backends mutually exclusive and will
+# prioritize wayland if it is enabled, but wayland has dependencies that cannot
+# be satisfied by this layer so it is disabled by default
+
+PACKAGECONFIG ??= "x11"
+
+PACKAGECONFIG[wayland] = "-DGLFW_USE_WAYLAND=ON,,wayland wayland-native wayland-protocols extra-cmake-modules libxkbcommon"

I wonder if extra-cmake-modules recipe is common enough to live in meta-oe

I'd be happy to offer up a recipe loosely based on what we've got in meta-arago if you think it's worth it, but it seems to be mostly KDE specific excluding this weird instance and a handful of desktop applications that aren't packaged by oe-core or meta-oe.

Quoted 6 lines
Quoted 6 lines
meta-oe/recipes-core/glfw/glfw_3.3.bb +1 -1
+PACKAGECONFIG[x11] = ",,libxrandr libxinerama libxi libxcursor"
 
  COMPATIBLE_HOST:libc-musl = "null"
--

2.40.0

#3 lore raw
Quoted 39 lines · Randolph Sapp
Quoted 21 lines · Khem Raj
Quoted 20 lines · On Thu, Apr 27, 2023 at 9:47 AM <[email protected]> wrote:

From: Randolph Sapp <[email protected]>

GLFW has the ability to use a wayland backend. This patch adds a config for it, but does not enable it by default because it has a dependency on extra-cmake-modules which is provided (most commonly) by meta-qt5-extra.

---
  meta-oe/recipes-core/glfw/glfw_3.3.bb | 14 ++++++++++++--
  1 file changed, 12 insertions(+), 2 deletions(-)
meta-oe/recipes-core/glfw/glfw_3.3.bb +0 -0
index b31bba6b6b..5b0d61241e 100644
@@ -20,7 +20,17 @@ EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DGLFW_BUILD_DOCS=OFF"
 
  CFLAGS += "-fPIC"
 
Quoted 15 lines

meta-oe/recipes-core/glfw/glfw_3.3.bb EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DGLFW_BUILD_DOCS=OFF" · line 33

Quoted 13 lines
meta-oe/recipes-core/glfw/glfw_3.3.bb +11 -2
-DEPENDS = "libpng libglu zlib libxrandr libxinerama libxi libxcursor"
-REQUIRED_DISTRO_FEATURES = "x11 opengl"
+DEPENDS = "libpng libglu zlib"
+REQUIRED_DISTRO_FEATURES = "opengl"
+ANY_OF_DISTRO_FEATURES = "wayland x11"
+
+# upstream considers x11 and wayland backends mutually exclusive and will
+# prioritize wayland if it is enabled, but wayland has dependencies that cannot
+# be satisfied by this layer so it is disabled by default
+
+PACKAGECONFIG ??= "x11"
+
+PACKAGECONFIG[wayland] = "-DGLFW_USE_WAYLAND=ON,,wayland wayland-native wayland-protocols extra-cmake-modules libxkbcommon"

I wonder if extra-cmake-modules recipe is common enough to live in meta-oe

Quoted 4 lines

I'd be happy to offer up a recipe loosely based on what we've got in meta-arago if you think it's worth it, but it seems to be mostly KDE specific excluding this weird instance and a handful of desktop applications that aren't packaged by oe-core or meta-oe.

We dont want KDE stuff, but the fact that enabling wayland support needs it is less than ideal.

Quoted 8 lines
Quoted 7 lines
Quoted 7 lines
meta-oe/recipes-core/glfw/glfw_3.3.bb +1 -1
+PACKAGECONFIG[x11] = ",,libxrandr libxinerama libxi libxcursor"
 
  COMPATIBLE_HOST:libc-musl = "null"
--

2.40.0

#4 lore raw
Quoted 40 lines · Khem Raj
Quoted 39 lines · Randolph Sapp
Quoted 36 lines · Khem Raj
Quoted 23 lines · On Thu, Apr 27, 2023 at 9:47 AM <[email protected]> wrote:

From: Randolph Sapp <[email protected]>

GLFW has the ability to use a wayland backend. This patch adds a config for it, but does not enable it by default because it has a dependency on extra-cmake-modules which is provided (most commonly) by meta-qt5-extra.

---
   meta-oe/recipes-core/glfw/glfw_3.3.bb | 14 ++++++++++++--
   1 file changed, 12 insertions(+), 2 deletions(-)
meta-oe/recipes-core/glfw/glfw_3.3.bb +1 -2
index b31bba6b6b..5b0d61241e 100644
@@ -20,7 +20,17 @@ EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DGLFW_BUILD_DOCS=OFF"
 
   CFLAGS += "-fPIC"
 
-DEPENDS = "libpng libglu zlib libxrandr libxinerama libxi libxcursor"
-REQUIRED_DISTRO_FEATURES = "x11 opengl"
+DEPENDS = "libpng libglu zlib"

meta-oe/recipes-core/glfw/glfw_3.3.bb EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DGLFW_BUILD_DOCS=OFF" · line 33

Quoted 10 lines
meta-oe/recipes-core/glfw/glfw_3.3.bb +10 -0
+REQUIRED_DISTRO_FEATURES = "opengl"
+ANY_OF_DISTRO_FEATURES = "wayland x11"
+
+# upstream considers x11 and wayland backends mutually exclusive and will
+# prioritize wayland if it is enabled, but wayland has dependencies that cannot
+# be satisfied by this layer so it is disabled by default
+
+PACKAGECONFIG ??= "x11"
+
+PACKAGECONFIG[wayland] = "-DGLFW_USE_WAYLAND=ON,,wayland wayland-native wayland-protocols extra-cmake-modules libxkbcommon"

I wonder if extra-cmake-modules recipe is common enough to live in meta-oe

Quoted 8 lines
Quoted 4 lines

I'd be happy to offer up a recipe loosely based on what we've got in meta-arago if you think it's worth it, but it seems to be mostly KDE specific excluding this weird instance and a handful of desktop applications that aren't packaged by oe-core or meta-oe.

We dont want KDE stuff, but the fact that enabling wayland support needs it is less than ideal.

Given that this may be required for other components and exists to extend cmake should I make a push to integrate this into oe-core alongside cmake or do you think it's still enough of an optional package that it should be in one of the meta-openembedded layers?

Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
Quoted 7 lines
meta-oe/recipes-core/glfw/glfw_3.3.bb +1 -1
+PACKAGECONFIG[x11] = ",,libxrandr libxinerama libxi libxcursor"
 
   COMPATIBLE_HOST:libc-musl = "null"
--

2.40.0

#5 lore raw
Quoted 47 lines · Randolph Sapp
Quoted 45 lines · Khem Raj
Quoted 43 lines · Randolph Sapp
Quoted 21 lines · Khem Raj
Quoted 20 lines · On Thu, Apr 27, 2023 at 9:47 AM <[email protected]> wrote:

From: Randolph Sapp <[email protected]>

GLFW has the ability to use a wayland backend. This patch adds a config for it, but does not enable it by default because it has a dependency on extra-cmake-modules which is provided (most commonly) by meta-qt5-extra.

---
   meta-oe/recipes-core/glfw/glfw_3.3.bb | 14 ++++++++++++--
   1 file changed, 12 insertions(+), 2 deletions(-)
meta-oe/recipes-core/glfw/glfw_3.3.bb +0 -0
index b31bba6b6b..5b0d61241e 100644
@@ -20,7 +20,17 @@ EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DGLFW_BUILD_DOCS=OFF"
 
   CFLAGS += "-fPIC"
 
Quoted 15 lines

meta-oe/recipes-core/glfw/glfw_3.3.bb EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DGLFW_BUILD_DOCS=OFF" · line 33

Quoted 13 lines
meta-oe/recipes-core/glfw/glfw_3.3.bb +11 -2
-DEPENDS = "libpng libglu zlib libxrandr libxinerama libxi libxcursor"
-REQUIRED_DISTRO_FEATURES = "x11 opengl"
+DEPENDS = "libpng libglu zlib"
+REQUIRED_DISTRO_FEATURES = "opengl"
+ANY_OF_DISTRO_FEATURES = "wayland x11"
+
+# upstream considers x11 and wayland backends mutually exclusive and will
+# prioritize wayland if it is enabled, but wayland has dependencies that cannot
+# be satisfied by this layer so it is disabled by default
+
+PACKAGECONFIG ??= "x11"
+
+PACKAGECONFIG[wayland] = "-DGLFW_USE_WAYLAND=ON,,wayland wayland-native wayland-protocols extra-cmake-modules libxkbcommon"

I wonder if extra-cmake-modules recipe is common enough to live in meta-oe

I'd be happy to offer up a recipe loosely based on what we've got in meta-arago if you think it's worth it, but it seems to be mostly KDE specific excluding this weird instance and a handful of desktop applications that aren't packaged by oe-core or meta-oe.

Quoted 8 lines
Quoted 3 lines

We dont want KDE stuff, but the fact that enabling wayland support needs it is less than ideal.

Given that this may be required for other components and exists to extend cmake should I make a push to integrate this into oe-core alongside cmake or do you think it's still enough of an optional package that it should be in one of the meta-openembedded layers?

Since this enabled wayland, I am interested to see if we can have it in common (non-kde) place.
or make changes to glfw to not need it to enable wayland support.

Quoted 10 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
Quoted 8 lines
meta-oe/recipes-core/glfw/glfw_3.3.bb +1 -1
+PACKAGECONFIG[x11] = ",,libxrandr libxinerama libxi libxcursor"
 
   COMPATIBLE_HOST:libc-musl = "null"
--

2.40.0

#6 lore raw
In reply to [email protected]

Doesn't this need to land it Master first? Kirkstone is in the subject

- armin

Quoted 35 lines · On 4/27/23 12:47 PM, [email protected] wrote:

From: Randolph Sapp <[email protected]>

GLFW has the ability to use a wayland backend. This patch adds a config for it, but does not enable it by default because it has a dependency on extra-cmake-modules which is provided (most commonly) by meta-qt5-extra.

---
  meta-oe/recipes-core/glfw/glfw_3.3.bb | 14 ++++++++++++--
  1 file changed, 12 insertions(+), 2 deletions(-)
meta-oe/recipes-core/glfw/glfw_3.3.bb +12 -2
index b31bba6b6b..5b0d61241e 100644
@@ -20,7 +20,17 @@ EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DGLFW_BUILD_DOCS=OFF"
 
  CFLAGS += "-fPIC"
 
-DEPENDS = "libpng libglu zlib libxrandr libxinerama libxi libxcursor"
-REQUIRED_DISTRO_FEATURES = "x11 opengl"
+DEPENDS = "libpng libglu zlib"
+REQUIRED_DISTRO_FEATURES = "opengl"
+ANY_OF_DISTRO_FEATURES = "wayland x11"
+
+# upstream considers x11 and wayland backends mutually exclusive and will
+# prioritize wayland if it is enabled, but wayland has dependencies that cannot
+# be satisfied by this layer so it is disabled by default
+
+PACKAGECONFIG ??= "x11"
+
+PACKAGECONFIG[wayland] = "-DGLFW_USE_WAYLAND=ON,,wayland wayland-native wayland-protocols extra-cmake-modules libxkbcommon"
+PACKAGECONFIG[x11] = ",,libxrandr libxinerama libxi libxcursor"
 
  COMPATIBLE_HOST:libc-musl = "null"
#7 lore raw
Quoted 4 lines · On 4/28/23 06:16, akuster808 wrote:

Doesn't this need to land it Master first? Kirkstone is in the subject

- armin

Perhaps, but I've only had a chance to test it against kirkstone so I flagged it as such. At this point I'm still vetting solutions to this dependency chain though. Looking for something this layer would actually like to carry.

Quoted 38 lines · On 4/27/23 12:47 PM, [email protected] wrote:
Quoted 36 lines

From: Randolph Sapp <[email protected]>

GLFW has the ability to use a wayland backend. This patch adds a config for it, but does not enable it by default because it has a dependency on extra-cmake-modules which is provided (most commonly) by meta-qt5-extra.

---
  meta-oe/recipes-core/glfw/glfw_3.3.bb | 14 ++++++++++++--

  1 file changed, 12 insertions(+), 2 deletions(-)
meta-oe/recipes-core/glfw/glfw_3.3.bb +0 -1
index b31bba6b6b..5b0d61241e 100644
@@ -20,7 +20,17 @@ EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON 
-DGLFW_BUILD_DOCS=OFF"

  CFLAGS += "-fPIC"

meta-oe/recipes-core/glfw/glfw_3.3.bb +5 -2
-DEPENDS = "libpng libglu zlib libxrandr libxinerama libxi libxcursor"
-REQUIRED_DISTRO_FEATURES = "x11 opengl"
+DEPENDS = "libpng libglu zlib"
+REQUIRED_DISTRO_FEATURES = "opengl"
+ANY_OF_DISTRO_FEATURES = "wayland x11"
+
+# upstream considers x11 and wayland backends mutually exclusive and 

will
+# prioritize wayland if it is enabled, but wayland has dependencies that cannot

meta-oe/recipes-core/glfw/glfw_3.3.bb +5 -0
+# be satisfied by this layer so it is disabled by default
+
+PACKAGECONFIG ??= "x11"
+
+PACKAGECONFIG[wayland] = "-DGLFW_USE_WAYLAND=ON,,wayland 

wayland-native wayland-protocols extra-cmake-modules libxkbcommon" +PACKAGECONFIG[x11] = ",,libxrandr libxinerama libxi libxcursor" COMPATIBLE_HOST:libc-musl = "null"

#8 lore raw

The version which was merged with:

PACKAGECONFIG ??= "x11"

Should still respect x11 in DISTRO_FEATURES, now this causes:

ERROR: Nothing PROVIDES 'libxi' (but meta-oe/recipes-core/glfw/glfw_3.3.bb DEPENDS on or otherwise requires it)
libxi was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libxinerama' (but meta-oe/recipes-core/glfw/ glfw_3.3.bb DEPENDS on or otherwise requires it)
libxinerama was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libxrandr' (but meta-oe/recipes-core/glfw/ glfw_3.3.bb DEPENDS on or otherwise requires it)
libxrandr was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libglu' (but meta-oe/recipes-core/glfw/glfw_3.3.bb DEPENDS on or otherwise requires it)
libglu was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libxcursor' (but meta-oe/recipes-core/glfw/ glfw_3.3.bb DEPENDS on or otherwise requires it)
libxcursor was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)

when wayland and opengl are in DISTRO_FEATURES, but x11 isn't.

REQUIRED_DISTRO_FEATURES is satisfied by "opengl" and ANY_OF_DISTRO_FEATURES by "wayland", but the default PACKAGECONFIG doesn't match with that.

Quoted 63 lines · Randolph Sapp via lists.openembedded.org
Quoted 4 lines · On 4/28/23 06:16, akuster808 wrote:

Doesn't this need to land it Master first? Kirkstone is in the subject

- armin

Perhaps, but I've only had a chance to test it against kirkstone so I flagged it as such. At this point I'm still vetting solutions to this dependency chain though. Looking for something this layer would actually like to carry.

Quoted 30 lines · On 4/27/23 12:47 PM, [email protected] wrote:
Quoted 29 lines

From: Randolph Sapp <[email protected]>

GLFW has the ability to use a wayland backend. This patch adds a config for it, but does not enable it by default because it has a dependency on extra-cmake-modules which is provided (most commonly) by meta-qt5-extra.

---
  meta-oe/recipes-core/glfw/glfw_3.3.bb | 14 ++++++++++++--
  1 file changed, 12 insertions(+), 2 deletions(-)
meta-oe/recipes-core/glfw/glfw_3.3.bb +5 -3
index b31bba6b6b..5b0d61241e 100644
@@ -20,7 +20,17 @@ EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON
-DGLFW_BUILD_DOCS=OFF"
  CFLAGS += "-fPIC"
-DEPENDS = "libpng libglu zlib libxrandr libxinerama libxi libxcursor"
-REQUIRED_DISTRO_FEATURES = "x11 opengl"
+DEPENDS = "libpng libglu zlib"
+REQUIRED_DISTRO_FEATURES = "opengl"
+ANY_OF_DISTRO_FEATURES = "wayland x11"
+
+# upstream considers x11 and wayland backends mutually exclusive and

will
+# prioritize wayland if it is enabled, but wayland has dependencies that cannot

Quoted 9 lines
Quoted 8 lines
meta-oe/recipes-core/glfw/glfw_3.3.bb +5 -0
+# be satisfied by this layer so it is disabled by default
+
+PACKAGECONFIG ??= "x11"
+
+PACKAGECONFIG[wayland] = "-DGLFW_USE_WAYLAND=ON,,wayland

wayland-native wayland-protocols extra-cmake-modules libxkbcommon" +PACKAGECONFIG[x11] = ",,libxrandr libxinerama libxi libxcursor"
COMPATIBLE_HOST:libc-musl = "null"

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#102225):
https://lists.openembedded.org/g/openembedded-devel/message/102225
Mute This Topic: https://lists.openembedded.org/mt/98540896/3617156
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#9 lore raw
Quoted 17 lines · Martin Jansa

The version which was merged with:

PACKAGECONFIG ??= "x11"

Should still respect x11 in DISTRO_FEATURES, now this causes:

ERROR: Nothing PROVIDES 'libxi' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it) libxi was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libxinerama' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it) libxinerama was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libxrandr' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it) libxrandr was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libglu' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it) libglu was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libxcursor' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it) libxcursor was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)

Quoted 2 lines

when wayland and opengl are in DISTRO_FEATURES, but x11 isn't.

Yeah, that's expected behavior at this point. You need to manually override the PACKAGECONFIG for wayland in this patch. Just slightly better than no wayland at all.

The only way we can get around it is if this layer or one of it's dependencies decides to adopt extra-cmake-modules. They the packageconfig can automatically configure itself. Discussion on who's job it is to carry this package has yet to conclude.

Quoted 81 lines

REQUIRED_DISTRO_FEATURES is satisfied by "opengl" and ANY_OF_DISTRO_FEATURES by "wayland", but the default PACKAGECONFIG doesn't match with that.

On Fri, Apr 28, 2023 at 6:32 PM Randolph Sapp via lists.openembedded.org <http://lists.openembedded.org> <[email protected] <mailto:[email protected]>> wrote:

    On 4/28/23 06:16, akuster808 wrote:
     > Doesn't this need to land it Master first? Kirkstone is in the
    subject
     >
     > - armin
     >

    Perhaps, but I've only had a chance to test it against kirkstone so I
    flagged it as such. At this point I'm still vetting solutions to this
    dependency chain though. Looking for something this layer would
    actually
    like to carry.

     > On 4/27/23 12:47 PM, [email protected] <mailto:[email protected]> wrote:
     >> From: Randolph Sapp <[email protected] <mailto:[email protected]>>
     >>
     >> GLFW has the ability to use a wayland backend. This patch adds a
    config
     >> for it, but does not enable it by default because it has a
    dependency on
     >> extra-cmake-modules which is provided (most commonly) by
    meta-qt5-extra.
     >>
     >> Signed-off-by: Randolph Sapp <[email protected] <mailto:[email protected]>>
     >> ---
     >>   meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> |
    14 ++++++++++++--
     >>   1 file changed, 12 insertions(+), 2 deletions(-)
     >>
     >> diff --git a/meta-oe/recipes-core/glfw/glfw_3.3.bb
    <http://glfw_3.3.bb>
     >> b/meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb>
     >> index b31bba6b6b..5b0d61241e 100644
     >> --- a/meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb>
     >> +++ b/meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb>
     >> @@ -20,7 +20,17 @@ EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON
     >> -DGLFW_BUILD_DOCS=OFF"
     >>   CFLAGS += "-fPIC"
     >> -DEPENDS = "libpng libglu zlib libxrandr libxinerama libxi
    libxcursor"
     >> -REQUIRED_DISTRO_FEATURES = "x11 opengl"
     >> +DEPENDS = "libpng libglu zlib"
     >> +REQUIRED_DISTRO_FEATURES = "opengl"
     >> +ANY_OF_DISTRO_FEATURES = "wayland x11"
     >> +
     >> +# upstream considers x11 and wayland backends mutually
    exclusive and
     >> will
     >> +# prioritize wayland if it is enabled, but wayland has
    dependencies
     >> that cannot
     >> +# be satisfied by this layer so it is disabled by default
     >> +
     >> +PACKAGECONFIG ??= "x11"
     >> +
     >> +PACKAGECONFIG[wayland] = "-DGLFW_USE_WAYLAND=ON,,wayland
     >> wayland-native wayland-protocols extra-cmake-modules libxkbcommon"
     >> +PACKAGECONFIG[x11] = ",,libxrandr libxinerama libxi libxcursor"
     >>   COMPATIBLE_HOST:libc-musl = "null"
     >


    -=-=-=-=-=-=-=-=-=-=-=-
    Links: You receive all messages sent to this group.
    View/Reply Online (#102225):
    https://lists.openembedded.org/g/openembedded-devel/message/102225
    <https://lists.openembedded.org/g/openembedded-devel/message/102225>
    Mute This Topic: https://lists.openembedded.org/mt/98540896/3617156
    <https://lists.openembedded.org/mt/98540896/3617156>
    Group Owner: [email protected]
    <mailto:openembedded-devel%[email protected]>
    Unsubscribe:
    https://lists.openembedded.org/g/openembedded-devel/unsub
    <https://lists.openembedded.org/g/openembedded-devel/unsub>
    [[email protected] <mailto:[email protected]>]
    -=-=-=-=-=-=-=-=-=-=-=-
#10 lore raw
Quoted 37 lines · Randolph Sapp
Quoted 32 lines · Martin Jansa

The version which was merged with:

PACKAGECONFIG ??= "x11"

Should still respect x11 in DISTRO_FEATURES, now this causes:

ERROR: Nothing PROVIDES 'libxi' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it)
libxi was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libxinerama' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it)
libxinerama was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libxrandr' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it)
libxrandr was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libglu' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it)
libglu was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libxcursor' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it)
libxcursor was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)

Quoted 2 lines

when wayland and opengl are in DISTRO_FEATURES, but x11 isn't.

Quoted 9 lines

Yeah, that's expected behavior at this point. You need to manually override the PACKAGECONFIG for wayland in this patch. Just slightly better than no wayland at all.

The only way we can get around it is if this layer or one of it's dependencies decides to adopt extra-cmake-modules. They the packageconfig can automatically configure itself. Discussion on who's job it is to carry this package has yet to conclude.

May be bring it to meta-oe at this point.

Quoted 86 lines
Quoted 85 lines

REQUIRED_DISTRO_FEATURES is satisfied by "opengl" and ANY_OF_DISTRO_FEATURES by "wayland", but the default PACKAGECONFIG doesn't match with that.

On Fri, Apr 28, 2023 at 6:32 PM Randolph Sapp via lists.openembedded.org
<http://lists.openembedded.org> <[email protected] <mailto:[email protected]>> wrote:

    On 4/28/23 06:16, akuster808 wrote:
     > Doesn't this need to land it Master first? Kirkstone is in the
    subject
     >
     > - armin
     >

    Perhaps, but I've only had a chance to test it against kirkstone so I
    flagged it as such. At this point I'm still vetting solutions to this
    dependency chain though. Looking for something this layer would
    actually
    like to carry.

     > On 4/27/23 12:47 PM, [email protected] <mailto:[email protected]> wrote:
     >> From: Randolph Sapp <[email protected] <mailto:[email protected]>>
     >>
     >> GLFW has the ability to use a wayland backend. This patch adds a
    config
     >> for it, but does not enable it by default because it has a
    dependency on
     >> extra-cmake-modules which is provided (most commonly) by
    meta-qt5-extra.
     >>
     >> Signed-off-by: Randolph Sapp <[email protected] <mailto:[email protected]>>
     >> ---
     >>   meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> |
    14 ++++++++++++--
     >>   1 file changed, 12 insertions(+), 2 deletions(-)
     >>
     >> diff --git a/meta-oe/recipes-core/glfw/glfw_3.3.bb
    <http://glfw_3.3.bb>
     >> b/meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb>
     >> index b31bba6b6b..5b0d61241e 100644
     >> --- a/meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb>
     >> +++ b/meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb>
     >> @@ -20,7 +20,17 @@ EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON
     >> -DGLFW_BUILD_DOCS=OFF"
     >>   CFLAGS += "-fPIC"
     >> -DEPENDS = "libpng libglu zlib libxrandr libxinerama libxi
    libxcursor"
     >> -REQUIRED_DISTRO_FEATURES = "x11 opengl"
     >> +DEPENDS = "libpng libglu zlib"
     >> +REQUIRED_DISTRO_FEATURES = "opengl"
     >> +ANY_OF_DISTRO_FEATURES = "wayland x11"
     >> +
     >> +# upstream considers x11 and wayland backends mutually
    exclusive and
     >> will
     >> +# prioritize wayland if it is enabled, but wayland has
    dependencies
     >> that cannot
     >> +# be satisfied by this layer so it is disabled by default
     >> +
     >> +PACKAGECONFIG ??= "x11"
     >> +
     >> +PACKAGECONFIG[wayland] = "-DGLFW_USE_WAYLAND=ON,,wayland
     >> wayland-native wayland-protocols extra-cmake-modules libxkbcommon"
     >> +PACKAGECONFIG[x11] = ",,libxrandr libxinerama libxi libxcursor"
     >>   COMPATIBLE_HOST:libc-musl = "null"
     >


    -=-=-=-=-=-=-=-=-=-=-=-
    Links: You receive all messages sent to this group.
    View/Reply Online (#102225):
    https://lists.openembedded.org/g/openembedded-devel/message/102225
    <https://lists.openembedded.org/g/openembedded-devel/message/102225>
    Mute This Topic: https://lists.openembedded.org/mt/98540896/3617156
    <https://lists.openembedded.org/mt/98540896/3617156>
    Group Owner: [email protected]
    <mailto:openembedded-devel%[email protected]>
    Unsubscribe:
    https://lists.openembedded.org/g/openembedded-devel/unsub
    <https://lists.openembedded.org/g/openembedded-devel/unsub>
    [[email protected] <mailto:[email protected]>]
    -=-=-=-=-=-=-=-=-=-=-=-
#11 lore raw
Quoted 42 lines · Khem Raj
Quoted 41 lines · Randolph Sapp
Quoted 32 lines · Martin Jansa

The version which was merged with:

PACKAGECONFIG ??= "x11"

Should still respect x11 in DISTRO_FEATURES, now this causes:

ERROR: Nothing PROVIDES 'libxi' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it)
libxi was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libxinerama' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it)
libxinerama was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libxrandr' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it)
libxrandr was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libglu' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it)
libglu was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libxcursor' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it)
libxcursor was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)

Quoted 2 lines

when wayland and opengl are in DISTRO_FEATURES, but x11 isn't.

Yeah, that's expected behavior at this point. You need to manually override the PACKAGECONFIG for wayland in this patch. Just slightly better than no wayland at all.

Quoted 7 lines
Quoted 5 lines

The only way we can get around it is if this layer or one of it's dependencies decides to adopt extra-cmake-modules. They the packageconfig can automatically configure itself. Discussion on who's job it is to carry this package has yet to conclude.

May be bring it to meta-oe at this point.

Roger. Patches Soon™

Quoted 87 lines
Quoted 87 lines
Quoted 86 lines

REQUIRED_DISTRO_FEATURES is satisfied by "opengl" and ANY_OF_DISTRO_FEATURES by "wayland", but the default PACKAGECONFIG doesn't match with that.

On Fri, Apr 28, 2023 at 6:32 PM Randolph Sapp via lists.openembedded.org
<http://lists.openembedded.org> <[email protected] <mailto:[email protected]>> wrote:

     On 4/28/23 06:16, akuster808 wrote:
      > Doesn't this need to land it Master first? Kirkstone is in the
     subject
      >
      > - armin
      >

     Perhaps, but I've only had a chance to test it against kirkstone so I
     flagged it as such. At this point I'm still vetting solutions to this
     dependency chain though. Looking for something this layer would
     actually
     like to carry.

      > On 4/27/23 12:47 PM, [email protected] <mailto:[email protected]> wrote:
      >> From: Randolph Sapp <[email protected] <mailto:[email protected]>>
      >>
      >> GLFW has the ability to use a wayland backend. This patch adds a
     config
      >> for it, but does not enable it by default because it has a
     dependency on
      >> extra-cmake-modules which is provided (most commonly) by
     meta-qt5-extra.
      >>
      >> Signed-off-by: Randolph Sapp <[email protected] <mailto:[email protected]>>
      >> ---
      >>   meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> |
     14 ++++++++++++--
      >>   1 file changed, 12 insertions(+), 2 deletions(-)
      >>
      >> diff --git a/meta-oe/recipes-core/glfw/glfw_3.3.bb
     <http://glfw_3.3.bb>
      >> b/meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb>
      >> index b31bba6b6b..5b0d61241e 100644
      >> --- a/meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb>
      >> +++ b/meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb>
      >> @@ -20,7 +20,17 @@ EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON
      >> -DGLFW_BUILD_DOCS=OFF"
      >>   CFLAGS += "-fPIC"
      >> -DEPENDS = "libpng libglu zlib libxrandr libxinerama libxi
     libxcursor"
      >> -REQUIRED_DISTRO_FEATURES = "x11 opengl"
      >> +DEPENDS = "libpng libglu zlib"
      >> +REQUIRED_DISTRO_FEATURES = "opengl"
      >> +ANY_OF_DISTRO_FEATURES = "wayland x11"
      >> +
      >> +# upstream considers x11 and wayland backends mutually
     exclusive and
      >> will
      >> +# prioritize wayland if it is enabled, but wayland has
     dependencies
      >> that cannot
      >> +# be satisfied by this layer so it is disabled by default
      >> +
      >> +PACKAGECONFIG ??= "x11"
      >> +
      >> +PACKAGECONFIG[wayland] = "-DGLFW_USE_WAYLAND=ON,,wayland
      >> wayland-native wayland-protocols extra-cmake-modules libxkbcommon"
      >> +PACKAGECONFIG[x11] = ",,libxrandr libxinerama libxi libxcursor"
      >>   COMPATIBLE_HOST:libc-musl = "null"
      >


     -=-=-=-=-=-=-=-=-=-=-=-
     Links: You receive all messages sent to this group.
     View/Reply Online (#102225):
     https://lists.openembedded.org/g/openembedded-devel/message/102225
     <https://lists.openembedded.org/g/openembedded-devel/message/102225>
     Mute This Topic: https://lists.openembedded.org/mt/98540896/3617156
     <https://lists.openembedded.org/mt/98540896/3617156>
     Group Owner: [email protected]
     <mailto:openembedded-devel%[email protected]>
     Unsubscribe:
     https://lists.openembedded.org/g/openembedded-devel/unsub
     <https://lists.openembedded.org/g/openembedded-devel/unsub>
     [[email protected] <mailto:[email protected]>]
     -=-=-=-=-=-=-=-=-=-=-=-
#12 lore raw
In reply to Khem Raj
Quoted 42 lines · Khem Raj
Quoted 41 lines · Randolph Sapp
Quoted 32 lines · Martin Jansa

The version which was merged with:

PACKAGECONFIG ??= "x11"

Should still respect x11 in DISTRO_FEATURES, now this causes:

ERROR: Nothing PROVIDES 'libxi' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it)
libxi was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libxinerama' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it)
libxinerama was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libxrandr' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it)
libxrandr was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libglu' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it)
libglu was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libxcursor' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it)
libxcursor was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)

Quoted 2 lines

when wayland and opengl are in DISTRO_FEATURES, but x11 isn't.

Yeah, that's expected behavior at this point. You need to manually override the PACKAGECONFIG for wayland in this patch. Just slightly better than no wayland at all.

Quoted 7 lines
Quoted 5 lines

The only way we can get around it is if this layer or one of it's dependencies decides to adopt extra-cmake-modules. They the packageconfig can automatically configure itself. Discussion on who's job it is to carry this package has yet to conclude.

May be bring it to meta-oe at this point.

I wonder if it would be better/cleaner to extract a single CMake module this glfw package needs to configure wayland support and carry it locally, instead of bringing in the entire KDE-specific set of such CMake modules and be on the hook for updating it forever?
https://api.kde.org/frameworks/extra-cmake-modules/html/index.html
https://invent.kde.org/frameworks/extra-cmake-modules

Quoted 67 lines
Quoted 67 lines
Quoted 67 lines

REQUIRED_DISTRO_FEATURES is satisfied by "opengl" and ANY_OF_DISTRO_FEATURES by "wayland", but the default PACKAGECONFIG doesn't match with that.

On Fri, Apr 28, 2023 at 6:32 PM Randolph Sapp via lists.openembedded.org
<http://lists.openembedded.org> <[email protected] <mailto:[email protected]>> wrote:

    On 4/28/23 06:16, akuster808 wrote:
     > Doesn't this need to land it Master first? Kirkstone is in the
    subject
     >
     > - armin
     >

    Perhaps, but I've only had a chance to test it against kirkstone so I
    flagged it as such. At this point I'm still vetting solutions to this
    dependency chain though. Looking for something this layer would
    actually
    like to carry.

     > On 4/27/23 12:47 PM, [email protected] <mailto:[email protected]> wrote:
     >> From: Randolph Sapp <[email protected] <mailto:[email protected]>>
     >>
     >> GLFW has the ability to use a wayland backend. This patch adds a
    config
     >> for it, but does not enable it by default because it has a
    dependency on
     >> extra-cmake-modules which is provided (most commonly) by
    meta-qt5-extra.
     >>
     >> Signed-off-by: Randolph Sapp <[email protected] <mailto:[email protected]>>
     >> ---
     >>   meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> |
    14 ++++++++++++--
     >>   1 file changed, 12 insertions(+), 2 deletions(-)
     >>
     >> diff --git a/meta-oe/recipes-core/glfw/glfw_3.3.bb
    <http://glfw_3.3.bb>
     >> b/meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb>
     >> index b31bba6b6b..5b0d61241e 100644
     >> --- a/meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb>
     >> +++ b/meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb>
     >> @@ -20,7 +20,17 @@ EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON
     >> -DGLFW_BUILD_DOCS=OFF"
     >>   CFLAGS += "-fPIC"
     >> -DEPENDS = "libpng libglu zlib libxrandr libxinerama libxi
    libxcursor"
     >> -REQUIRED_DISTRO_FEATURES = "x11 opengl"
     >> +DEPENDS = "libpng libglu zlib"
     >> +REQUIRED_DISTRO_FEATURES = "opengl"
     >> +ANY_OF_DISTRO_FEATURES = "wayland x11"
     >> +
     >> +# upstream considers x11 and wayland backends mutually
    exclusive and
     >> will
     >> +# prioritize wayland if it is enabled, but wayland has
    dependencies
     >> that cannot
     >> +# be satisfied by this layer so it is disabled by default
     >> +
     >> +PACKAGECONFIG ??= "x11"
     >> +
     >> +PACKAGECONFIG[wayland] = "-DGLFW_USE_WAYLAND=ON,,wayland
     >> wayland-native wayland-protocols extra-cmake-modules libxkbcommon"
     >> +PACKAGECONFIG[x11] = ",,libxrandr libxinerama libxi libxcursor"
     >>   COMPATIBLE_HOST:libc-musl = "null"
#13 lore raw
Quoted 50 lines · Denys Dmytriyenko
Quoted 48 lines · Khem Raj
Quoted 46 lines · Randolph Sapp
Quoted 32 lines · Martin Jansa

The version which was merged with:

PACKAGECONFIG ??= "x11"

Should still respect x11 in DISTRO_FEATURES, now this causes:

ERROR: Nothing PROVIDES 'libxi' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it)
libxi was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libxinerama' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it)
libxinerama was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libxrandr' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it)
libxrandr was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libglu' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it)
libglu was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libxcursor' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on or otherwise requires it)
libxcursor was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)

Quoted 2 lines

when wayland and opengl are in DISTRO_FEATURES, but x11 isn't.

Yeah, that's expected behavior at this point. You need to manually override the PACKAGECONFIG for wayland in this patch. Just slightly better than no wayland at all.

The only way we can get around it is if this layer or one of it's dependencies decides to adopt extra-cmake-modules. They the packageconfig can automatically configure itself. Discussion on who's job it is to carry this package has yet to conclude.

Quoted 9 lines
Quoted 1 line

May be bring it to meta-oe at this point.

I wonder if it would be better/cleaner to extract a single CMake module this glfw package needs to configure wayland support and carry it locally, instead of bringing in the entire KDE-specific set of such CMake modules and be on the hook for updating it forever?
https://api.kde.org/frameworks/extra-cmake-modules/html/index.html
https://invent.kde.org/frameworks/extra-cmake-modules

if it does not get updated often then it should be fine too. Its maintenance either way

Quoted 77 lines
Quoted 60 lines
Quoted 60 lines
Quoted 60 lines

REQUIRED_DISTRO_FEATURES is satisfied by "opengl" and ANY_OF_DISTRO_FEATURES by "wayland", but the default PACKAGECONFIG doesn't match with that.

On Fri, Apr 28, 2023 at 6:32 PM Randolph Sapp via lists.openembedded.org
<http://lists.openembedded.org> <[email protected] <mailto:[email protected]>> wrote:

    On 4/28/23 06:16, akuster808 wrote:
     > Doesn't this need to land it Master first? Kirkstone is in the
    subject
     >
     > - armin
     >

    Perhaps, but I've only had a chance to test it against kirkstone so I
    flagged it as such. At this point I'm still vetting solutions to this
    dependency chain though. Looking for something this layer would
    actually
    like to carry.

     > On 4/27/23 12:47 PM, [email protected] <mailto:[email protected]> wrote:
     >> From: Randolph Sapp <[email protected] <mailto:[email protected]>>
     >>
     >> GLFW has the ability to use a wayland backend. This patch adds a
    config
     >> for it, but does not enable it by default because it has a
    dependency on
     >> extra-cmake-modules which is provided (most commonly) by
    meta-qt5-extra.
     >>
     >> Signed-off-by: Randolph Sapp <[email protected] <mailto:[email protected]>>
     >> ---
     >>   meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> |
    14 ++++++++++++--
     >>   1 file changed, 12 insertions(+), 2 deletions(-)
     >>
     >> diff --git a/meta-oe/recipes-core/glfw/glfw_3.3.bb
    <http://glfw_3.3.bb>
     >> b/meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb>
     >> index b31bba6b6b..5b0d61241e 100644
     >> --- a/meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb>
     >> +++ b/meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb>
     >> @@ -20,7 +20,17 @@ EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON
     >> -DGLFW_BUILD_DOCS=OFF"
     >>   CFLAGS += "-fPIC"
     >> -DEPENDS = "libpng libglu zlib libxrandr libxinerama libxi
    libxcursor"
     >> -REQUIRED_DISTRO_FEATURES = "x11 opengl"
     >> +DEPENDS = "libpng libglu zlib"
     >> +REQUIRED_DISTRO_FEATURES = "opengl"
     >> +ANY_OF_DISTRO_FEATURES = "wayland x11"
     >> +
     >> +# upstream considers x11 and wayland backends mutually
    exclusive and
     >> will
     >> +# prioritize wayland if it is enabled, but wayland has
    dependencies
     >> that cannot
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

>> +# be satisfied by this layer so it is disabled by default >> +
>> +PACKAGECONFIG ??= "x11"
>> +
>> +PACKAGECONFIG[wayland] = "-DGLFW_USE_WAYLAND=ON,,wayland >> wayland-native wayland-protocols extra-cmake-modules libxkbcommon" >> +PACKAGECONFIG[x11] = ",,libxrandr libxinerama libxi libxcursor"
>> COMPATIBLE_HOST:libc-musl = "null"

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#102272): https://lists.openembedded.org/g/openembedded-devel/message/102272
Mute This Topic: https://lists.openembedded.org/mt/98540896/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#14 lore raw
In reply to Randolph Sapp
Quoted 38 lines · Randolph Sapp
Quoted 8 lines · Martin Jansa

The version which was merged with:

PACKAGECONFIG ??= "x11"

Should still respect x11 in DISTRO_FEATURES, now this causes:

ERROR: Nothing PROVIDES 'libxi' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on

or

Quoted 5 lines

otherwise requires it)
libxi was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libxinerama' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on

or

Quoted 5 lines

otherwise requires it)
libxinerama was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libxrandr' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on

or

Quoted 5 lines

otherwise requires it)
libxrandr was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libglu' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on

or

Quoted 5 lines

otherwise requires it)
libglu was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Nothing PROVIDES 'libxcursor' (but meta-oe/recipes-core/glfw/glfw_3.3.bb <http://glfw_3.3.bb> DEPENDS on

or

Quoted 4 lines

otherwise requires it)
libxcursor was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)

Quoted 7 lines
Quoted 2 lines

when wayland and opengl are in DISTRO_FEATURES, but x11 isn't.

Yeah, that's expected behavior at this point. You need to manually override the PACKAGECONFIG for wayland in this patch. Just slightly better than no wayland at all.

And slightly worse than before, because before it was automatically skipped thanks to REQUIRED_DISTRO_FEATURES and now it's pulled into world builds even when it doesn't build at all.

The only way we can get around it is if this layer or one of it's

Quoted 4 lines

dependencies decides to adopt extra-cmake-modules. They the packageconfig can automatically configure itself. Discussion on who's job it is to carry this package has yet to conclude.

There is also libglu in regular DEPENDS which has x11 in REQUIRED_DISTRO_FEATURES.

After moving libglu to x11 PACKAGECONFIG and enabling x11 only when it's in DISTRO_FEATURES as in:
https://git.openembedded.org/meta-openembedded-contrib/commit/?h=jansa/master&id=721240c27e7a8ebe83f2730cf94e12a57932db82

it still fails with:
glfw/3.3+gitAUTOINC+781fbbadb0-r0/recipe-sysroot-native/usr/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
| Could NOT find X11 (missing: X11_X11_INCLUDE_PATH X11_X11_LIB)

Maybe return x11 to REQUIRED_DISTRO_FEATURES until the wayland discussion is resolved somehow?

Regards,