Skip to contentSkip to conversation

fpga: cyclon2: Remove message never printed

PATCH Applied Alexander Dahl 2 participants 2 messages Aug 4, 2025 – Aug 18, 2025 FPGA manager framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fpga: cyclon2: Remove message never printed

else branch is never reached. Print "Done." anyways to keep behaviour.

Addresses-Coverity-ID: 583148

Fixes f0ff4692ff33 ("Add FPGA Altera Cyclone 2 support Patch by Heiko Schocher, 15 Aug 2006")
---
 drivers/fpga/cyclon2.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/fpga/cyclon2.c +1 -4
index 7e78d6e2d6c..1c464c1e912 100644
@@ -174,10 +174,7 @@ static int CYC2_ps_load(Altera_desc *desc, const void *buf, size_t bsize)
 		ret_val = FPGA_SUCCESS;
 
 #ifdef CONFIG_SYS_FPGA_PROG_FEEDBACK
-		if (ret_val == FPGA_SUCCESS)
-			puts("Done.\n");
-		else
-			puts("Fail.\n");
+		puts("Done.\n");
 #endif
 
 		/*

base-commit: ae5711f881100f856ead1e76832c32b92dba93c7

Signature · 1 line
2.39.5
Applied
#1 lore raw
Quoted 27 lines · Alexander Dahl

else branch is never reached. Print "Done." anyways to keep behaviour.

Addresses-Coverity-ID: 583148

Fixes f0ff4692ff33 ("Add FPGA Altera Cyclone 2 support Patch by Heiko Schocher, 15 Aug 2006")
---
  drivers/fpga/cyclon2.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)
drivers/fpga/cyclon2.c +1 -4
index 7e78d6e2d6c..1c464c1e912 100644
@@ -174,10 +174,7 @@ static int CYC2_ps_load(Altera_desc *desc, const void *buf, size_t bsize)
  		ret_val = FPGA_SUCCESS;
 
  #ifdef CONFIG_SYS_FPGA_PROG_FEEDBACK
-		if (ret_val == FPGA_SUCCESS)
-			puts("Done.\n");
-		else
-			puts("Fail.\n");
+		puts("Done.\n");
  #endif
 
  		/*
Quoted 1 line

base-commit: ae5711f881100f856ead1e76832c32b92dba93c7

Applied.
M